Comm
(2 files, 265 lines)
[root]/Core/Util
Comm
(2 files, 265 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 57 (100.0%) | 1103 (100.0%) | 19.3 |
| jas | 22 (38.6%) | 776 (70.4%) | 35.2 |
| dav | 34 (59.6%) | 322 (29.2%) | 9.4 |
| luitjens | 1 (1.8%) | 5 (0.5%) | 5.0 |
More descriptive error message... apparently perror doesn't work for network function calls.
0 lines of code changed in 2 files:
Added show_env()... useful for testing.
0 lines of code changed in 4 files:
Initial framework for in-simulation Uintah tracking system. Messages
will be sent from sus (from each and every process sus is using) to a
simulation tracking server. This will help track the state of
simulations and where/when they fail.
M Core/Util/Socket.h
- BOLD comment about important return condition. (Hopefully gets the
users attention.)
- Added info function.
M Core/Util/Socket.cc
Accept() should be using the new socket (I believe). (Note, I think
both the old and new socket (at this point) are the same, but
still...) Displays an error message if the accept'ance fails.
Implemented the getSocketInfo() function.
M Packages/Uintah/CCA/Components/SimulationController/sub.mk
- Use the tracker.
- Alphabetize. Led to removal of duplicate DataArchiver listing.
M Packages/Uintah/CCA/Components/SimulationController/AMRSimulationController.cc
- Start using the tracker. (Currently only tracks the beginning of each timestep.)
- Better ordering of #includes.
M Packages/Uintah/StandAlone/sub.mk
Use tracker.
A Packages/Uintah/StandAlone/tools/tracker
A Packages/Uintah/StandAlone/tools/tracker/sub.mk
A Packages/Uintah/StandAlone/tools/tracker/TrackerProgram.cc
Very basic simulation tracking server. Needs to be updated to handle
a threaded server library (which needs to be implemented soon, see below.)
M Packages/Uintah/StandAlone/tools/sub.mk
- Build tracker server.
- Untabify.
M Packages/Uintah/StandAlone/sus.cc
- Add '-track' option.
M Packages/Uintah/Core/sub.mk
Use tracker.
A Packages/Uintah/Core/Tracker
A Packages/Uintah/Core/Tracker/sub.mk
A Packages/Uintah/Core/Tracker/Tracker.cc
A Packages/Uintah/Core/Tracker/TrackerClient.h
A Packages/Uintah/Core/Tracker/Tracker.h
A Packages/Uintah/Core/Tracker/TrackerServer.cc
A Packages/Uintah/Core/Tracker/TrackerServer.h
A Packages/Uintah/Core/Tracker/TrackerClient.cc
Initial commit of tracker libraries (for server and client). Server
needs to be updated to use Threads (so that a server program can query
the server library to ask about status etc (without blocking).
Currently only a few messages are sent... most of the code needs to be
updated to send tracking messages.
22 lines of code changed in 3 files:
Use the proper memory deallocations.
1 lines of code changed in 1 file:
Added (and used in sus) the option to make parsing of the .scirunrc
file silent.
M Core/Util/Environment.h
M Core/Util/Environment.cc
Added beSilent option so no print statements occur when parsing (or
failing to parse) .scirunrc. This defaults to false (ie, defaults to
old behavior of being verbose).
Moved some 'global' functions to just be local as they shouldn't
be/arent called from anywhere but Environment.cc.
M Packages/Uintah/StandAlone/sus.cc
Use the beSilent option (for create_sci_environment()) so that large
runs don't spam the output with "Parsing... not found", etc.
30 lines of code changed in 2 files:
This update allows the Problem Spec Reader to find the .ups xml spec
file based on the location of the src tree. (Previously, it looked in
the current directory and thus only succeeded if you had 'inputs/'
there.) Now it will work no matter where you run from.
IMPORTANT NOTE:
To make this work, I had to call "create_sci_environment(...);"
at the beginning of sus. This should just work... but it is
possible that it will cause problems on some machines. Note,
create_sci_environment() will attempt to access a .scirunrc file,
which you can use to set environment variables that you want seen
in sus. This (assuming it really works) could mean that you don't
have to pass env vars via -X (or somesuch) in mpirun calls.
M Core/Util/Environment.cc
- Warn user if create_sci_environment() has NOT been called before
doing a sci_getenv().
- endl's are evil. :p ;) :)
- Indent.
M Packages/Uintah/CCA/Components/ProblemSpecification/ProblemSpecReader.cc
- Look for the ups_spec.xml file based on absolute path.
M Packages/Uintah/StandAlone/sus.cc
- Always call create_sci_environment(). (This shouldn't break
anything...but please verify before using in batch systems for big
runs.)
32 lines of code changed in 1 file:
More fixes to fixes for PGI compiler.
4 lines of code changed in 2 files:
Fixes to allow Uintah to build using the PGI compiler:
M configure
M configure.ac
- Figure out size of 'long long' so that Endian.cc swapbytes() can be
set correctly... perhaps a bit of overkill, but...
- PGI compilers don't support -Wall, so don't use it.
- Better messages when determining dependency generation flag. Fix
grep for ":" as it sometimes is " :". See below (configVars.mk.in).
- pgf77 needs -lrt to link.
M configVars.mk.in
- ECHO should not be "echo -n" (no newline)... so named it more appropriately.
- Many compilers don't create dependency files (.d) with exactly "name.o : name.cc".
Then may use "name.o:name.cc". So don't use the ":" in the sed. This should
never cause a problem because of the "^".
- Added the dependency mode of: 'modify_and_move'. PGI compiler creates an invalid
.d file in the wrong place, so we have to fix it and move it.
- NOTE: the F77 dependency flag is currently (historically) just a copy of the CXX
flag... this has worked in the past and still works for everything but pgf77.
Soon (but not in this update) I will fix configure to do this correctly.
M StandAlone/regression/sub.mk
M Packages/Uintah/StandAlone/tools/compare_mms/sub.mk
M Packages/Uintah/StandAlone/tools/radiusMaker/sub.mk
- Need BLAS_LIBRARY to link... at least on Ranger using PGI.
- Please indent... it really does make it easier to read.
M Core/Malloc/Allocator.cc
Moved variable into the #if section that it is used in. Avoids compiler warning.
M Core/Util/Endian.cc
A Core/Util/testEndian.h.in
D Core/Util/Endian.h
- pgcc is requiring the swapbytes() for 'long long'... So add it
in. Since 'long long' size can be different on different machines,
use overkill method with configure figuring out size and setting it
for us.
- Moved Endian.h to testEndian.h.in to allow configure to modify it.
- Indented.
M Core/Util/sub.mk
M Packages/Uintah/Core/Grid/Variables/sub.mk
Untabified.
M Core/Util/Socket.cc
Fix compiler warning and possible 'random' error.
M Core/Math/MiscMath.cc
Fix PGI compiler issue.
M Packages/Uintah/CCA/Components/DataArchiver/DataArchiver.cc
M Packages/Uintah/CCA/Components/Schedulers/SchedulerCommon.cc
#include <time.h> is required for time functions.
M Packages/Uintah/CCA/Components/ICE/EOS/IdealGas.cc
M Packages/Uintah/CCA/Components/ICE/CustomBCs/sine.h
M Packages/Uintah/CCA/Components/ICE/CustomBCs/MMS_BCs.cc
M Packages/Uintah/CCA/Components/ICE/CustomBCs/microSlipBCs.cc
M Packages/Uintah/CCA/Components/ICE/BoundaryCond.cc
- Removed a bunch of definitions of "iter". (vector<IntVector>::const_iterator)...
probably a leftover from the iterator update a while back. In some cases,
renamed an interior (for loop) iterator from "iter" to "cIter" so that the
code would be a little more clear as to which iterator was being used
inside the inner for loop. Also, define some iterators in the for loop,
instead of above the loop. (for( vector::iterator iter...))
M Packages/Uintah/CCA/Components/ICE/AMRICE.h
M Packages/Uintah/Core/Grid/Variables/GridVariable.h
M Packages/Uintah/Core/Grid/Variables/GridVariableBase.h
Fix compiler warning about hidden parent class function.
M Packages/Uintah/CCA/Components/Arches/ExtraScalarSolver.h
Fix compiler warning about ineffectual use of a const return type. Eg:
const int doSomething() { return 1; }
doesn't mean anything... it doesn't make sense for the returned int to
be const. Should just be:
int doSomething() { return 1; }
M Packages/Uintah/CCA/Ports/SFC.h
Fix problem with nested comments. Don't use /* ... */ over many lines. Use #if 0.
M Packages/Uintah/StandAlone/tools/uda2nrrd/particles.cc
Comment about invalid code.
M Packages/Uintah/StandAlone/tools/puda/varsummary.cc
PGI compiler needs Min/Max defined.
M Packages/Uintah/StandAlone/tools/extractors/partextract.cc
#include <stdlib.h> for strtoll... Add hack to force (older (verion
7.1-2)) pgCC to allow strtoll.
M Packages/Uintah/Core/Grid/Patch.h
M Packages/Uintah/Core/Grid/AMR.h
Hack to remove PGI compiler warnings about unreachable code.
M Packages/Uintah/Core/Grid/Grid.h
Use white space... it is also your friend. Seriously (on a related
note ;) can someone tell me why they think "x=3;" is better than "x = 3;"?
M Packages/Uintah/Core/Grid/Variables/ReductionVariable_special.cc
Wow, this is an ugly file... Had to add some (templated) functions
that the PGI compiler was requiring.
M Packages/Uintah/Core/Grid/Variables/ComputeSet.h
Don't seem to need to #include the .cc file (for the templates) with
PGI anymore... at least not on Ranger using pgCC version 7.1-2.
M Packages/Uintah/Core/Grid/Variables/VarTypes.h
Needs the 'long long' var type.
M Packages/Uintah/Core/Grid/Variables/ComputeSet_special.cc
More use of white space, indentation, etc.
M Packages/Uintah/Core/DataArchive/DataArchive.cc
Added {} around what looks like a necessary block of code... strange
that this didn't cause hangs, etc in the code. Perhaps this section
of code isn't used that often? Hope the RT doesn't gripe
tomorrow... it's not my fault!
M Packages/Uintah/Core/Disclosure/TypeUtils.h
M Packages/Uintah/Core/Disclosure/TypeUtils.cc
Added 'long long' function. Organized the code a tad bit to make it
easier to see which functions (for which types) are defined.
M Packages/Uintah/testprograms/sub.mk
M Packages/Uintah/testprograms/PatchBVH/sub.mk
M Packages/Uintah/testprograms/TestFastMatrix/sub.mk
M Packages/Uintah/testprograms/BNRRegridder/sub.mk
M Packages/Uintah/testprograms/IteratorTest/sub.mk
Untabify. Clean up. Removed double definition of LIBS. Requires
BLAS_LIBRARY to link.
M Packages/Uintah/tools/BlasLapackTests/test_blas.c
Ranger's version of testcase... not sure I should have checked it
in... Probably need to have both with the #if separating them.
M Packages/Uintah/Dataflow/Modules/Selectors/ParticleFieldExtractor.h
Fix compiler warning about hidden function (update_progress).
M Packages/Uintah/Dataflow/Modules/Selectors/ParticleFieldExtractor.cc
Fix includes (better ordering). Fix (hack) PGI problem with finding atoll.
M Packages/Uintah/Dataflow/Modules/Selectors/FieldExtractor.h
More white space. Remove unused var. Move common code to above 'if'.
138 lines of code changed in 6 files:
Fix destructor in the event the the developer is switching between cout and cerr for debug streams.
0 lines of code changed in 2 files:
Use the proper c++ standard for include files for the C inlude files, i.e.
<stdio.h> --> <cstdio>
<math.h> --> <cmath>
Tested on g++ 4.2 and 4.3 compilers.
768 lines of code changed in 16 files:
Fix compiler build problems with gcc-4.3
3 lines of code changed in 2 files:
Changed debug streams to default to cout instead of cerr. cerr can cause output to be jumbled when running in parallel.
5 lines of code changed in 1 file:
Adding in problem spec (.ups) validation. It will only produce
warnings for now... but soon it will kill the run with an
exception... so fix your .ups files. You can use use sus to validate
your .ups file by doing the following (note, you only need one
processor to do this):
> sus -validate simulation.ups
This will do the validation and then quit sus.
WARNING... if you run sus from anywhere but its build directory (or if
the build dir does not have a symbolic link to the inputs/ dir),
validation will not take place because the code will not be able to
find the ups_spec.xml file... I'll try to come up with a fix for this
soon.
M Core/Containers/StringUtil.h
M Core/Containers/StringUtil.cc
Updated split_string to allow multiple separator characters.
M Core/Init/init.cc
M Core/Util/FileUtils.cc
Use new split_string.
M Packages/Uintah/CCA/Components/ProblemSpecification/sub.mk
Need Core/Containers for StringUtil.
M Packages/Uintah/CCA/Components/ProblemSpecification/ProblemSpecReader.h
M Packages/Uintah/CCA/Components/ProblemSpecification/ProblemSpecReader.cc
Validate the .ups file passed in. Uses the inputs/ups_spec.xml file
for the validation. Still needs some work to handle "children"
elements in ups_spec.xml... This element will specify how children
relate to each other, but hasn't been completely thought through yet.
(For example, it could specify that all children tags are necessary,
or that only one of two tags is valid, but not both... etc.)
M Packages/Uintah/StandAlone/sus.cc
* Added some blank lines around exception prints to make them MUCH
easier to see in the output.
* Added -validate flag to only validate .ups file and quit.
M Packages/Uintah/Core/Grid/SimulationTime.cc
Made the naming consistent for the tags in the Time block... all now
start with a lowercase letter, followed by capital letters for each
new word... (instead of using '_'). I know, I know, but I couldn't
help myself... at least I didn't change every single tag in all the
.ups files to be consistent.
M Packages/Uintah/Core/ProblemSpec/sub.mk
Cosmetic fix.
M Packages/Uintah/StandAlone/inputs/*/*.ups
Fixed Time block to use new (old/consistent) naming standard.
M Packages/Uintah/StandAlone/inputs/ups_spec.xml
Added a common tags section so that they can be reused in the spec
without having to write them out every time. Added a few example
"children" elements, but they aren't used yet.
10 lines of code changed in 1 file:
M Util/ProgressiveWarning.h
Added some documentation as to what I think this class does...
M Util/ProgressiveWarning.cc
If multiplier is set to 1, an infinite loop occurs... Catch this case and change the multiplier to 2...
0 lines of code changed in 4 files:
Fix compiler warnings having to do with const char declarations.
4 lines of code changed in 3 files:
fix errno printing problem
1 lines of code changed in 1 file:
M Core/Util/FileUtils.h
M Core/Util/FileUtils.cc
Fix the bogus verbose parameter... it was used because the resultant
file size was not being checked... now actually check to make sure
that the file is the correct size. Add the processor rank (if using
MPI) to the file name to differentiate it.
If Stat or Remove fail, that is an ERROR, not a WARNING.
M Packages/Uintah/CCA/Components/DataArchiver/DataArchiver.cc
M Packages/Uintah/CCA/Components/ProblemSpecification/ProblemSpecReader.cc
M Packages/Uintah/StandAlone/tools/mpi_test/mpi_test.cc
Fix use of (bogus/deprecated) 'verbose' parameter.
27 lines of code changed in 2 files:
M Core/Util/FileUtils.h
M Core/Util/FileUtils.cc
Make the testFilesystem() call return any errors in a stream to be
displayed as the caller wishes.
M Packages/Uintah/CCA/Components/DataArchiver/DataArchiver.cc
M Packages/Uintah/CCA/Components/ProblemSpecification/ProblemSpecReader.cc
Print out the filesystem test error message as required now.
M Packages/Uintah/StandAlone/tools/mpi_test/sub.mk
Need FileUtils from Core/Util.
M Packages/Uintah/StandAlone/tools/mpi_test/mpi_test.cc
- Get the hostname.
- Fixed compilation errors under GCC on inferno.
- Added file system check (for inferno only right now).
- Added copyright.
- Couple of cosmetic fixes.
19 lines of code changed in 2 files:
M configure
M configure.ac
M configVars.mk.in
M Core/Malloc/sub.mk
Only compile Trace.cc if malloc tracing is turned on.
M Core/Malloc/Trace.cc
Put AllocatorSetDefaultTagMalloc() func in SCIRun namespace.
M Core/Malloc/malloc.cc
Don't compile Allocator version of AllocatorSetDefaultTagMalloc if malloc tracing is on.
M Core/Util/sci_system.cc
Fix namespace problem.
4 lines of code changed in 1 file:
This commit adds the SCI_MALLOC_TRACE functionality (found in the
Core/Malloc/Trace.h file (though accessed through
Core/Malloc/Allocator.h). The Malloc tracing will create a file and
record every malloc/free in it. (This will capture the news/deletes
too.) By using scinew, the name of the file and line number of each
new() will be recorded. (Note, until a file name to save information
to is specified, mallocs will be traced via stdout. You can only use
one of malloc trace or sci malloc, but not both at the same time.
M configure.ac
M configure
Use "--enable-sci-malloc-trace" on the configure line to turn on
malloc tracing.
M include/sci_defs/malloc_testdefs.h.in
Contains the #define for malloc trace if enabled via confiure.
A Core/Malloc/Trace.cc
A Core/Malloc/Trace.h
Implements the tracing functionality... Note, you should #include
Allocator.h and not Trace.h.
M Core/Malloc/sub.mk
Compile Trace.cc.
M Core/Malloc/Allocator.h
M Core/Malloc/Allocator.cc
Indent some # stuff. Don't create Allocator stuff in SCI Malloc is
off or SCI Trace is on.
M Core/Util/sci_system.cc
Indent # stuff. Only lock/unlock allocator if using SCI Malloc.
M Core/Geometry/BBox.h
Be specific about #undef of min and max instead of assuming they both
are always exist together. (They probably do, but...)
M Core/GuiInterface/MemStats.cc
Fix to only use parts of code if SCI Malloc is on.
M testprograms/Malloc/test14.cc
Test 14 doesn't do anything currently, so printed out a message to let the user know.
M Packages/Uintah/Dataflow/Modules/Visualization/SubFieldHistogram.cc
Removed "using SCIRun::Allocator" (etc) as it wasn't being used.
M Packages/Uintah/CCA/Components/SimulationController/AMRSimulationController.cc
M Packages/Uintah/CCA/Components/Schedulers/SchedulerCommon.cc
M Packages/Uintah/Core/Parallel/Parallel.cc
Only use Allocator functions if SCI Malloc on.
M Packages/Uintah/CCA/Components/ICE/ICE.cc
Turned off setting of unused variable "Time".
M Packages/Uintah/Core/DataArchive/DataArchive.cc
Don't use Allocator functions if SCI Malloc is off... Fixed some initialization of variables.
M Packages/Uintah/StandAlone/sus.cc
Added sample of turning on malloc trace file.
35 lines of code changed in 1 file: