TabProps
(0 files, 0 lines)
[root]/CCA/Components/Arches/Mixing
TabProps
(0 files, 0 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 73 (100.0%) | 53 (100.0%) | 0.7 |
| jas | 51 (69.9%) | 43 (81.1%) | 0.8 |
| jthornoc | 6 (8.2%) | 6 (11.3%) | 1.0 |
| luitjens | 4 (5.5%) | 4 (7.5%) | 1.0 |
| harman | 12 (16.4%) | 0 (0.0%) | 0.0 |
removed
using namespace SCIRun
0 lines of code changed in 8 files:
Undid Todd's SCIRun rampage until the explode2D segfault is figured out.
4 lines of code changed in 4 files:
removed
using namespace SCIRun;
0 lines of code changed in 4 files:
BoundaryConditions.*:
Standard Arches inlets can now be named.
Inlet area is printed out with name when case starts up.
Also allow one to set the second mixture fraction in the old ARCHES bc. This is needed for property evaluation and should be fixed at some point when the old property evaluator goes away.
InletStream.cc:
Initializing second mixture fraction.
ExplicitSolver.cc
Tweaks on the scalar solver solve. i
Because of the multiple density issue and the generally bad abstraction of how density is handled, the scalar eqn needs to use tempDensity to stand in for the previous rk density for the FE update.
ScalarEqn.cc
Changes in which density is used.
Turns out Arches is copying density from old_dw->new_dw at the beginning of each time step so old_dw density was never needed.
Also need to use tempDensity for the explicit update.
Finally, needed to change the "evalTransportEqn" to check if the equation used density guess to be able to handle density abstraction (see update to ExplicitSolver.cc).
arches_ups.xml
Update spec to allow for naming of inlet and adding mixture_fraction_2 value or <FlowInlet>.
2 lines of code changed in 2 files:
Arches.cc:
* Reordered the construction of scalar equations to allow an extra scalar equation to be used as a mixture fraction.
* Added call to TabPropsInterface through reComputeProps_new. The _new function will go away once properties is removed.
BoundaryCondition.cc:
* Flow inlets can now set a "mixture_fraction_2" for the the second mixture fraction.
ExplicitSolver.cc:
* Added call to reComputeProps_new and added ability to update scalar equations if density guess boolean is true (as set from the input file).
Properties.cc, Properties.h:
~ Ultimately it would be nice to either get rid or greatly simplify this code. I think there is a lot of unnecessary stuff going on in here.
~ This code still needs a little cleanup to remove (old) TabProp weeds.
* Added the TabProps interface option in problem setup.
* Added an access function to determine what mixing model was being used.
* Removed some old tabprop weeds.
* Added boundary condition property update for tabprops
* Added reComputeProps_new which accesses TabProps.
EqnBase.h:
* Added the d_use_density_guess boolean which informs the algorithm that this particular transport equation should be updated *before* properties are computed, using the guessed density as the rho^(n+1) rather than the density coming from the table. Just add <use_density_guess/> tag to transport equation block.
ScalarEqn.cc:
* Initialization for d_use_density_guess boolean.
TabPropsInterface.cc, *.h:
~ Still needs some major cleanup and bullet proofing
* Removed TabPropsTable because the name was a bit redundant and replaced it with this class.
* Major rewrite of this method to simplify things a bit.
MixingRxnTable.cc, *.h:
* Robustness, generality
InletStream.h:
* Added second mixture fraction.
4 lines of code changed in 4 files:
Update copyright dates.
1 lines of code changed in 1 file:
Update copyright dates
14 lines of code changed in 22 files:
Undoing commit 45403
14 lines of code changed in 14 files:
Update copyright date.
14 lines of code changed in 14 files: