Lines of Code
[root]/CCA/Components/Arches/TransportEqns
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 58 (100.0%) | 1083 (100.0%) | 18.6 |
| jthornoc | 47 (81.0%) | 971 (89.7%) | 20.6 |
| jpedel | 6 (10.3%) | 72 (6.6%) | 12.0 |
| charlesreid | 2 (3.4%) | 28 (2.6%) | 14.0 |
| jas | 3 (5.2%) | 12 (1.1%) | 4.0 |
TabPropsInterface:
Removed a variable that wasn't needed and used the private class
variable instead.
ExplicitSolver.cc:
Rearranged the dummy solve a little. This shouldn't change the answers
but makes more intuitive sense (expect the dummy solve makes no sense --
so just try to figure that one out)
ScalarEqn.cc:
In addition to the clipping after the averaging, do clipping after the
FE update to ensure bounded scalars.
3 lines of code changed in 2 files:
Yet another missing ghost cell.
0 lines of code changed in 2 files:
Ghost number requirement for area fraction needed fixin'
2 lines of code changed in 1 file:
TabPropsInterface.cc/.h
-> Allow for enthalpy to be turned on but radiation be off for adiabatic
cases
-> Use BSpline pointers rather than strings for table lookup
-> Check bounds on derived mixture fraction for coal tables
-> Complete rehash of how property BCs are being computed
-> Removed d_hl_outlet and d_hl_pressure in favor of the previous
comment
Discretization_new.h
-> Fixed a bug in super_bee for internal boundary conditions
-> Changed the diffusion calculation for now at boundaries so that they
behave exactly like the old Arches boundary conditions. We should
revisit this.
tableProbe.m
-> Read in a string.
arches_spec.xml
-> updated spec to match above changes
102 lines of code changed in 2 files:
Passing by reference.
7 lines of code changed in 1 file:
Fixed a "bug" where the new scalar solver was not time averaging in a
consistent manner with the other (old) scalars. This was causing
general instabilities in certain cases where the new scalars were acting
as table parameters. To fix this I had to:
1) Separate out the time averaging in the scalar eqn and schedule it
later in the algorithm
2) Create a new timeAve procedure for equations that needed density
3) Turned off the density guess knob for scalar equations until the
algorithmic issues are settled.
96 lines of code changed in 7 files:
More explicit error message in MomentumSolver.cc
Actually returning the source term type in SourceTermBase.h
Some minor bulletproofing in the initialization of transport equations.
4 lines of code changed in 1 file:
* Added a new source term that will inject source terms as inlet
* conditions normal to specified solid geometry.
* Fixed a warning in LaminarPrNo
* Fixed a warning in TabStripFactor
* Fixed notation in Inject
* Modified the SourceTemplatedTemplate
* Fixed a warning in Discretization_new
* Added spec for IntrusionInlets
1 lines of code changed in 1 file:
Fix doxygen errors.
6 lines of code changed in 1 file:
Scalar equation can now handle a variable Pr number.
Overloaded the diffusion calculation to handle variable Pr numbers.
Removed calculation of diffusion coefficient in LaminarPrNo as it is not needed.
294 lines of code changed in 4 files:
Adding some labels to the dummy solve (necessary for mpmarches)
18 lines of code changed in 1 file:
EqnBase.cc
More info on print statement
DQMOMEqn.cc
Performing a copy for dummyInit to ensure initial conditions aren't lost.
TabProps.*
Cleanup. Also, all IV that are transported are now specified with the new scalar equations.
3 lines of code changed in 3 files:
An iteration on the unweighted abscissa code.
Please note that one must now specify the type of DQMOM being used:
<DQMOM type="unweightedAbs"> OR <DQMOM type="weightedAbs">
23 lines of code changed in 2 files:
Adding capability to transport unweighted abscissas which will avoid numerical problems
53 lines of code changed in 4 files:
Bandaid for TabProps interface to deal with the noSolve for mpmArches.
1 lines of code changed in 1 file:
BoundaryConditions.*:
Standard Arches inlets can now be named.
Inlet area is printed out with name when case starts up.
Also allow one to set the second mixture fraction in the old ARCHES bc. This is needed for property evaluation and should be fixed at some point when the old property evaluator goes away.
InletStream.cc:
Initializing second mixture fraction.
ExplicitSolver.cc
Tweaks on the scalar solver solve. i
Because of the multiple density issue and the generally bad abstraction of how density is handled, the scalar eqn needs to use tempDensity to stand in for the previous rk density for the FE update.
ScalarEqn.cc
Changes in which density is used.
Turns out Arches is copying density from old_dw->new_dw at the beginning of each time step so old_dw density was never needed.
Also need to use tempDensity for the explicit update.
Finally, needed to change the "evalTransportEqn" to check if the equation used density guess to be able to handle density abstraction (see update to ExplicitSolver.cc).
arches_ups.xml
Update spec to allow for naming of inlet and adding mixture_fraction_2 value or <FlowInlet>.
21 lines of code changed in 1 file:
- Saving weight label and "small" value so we don't have to find it each time
- Not setting weight/weighted abscissa to 0 (I thought I had changed this already but apparently not...)
28 lines of code changed in 2 files:
1) Density should not be treated differently on boundaries. Now always interpolated with 2nd order interpolant.
2) Because of 1), there is no longer a need to have a special getDensityOnFace function.
3) Indexing was incorrect on construting the Boundary face iterator.
24 lines of code changed in 3 files:
Print statement was incorrect.
0 lines of code changed in 2 files:
Fixed an issue (le bug) with the density for multi RK timestepping.
Removed unnecessary gets for phi in the buildTransportEqn method.
Removed uncecessary boundary condition application in the buildTransportEqn method.
53 lines of code changed in 2 files:
(8 more)