Lines of Code
[root]/CCA/Components/Arches/BoundaryConditions
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 20 (100.0%) | 1296 (100.0%) | 64.8 |
| jthornoc | 15 (75.0%) | 1269 (97.9%) | 84.6 |
| dav | 5 (25.0%) | 27 (2.1%) | 5.4 |
* Added a “modifies” for the boundary condition functors. This will allow one to modify other variables besides the variable on which the bc is being applied.
* Added a subgrid injector bc functor. This needs a little work.
* Added a function in UniformGrid to allow one to check for intersections between two distinct points. Previous functionality only allowed the check between a point and infinity.
* Added a thin-wall check when tri geometry is used as an intrusion in Arches.
293 lines of code changed in 2 files:
Add an identifier for domain edge and internal face BCs.
Do not throw an error if the internal face BC is missing.
Autoname internal face BCs.
49 lines of code changed in 1 file:
Remove a static function and code cleanup.
608 lines of code changed in 1 file:
Cleaning up warnings and adding Shunn 1D mms.
29 lines of code changed in 1 file:
Update boundary conditions including adding MMS BCs.
259 lines of code changed in 1 file:
* cleaned up some unused functionality in the ConvectionHelper - Specifically the old implementation of the staggered convective operator.
* In GridTools, moved around the enums for the DIR variable to make better sense.
* Added the start of a 1D interpolator. This needs some (re)verification since I modified what Oscar had initially.
* Had to add const version of the VariableHelper.
* Using the 1D interpolator, added a helper task to do 1D interpolation. Needs a little more work as it currently excludes FC -> FC
1 lines of code changed in 1 file:
More API change.
20 lines of code changed in 3 files:
Arches task interface API changed to pass packed_task boolean.
3 lines of code changed in 1 file:
- Refinements on the new scheduling interface.
- Arches tasks can now be packed when appropriate into super tasks.
- Catching more errors in scheduling when packed or unpacked tasks are
present to prevent user from scheduling variable needs incorrectly.
7 lines of code changed in 4 files:
Continuation of commit r56249 - getting into the Core and the UCF now.
Mostly cosmetic changes - removing the actual hack (see Handle.h below) to
allow for better type safety using c++11 nullptr.
These changes have passed the local RT on Baja.
- The biggest update in this commit (the update to remove the c++11 warning hack) is that you will
no longer be able to compare a ProblemSpecP to 0 (you will need to compare to 'nullptr').
- White space, coding standards, indentation, remove tabs.
- Line up some variables to make them easier to read.
- Use of 80+ columns of text (we decided to allow this 10 years ago) and it makes reading longer lines of code on the screen easier.
- Use {} for if/else clauses even if they are only one line long.
- Please put "else" and "else if" on a new line. The added white space makes following the branching much easier.
M CCA/Components/Arches/BoundaryConditions/BoundaryFunctorHelper.cc
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/Schedulers/DynamicMPIScheduler.cc
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/UnifiedScheduler.cc
M CCA/Ports/PIDXOutputContext.cc
M Core/GeometryPiece/GeometryPieceFactory.cc
M Core/Grid/BoundaryConditions/BCDataArray.cc
M Core/Grid/BoundaryConditions/BCDataArray.h
- Pass const strings as references instead of copying.
M Core/Grid/BoundaryConditions/BCUtils.cc
M Core/Grid/BoundaryConditions/BoundCondReader.cc
M Core/Grid/Level.h
M Core/Grid/Level.cc
- Pass const params as const.
- Removed m_patches variables as it isn't used anywhere.
- Very few real changes in this file, use diff -w.
M Core/Grid/Patch.h
M Core/Grid/Patch.cc
- Place .h one line functions on one line as it makes the viewing of the Class spec easier
(and this is the main purpose of the .h file.)
- Line up vars/ for easier reading.
M Core/Grid/Task.cc
M Core/Grid/Variables/ComputeSet.h
- Place .h one line functions on one line as it makes the viewing of the Class spec easier
(and this is the main purpose of the .h file.)
M Core/Grid/Variables/ParticleVariable.h
M Core/Grid/Variables/ParticleVariable_special.cc
M Core/Grid/Variables/Variable.cc
- Fix end comment on readPIDX()
M Core/Util/Handle.h
- Here is the hack that is being removed... The "==" operator was overloaded in order
to allow for comparison of pointers to 0. When this is removed, then (previous to these
commits) you would be spammed by warnings about ambiguous "==" operator. By removing this
operator and forcing the comparison to nullptr (as of c++11), type safety is increased.
2 lines of code changed in 2 files:
Mostly cosmetic changes, and preparing for removing a hacked out warning when we moved to C++ 11.
These changes have passed the local RT on Baja.
- The biggest update in this commit (the update to remove the c++11 warning hack) is that you will
no longer be able to compare a ProblemSpecP to 0 (you will need to compare to 'nullptr').
- White space, coding standards, indentation, remove tabs.
- Line up some variables to make them easier to read.
- Use of 80+ columns of text (we decided to allow this 10 years ago) and it makes reading longer lines of code on the screen easier.
- Please put "else" and "else if" on a new line. The added white space makes following the branching much easier.
- Use {} for if/else clauses even if they are only one line long.
- Swatted some evil endls. (Use "\n")
- Alphabetize #includes and remove some unneeded ones.
- Add in Copyright notice to some files that were missing it.
M CCA/Components/Arches/Arches.cc
M CCA/Components/Arches/ArchesLabel.cc
- Fix code so that "found_role = true" is not repeated a hundred times... As I tell my CS 1000 students, if it
happens in every branch of the 'if' statement, it should be moved out of all of them.
M CCA/Components/Arches/BoundaryCond_new.cc
M CCA/Components/Arches/BoundaryCondition.cc
M CCA/Components/Arches/BoundaryConditions/BoundaryConditionFactory.cc
M CCA/Components/Arches/BoundaryConditions/BoundaryFunctors.h
M CCA/Components/Arches/BoundaryConditions/HandOff.h
M CCA/Components/Arches/CQMOM.cc
M CCA/Components/Arches/ChemMix/ColdFlow.cc
M CCA/Components/Arches/ChemMix/MixingRxnModel.cc
M CCA/Components/Arches/ChemMix/TableLookup.cc
M CCA/Components/Arches/CoalModels/CharOxidationSmith.cc
M CCA/Components/Arches/CoalModels/Deposition.cc
M CCA/Components/Arches/CoalModels/EnthalpyShaddix.cc
M CCA/Components/Arches/CoalModels/HeatTransfer.cc
M CCA/Components/Arches/CoalModels/KobayashiSarofimDevol.cc
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.cc
M CCA/Components/Arches/DQMOM.cc
M CCA/Components/Arches/ExplicitSolver.cc
M CCA/Components/Arches/IntrusionBC.cc
M CCA/Components/Arches/IntrusionBC.h
M CCA/Components/Arches/LagrangianParticles/LagrangianParticleFactory.cc
M CCA/Components/Arches/MomentumSolver.cc
M CCA/Components/Arches/MomentumSolver.h
M CCA/Components/Arches/ParticleModels/CQMOMSourceWrapper.cc
M CCA/Components/Arches/ParticleModels/ParticleModelFactory.cc
M CCA/Components/Arches/ParticleModels/ParticleTools.h
M CCA/Components/Arches/ParticleModels/ShaddixEnthalpy.h
M CCA/Components/Arches/PressureSolverV2.cc
M CCA/Components/Arches/PropertyModels/RadProperties.cc
M CCA/Components/Arches/PropertyModelsV2/DensityPredictor.cc
M CCA/Components/Arches/PropertyModelsV2/PropertyModelFactoryV2.cc
M CCA/Components/Arches/PropertyModelsV2/VariableStats.cc
M CCA/Components/Arches/Radiation/DORadiationModel.cc
M CCA/Components/Arches/Radiation/RadPropertyCalculator.cc
M CCA/Components/Arches/Radiation/RadPropertyCalculator.h
M CCA/Components/Arches/SourceTerms/DORadiation.cc
M CCA/Components/Arches/SourceTerms/IntrusionInlet.h
M CCA/Components/Arches/SourceTerms/PCTransport.cc
M CCA/Components/Arches/SourceTerms/SourceTermFactory.cc
M CCA/Components/Arches/Transport/ComputePsi.h
M CCA/Components/Arches/Transport/KFEUpdate.h
M CCA/Components/Arches/Transport/KMomentum.h
M CCA/Components/Arches/Transport/KScalarRHS.h
M CCA/Components/Arches/Transport/TransportFactory.cc
M CCA/Components/Arches/TransportEqns/CQMOMEqn.cc
M CCA/Components/Arches/TransportEqns/CQMOM_Convection.cc
M CCA/Components/Arches/TransportEqns/DQMOMEqn.cc
M CCA/Components/Arches/TransportEqns/DQMOMEqnFactory.cc
M CCA/Components/Arches/TransportEqns/ScalarEqn.cc
M CCA/Components/Arches/UPSHelper.h
M CCA/Components/Arches/Utility/InitializeFactory.cc
M CCA/Components/Arches/Utility/TaskAlgebra.h
M CCA/Components/Arches/Utility/UtilityFactory.cc
M CCA/Components/Arches/WBCHelper.cc
M CCA/Components/Arches/WallHTModels/WallModelDriver.cc
- See above for list of updates.
25 lines of code changed in 3 files: