Directory CCA/Components/Arches/CoalModels/

Lines of Code

Developers

Most Recent Commits

jthornoc 2017-12-18 12:16 Rev.: 57467

Adding initial implementation of DQMOM in the
Arches/Kokkos/TaskInterface mode.

This still needs some work...

21 lines of code changed in 2 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith2016.cc (+21 -21)

allen 2017-11-24 15:37 Rev.: 57339

removed the delta T label from the shared state and began removing the shared state where possible

25 lines of code changed in 25 files:

• CCA/Components/Arches/CoalModels: BirthDeath.cc (+2 -2), CharOxidationShaddix.cc (+2 -2), CharOxidationSmith.cc (new), CharOxidationSmith2016.cc (+2 -2), DragModel.cc (+2 -2), EnthalpyShaddix.cc (new), FOWYDevol.cc (+2 -2), KobayashiSarofimDevol.cc (+2 -2), LinearSwelling.cc (new), MaximumTemperature.cc (new), RichardsFletcherDevol.cc (+2 -2), ShaddixHeatTransfer.cc (new), YamamotoDevol.cc (new)

allen 2017-11-21 15:40 Rev.: 57322

update to move to a application common class and remove the shared state

61 lines of code changed in 3 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+24 -26), CharOxidationSmith2016.cc (+24 -26), FOWYDevol.cc (+13 -14)

jas 2017-10-13 14:42 Rev.: 57138

Replace all instances of StaticArray with std::vector. This has been tested on the RT for all components. It is a drop in replacement. StaticArray is being removed.

14 lines of code changed in 5 files:

• CCA/Components/Arches/CoalModels: CharOxidationShaddix.cc (+2 -2), CharOxidationShaddix.h (-2), CharOxidationSmith.cc (+6 -7), CharOxidationSmith2016.cc (+6 -7)

jthornoc 2017-10-06 10:47 Rev.: 57091

Remove a pow and if statement inside a tight loop.

24 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: BirthDeath.cc (+24 -17)

bisaac 2017-09-29 17:32 Rev.: 57055

Fixed hi yield bug which occurs when temperatues exceed Tbp_graphite.

1 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: FOWYDevol.cc (+1)

bisaac 2017-09-25 17:07 Rev.: 57027

Updated the FOWY devol model to include linear increasing yield above 1800K. This will break all coal cases using FOWY.

14 lines of code changed in 3 files:

• CCA/Components/Arches/CoalModels: FOWYDevol.cc (+10 -16), FOWYDevol.h (+4 -2)

bisaac 2017-08-07 17:12 Rev.: 56852

Fixed a bug related to the deposition model. This was setting the destruction rate to zero. This will break deposition regression tests.

6 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: BirthDeath.cc (+6 -22)

jas 2017-08-04 09:53 Rev.: 56846

Use C++11 hashmap.

0 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: FOWYDevol.h (-3)

jthornoc 2017-06-19 23:58 Rev.: 56665

Remove an empty model.

Minor beautification.

33 lines of code changed in 5 files:

• CCA/Components/Arches/CoalModels: BirthDeath.cc (+31 -22), ParticleConvection.cc (del), ParticleConvection.h (del), sub.mk (+2 -3)

jthornoc 2017-06-19 23:57 Rev.: 56664

SimpleBirth->BirthDeath

10 lines of code changed in 6 files:

• CCA/Components/Arches/CoalModels: CharOxidationShaddix.cc (+2 -2), CharOxidationSmith.cc (+2 -2), CharOxidationSmith2016.cc (+3 -3), DragModel.cc (+1 -1), FOWYDevol.cc (+1 -1), LinearSwelling.cc (+1 -1)

jthornoc 2017-06-19 23:57 Rev.: 56663

SimpleBirth->BirthDeath
Death is only on when wall deposition is occurring. It is auto-parsed
from the input file and turned on for the user.

471 lines of code changed in 5 files:

• CCA/Components/Arches/CoalModels: BirthDeath.cc (+366), BirthDeath.h (new 104), SimpleBirth.cc (del), SimpleBirth.h (del), sub.mk (+1 -1)

jthornoc 2017-06-19 23:57 Rev.: 56659

Actually added affect of dstrc src on the birth term.

2 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: SimpleBirth.cc (new 2)

jthornoc 2017-06-19 23:57 Rev.: 56658

Moved deposition destruction rates into simple birth. Modified 1GW test to make them run with the combined model.

102 lines of code changed in 2 files:

• CCA/Components/Arches/CoalModels: SimpleBirth.cc (+94 -2), SimpleBirth.h (new 8)

jthornoc 2017-06-19 23:56 Rev.: 56645

This commit movies particle temperature, density, and total number density to which_dw instead of new_dw, for the CoalModel files only.

27 lines of code changed in 9 files:

• CCA/Components/Arches/CoalModels: CharOxidationShaddix.cc (+4 -4), CharOxidationSmith.cc (+4 -4), CharOxidationSmith2016.cc (+6 -6), DragModel.cc (+2 -2), EnthalpyShaddix.cc (+3 -3), FOWYDevol.cc (+2 -2), MaximumTemperature.cc (+2 -2), Thermophoresis.cc (+4 -4)

bisaac 2017-06-06 14:58 Rev.: 56611

Fixed an issue related to char-oxidation clipping with a limiting oxidizer. This commit changes OFC_smith2016 and its restart within machine precision.

10 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith2016.cc (+10 -37)

jthornoc 2017-06-06 09:32 Rev.: 56604

Looks like a missing delete was causing a memory failure.

3 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith2016.cc (+3 -2)

bisaac 2017-06-06 00:22 Rev.: 56603

Fixed an issue related to char-oxidation clipping with a limiting oxidizer. This commit shouldn't impact regression tests.

10 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+10 -9)

bisaac 2017-05-26 11:59 Rev.: 56581

Removed clipping bug in FOWY, and gas-integration bugs that were making it so we couldn't run second-order. This commit will break pcoal_drag (second order), coal_RadPropsPlanck (second order), and partMassFlow (clipping).

0 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: FOWYDevol.cc (-8)

bisaac 2017-04-26 12:14 Rev.: 56482

Fixed the MW for CO2 in the OFC4_smith.ups regression test, and added the impact of gasification reactions on the heat of reaction for char oxidation. This will break OFC4_smith

32 lines of code changed in 3 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+29 -6), CharOxidationSmith.h (+3 -1)

jas 2017-04-20 13:20 Rev.: 56454

Update copyright.

8 lines of code changed in 11 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+1 -1), CharOxidationSmith.h (+1 -1), CharOxidationSmith2016.cc (+1 -1), CharOxidationSmith2016.h (new), Deposition.cc (new), EnthalpyShaddix.cc (+1 -1), KobayashiSarofimDevol.cc (+1 -1), SimpleHeatTransfer.cc (+1 -1)

derekhar 2017-04-05 17:20 Rev.: 56392

Updated absorption property model to be more modular.
The primary motivation of this commit is to progress towards removing dependence on radprops.
Also, this commit cleaned up years of "hacks" aimed at quickly adapting the code to fit the needs of the center.
This commit will change every radiation test, most of which are due to round-off differences.
In some instances, a bug of using inconsistent data-warehouses was also present.

15 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: EnthalpyShaddix.cc (+15 -35)

tsaad 2017-03-31 13:06 Rev.: 56385

replace !=0 with != nullptr when checking the validity of ProbleSpecP. This was causing compilation issues on my mac.

2 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith2016.cc (+2 -2)

bisaac 2017-03-28 00:52 Rev.: 56362

This commit adds particle shrinkage and swelling, modifies the density function to compute the literal density with dqmom, and makes input files consistent with coal_density. Shouldn't change any answers.

848 lines of code changed in 7 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith2016.cc (+91 -9), CharOxidationSmith2016.h (+7), LinearSwelling.cc (+289), LinearSwelling.h (new 111), ShrinkageRate.cc (new 236), ShrinkageRate.h (new 110), sub.mk (+4 -2)

bisaac 2017-03-23 09:38 Rev.: 56348

Adding the new char oxidation model with the particle shrinkage soure-term, and additional functions within ParticleTools. This should not impact regression tests.

1328 lines of code changed in 7 files:

• CCA/Components/Arches/CoalModels: CharOxidation.cc (+6), CharOxidation.h (+4), CharOxidationSmith2016.cc (+997), CharOxidationSmith2016.h (+320), sub.mk (+1)

derekhar 2017-03-17 13:29 Rev.: 56337

Added pressure to oxidationSmith. Also corrected rawcoal computed for use in rate clipping.

25 lines of code changed in 2 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+24 -18), CharOxidationSmith.h (+1)

derekhar 2017-03-15 15:43 Rev.: 56333

Changed convergence tolerance in charoxy_smith to use a relative tolerance, based on fastest reaction.

5 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+5 -2)

jthornoc 2017-03-15 12:02 Rev.: 56330

Adding access to the table keys through the ChemHelper.
This will prevent passing the entire table around when one just needs a
small subset of information.

9 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+9 -2)

allen 2017-03-03 14:09 Rev.: 56284

add min/max bounds to the in-situ vars, fixed handle checks

6 lines of code changed in 2 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+4), FOWYDevol.cc (+2)

dav 2017-02-24 00:50 Rev.: 56249

Mostly cosmetic changes, and preparing for removing a hacked out warning when we moved to C++ 11.
These changes have passed the local RT on Baja.

- The biggest update in this commit (the update to remove the c++11 warning hack) is that you will
no longer be able to compare a ProblemSpecP to 0 (you will need to compare to 'nullptr').

- White space, coding standards, indentation, remove tabs.
- Line up some variables to make them easier to read.
- Use of 80+ columns of text (we decided to allow this 10 years ago) and it makes reading longer lines of code on the screen easier.

- Please put "else" and "else if" on a new line. The added white space makes following the branching much easier.
- Use {} for if/else clauses even if they are only one line long.

- Swatted some evil endls. (Use "\n")

- Alphabetize #includes and remove some unneeded ones.

- Add in Copyright notice to some files that were missing it.

M CCA/Components/Arches/Arches.cc
M CCA/Components/Arches/ArchesLabel.cc

- Fix code so that "found_role = true" is not repeated a hundred times... As I tell my CS 1000 students, if it
happens in every branch of the 'if' statement, it should be moved out of all of them.

M CCA/Components/Arches/BoundaryCond_new.cc
M CCA/Components/Arches/BoundaryCondition.cc
M CCA/Components/Arches/BoundaryConditions/BoundaryConditionFactory.cc
M CCA/Components/Arches/BoundaryConditions/BoundaryFunctors.h
M CCA/Components/Arches/BoundaryConditions/HandOff.h
M CCA/Components/Arches/CQMOM.cc
M CCA/Components/Arches/ChemMix/ColdFlow.cc
M CCA/Components/Arches/ChemMix/MixingRxnModel.cc
M CCA/Components/Arches/ChemMix/TableLookup.cc
M CCA/Components/Arches/CoalModels/CharOxidationSmith.cc
M CCA/Components/Arches/CoalModels/Deposition.cc
M CCA/Components/Arches/CoalModels/EnthalpyShaddix.cc
M CCA/Components/Arches/CoalModels/HeatTransfer.cc
M CCA/Components/Arches/CoalModels/KobayashiSarofimDevol.cc
M CCA/Components/Arches/CoalModels/SimpleHeatTransfer.cc
M CCA/Components/Arches/DQMOM.cc
M CCA/Components/Arches/ExplicitSolver.cc
M CCA/Components/Arches/IntrusionBC.cc
M CCA/Components/Arches/IntrusionBC.h
M CCA/Components/Arches/LagrangianParticles/LagrangianParticleFactory.cc
M CCA/Components/Arches/MomentumSolver.cc
M CCA/Components/Arches/MomentumSolver.h
M CCA/Components/Arches/ParticleModels/CQMOMSourceWrapper.cc
M CCA/Components/Arches/ParticleModels/ParticleModelFactory.cc
M CCA/Components/Arches/ParticleModels/ParticleTools.h
M CCA/Components/Arches/ParticleModels/ShaddixEnthalpy.h
M CCA/Components/Arches/PressureSolverV2.cc
M CCA/Components/Arches/PropertyModels/RadProperties.cc
M CCA/Components/Arches/PropertyModelsV2/DensityPredictor.cc
M CCA/Components/Arches/PropertyModelsV2/PropertyModelFactoryV2.cc
M CCA/Components/Arches/PropertyModelsV2/VariableStats.cc
M CCA/Components/Arches/Radiation/DORadiationModel.cc
M CCA/Components/Arches/Radiation/RadPropertyCalculator.cc
M CCA/Components/Arches/Radiation/RadPropertyCalculator.h
M CCA/Components/Arches/SourceTerms/DORadiation.cc
M CCA/Components/Arches/SourceTerms/IntrusionInlet.h
M CCA/Components/Arches/SourceTerms/PCTransport.cc
M CCA/Components/Arches/SourceTerms/SourceTermFactory.cc
M CCA/Components/Arches/Transport/ComputePsi.h
M CCA/Components/Arches/Transport/KFEUpdate.h
M CCA/Components/Arches/Transport/KMomentum.h
M CCA/Components/Arches/Transport/KScalarRHS.h
M CCA/Components/Arches/Transport/TransportFactory.cc
M CCA/Components/Arches/TransportEqns/CQMOMEqn.cc
M CCA/Components/Arches/TransportEqns/CQMOM_Convection.cc
M CCA/Components/Arches/TransportEqns/DQMOMEqn.cc
M CCA/Components/Arches/TransportEqns/DQMOMEqnFactory.cc
M CCA/Components/Arches/TransportEqns/ScalarEqn.cc
M CCA/Components/Arches/UPSHelper.h
M CCA/Components/Arches/Utility/InitializeFactory.cc
M CCA/Components/Arches/Utility/TaskAlgebra.h
M CCA/Components/Arches/Utility/UtilityFactory.cc
M CCA/Components/Arches/WBCHelper.cc
M CCA/Components/Arches/WallHTModels/WallModelDriver.cc

- See above for list of updates.

184 lines of code changed in 7 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+2 -2), Deposition.cc (+48 -21), EnthalpyShaddix.cc (+51 -22), HeatTransfer.cc (+15 -16), KobayashiSarofimDevol.cc (+33 -7), SimpleHeatTransfer.cc (+35 -8)

bisaac 2017-02-19 22:18 Rev.: 56238

Fixed 3x3 matrix inversion for char oxidation model. Shouldn't change ansers.

59 lines of code changed in 2 files:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+11 -20), CharOxidationSmith.h (+48 -2)

jthornoc 2017-01-19 16:42 Rev.: 56181

Remove redundant spec for the table input.
Update the script to update the input files.

5 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+5 -1)

jthornoc 2017-01-19 16:41 Rev.: 56176

This pulls ArchesLabels out of the table interface.

214 lines of code changed in 3 files:

• CCA/Components/Arches/CoalModels: CharOxidationShaddix.cc (+8 -6), CharOxidationSmith.cc (+169 -169), CharOxidationSmith.h (+37 -37)

derekhar 2017-01-12 17:54 Rev.: 56173

More optimizations. This will require an update for the RT, OFC4_smith.

12 lines of code changed in 3 files:

• CCA/Components/Arches/CoalModels: CharOxidationShaddix.cc (+5 -4), CharOxidationSmith.cc (+7 -9), CharOxidationSmith.h (-1)

derekhar 2017-01-11 17:21 Rev.: 56171

Removed unneeded function evaluation of char reaction rate in inner loop.

8 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+8 -8)

derekhar 2017-01-11 15:09 Rev.: 56169

Switched core coal reaction and energy models for coal to use lambdas.

324 lines of code changed in 7 files:

• CCA/Components/Arches/CoalModels: CharOxidationShaddix.cc (+167 -32), CharOxidationShaddix.h (-266), EnthalpyShaddix.cc (+93 -24), EnthalpyShaddix.h (new), FOWYDevol.cc (+64 -18), FOWYDevol.h (-124)

derekhar 2017-01-10 12:33 Rev.: 56166

Fixed index ambiguity in CharOxiSmith.

2 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+2 -2)

derekhar 2017-01-09 17:24 Rev.: 56163

Changed iterator in CharOxidationSmith to lambda.

67 lines of code changed in 1 file:

• CCA/Components/Arches/CoalModels: CharOxidationSmith.cc (+67 -80)

derekhar 2017-01-09 12:01 Rev.: 56161

Particle drag model placed in a lambda. Replaced if-statement with functor in inner loop.

35 lines of code changed in 3 files:

• CCA/Components/Arches/CoalModels: DragModel.cc (+35 -51), DragModel.h (-1)