Directory Core/Malloc/

Lines of Code

Developers

Most Recent Commits

ahumphrey 2017-12-19 15:29 Rev.: 57481

* Finish repairs and cleanup in Core/Malloc, specifically the Uintah default Allocator (when SCI_MALLOC is enabled). Remove legacy pthread code, recursive locks, etc. Use std::mutex, no need for recursive mutex.

* Remove sci_system, use std:system

* Remove all remaining pthread remnants (including THREAD_LIBRARY references). Only use and rely on std::thread. Should have never been mixing pthreads with std::thread. Can't bank on what the underlying thread impl is.

* Generate new configure script.

* Lastly, fix issue with MPM PetscSolver include. Now Uintah compiles without Petsc (e.g. --without-petsc), as it should be able to.

234 lines of code changed in 12 files:

• Core/Malloc: AllocOS.cc (new), AllocOS.h (+19 -14), AllocPriv.h (+66 -96), Allocator.cc (new), Allocator.h (new), sub.mk (new)

ahumphrey 2017-12-15 15:16 Rev.: 57459

Define scinew to new when defined( DISABLE_SCI_MALLOC )

6 lines of code changed in 1 file:

• Core/Malloc: Allocator.h (+6 -1)

ahumphrey 2017-12-15 14:35 Rev.: 57457

Beginnings MALLOC_TRACE support removal, e.g. MALLOC_TRACE_TAG_SCOPE and other macros.

This library, though once useful, no longer works with Uintah and is not maintained, plus inextricably tied to SCI_MALLOC, which ultimately needs to go away.

84 lines of code changed in 3 files:

• Core/Malloc: AllocPriv.h (+21 -22), Allocator.cc (+29 -32), Allocator.h (+34 -51)

ahumphrey 2017-12-15 12:33 Rev.: 57456

Additional Uintah::Allocator cleanup.

130 lines of code changed in 2 files:

• Core/Malloc: Allocator.cc (+72 -64), Allocator.h (+58 -55)

ahumphrey 2017-12-12 17:27 Rev.: 57432

Fix redundant calls to shutdown within Uintah::Allocator. When SCI_MALLOC was enabled, this was being called for all allocs, frees, etc, rewinding the file pointer and rewriting the stats_out file in some cases on the order of millions of times, appending redundnat info. The failing multibox_coal_rmcrt tests were not actually failing, but simply taking too long (because of this issue) and was killed because a max run time was exceeded.

Now we explicitly register shutdown function with std::atexit. This way the malloc_stats file, with accumulated data gets written once at very end. This is orders of magnitude faster than before and captures the full range of allocs, frees, occuring during entire simulation. I am convinced the previous code omitted ~5% of the total memory-related calls.

Removed USE_LENNY_HACK and LINUX_GETENV_HACK macros, and cleaned up Allocator significantly. It is now fairly readable. Need to purge MallocTrace remnants in the near future. This is additional confusing logic (interleaved with MALLOC_STATS code) for a library that no longer works with Uintah.

954 lines of code changed in 4 files:

• Core/Malloc: AllocOS.cc (+4 -4), AllocPriv.h (+1 -1), Allocator.cc (+903 -707), Allocator.h (+46 -33)

ahumphrey 2017-12-11 19:09 Rev.: 57428

Fix failing multibox_rmcrt_coal tests.

Faulty logic in the use of USE_LENNY_HACK macro was causing shutdown() to be called an inordinate amounts of times, consequently having to unnecessarily rifle through all the MALLOC_STATS bookkeeping each time.

Please someone tell me that Uintah no longer needs things like USE_LENNY_HACK and LINUX_GETENV_HACK.....

6 lines of code changed in 2 files:

• Core/Malloc: Allocator.cc (+4 -4), Allocator.h (+2 -2)

allen 2017-09-12 14:12 Rev.: 56986

added specified z library

1 lines of code changed in 1 file:

• Core/Malloc: sub.mk (+1 -1)

jas 2017-04-20 13:18 Rev.: 56452

Update copyright.

8 lines of code changed in 10 files:

• Core/Malloc: AllocOS.cc (+1 -1), AllocOS.h (+1 -1), AllocPriv.h (+1 -1), Allocator.cc (+1 -1), Allocator.h (+1 -1), malloc.cc (+1 -1), new.cc (+1 -1), sub.mk (+1 -1)