Lines of Code
[root]/CCA/Components/OnTheFlyAnalysis
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 133 (100.0%) | 2922 (100.0%) | 21.9 |
| harman | 131 (98.5%) | 2919 (99.9%) | 22.2 |
| dav | 2 (1.5%) | 3 (0.1%) | 1.5 |
Added bullet proofing in getFaceIterator()
Fixed bug(s) when a control volume face coincides with a patch boundary.
constantPress_BC.ups
Added control volume to each corner of the domain. The size of the CV matches the patch extends.
0 lines of code changed in 6 files:
Changed allFaces from initializer_list to std::vector.
7 lines of code changed in 2 files:
Memory leaks:
- sched_initialize() only schedule task once per proc. VarLabels are created in the task and
they should be created once per proc.
- deleted scinew var faceQ.
15 lines of code changed in 1 file:
Moved allFaces initialization from .h file to constructor. Clang-9 reports an error otherwise.
4 lines of code changed in 2 files:
Dial back the number format precision so gnuplot can read the files.
0 lines of code changed in 2 files:
controlVolFluxes:
- Small changes so it will run in parallel and with other analysis modules.
Added input file that is useful in testing the control volume fluxes of Q against the total Q in a controlVol.
Added script for plotting the change in Q in the control vol and the net fluxes across the control vol faces.
16 lines of code changed in 1 file:
- Increased output precision to 16 sig. figs. That value can be changed using m_precision variable.
- defined new face iterator SFC_Cells.
It's working and giving the correct answers for 1 patch.
25 lines of code changed in 4 files:
Now writing out each of the faces fluxes and the net fluxes for each control volume.
Added warning if user specifies a control volume outside the computational domain.
Eliminated EOL spaces.
177 lines of code changed in 4 files:
controlVolume.*
- renamed d_X -> m_X
controlVolFluxes.*
- removed faceInfo(), bulletproofing(), assignLabel().
- Output is working for multiple control volumes.
- Progress made on creating a vectors of control volumes with a vector of varLabels.
Still under heavy construction
294 lines of code changed in 4 files:
The main pieces are in place and it runs.
130 lines of code changed in 4 files:
Integrated control volume class into controlVolFluxes.
Under heavy construction.
238 lines of code changed in 4 files:
Added new module to compute the face fluxes of Q and total Q inside control volume(s). For each
control volume the total Q, the net fluxes through each face and each of the faces
fluxes will be output to a separate file. The output frequency is controlled by the user.
1028 lines of code changed in 6 files:
Added controlVolume class that contains methods for looping over the control volume and the each of the
control volume faces. This class is based on Patch.
388 lines of code changed in 3 files:
Added support for face-centered <Vector> variables (tau_X_FC, tau_Y_FC and tau_Z_FC).
Consolidated redundant code into the new methods:
printHeader()
fprintf_Arrays()
Column width is controlled by d_col_width variable.
0 lines of code changed in 4 files:
Removed EOL spaces.
Changed output formatting, the delimiter is now " " instead of "\t"
containsCellInclusive()
- changes so the user can set a plane next to the x+,y+,z+ domain faces.
0 lines of code changed in 4 files:
- analyzeVars maintaines it's material subset.
- fixed memory leaks.
0 lines of code changed in 4 files:
Removed radiometer module from OnTheFlyAnalysis. It's been bolted directly to Arches.
0 lines of code changed in 4 files:
This commit fixes the error seen on the latest XCode (Mac) compiler.
It is my opinion that the current compiler is wrong, and that it will
be fixed at some point, which means the 'hack' in this commit could
be removed at that point. The only file in this commit that relates
to the XCode issue is SuperBox.h
There are also a few cosmetic / warning removal updates here too.
[Note: These commits passed my (partial) local RT, so shoving them into the build bot for full verification.]
M Core/Containers/SuperBox.h
* Main fix for XCode: Added the ValueCompare2 function. See comment in file
about the issue.
* Added some white space.
* For header files, one line functions should be on the same line as the function name.
The main purpose of header files is to see the interface, and this makes reading
the interface much easier. The implementation is (especially for one line functions)
usually not material to the person looking through the spec (.h file).
* Added a comment with the name of the class at the end of the class to make
scanning through the file easier.
M CCA/Components/OnTheFlyAnalysis/meanTurbFluxes.cc
- Fixed warning (ie: initialized var)... and probable actual error (if, I think, there were no comments
in the file being read).
M CCA/Components/Schedulers/DetailedTasks.cc
- Always use {}, even in single line if/for statements. It's just a good habit.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Fix type mismatch warning (and added some white space).
M CCA/Components/Solvers/HypreSolver.h
- It is undefined to throw exceptions in destructors. Also, these throws should
never happen as the type is checked when the object is created. Replaced with error messages
and program exit.
M Core/Grid/Variables/ComputeSet.cc
- Fix compiler warnings. Can't pass a null reference, so doesn't make sense to check for one.
Instead, check to see if the referenced object doesn't contain anything.
3 lines of code changed in 2 files:
Dust off nodalHeatFlux task so the flatPlate heat flux module works.
MPMFlags:
- simplified setting d_computeNodalHeatFlux & d_computeScaleFactor flags
HeatConduction:
- Added dividers
- Added printSchedule() & printTask() calls
SerialMPM:
- Added "MPM::" to all printTask() and printSchedule() messages.
- uncommented scheduleComputeNodalHeatFlux()
4 lines of code changed in 2 files:
planeAverage:
- fixed an issue when periodic BC are used.
meanTurbFluxes:calc_Q_prime()
- Throw an exception if the planar average has not been previously computed
15 lines of code changed in 3 files:
Fixed memory double deletes.
6 lines of code changed in 3 files:
Polish
- more descriptive variable names
- removed debugging code.
- update comments
meanTurbFluxesVerify.py
-cast numSamples, so it works with python 3.5.
47 lines of code changed in 4 files:
- Instructions on how to verify this module.
- Added "switch" to control when verification task is enabled.
<enableVerification/>
planeAverage::transformCellIndex()
- fixed bug with YZ plane.
All plane orientations have been verifed on 27 patches & cores.
47 lines of code changed in 3 files:
Added MPI::Bcast() call after MPI::Reduce() so all cores have the same values for
sum and weight.
Identical answers for the verification test, 1 patch vs 27 patches in the XY plane.
33 lines of code changed in 4 files:
Added code so verification tests can be performed when there are multiple patches orthogonal to the
specified plane.
It runs in parallel (27 cores) but the answers are off.
207 lines of code changed in 4 files:
meanTurbFluxesVerify.py
- Fixed error in covariance calculation.
- Cutput the covariance to a file.
- More descriptive file headers
meanTurbFluxes/planAverage
- fixed copy/paste error
- vel.z() * vel.z() ); // w'u'
+ vel.z() * vel.u() ); // w'u'
( Even your mother can find these types of errors if you do a good job formating the equations.)
Allow for dynamic headers used in the output files.
The code is verified for a single patch problem.
78 lines of code changed in 3 files:
Added description of the algorithm.
More work on verifying the code.
131 lines of code changed in 3 files:
Updated Copyright date
29 lines of code changed in 43 files: