Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 24 (100.0%) | 141 (100.0%) | 5.8 |
| harman | 22 (91.7%) | 93 (66.0%) | 4.2 |
| dav | 2 (8.3%) | 48 (34.0%) | 24.0 |
OffsetArray1.h
- using m_<var> intead of _<var>
- Added {} as needed
- Added method "to_stl_vector()". This converts offset1 -> std::vector.
DORadiationModel
- Eliminated base 1 arrays used in fortran routines. No more +1, -1 offsets all over the place.
- Name changes:
oxi -> m_oxi
omu -> m_omu
oeta -> m_oeta
wt -> m_wt
_radIntSource -> _emissSrc_label
- Added const to method prototypes variables as needed.
- Added intensityIndx() method to compute the intensity index. No more "ord+iband*m_totalOrds" all over.
82 lines of code changed in 2 files:
This commit fixes the error seen on the latest XCode (Mac) compiler.
It is my opinion that the current compiler is wrong, and that it will
be fixed at some point, which means the 'hack' in this commit could
be removed at that point. The only file in this commit that relates
to the XCode issue is SuperBox.h
There are also a few cosmetic / warning removal updates here too.
[Note: These commits passed my (partial) local RT, so shoving them into the build bot for full verification.]
M Core/Containers/SuperBox.h
* Main fix for XCode: Added the ValueCompare2 function. See comment in file
about the issue.
* Added some white space.
* For header files, one line functions should be on the same line as the function name.
The main purpose of header files is to see the interface, and this makes reading
the interface much easier. The implementation is (especially for one line functions)
usually not material to the person looking through the spec (.h file).
* Added a comment with the name of the class at the end of the class to make
scanning through the file easier.
M CCA/Components/OnTheFlyAnalysis/meanTurbFluxes.cc
- Fixed warning (ie: initialized var)... and probable actual error (if, I think, there were no comments
in the file being read).
M CCA/Components/Schedulers/DetailedTasks.cc
- Always use {}, even in single line if/for statements. It's just a good habit.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Fix type mismatch warning (and added some white space).
M CCA/Components/Solvers/HypreSolver.h
- It is undefined to throw exceptions in destructors. Also, these throws should
never happen as the type is checked when the object is created. Replaced with error messages
and program exit.
M Core/Grid/Variables/ComputeSet.cc
- Fix compiler warnings. Can't pass a null reference, so doesn't make sense to check for one.
Instead, check to see if the referenced object doesn't contain anything.
48 lines of code changed in 2 files:
Updated Copyright date
11 lines of code changed in 20 files: