fortran
(1 files, 37 lines)
[root]/CCA/Components/Arches/CoalModels
fortran
(1 files, 37 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 151 (100.0%) | 3810 (100.0%) | 25.2 |
| jthornoc | 78 (51.7%) | 2007 (52.7%) | 25.7 |
| u0407585 | 34 (22.5%) | 1483 (38.9%) | 43.6 |
| wyxpuma | 10 (6.6%) | 215 (5.6%) | 21.5 |
| derekhar | 17 (11.3%) | 95 (2.5%) | 5.5 |
| awabboud | 6 (4.0%) | 6 (0.2%) | 1.0 |
| dav | 6 (4.0%) | 4 (0.1%) | 0.6 |
Added more statements to inform users of bad input.
0 lines of code changed in 2 files:
Add back in missing files from Dav's commit r52897.
429 lines of code changed in 2 files:
Recommitting Arches changes that were reverted by Dav's commit, r52897.
0 lines of code changed in 8 files:
Reverting code to r52880 before my memory use fix commit. While most tests passed, the ones using AMR and the dynamic load balancer were not passing and the weeds are too deep within them to quickly figure out what is causing the problems. Next week I will attempt to figure out what is going on with them. My guess is that it will take quite a bit of effort to understand the inner workings of the dynamic loadbalancer in order to get everything to work, so it may be quite a while before this fix may go in.
4 lines of code changed in 6 files:
Added Tognotti's Devolatilization model. This will not impact regression tests.
430 lines of code changed in 3 files:
Fixed a bad merge from a previous commit.
3 lines of code changed in 1 file:
Added an additional particle model for radiation. The constant complex-index-refraction model. Decoupled the particle temperature from the gas temperature for radiation.
10 lines of code changed in 3 files:
Fix some mistakes during merge.
0 lines of code changed in 3 files:
Made Coal regression tests have consistent boundary conditions and
initial conditions.
14 lines of code changed in 2 files:
Made the 2 regression test work, and dqmom_test_1. Modified radiation
files so that they are compatible with new coal data base, and new
labels.
2 lines of code changed in 3 files:
Fixed a failed merge and used Derek's latest version of RadProperties
from svn tree.
2 lines of code changed in 1 file:
Removed Ben print statements. Added Yamamotodevol changes. Made
coal_channel work. Eddited radiation files to fix bugs. Fixed Enthalpy
shadix radiation bug.
6 lines of code changed in 2 files:
adding abskp varlable to enthalpy shaddix
51 lines of code changed in 1 file:
Adding in Ben\'s commits, which update the models to the non-time-lagged
version. Several other modification were made in these changes to aid in
fixing the time-lag problem.
-Jeremy and Ben
6 lines of code changed in 4 files:
Merge conflicts.
5 lines of code changed in 3 files:
add comment for derek.
1 lines of code changed in 1 file:
Removed Ben print statements. Added Yamamotodevol changes. Made
coal_channel work. Eddited radiation files to fix bugs. Fixed Enthalpy
shadix radiation bug.
222 lines of code changed in 8 files:
adding abskp varlable to enthalpy shaddix
53 lines of code changed in 1 file:
Fix some compiler errors.
Remove git test commit to demonstrate the awesomeness that is Git.
5 lines of code changed in 2 files:
Adding in Ben\'s commits, which update the models to the non-time-lagged
version. Several other modification were made in these changes to aid in
fixing the time-lag problem.
-Jeremy and Ben
895 lines of code changed in 20 files:
Merge conflicts.
209 lines of code changed in 10 files:
Merge conflicts.
107 lines of code changed in 7 files:
Added bullet-proofing for several of the labels used radiation coefficient model.
Fixed some radiation related screen-output. General housekeeping changes.
2 lines of code changed in 1 file:
Fix unit error in source term for gas enthalpy.
3 lines of code changed in 1 file:
This commit, moves all computations of abskp to radPropertyCalculator.cc. It also makes improvements to DO-radiation scattering, and radprops.
A new class was created in this commit, which contains the machinery for computing particle absorption coefficients.
This commit changes the answers to two arches tests, coal_channel and coal_RadPropsPlanck.
66 lines of code changed in 3 files:
Update the Re correlation for drag models. Replace the unneeded spherical coordinate calculation with only magnitude calculation
6 lines of code changed in 6 files:
Fixed Char oxidation activation energy sign error. This will break the coal regression testssvn --helpsvn --help
7 lines of code changed in 1 file:
Fixed bug that prevents restart in this devolatilization model.
1 lines of code changed in 1 file:
added extra coefficients to Richards/fletcher devol model for derek
13 lines of code changed in 2 files:
added 2-step richards-fletcher devol model, and fixed kobayashi-sarovim devol model. No regression tests should break
777 lines of code changed in 7 files:
Added comments to improve clairity of coal drag model.
3 lines of code changed in 2 files:
Pulled user options from the coal source code, and made them required inputs in arche spec
255 lines of code changed in 20 files:
Corrected heat transfer model for coal. The difference in velocity components will now be used to compute the rate of convective heat transfer. For coal particles and previous to this commit, convection used to be based on the difference between total velocity magnitude of gas and particles.
2 lines of code changed in 1 file:
This patch changes the interface used to invoke radiation property models: hottel-sarofim, Burns-christian, and constant.
///---IMPORTANT!! OLD INPUT FILES WILL NO LONGER PARSE CORRECTLY AND MUST INVOKE THE DESIRED PROPERTY MODEL USING "property_calculator" WITHIN THE RADIATION MODEL --//
The property models are now called using property_calculator. The regression test input files show the correct syntax to invoke the property models.
This was done to improve the modularity of the code.
A coal regression test has also been added.
Other notes:
--The OPL for hottel-sarofim can no longer be passed through the radiation model and must also be passed through the property_calculator.
--The label for the absorption coefficient must be set through the property_calculator.
--For coal cases, the label of abskp must be set to "Julien_abskp" in both the PropertyModel and property_calculator. The user will be given more freedom in future patches. This was done to prevent a multiple-computes error.
--For coal cases, computation of the abskp values is less than ideal. Currently, abskp is computed for every time step, however it is only needed when then the radiation solve is executed. This will be removed in future patches.
--For coal cases, a bug was removed where abskp was summed to be 3x its correct value when using second order Runge-Kutta. Fortunately, first order Runge-Kutta computed the correct value for abskp.
6 lines of code changed in 3 files:
to fix the drag force balance
3 lines of code changed in 3 files:
to update the drag force
212 lines of code changed in 7 files: