Lines of Code
[root]/CCA/Components/Arches/PropertyModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 53 (100.0%) | 1085 (100.0%) | 20.4 |
| derekhar | 21 (39.6%) | 545 (50.2%) | 25.9 |
| jthornoc | 26 (49.1%) | 526 (48.5%) | 20.2 |
| u0407585 | 2 (3.8%) | 7 (0.6%) | 3.5 |
| dav | 4 (7.5%) | 7 (0.6%) | 1.7 |
Recommitting Arches changes that were reverted by Dav's commit, r52897.
0 lines of code changed in 4 files:
Reverting code to r52880 before my memory use fix commit. While most tests passed, the ones using AMR and the dynamic load balancer were not passing and the weeds are too deep within them to quickly figure out what is causing the problems. Next week I will attempt to figure out what is going on with them. My guess is that it will take quite a bit of effort to understand the inner workings of the dynamic loadbalancer in order to get everything to work, so it may be quite a while before this fix may go in.
6 lines of code changed in 2 files:
Added an additional particle model for radiation. The constant complex-index-refraction model. Decoupled the particle temperature from the gas temperature for radiation.
21 lines of code changed in 2 files:
Fixed particle temperature labels, so they are consistent with the new
particle temperature calculation.
2 lines of code changed in 1 file:
Fixed a failed merge and used Derek's latest version of RadProperties
from svn tree.
1 lines of code changed in 1 file:
Removed Ben print statements. Added Yamamotodevol changes. Made
coal_channel work. Eddited radiation files to fix bugs. Fixed Enthalpy
shadix radiation bug.
43 lines of code changed in 1 file:
Removed Ben print statements. Added Yamamotodevol changes. Made
coal_channel work. Eddited radiation files to fix bugs. Fixed Enthalpy
shadix radiation bug.
1 lines of code changed in 1 file:
Added bullet-proofing for several of the labels used radiation coefficient model.
Fixed some radiation related screen-output. General housekeeping changes.
45 lines of code changed in 1 file:
Minor housekeeping commit. Changed spacing and coding-order to be easier to read.
101 lines of code changed in 1 file:
This commit, moves all computations of abskp to radPropertyCalculator.cc. It also makes improvements to DO-radiation scattering, and radprops.
A new class was created in this commit, which contains the machinery for computing particle absorption coefficients.
This commit changes the answers to two arches tests, coal_channel and coal_RadPropsPlanck.
201 lines of code changed in 7 files:
Added Scattering in discrete ordinates radiation using the radProps property model. Also made some changes to reflections in discrete ordinates radiation. In this version, the complex index of refraction is a constant for all particles.
43 lines of code changed in 1 file:
This is Stage 1 of a commit which adds reflections for DO-Radiation. The RT-Tests are expected to fail, due to a new VarLabel in the checkpoints. The uda files are expected to remain unchanged.
2 lines of code changed in 1 file:
Carry forward properties properly.
1 lines of code changed in 1 file:
RMCRT should be using the OLDDW values of abskg.
This was fixed by carrying forward the radiation properties from the
previous timestep rather than changing the DW in the RMCRT source term
due to a grid issue with the dataonion approach.
Also, fixed a missing call to commonProblemSetup for the radiation
properties. This was causing properties to have bogus values on the
first timestep that could lead to non-terminating rays.
This commit may change the answers.
6 lines of code changed in 2 files:
- Cleanups from Vulcan@LLNL. Mostly cosmetic, though a few real fixes
found while porting to BGQ machine.
- Replaced proc0thread0cerr with proc0cerr as proc0cerr is (now
specifically) defined to only print out from thread 0 of process 0.
M CCA/Components/SimulationController/AMRSimulationController.cc
- Cosmetic
- Alphabetize the #includes for better readability and to remove duplicates.
- Put the #ifdef USE_GPERFTOOLS around entire block, instead of having
it multiple times and leaving dead if statements around it.
M CCA/Components/SimulationController/SimulationController.cc
- Cosmetic: Fix indentation (use diff -b to better see differences.)
M CCA/Components/DataArchiver/DataArchiver.cc
- Added the ability to specify checkpoint time via hours (in addition to seconds).
- Cleaned up the code to make it more readable for parsing this
information from input file - ie, use variable names that correspond
to the data they hold.
- Commented out a few lines of code that didn't do anything.
- Indented for readability, lined up some variable assignments.
M CCA/Components/Arches/CompDynamicProcedure.cc
- Alphabetize the #includes for better readability and to remove duplicates.
- Replaced proc0thread0cerr with proc0cerr.
M CCA/Components/Arches/DQMOM.cc
M CCA/Components/Arches/PropertyModels/PropertyModelBase.h
M CCA/Components/Arches/IncDynamicProcedure.cc
M CCA/Components/Arches/Arches.cc
- Replaced proc0thread0cerr with proc0cerr.
M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
- Throw a ProblemSetupException as that is what the error is.
M Core/Exceptions/InvalidState.cc
- Propagate (user supplied) error message.
M Core/Grid/Patch.cc
- Whitespace cleanup for readability.
M Core/Grid/Grid.h
- Whitespace cleanup for readability.
- Parameter to setExtraCells() is now (explicitly) const.
M Core/Grid/Level.cc
M Core/Grid/Grid.cc
- Coding standard and whitespace cleanup.
M Core/Parallel/Parallel.h
- Updated proc0cout to handle threaded versions of Uintah. If in MPI
only mode, then only prints for proc 0. If in threaded mode, only
prints for proc 0 thread 0.
- Removed proc0thread0cout as now only proc0cout is needed.
M Core/Thread/ThreadPool.h
- Remove tabs, line up code.
M Core/Thread/Thread.h
M Core/Thread/Parallel.h
M testprograms/Thread/parallel.cc
- Added the ThreadNS namespace because there are two classes named
'Parallel' in Uintah, and the one in the new ThreadNS is only used
in a few locations and thus is easier to move into its own NS.
M StandAlone/inputs/UPS_SPEC/ups_spec.xml
- Added 'walltimeStartHours' and 'walltimeIntervalHours' (to augment the
version that uses just seconds).
- Lined up for better readability.
M tools/StackTrace/StackTrace.cc
- Fixes for the stack trace tool for machines that only provide symbol
numbers in their stack traces. However, unfortunately, this still
doesn't seem to provide a valid stack trace on Vulcan.
1 lines of code changed in 2 files:
Apply a BC after initialization for HL.
-Ben, Derek and Jeremy
0 lines of code changed in 2 files:
Added "reqiures" for variables needed in cases using the RadProps library.
22 lines of code changed in 1 file:
Switched order of operations in RadProperties so that the _calc object is populated first.
2 lines of code changed in 1 file:
This commit has added a regression test and is expected to cause failure in the nightly RT on coal_RadPropsPlanck.ups!
Fixed the interface for computation of absorption coefficients using the RadProps library.
The RadProps library can use one of two methods to compute the particle absorption coefficients (Planck or Rossland).
The new R-Test is similar to the coal-channel case called coal_RadPropsPlanck.
This commit also removed a work-around (or hack) due to a boundary condition bug, which was fixed by Tony Saad.
79 lines of code changed in 2 files:
* move operator creation out of Arches.cc and into Operators.cc
* Added a couple new input files.
* More work on the Lagrangian particle stuff, including velocity and
position updates.
1 lines of code changed in 1 file:
Added an additional function to the radiation properties which sets absorption coefficients at the boundaries.
7 lines of code changed in 2 files:
Cleaning up some more bugs associated with an earlier commit.
0 lines of code changed in 2 files:
The saga continues...missing another delete. Would be useful if memory
tests actually worked on a mac.
1 lines of code changed in 1 file:
Adding missing files.
400 lines of code changed in 2 files:
** THIS COMMIT CHANGES THE ANSWERS **
Moving the radiation properties into the property model. Currently, the
properties are being computed every timestep on every RK stage. This
fact changes the answers from previous results. Also, the ERSCG term was
moved into the fortran for DORadiation which also caused some numerical
fuzzzzzzzzzz.
With this commit, the radiation properties are completely independent
from the radiation model allowing for use of multiple radiation models
at once (ie, DORadiation + RMCRT virtual radiaometer).
1 lines of code changed in 1 file:
Complete divorce of the radiation properties from the radiation models
themselves. This simplified the radiation models considerably. The
properties are now being computed upstream and only accessed by the
models themselves.
For the RadProps models with particles, the particle interface needs to
added back in. It should be done in a generic way so as not to preclude
any CQMOM interface.
1 lines of code changed in 2 files:
Removed cout statement in problem initilization.
0 lines of code changed in 1 file:
This patch changes the interface used to invoke radiation property models: hottel-sarofim, Burns-christian, and constant.
///---IMPORTANT!! OLD INPUT FILES WILL NO LONGER PARSE CORRECTLY AND MUST INVOKE THE DESIRED PROPERTY MODEL USING "property_calculator" WITHIN THE RADIATION MODEL --//
The property models are now called using property_calculator. The regression test input files show the correct syntax to invoke the property models.
This was done to improve the modularity of the code.
A coal regression test has also been added.
Other notes:
--The OPL for hottel-sarofim can no longer be passed through the radiation model and must also be passed through the property_calculator.
--The label for the absorption coefficient must be set through the property_calculator.
--For coal cases, the label of abskp must be set to "Julien_abskp" in both the PropertyModel and property_calculator. The user will be given more freedom in future patches. This was done to prevent a multiple-computes error.
--For coal cases, computation of the abskp values is less than ideal. Currently, abskp is computed for every time step, however it is only needed when then the radiation solve is executed. This will be removed in future patches.
--For coal cases, a bug was removed where abskp was summed to be 3x its correct value when using second order Runge-Kutta. Fortunately, first order Runge-Kutta computed the correct value for abskp.
29 lines of code changed in 3 files:
Adding a gaussian initialization function to the property model.
To do: This really could be generalized to transport eqns, sources, etc...
60 lines of code changed in 2 files:
Cleanup a few minor issues with the Turbulence model. Also added a box
filter to the mix.
8 lines of code changed in 2 files: