Lines of Code
[root]/CCA/Components/Wasatch/Expressions/EmbeddedGeometry
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 20 (100.0%) | 65 (100.0%) | 3.2 |
| tsaad | 6 (30.0%) | 42 (64.6%) | 7.0 |
| jsutherland | 12 (60.0%) | 22 (33.8%) | 1.8 |
| dav | 2 (10.0%) | 1 (1.5%) | 0.5 |
Numerous changes to address warnings kicked up by "cppcheck" - a decent static code analysis tool.
Also some formatting changes along the way.
7 lines of code changed in 4 files:
remove an unnecessary division when constructing the oscillating cylinder. Thanks James for pointing this out.
0 lines of code changed in 2 files:
allow creation of shared geometry across multiple expressions. this will reduce input file clutter and overhead.
13 lines of code changed in 1 file:
change inclusion path for a header
2 lines of code changed in 2 files:
Remove "structured" namespace which has now been removed from SpatialOps
3 lines of code changed in 4 files:
update doxygen in Wasatch. This will help us get automatic builds of a Wasatch doxygen page through Jenkins.
10 lines of code changed in 1 file:
add nebo-based boundary conditions to Wasatch. This change will allow us to execute boundary conditions on GPUs. This is a transitional commit and you will notice an increase in memory usage due to supporting both types of applying boundary conditions. Not all boundary conditions are currently FULLY GPU-ready. As we go through the transition, more boundary conditions will be GPU ready. With this commit however, all constant-value boundary conditions are GPU ready.
4 lines of code changed in 1 file:
Eliminate obsolete header file.
0 lines of code changed in 1 file:
The following commits are mostly cosmetic in nature and should not
change any answers.
Lots of white space and indentation fixes. It is so much easier to
read code when variables are lined up, and values assigned to them
are also lined up.
M CCA/Components/Parent/Switcher.cc
- Variable "no_solver_specified" was misleading. It meant "no command
line solver specified". However, this is the default case and thus
this variable is not needed.
M CCA/Components/Wasatch/Expressions/EmbeddedGeometry/EmbeddedGeometryHelper.h
- InvalidState exception moved to Uintah namespace.
M CCA/Components/Solvers/AMR/AMRSolver.h
- Parent scheduleInitialize() is purely virtual so must be implemented
in each solver. This allows the user to more easily see whether the
scheduleInitialize() step actually does anything or not.
M CCA/Components/Solvers/HypreSolver.cc
- 'firstPassThrough_' is a class variable so needs the '_' suffix to
meet coding standard.
M CCA/Components/Solvers/SolverFactory.cc
M CCA/Components/Solvers/DirectSolve.cc
M CCA/Components/Solvers/HypreSolver.h
M CCA/Components/Solvers/SolverFactory.h
M CCA/Components/Solvers/DirectSolve.h
M CCA/Components/Solvers/CGSolver.h
- Indentation.
- Added (empty) scheduleInitialize() to Solvers that
require it to be implemented but do not actually use it.
M CCA/Ports/SolverInterface.h
- Moved destructor/constructor empty implementations into .h file for
easier viewing.
- Indentation / white space.
M CCA/Ports/SolverInterface.cc
- This file is empty now so should most likely be removed soon.
M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
- Throw exception if gzipInflate fails (previously it tried to just
kept going and the error was thus hard to find).
M CCA/Ports/sub.mk
- Don't need to compile empty file SolverInterface.cc now.
M Core/Exceptions/ErrnoException.h
M Core/Exceptions/ErrnoException.cc
- Change var name from errno_ to err_ as it might be easy to confuse "errno_" with "errno".
M Core/Exceptions/sub.mk
- Alphabetize list of libraries.
M Core/Exceptions/InvalidValue.cc
- Don't need superfluous "using std::cout".
M Core/Exceptions/InvalidState.cc
M Core/Exceptions/InvalidState.h
- Moved from SCIRun namespace to Uintah for two reasons:
1) SCIRun namespace will eventually go away.
2) InvalidState exception is already in Uintah namespace and these should be consistent.
M Core/IO/sub.mk
- IO now relies on Exception as the UintahZlibUtil now throws an exception if an error occurs.
M Core/IO/UintahZlibUtil.h
- White space / indentation.
- Add comment about what gzipInflate returns.
M Core/IO/UintahZlibUtil.cc
- Throw an exception when an error occurs instead of just return 0, as
the 0 is never checked and causes debugging to be more difficult.
M StandAlone/sus.cc
- Indent / white space.
- Print out which solver is being used.
1 lines of code changed in 2 files:
set proper intrusion values in extra cells. This approach will reduce the number of if statements in other loops (e.g. coef matrix) that require knowledge of the intrusion. This is an important step to handle intrusions that intersect with domain boundaries.
25 lines of code changed in 2 files: