Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 14 (100.0%) | 92 (100.0%) | 6.5 |
| dav | 2 (14.3%) | 80 (87.0%) | 40.0 |
| jas | 9 (64.3%) | 7 (7.6%) | 0.7 |
| ahumphrey | 3 (21.4%) | 5 (5.4%) | 1.6 |
This fixes the lineextract problem seen on BGQ machine vulcan@llnl.
However, it is likely that this same problem will/does occur on any
strange statically linked architecture. While this isn't a complete
fix, it will allow Jennifer to use the utility for now.
The problem in this case is that static variables are not always
(ever?) created (or at least their constructors are not called) upon
program startup (like they are supposed to be). The Uintah type
system creates a list of all variable types (eg: CCVariable<double>)
that are available to the program, and these are stored in the static
map variables 'types' found in Core/Disclosure/TypeDescription.cc.
However, these types are put into the 'types' variable by the
register_type() function which is called from the TypeDescription
constructor for each type.
Later, when a (textual) type decription is read from an UDA file, that
string is looked up in the 'types' map... If the map was never populated,
then an 'unknown type' type is returned and then an error occurs because
we don't know the real type.
To solve this problem, I just manually instantiate a number of
variable types in the bgq_hack() function in lineextract.cc.
M StandAlone/tools/extractors/lineextract.cc
- Line up variables (and their initialization) for easier viewing.
- Add white space, remove tabs and indent properly.
- Number of coding standard stylistic updates.
- Added bgq_hack() function to manually instantiate needed types.
- Added in warning message in case a needed type hasn't been hacked in yet.
M StandAlone/tools/extractors/timeextract.cc
- White space fixes.
- This file has not been 'hacked' like lineextract, but if it is needed, the
same hack would be easy to copy over.
M Core/DataArchive/DataArchive.cc
M Core/Disclosure/TypeDescription.cc
- Cosmetic updates - white space and coding standard clean ups.
80 lines of code changed in 2 files:
Remove Heirarchical and BNR regridder and supporting classes, tests, etc.
* NOTE: It has been shown these do not scale, and in the case of ICE these regridders have undesired side effects WRT fine level solution, and in fact are disallowed by ICE.
* The only input file found to be using the Heirarchical regridder was /inputs/Examples/wave.ups (Similar to AMRWaveEquation test problem from Chombo), and has been changed to have the appropriate <Regridder> attributes.
* This commit also enables clean support for GPUPerPatch variables need by Wasatch with CUDA enabled.
4 lines of code changed in 2 files:
Finish stripping out Windows support.
Also update UPS_Spec from previous commit.
1 lines of code changed in 1 file:
Eliminate warnings as turned up by clang.
2 lines of code changed in 1 file:
Updated copyright information.
5 lines of code changed in 8 files: