Lines of Code
[root]/CCA/Components/Arches/ParticleModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 131 (100.0%) | 3117 (100.0%) | 23.7 |
| jthornoc | 95 (72.5%) | 2638 (84.6%) | 27.7 |
| derekhar | 8 (6.1%) | 217 (7.0%) | 27.1 |
| dav | 4 (3.1%) | 109 (3.5%) | 27.2 |
| dsunder | 3 (2.3%) | 82 (2.6%) | 27.3 |
| u0407585 | 12 (9.2%) | 50 (1.6%) | 4.1 |
| wyxpuma | 3 (2.3%) | 14 (0.4%) | 4.6 |
| bisaac | 4 (3.1%) | 6 (0.2%) | 1.5 |
| ahumphrey | 2 (1.5%) | 1 (0.0%) | 0.5 |
Warning.
0 lines of code changed in 2 files:
Adding a stub for a kokkos momentum solver.
Adding a print statement for registered Arches tasks.
1 lines of code changed in 2 files:
Have the solvers generate the new task factories rather than Arches.cc
3 lines of code changed in 2 files:
Reduce the domain edge BC information to be contained to local patches
only. Also reduce the numbers of reduction variables for inlet areas to
only occur in the case of Swirl and MassFlow inlets.
Clean up some warnings.
This commit should only change the answers for the
channel_LagPart_inlet.
0 lines of code changed in 1 file:
The main updates in this commit are to configure and the build system:
A number of bullet-proofing / clean-ups have been added to configure,
and the dependency of Arches on Wasatch has been removed. (Note,
Arches still needs to build TabProps/RadProps in the Wasatch 3P.) I
have tested this on several machines, but it is possible that it will
now catch some peoples' bad configure lines (that 'worked' before but
only accidentally). If your configure stops working because of this
commit, please let me know so I can help you fix it. -Dav
M configure
M configure.ac
- Force bad configure command line arguments to be errors instead of warnings.
This will help avoid users accidentally mis-typing an arg and not noticing.
The autoconf configure system does not normally allow this to happen as
their philosophy is that configure usually calls a sub-configure and passes
args down to it... Thus configure "ignores" bad args under the theory that
a "sub configure" will use them. However, we don't do this and this will
help catch configure command line typos and potentially save developers and
users a lot of headaches.
The bad news is that in order to get this functionality, we have
to hack the autconf'd generated configure script and add a
variable (enable_option_checking=fatal) at the top. I have added
a section to configure.ac with the information about doing this,
but anyone who re-generates configure needs to manually follow the
instructions.
- Configure now will immediately tell you if you have typed in an invalid
file/directory name (bad spelling, doesn't exist) for the --with flags.
Perviously this occurred manually each time (now it is part of the macro)
at the point in the configure script when the library was tested for.
- Fix handling of finding the C/C++ compilers and version checking better.
Configure now determines which compiler (eg: GCC, ICC, XLC) you are
using explicitly and can test for things (like version) appropriately.
The version check may still need to be updated a little.
- Updated the --with handling to know whether the flag was set or not. Previously
we were using a "" (blank) value, which was ambiguous.
- Flag --without as invalid on anything we don't explicitly handle (we
only handle without on a few things such as: --without-fortran or
--without-hypre).
- Allow the external Wasatch 3P to be specified on a single line (instead
of having a separate line for SpatialOps, ExprLib, etc) using
--with-wasatch3p=DIR. This will find all 4 W3P libs with one configure line.
- Got rid of IS_VS (wasn't set/used and don't know what it was for).
- While "no" and no (without quotes) are the same thing to configure, be consistent
and use "no" (with quotes) everywhere.
- Remove the BUILD_WASATCH_FOR_ARCHES logic, as we no longer need Wasatch to
be built for Arches.
- Clean up the left over files from relatively new MPI const test section.
- Fix the HAVE_ACCELERATE
- Update --enable-wasatch_3p to take a list of libs to build (in the case you only
wish to build a subset. Eg: --enable-wasatch_3p=radprops,tabprops
Pass list of libs to the build_wasatch_3p.sh script.
17 lines of code changed in 2 files:
Removed the running-sum averaging variables from the deposition model and wall heat transfer model. Removed t_ave_start flag. Modified the way the deposition rate is accounting for multiple environments. This commit is expected to change the answers, and the number of saved variables for the arches rt test: 1GW_RT.
6 lines of code changed in 4 files:
Dont output init timestep on coal_channel_hi_vel because this seems to
be causing problems for the RT.
Clean up some warnings.
3 lines of code changed in 1 file:
Missing include.
0 lines of code changed in 2 files:
Removing Operators.
281 lines of code changed in 34 files:
Removing spatialops includes.
Converting Lagrangian particle to standard Uintah loops.
2 lines of code changed in 7 files:
Change relaxation_coe to relation_coef.
Change channel_WD_CO to have a shorter, symmetric geometry.
1 lines of code changed in 1 file:
Kokkos for RateDeposition.
Committed for Minmin (he did the hard work).
757 lines of code changed in 2 files:
Make sure coal density is initialized to zero in the extra cells.
Add a wall-deposition test (contribution from Minmin).
7 lines of code changed in 1 file:
Turn off Yamamoto. This model isnt implemented correctly and is
producing garbage.
Change the branching in CoalDensity. This keeps answers consistent with
the SpatialOps implementation so as not to change answers.
39 lines of code changed in 1 file:
Kokkos -> ShaddixOxidation. This seems to have changed the answers for
CQMOM_coal_test. This isnt too surprising because the SO version was
iterating the entire patch with the same number of iterations while this
new version is iterating pointwise. The differences seem like fuzz.
310 lines of code changed in 3 files:
Kokkos -> ShaddixEnthalpy.
301 lines of code changed in 2 files:
Kokkos into FOWY (new version).
This model still needs to be updated to be consistent with the version
Ben was developing.
184 lines of code changed in 2 files:
Fixed the bug with partMassFlow.ups and cleaned up the files a little.
196 lines of code changed in 4 files:
More kokkos into Arches.
Injecting some parallel_for into DepositionVelocity. This still needs
work.
67 lines of code changed in 3 files:
Turns out that multipying your model by a random number is a bad idea.
(fix a missing initialization on m_pi)
80 lines of code changed in 1 file:
Missing initialization of a couple variables.
3 lines of code changed in 1 file:
Get the example cleaned up and working.
22 lines of code changed in 2 files:
Drag model -> Kokkos
Updated input files + spec.
114 lines of code changed in 5 files:
Kokkos for CoalTemperature.
Update OFC4_smith to use correct input.
19 lines of code changed in 1 file:
GridTools->ArchesCore namespace.
2 lines of code changed in 1 file:
Typos.
2 lines of code changed in 1 file:
Kokkos-ized CoalDensity.
56 lines of code changed in 1 file:
Kokkos-izing BodyForce.
56 lines of code changed in 2 files:
Constant Particle Lambda.
28 lines of code changed in 2 files:
Lambdas for CoalMassClip. This model wasn't under RT but isn\'t being
use. It may need to be pruned.
10 lines of code changed in 1 file:
Remove CoalTemperatureNebo.
Update SampleTask with lambdas.
0 lines of code changed in 4 files:
to update the deposition thickness calculation by relaxation strategy
13 lines of code changed in 2 files:
Replace usage of NULL macro (type int) with nullptr (pointer literal of type: nullptr_t).
nullptr is implicitly convertible and comparable to any pointer type or pointer-to-member type, but is not implicitly comparable to integral types, except that it is convertible to bool (explicitly).
1 lines of code changed in 2 files:
Removing code duplication that was used for functor profiling.
0 lines of code changed in 2 files:
Fix the problem with fortran .h files (in Arches) not being generated correctly (on the binary
side) when CUDA is turned on.
Update the make system so that the dependency rules for CUDA enabled files are created
automatically. The user no-longer has to specify that each CUDA_ENABLED_SRCS .cu file
depends on the corresponding .cc file. Updated both Wasatch and Arches to use the
new approach.
M Makefile.in
- Add a 'function' (make-cuda-target) that will create CUDA dependency rules automatically,
instead of having the developer have to list the rules manually. This function must
be called in each sub.mk file that creates a CUDA_ENABLED_SRCS list.
- Remove all .cu and (mostly fortran) .h files from the <bin> side when
"make cleanreally" is called.
M configure
M configure.ac
- Put in check to verify that Uintah and Wasatch 3P are both (or neither) being
built with CUDA.
- Will also add Candera check once I get more info.
A include/sci_defs/wasatch_testdefs.h.in
- Place PoKitt and Candera defines in new (configure generated binary side) wasatch_defs.h
file.
M CCA/Components/Arches/sub.mk
- Fix fortran .h file dependency problem. Note, these dependencies are have been (and
continue to be) manually entered into the sub.mk file. However, previously, they
used multiple lines (eg: Source.$(OBJEXT) was written 5 times. You don't need to
do this, you can just list it once and then put all the files it depends on.
When building without CUDA, the fortran .h files are needed to create
the object files (eg: Source.o). However, if CUDA is turned on, then they are
needed to create the CUDA .cu file (eg: <bin>/Source.cu). Perviously, at least
on some machines (though the problem should have shown up on all machines?), the fortran
.h files were not being generated.
It appears that currently Arches/sub.mk is the only directory that has CUDA files that
are dependent on fortran .h files. If this occurs in other sub-dirs for Arches (as
CUDA is added to the code), then the same approach should be taken in those files.
M CCA/Components/Arches/ChemMix/sub.mk
M CCA/Components/Arches/CoalModels/sub.mk
M CCA/Components/Arches/LagrangianParticles/sub.mk
M CCA/Components/Arches/Operators/sub.mk
M CCA/Components/Arches/ParticleModels/sub.mk
M CCA/Components/Arches/PropertyModels/sub.mk
M CCA/Components/Arches/PropertyModelsV2/sub.mk
M CCA/Components/Arches/SourceTerms/sub.mk
M CCA/Components/Arches/Task/sub.mk
M CCA/Components/Arches/Transport/sub.mk
M CCA/Components/Arches/TransportEqns/sub.mk
M CCA/Components/Arches/Utility/sub.mk
M CCA/Components/Arches/WallHTModels/sub.mk
M CCA/Components/Wasatch/Expressions/BoundaryConditions/sub.mk
M CCA/Components/Wasatch/Expressions/MMS/sub.mk
M CCA/Components/Wasatch/Expressions/PostProcessing/sub.mk
M CCA/Components/Wasatch/Expressions/Turbulence/sub.mk
M CCA/Components/Wasatch/Expressions/sub.mk
M CCA/Components/Wasatch/Operators/sub.mk
M CCA/Components/Wasatch/Transport/sub.mk
M CCA/Components/Wasatch/sub.mk
- Call make system function make-cuda-target to generate CUDA .cu dependencies.
8 lines of code changed in 1 file:
Added task->requires for time-step size. This should fix the broken OFC4 RT test.
1 lines of code changed in 1 file:
Changed ash deposition averating time start tag from _t_interval to _t_ave_start to be more descriptive.
6 lines of code changed in 2 files:
to fix a bug in calculating on average deposition velocity
1 lines of code changed in 1 file:
Fix dataware house bug in DQMOMEqn::buildRHS and hack CoalTemperature to avoid creating a reference to a nullptr
70 lines of code changed in 2 files:
Refactor Array3 to remove iterator to make it possible to merge trunk
into the kokkos_dev branch
12 lines of code changed in 1 file:
(14 more)