Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 129 (100.0%) | 699 (100.0%) | 5.4 |
| allen | 63 (48.8%) | 338 (48.4%) | 5.3 |
| dav | 12 (9.3%) | 272 (38.9%) | 22.6 |
| harman | 6 (4.7%) | 47 (6.7%) | 7.8 |
| jas | 46 (35.7%) | 29 (4.1%) | 0.6 |
| ahumphrey | 2 (1.6%) | 13 (1.9%) | 6.5 |
minor interface change as vars do not need to be passed, also minor name change so to associate it with a recomute
0 lines of code changed in 2 files:
added friend class
0 lines of code changed in 2 files:
refactored the task graph index setting to be task based, added set/get for the index, Within arches refactor the dynamic stepping to be completing with DoRadiation and the fixed stepping in Explicit Solver, and added a check method for reduction vars
2 lines of code changed in 1 file:
Infrastructure restructuring and cleanup while starting last thesis-related task graph work.
Big things that I will always change when I see them.... and I saw much of this recently:
1.) ALWAYS use {} for 1-line conditionals.
if (<predicate>) {
// do stuff
}
2.) Use C++ static _cast over C-style casts, static_cast<int>(myvar) is checked at compile time, C casts are not and can fail at runtime.
3.) use "nullptr" over "0 or NULL" in the context of pointers and their assignment. Using NULL or 0 can be ambigous, e.g., compiler converting to non-pointer type 'int' from NULL (nullptr can't be assigned to an integral type). nullptr is a keyword and usage/intent is clear. From the standard: "The pointer literal is the keyword nullptr. It is an rvalue of type std::nullptr_t.".
4.) Things like Dout/Debugstreams that are specific to a compilation unit should be placed into an unnamed namespace (which is a utility to make an identifier translation unit local). The effect is almost identical to decalring something static.
5.) Use meanigful names, a bit lengthy is OK if it helps clarity. Remember, the compiler doesn't care about your names (values just go into registers), but the people maintaining your code do.. Code is meant to be read and maintained.
6.) Whitespace is our friend, but 80 column lines went away long ago.....
10 lines of code changed in 1 file:
removed the time from the getTaskGraphIndex interface and changed the name
5 lines of code changed in 1 file:
added an interface for creating a reduction var
3 lines of code changed in 1 file:
minor rework of the reduction vars
4 lines of code changed in 1 file:
added access methods to the count and overriden flag
6 lines of code changed in 1 file:
made the scrubbing of saved vars optional
4 lines of code changed in 1 file:
added the ability to save the old data warehouse
9 lines of code changed in 1 file:
removed the start sim time and sim to wall time stats. Added friend class to the app. interface
16 lines of code changed in 1 file:
removed the recompile flag from app common and restructured the calls
5 lines of code changed in 1 file:
added reading time spec attributes for output and checkpoint dumping when thresholds are met, refined the flags, minor name changes
3 lines of code changed in 1 file:
refined the application reduction var class
9 lines of code changed in 1 file:
added reduction option for on demand output and checkpointing
2 lines of code changed in 1 file:
cleaned up the DOUT macros, consistent naming of timethresholds, added option to validate next delta before the reduction
20 lines of code changed in 1 file:
deprecated the SimulationTime class and moved it to be fully contained in the ApplicationCommon
38 lines of code changed in 1 file:
variable and comment clean up to refer to the material manager rather than the state
4 lines of code changed in 8 files:
removal of shared state and introduction of a material manager
22 lines of code changed in 12 files:
added a managing class for application reduction variables
14 lines of code changed in 2 files:
made the recompute and abort reduction vars
70 lines of code changed in 4 files:
change from restart to recompute time step so to differentiate from restarting a time step from a checkpoint
13 lines of code changed in 4 files:
This fixes an issue with (older/non-compliant?) file systems with respect to deleting directories.
For many years We had a 'hack' in place for AIX file systems to use 'stat' instead of the cheaper
"file->d_type" check. It turns out that we should (have been) use the hack anytime that file->d_type
is DT_UNKNOWN, not just under AIX. This should fix the problem that some people were seeing on some
file systems where (checkpoint) diretories were not being deleted when they should have been.
M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc
- Const'ify a number of method params that are not changed in the functions (and thus should be declared const).
- Add some white space for readability.
- Actually print out warning messages when old checkpoint directories fail to be deleted.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
M CCA/Components/SimulationController/SimulationController.cc
- Purely cosmetic: Add some white space for readability.
M CCA/Ports/Output.h
- Match updated interface (ie, use of const) for DataArchiver.
- Add some white space for readability.
M Core/OS/Dir.h
M Core/OS/Dir.cc
- Add 'const' due to addition of const above.
- Add some white space for readability.
- Fix the check that we use to determine if a 'file' is a directory (see above).
M Core/OS/Dir_boost.cc
- Add const, white space, and {} for if statement.
27 lines of code changed in 1 file:
Updates toward getting particle data to work with PIDX. This commit is not the complete fix,
but particles aren't being used with PIDX anyway, so it won't affect anything.
M CCA/Components/DataArchiver/DataArchiver.cc
- Add PIDX support for IntVector.
- Fix the long64_type params.
- Initial setting of particle position index, though this will change soon with the updating of PIDX to use multiple particles at some point.
M CCA/Ports/PIDXOutputContext.cc
- Fix name from UPS spec, just use "CHUNKING_ZFP" instead of "PIDX_CHUNKING_ZFP".
- Fix name of ParticleVars and NCVars output files.
M Core/DataArchive/DataArchive.cc
- Fixes for handling particle data in PIDX. Not a complete fix, but a step in the right direction.
Particle RT tests do NOT pass at this point.
7 lines of code changed in 2 files:
Use std::unordered_set (since C++11) in processor neighborhod determination. Sorting isn't necessary and this shaves several minutes of TG compilation time at higher core counts.
3 lines of code changed in 1 file:
added a flag to the app to know it is restarting
6 lines of code changed in 1 file:
minor cleanup for access to the application
0 lines of code changed in 1 file:
white space cleanup
2 lines of code changed in 1 file:
The solvers can now access the applicationInterface methods.
1 lines of code changed in 1 file:
Updates to support PIDX particle output (based on work last week with
Sid and Steve). The PIDX code is passing most local (non-particle)
tests, and the particle data is being saved to some extent at this
point - but the numbers do not compare exactly and there are a few other
strange things going on. I'm committing this so that Steve and Sid
can take a look.
(Note, there are a number of debug prints in the PIDX sections that
need to be removed when the other issues are resolved.)
Updated files:
M Components/DataArchiver/DataArchiver.cc
M Ports/PIDXOutputContext.cc
M Ports/PIDXOutputContext.h
44 lines of code changed in 3 files:
This commit updates the code to support a newer version of PIDX, including the beginnings
of particle support. This update passes all of the local RT using UDA output, but
fails on a number of (previously passing) PIDX tests. I am committing so that Sid/Steve
can take a look and fix the issue.
Sid, here is the output from (one of) the failing test:
Running test ---methane_fire_8patch--- (mpi 8 proc) at 01:04:31
Command Line: /usr/bin/time -p /usr/installed/mpich/mpich-3.2-gcc4.9.2-install/bin/mpirun -genvlist MALLOC_STATS -np 8 sus -svnStat -svnDiff methane_fire_8patch.ups
Successfully ran to completion
Comparing udas
*** ERROR, test (methane_fire_8patch) failed uda comparison, tolerances exceeded (256)
See /ssd2/home/dav/SVN/Uintah_Baseline/opt-mpich/local_RT/ARCHES-results/methane_fire_8patch/compare_sus_runs.log.txt for more comparison information.
Changes:
--------
M CCA/Components/DataArchiver/DataArchiver.cc
M CCA/Ports/PIDXOutputContext.h
M CCA/Ports/PIDXOutputContext.cc
- Updates for newer version of PIDX with (I think) the beginnings of particle support.
- Allow for better (finer grained) specification of PIDX flags in .ups input file.
M Core/Util/XMLUtils.h
M Core/Util/XMLUtils.cc
M Core/ProblemSpec/ProblemSpec.h
M Core/ProblemSpec/ProblemSpec.cc
- Added ability to check for unsigned ints.
M StandAlone/tools/extractors/particle2tiff.cc
- Fix compiler warning. White space. Use {} on one line 'if' statements.
M StandAlone/tools/pfs/sub.mk
M StandAlone/Benchmarks/sub.mk
- Link in PIDX.
M configure.ac
M configure
- Newest PIDX requires the zfp library.
140 lines of code changed in 2 files:
Removed SolverParameters tangled web from the components/applications. The each solver "owns" the parameters
and the component/application set the parameters via the solver, solver->getParameters()->SetSomething()
- Added virtual function getParameters()
- Removed tabs and other formatting.
- Rename HypreSolver2Params -> HypreParams
- Moved CG and Direct constructors/destructors code so there is consistency in code layout between the different solvers.
12 lines of code changed in 1 file:
This commit brings the PIDX data I/O branch (named: pidx_xml) back into the trunk.
All PIDX data I/O is, by default, turned off. To use PIDX you have to configure
against the PIDX library (either installing manually and pointing at it, or using
the --with-pidx flag (not 100% certain that this works at the moment)), and you must
set <DataArchiver type="PIDX"> (as opposed to the default which is type="UDA") in
the .ups input file.
Other caveats:
- Particles are not (currently?) supported in PIDX so any simulation that has a
particle data type will fail (most will print an error that PIDX does not
support them, but it seems some just die).
- Simulations that have overlapping patches (this may just be AMR type
sims) (eg: multibox_rmcrt_coal_1L) can save (slightly different) results.
In the multibox_rmcrt_coal_1L, we saw (only) a handful of differences like this:
((A 1 vs a 0 in a couple of locations) Also note that the UDA itself compared
successfully, but the checkpoint underneath it did not...)
DIFFERENCE [int 36, 5, 0] Time: 0.0003106658 Level: 0 Patch1: 0 Patch2: 0 Material: 0 Variable: areaFractionFX
multibox_RMCRT_coal_1L.uda/checkpoints goldStandard/.../multibox_RMCRT_coal_1L.uda/checkpoints
1 0
- "#if HAVE_PIDX" is used inconsistently through a number of files. Some PIDX stuff is #if'd out, while other code
is left in and compiles, it is just not used.
- There are a lot of cleanups that can and should take place wrt the PIDX integration.
While the code passes all the local RT tests (with the exception of particle tests),
I don't believe it has been run at large scale (though it should work) on a BGQ or Quartz@llnl.
Summary of changes: (Note, see pidx_xml branch commits if you want more information.)
M CCA/Ports/ApplicationInterface.h
M CCA/Components/Application/ApplicationCommon.h
- Added the ability to record (and retrieve) the number for the last regrid time step.
M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc
- When saving as PIDX, only create/output timestep.xml on the initial (I/O) time step that occurs after the regrid.
- Fixes that allow PIDX to save correctly (and efficiently) in parallel. If you are ever trying
to trace this back, read the comments from the commit logs for the "pidx_xml" branch.
- Remove createPIDX_dirs() as it was commented out and Sid tells me that PIDX creats its own dirs and we don't need this.
- Lot of white space fixes.
M CCA/Components/Examples/RMCRT_Test.cc
M CCA/Components/PostProcessUda/PostProcess.cc
- The DataArchive (DA) queryVariables() function now also returns the number of materials for each variable.
- "else" and "else if" should be on a separate line to make it easier to read.
M CCA/Components/Models/Radiation/RMCRT/RayGPU.cc
- Differentiate the output between the GPU and non-GPU reports so the viewer knows explicitly whether the GPU code was run.
M CCA/Components/Schedulers/OnDemandDataWarehouse.h
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Cosmetics: Line up variables, use more than 80 chars per line, white space.
Add in comments denoting default param values.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Cosmetics.
M CCA/Components/SimulationController/AMRSimulationController.cc
- Cosmetics: Use more white space, 80+ chars per line for better readability, etc.
M CCA/Ports/PIDXOutputContext.h
- const'ify some params.
- checkReturnCode() is a static function so mark it so.
M CCA/Ports/PIDXOutputContext.cc
- White spacee. Code alignment for readability.
M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc
- Add in PIDX functions. Note, queryPIDXSerial() is used (currently) by standalone codes (eg: puda).
Its purpose is to wrap the setupQueryPIDX()/queryPIDX() calls that have been added to
allow PIDX to truly run in parallel. At some point it would be good to update puda/compare_uda/etc
to run in parallel...
- See previous comments from PIDX branch for more details on the PIDX communicators that are necessary
to transfer data as some data does not live on all cores and thus can't use the golbal comm.
- Rename a few functions (queryAndSetParticlePositionName()) to be more accurate as to what they do.
- There are still a number of hacks in this code that need to be addressed (eg: var_materials map).
M Core/Geometry/IntVector.h
- Mostly cosmetics...
White space for readability.
Place 1-line functions in .h on one line to make it easier to see all provided functions.
M Core/Grid/Grid.cc
- White space, variable alignment for readability.
M Core/Grid/Level.h
M Core/Grid/Level.cc
- White space, coding standard (return type on its own line).
- Fix logic error in computeVariableExtents() that did not handle periodic boundaries correctly.
This fix was suggested as probably the correct way to do it by Todd... seems to pass tests and did fix
the issue (PIDX saving a particular something or other) that led me to it.
M Core/Grid/Patch.cc
- Place "else" on its own line for readability.
M Core/Grid/Variables/GridVariable.h
- Added emitPIDX().
- Opening "{" for functions in .h files goes on same line.
M Core/Grid/Variables/GridVariableBase.h
M Core/Grid/Variables/GridVariableBase.cc
- Organize #includes.
- White space, line up vars, etc for better readability.
- Return type on its own line.
M Core/Grid/Variables/ParticleData.h
- #include ParticleSubset.h for particleIndex.
M Core/Grid/Variables/ParticleSubset.h
- Cosmetic white space.
M Core/Grid/Variables/ParticleVariable.h
- White space, variable line up, etc.
- Added emitPIDX() function for particles. Note, particles do not fully work yet (on PIDX side).
And thus, this function hasn't really been tested.
M Core/Grid/Variables/ParticleVariableBase.h
M Core/Grid/Variables/ParticleVariableBase.cc
M Core/Grid/Variables/PerPatchBase.h
M Core/Grid/Variables/PerPatchBase.cc
M Core/Grid/Variables/ReductionVariableBase.h
M Core/Grid/Variables/ReductionVariableBase.cc
- Cosmetic white space. Coding standards. Etc.
M Core/Grid/Variables/Variable.h
M Core/Grid/Variables/Variable.cc
- Organize #includes.
- Use "const" on params that are const.
- Cosmetic white space, etc.
M Core/Grid/Variables/VarnameMatlPatch.h
- Pass non-changing strings by const reference (instead of copying them).
- White space for readability.
M Core/ProblemSpec/ProblemSpec.cc
- Line up vars, white space.
M R_Tester/helpers/compare_dat_files.pl
- Strip "/" from end of uda names.
- Clean up output to make it more readable (Todd I hope this doesn't break some of your scripts...)
M R_Tester/helpers/compare_dats
- White space.
M R_Tester/helpers/runSusTests.py
- Fix typo.
M StandAlone/compare_uda.cc
- White space.
- Line up vars.
- Coding standard.
- Line up case statement for better readability.
- 0 => nullptr
- query() now returns if the var was found (because PIDX has a list of all variables the simulation starts with
and the vars may not actually exist in the UDA.
- var => var_name (as it is actually the name, and not the var).
- Use 80+ columns.
M StandAlone/partvarRange.cco
M StandAlone/selectpart.cc
M StandAlone/tools/compute_Lnorm_udas.cc
M StandAlone/tools/dumpfields/dumpfields.cc
M StandAlone/tools/extractors/extractF.cc
M StandAlone/tools/extractors/extractS.cc
M StandAlone/tools/extractors/extractV.cc
M StandAlone/tools/extractors/faceextract.cc
M StandAlone/tools/extractors/lineextract.cc
M StandAlone/tools/extractors/partextract.cc
M StandAlone/tools/extractors/particle2tiff.cc
M StandAlone/tools/extractors/timeextract.cc
M StandAlone/tools/puda/AA_MMS.cc
M StandAlone/tools/puda/ER_MMS.cc
M StandAlone/tools/puda/GV_MMS.cc
M StandAlone/tools/puda/ICE_momentum.cc
M StandAlone/tools/puda/PIC.cc
M StandAlone/tools/puda/POL.cc
M StandAlone/tools/puda/asci.cc
M StandAlone/tools/puda/jacquie.cc
M StandAlone/tools/puda/jim1.cc
M StandAlone/tools/puda/jim2.cc
M StandAlone/tools/puda/jim3.cc
M StandAlone/tools/puda/pressure.cc
M StandAlone/tools/puda/puda.cc
M VisIt/interfaces/archiveInterface.cc
- queryVariables() now returns number of materials.
M StandAlone/tools/puda/varsummary.h
M StandAlone/tools/puda/varsummary.cc
- Swat some evil endls.
M build_scripts/build_pidx.sh
- FYI... Not sure if changing PIDX_TAG to "master" actually works...
M buildbot_try.sh
- Added a number of comments about use of this script.
- Fixed some typos.
- Spread command to multiple lines for readability.
48 lines of code changed in 3 files:
Added scheduleRestartInitialization() to the solver infrastructrure.
If you need a solver related variable from the old_DW and it isn't checkpointed then
create it in this task.
It's currently disabled in hypre.
4 lines of code changed in 1 file:
Removed code"hoops" that were jumped through so the hypreSolver could use the timestep.
SolverInterface.h:
-Formatting and added setWhichOldDW() and getWhichOldDW() methods
HypreSolver.cc
- Just get the timestep from the datawarehouse, either old_DW or parentOldDW. No more transferForwards (hoops).
impICE.cc
- removed scheduling the timestepLabel needed for Hypre. That is handled by hypreSolver.
ICE.cc
- formatting.
27 lines of code changed in 1 file:
Changed variable name modfies_hypre -> isFirstSolve and made a small change in the scheduling logic.
The hyper_solver_label was never modified. The scheduling logic changed after the first pass
through the solver, thus the name change.
1 lines of code changed in 1 file:
Removed sharedState from SolverParameters::readParameters(). It's not used.
HypreSolver.h
_ removed setSolveFrequency() and getSolveFrequency. The solve frequency is handled by the parameters.
BuildBotTry:
Changed #!/bin/csh -> #!/bin/csh -f
This fixed a oddball error.
2 lines of code changed in 1 file:
poked a temporary hole in the scheduler interface to get the application
5 lines of code changed in 1 file:
removed ICE models interface from the ModelInterafce, added HEChem interface and removed used methods
1 lines of code changed in 1 file:
moved the other performance stats to the application
30 lines of code changed in 1 file:
(8 more)