/trunk/src Developers: ahumphrey

Login name:
ahumphrey
Total Commits:
334 (2.6%)
Lines of Code:
5,131 (3.6%)
Most Recent Commit:
2018-12-14 16:17
Tweet this:
Tweet this

Activity by Clock Time

Activity by Hour of Day for ahumphrey

Activity by Day of Week for ahumphrey

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 334 (100.0%) 5131 (100.0%) 15.3
CCA/Components/Schedulers/ 101 (30.2%) 3002 (58.5%) 29.7
Core/Grid/ 27 (8.1%) 366 (7.1%) 13.5
CCA/Components/SimulationController/ 18 (5.4%) 359 (7.0%) 19.9
Core/Grid/Variables/ 25 (7.5%) 324 (6.3%) 12.9
CCA/Components/Application/ 3 (0.9%) 285 (5.6%) 95.0
Core/Util/ 17 (5.1%) 197 (3.8%) 11.5
CCA/Components/LoadBalancers/ 17 (5.1%) 193 (3.8%) 11.3
Core/Geometry/ 2 (0.6%) 151 (2.9%) 75.5
Core/Util/Timers/ 2 (0.6%) 77 (1.5%) 38.5
StandAlone/ 7 (2.1%) 32 (0.6%) 4.5
Core/Parallel/ 10 (3.0%) 29 (0.6%) 2.9
/ 10 (3.0%) 27 (0.5%) 2.7
CCA/Components/MPM/Materials/ConstitutiveModel/ 12 (3.6%) 17 (0.3%) 1.4
CCA/Ports/ 2 (0.6%) 13 (0.3%) 6.5
CCA/Components/MPM/ 2 (0.6%) 9 (0.2%) 4.5
include/sci_defs/ 6 (1.8%) 5 (0.1%) 0.8
Core/Math/ 6 (1.8%) 5 (0.1%) 0.8
StandAlone/tools/dumpfields/ 4 (1.2%) 4 (0.1%) 1.0
Core/Lockfree/ 2 (0.6%) 4 (0.1%) 2.0
Core/Grid/BoundaryConditions/ 1 (0.3%) 4 (0.1%) 4.0
CCA/Components/Parent/ 1 (0.3%) 3 (0.1%) 3.0
R_Tester/helpers/ 1 (0.3%) 2 (0.0%) 2.0
testprograms/TestMatrix3/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/TestFastMatrix/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/Regridders/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/RegionTest/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/PatchBVH/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/Malloc/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/IteratorTest/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/CubeRootTest/ 2 (0.6%) 1 (0.0%) 0.5
testprograms/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/puda/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/pfs/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/mpi_test/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/graphview/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/fsspeed/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/extractors/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/compare_mms/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/tools/ 2 (0.6%) 1 (0.0%) 0.5
StandAlone/Benchmarks/ 2 (0.6%) 1 (0.0%) 0.5
Core/DataArchive/ 1 (0.3%) 1 (0.0%) 1.0
CCA/Components/Wasatch/ 2 (0.6%) 1 (0.0%) 0.5
CCA/Components/PostProcessUda/ 1 (0.3%) 1 (0.0%) 1.0
CCA/Components/DataArchiver/ 1 (0.3%) 1 (0.0%) 1.0
CCA/Components/Arches/SourceTerms/ 1 (0.3%) 1 (0.0%) 1.0
testprograms/SFCTest/ 2 (0.6%) 0 (0.0%) 0.0
include/ 1 (0.3%) 0 (0.0%) 0.0
build_scripts/ 4 (1.2%) 0 (0.0%) 0.0
Core/IO/ 1 (0.3%) 0 (0.0%) 0.0
Core/Exceptions/ 4 (1.2%) 0 (0.0%) 0.0
Core/Datatypes/ 1 (0.3%) 0 (0.0%) 0.0
Core/Containers/ 1 (0.3%) 0 (0.0%) 0.0
CCA/Components/Examples/ 2 (0.6%) 0 (0.0%) 0.0

Activity of ahumphrey

Most Recent Commits

ahumphrey 2018-12-14 16:17 Rev.: 59091

Additionally report ghost cell requirements for ForgenVariable debug info.

0 lines of code changed in 2 files:

  • CCA/Components/Schedulers: OnDemandDataWarehouse.cc (new)
ahumphrey 2018-12-11 18:17 Rev.: 59059

Generalize the concept of a task graph having tasks with "distal" halo requirements, meaning the number, order, and appearance of TGs with distal requires is arbitrary. This is a much more robust way to determine distal neighborhood creation, etc. Prior to this, the code was quite brittle, depending on the distal TG being last in the order.

45 lines of code changed in 14 files:

  • CCA/Components/LoadBalancers: LoadBalancerCommon.h (new)
  • CCA/Components/Schedulers: SchedulerCommon.cc (new), SchedulerCommon.h (+5 -5), TaskGraph.cc (+6), TaskGraph.h (new)
  • CCA/Components/SimulationController: AMRSimulationController.cc (+2 -1)
  • Core/Grid: Task.cc (+12), Task.h (+2)
ahumphrey 2018-12-11 14:34 Rev.: 59057

* Fix MPI buffer truncation error in threaded RMCRT Examples tests.

* Some small cleanup in UnifiedScheduler (USE_PACKING is defined in MPIScheduler, not needed in Unified).

14 lines of code changed in 3 files:

  • CCA/Components/Schedulers: TaskGraph.cc (+3 -2), UnifiedScheduler.cc (new)
ahumphrey 2018-12-10 17:48 Rev.: 59048

* Fix RMCRT memory bloat.

* Move from referenceing SHRT_MAX to "req->m_num_ghost_cells >= MAX_HALO_DEPTH"

* Fix unitialized vars.

15 lines of code changed in 3 files:

  • CCA/Components/LoadBalancers: LoadBalancerCommon.cc (+12 -10)
  • CCA/Components/Schedulers: TaskGraph.cc (+3 -5)
ahumphrey 2018-12-03 13:51 Rev.: 58985

* Brace initializers for POD and pointer_type class members.

* cbegin() and/or cend() for const_iterators, especially for methods that return a const_iterator, e.g., Level::const_patch_iterator Level::patchesBegin() const.

* Use prefix ++ operator (e.g., ++iter) for more complicated types, avoiding tmp creation.

* Prefer using const when possible.

* Use auto keyword, leaving correct type deduction to the compiler.

94 lines of code changed in 10 files:

  • CCA/Components/LoadBalancers: LoadBalancerCommon.cc (+13 -9)
  • CCA/Components/Schedulers: DWDatabase.h (new), SchedulerCommon.cc (+16 -46), TaskGraph.cc (+7 -10), TaskGraph.h (+40 -31)
  • Core/Grid: Level.cc (+3 -3), Level.h (+9 -9)
ahumphrey 2018-11-30 13:45 Rev.: 58979

Cleanup under the hood as the most recent TG work/project moves forward. Mostly cosmetic changes for readability.

138 lines of code changed in 5 files:

  • CCA/Components/Schedulers: DWDatabase.h (+9 -9), SchedulerCommon.cc (+17 -19), TaskGraph.cc (+2)
  • Core/Grid/Variables: VarLabelMatl.h (+110 -73)
ahumphrey 2018-11-28 13:14 Rev.: 58967

Fix more inaccurate error mesgs in DWDatabase.

2 lines of code changed in 1 file:

  • CCA/Components/Schedulers: DWDatabase.h (+2 -2)
ahumphrey 2018-11-28 13:06 Rev.: 58965

Fix accuracy of error message when putting foreign vars into DW.
Reorder appearance of methods in OnDemandDW to match header... send/recvMPI methods adjacent in impl file.
A few minor cosmetic changes elswhere.

123 lines of code changed in 7 files:

  • CCA/Components/Schedulers: DWDatabase.h (+1 -1), OnDemandDataWarehouse.cc (+109 -109), SchedulerCommon.h (+9 -9)
  • Core/Grid/Variables: VarLabel.cc (new)
  • Core/Parallel: BufferInfo.cc (new)
ahumphrey 2018-11-28 12:21 Rev.: 58964

Massive cleanup and refactoring in OnDemandDW. This source code was diffuclut to read, and I'm needing to make significant changes in the MPI engine to support optimizations in TG dependency analysis (in the context of RMCRT radiation with threaded schedulers).

1456 lines of code changed in 9 files:

  • CCA/Components/Schedulers: DWDatabase.h (+7 -8), OnDemandDataWarehouse.cc (+852 -751), OnDemandDataWarehouse.h (+590 -478), SchedulerCommon.cc (+4 -4), UnifiedScheduler.cc (+1 -1)
  • CCA/Components/Wasatch: Wasatch.cc (+1 -1)
  • Core/Util: ProgressiveWarning.cc (new)
ahumphrey 2018-11-27 13:08 Rev.: 58954

Update and revive DW task access checking and RunningTaskInfo code.
Fixed a few other typos and formatting in these areas while under the hood.

123 lines of code changed in 8 files:

  • CCA/Components/Application: ApplicationCommon.cc (new)
  • CCA/Components/Schedulers: DetailedTask.cc (new), OnDemandDataWarehouse.cc (+82 -77), OnDemandDataWarehouse.h (+11 -14)
  • Core/Grid: Level.cc (+10 -16), Level.h (+15 -12)
ahumphrey 2018-11-19 13:31 Rev.: 58944

Infrastructure restructuring and cleanup while starting last thesis-related task graph work.

Big things that I will always change when I see them.... and I saw much of this recently:

1.) ALWAYS use {} for 1-line conditionals.
if (<predicate>) {
// do stuff
}

2.) Use C++ static _cast over C-style casts, static_cast<int>(myvar) is checked at compile time, C casts are not and can fail at runtime.

3.) use "nullptr" over "0 or NULL" in the context of pointers and their assignment. Using NULL or 0 can be ambigous, e.g., compiler converting to non-pointer type 'int' from NULL (nullptr can't be assigned to an integral type). nullptr is a keyword and usage/intent is clear. From the standard: "The pointer literal is the keyword nullptr. It is an rvalue of type std::nullptr_t.".

4.) Things like Dout/Debugstreams that are specific to a compilation unit should be placed into an unnamed namespace (which is a utility to make an identifier translation unit local). The effect is almost identical to decalring something static.

5.) Use meanigful names, a bit lengthy is OK if it helps clarity. Remember, the compiler doesn't care about your names (values just go into registers), but the people maintaining your code do.. Code is meant to be read and maintained.

6.) Whitespace is our friend, but 80 column lines went away long ago.....

793 lines of code changed in 14 files:

  • CCA/Components/Application: ApplicationCommon.cc (+283 -329)
  • CCA/Components/LoadBalancers: LoadBalancerCommon.cc (+80 -90), LoadBalancerCommon.h (+11 -10)
  • CCA/Components/Schedulers: DWDatabase.h (+9 -14), OnDemandDataWarehouse.cc (+217 -282), OnDemandDataWarehouse.h (+15 -14), TaskGraph.cc (+2 -2)
  • CCA/Ports: ApplicationInterface.h (+10 -11)
  • Core/Grid: Level.cc (+123 -122), Level.h (+17 -17)
  • Core/Parallel: CrowdMonitor.hpp (new), MasterLock.h (new)
ahumphrey 2018-10-25 14:59 Rev.: 58885

Specialize std::hash structure and inject into the std namespace so that VarLabelMatl<DomainType> can be used as a key in std::unordered_map.
Removed older version that publicly inherited from std::unary_function, which is deprecated as of C++11.

11 lines of code changed in 1 file:

  • CCA/Components/Schedulers: DWDatabase.h (+11 -3)
ahumphrey 2018-10-25 11:20 Rev.: 58882

Remove all traces of sci_hashmap. With Uintah being fully transitioned to C++11, these old TR1, GNU_HASHMAP and other extension hacks are unnecessary, confusing and error prone. We just use std::unordered_map, etc.

Generate new configure script.

35 lines of code changed in 4 files:

  • CCA/Components/Schedulers: DWDatabase.h (+20 -44), OnDemandDataWarehouse.h (+15 -19)
  • include: sci_hash_map.h (del)
  • include/sci_defs: hashmap_testdefs.h.in (del)
ahumphrey 2018-10-24 14:04 Rev.: 58879

Cleanup under the hood while working. Mainly readbility improvements and addding {} for single-line conditionals, etc.

256 lines of code changed in 4 files:

  • CCA/Components/SimulationController: SimulationController.cc (+101 -124)
  • Core/Geometry: IntVector.h (+151 -98)
  • Core/Lockfree: Lockfree_Pool.hpp (new)
ahumphrey 2018-10-17 11:14 Rev.: 58848

* Add build system support for Power9 (LLNL Lassen, a.k.a. uSierra) .

* This also adds support for CUDA compute capabillity 6.0 and 7.0, Pascal V100 and Volta GV100 GPUs, respectively.

* Also add support for IBM spectrum-MPI.

* Updated config.sub and config.guess for the LLNL Lassen OS.

* Generate new configure script with Dav's bullet proofing.

0 lines of code changed in 6 files:

  • aclocal.m4 (changed)
  • build_scripts: config.guess (new), config.sub (new)
ahumphrey 2018-10-16 18:19 Rev.: 58842

Add build system support for Pascal and Volta GPUs, e.g., compute capability 6.1 and 7.2, respectively.
Generate new configure script with Dav's bullet proofing.

3 lines of code changed in 1 file:

  • aclocal.m4 (+3 -3)
ahumphrey 2018-09-13 18:38 Rev.: 58671

Simulation controllers: DebugStream --> Dout
Some misc cleanup and output formatting.

76 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+76 -100)
ahumphrey 2018-09-11 17:31 Rev.: 58651

Repair Gpertools support.

6 lines of code changed in 3 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+1 -1)
  • include/sci_defs: gperftools_testdefs.h.in (+5 -5)
ahumphrey 2018-09-11 16:35 Rev.: 58650


Remove PAPI support.
This direct support is no longer necessary, as almost all profiling tools sit on top of PAPI. No sense in us maintaining code that's avialble through professional tools.

171 lines of code changed in 57 files:

  • configVars.mk.in (+2 -6)
  • CCA/Components/Schedulers: RuntimeStatsEnum.h (-9)
  • CCA/Components/SimulationController: AMRSimulationController.cc (+64 -61), AMRSimulationController.h (new), SimulationController.cc (+59 -230), SimulationController.h (new), sub.mk (new)
  • Core/Exceptions: PapiInitializationError.cc (del), PapiInitializationError.h (del), sub.mk (new)
  • StandAlone: sub.mk (+2 -2)
  • StandAlone/Benchmarks: sub.mk (+1 -1)
  • StandAlone/tools: sub.mk (+1 -1)
  • StandAlone/tools/compare_mms: sub.mk (new)
  • StandAlone/tools/dumpfields: sub.mk (+1 -1)
  • StandAlone/tools/extractors: sub.mk (+1 -1)
  • StandAlone/tools/fsspeed: sub.mk (new)
  • StandAlone/tools/graphview: sub.mk (new)
  • StandAlone/tools/mpi_test: sub.mk (new)
  • StandAlone/tools/pfs: sub.mk (new)
  • StandAlone/tools/puda: sub.mk (+1 -1)
  • include/sci_defs: papi_testdefs.h.in (del)
  • testprograms: sub.mk (new)
  • testprograms/CubeRootTest: sub.mk (+1 -1)
  • testprograms/IteratorTest: sub.mk (new)
  • testprograms/Malloc: sub.mk (new)
  • testprograms/PatchBVH: sub.mk (+1 -1)
  • testprograms/RegionTest: sub.mk (new)
  • testprograms/Regridders: sub.mk (+1 -1)
  • testprograms/SFCTest: sub.mk (new)
  • testprograms/TestFastMatrix: sub.mk (+1 -1)
  • testprograms/TestMatrix3: sub.mk (+1 -1)
ahumphrey 2018-09-11 15:06 Rev.: 58648

Complete the removal of RunLengthEncoder.

184 lines of code changed in 6 files:

  • CCA/Components/DataArchiver: DataArchiver.cc (+1 -2)
  • CCA/Components/Schedulers: OnDemandDataWarehouse.cc (+2 -2)
  • Core/Grid/Variables: Variable.cc (+105 -182), Variable.h (+76 -62)

(25 more)

Generated by StatSVN 0.7.0