Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 258 (100.0%) | 1014 (100.0%) | 3.9 |
| ahumphrey | 25 (9.7%) | 324 (32.0%) | 12.9 |
| dav | 23 (8.9%) | 291 (28.7%) | 12.6 |
| allen | 41 (15.9%) | 156 (15.4%) | 3.8 |
| derekhar | 14 (5.4%) | 100 (9.9%) | 7.1 |
| jas | 143 (55.4%) | 93 (9.2%) | 0.6 |
| jholmen | 2 (0.8%) | 38 (3.7%) | 19.0 |
| harman | 10 (3.9%) | 12 (1.2%) | 1.2 |
overhaul of the global vars to use share pointers while making each have the same class format
0 lines of code changed in 22 files:
Cleanup under the hood as the most recent TG work/project moves forward. Mostly cosmetic changes for readability.
110 lines of code changed in 2 files:
Fix accuracy of error message when putting foreign vars into DW.
Reorder appearance of methods in OnDemandDW to match header... send/recvMPI methods adjacent in impl file.
A few minor cosmetic changes elswhere.
1 lines of code changed in 2 files:
Replaced tabs with spaces.
11 lines of code changed in 5 files:
clean up of the dynamic radiation solve - made it fully local to arches
0 lines of code changed in 2 files:
added the ability to temporally schedule the radiation solve via reduction var
1 lines of code changed in 1 file:
Complete the removal of RunLengthEncoder.
181 lines of code changed in 4 files:
* Remove RunLengthEncoder and supporting classes, etc. This is no longer used. Removal will help clarity regarding Uintah::Variable functionality and features. This change has neccesitated explicit inclusion of "unistd.h" in a few spots, most specifically - MPM, for getpid() calls.
* Remove build system support for IPM and MAGMA libs, which have never been used. MAGAMA in fact, may ultimately hender Kokkos GPU asynchrony and performance.
* Generate new configure script with enable_option_checking bulletproofing.
* Delete unused header files.
* A few other cosmetic changes while under the hood, formatting, white space, etc.
23 lines of code changed in 7 files:
Fix error with "cleanreally/reallyclean" make targets. Previously, testprograms was always compiled. However, when the change was made to need explicit enablling (--enable-unit-tests), the old make traget generated a confusing error. Now conditionally remove .o files in the testprograms directory contingent the directory's exsistence.
Remove unused files in Core/Grid/Variables. Therer were 3 DataItem definitions within Uintah, one for GeometryObject and another for the DataWarehouse. Here, the unused third is removed, which looked like it was originally intended to be used with Reduction and Sole Variables.
0 lines of code changed in 5 files:
made isBenignValue a const and cleaned up the boolean checks
3 lines of code changed in 1 file:
added reduction option for on demand output and checkpointing
2 lines of code changed in 1 file:
Added parallel_for to arches boundary condition code.
ListOfCellsIterator was changed to achieve this. This infrastructure class had push_back removed from it to enable future portability.
This change is expected to not break any test in for any component. Due to this change use of the default constructor for this class is being made private.
100 lines of code changed in 14 files:
added a managing class for application reduction variables
2 lines of code changed in 1 file:
Fixed the benign value for the OR operation and removed comments
3 lines of code changed in 3 files:
SoleVariable.h & SchedulerCommon
scheduleAndDoDataCopy()
- Added code to copy SoleVariables to the new_dw when a regrid occurs.
overrideVariableBehavior()
- Improved the comments.
impICE.cc & HypreSolver.cc
- changed overrideVariable(hypre_solver_label) flags to copy data to new_dw.
1 lines of code changed in 1 file:
to allow sole and per patch vars to read/write I added swapbytes functions and readNormal for specialized sole and per patch vars
28 lines of code changed in 2 files:
This commit brings the PIDX data I/O branch (named: pidx_xml) back into the trunk.
All PIDX data I/O is, by default, turned off. To use PIDX you have to configure
against the PIDX library (either installing manually and pointing at it, or using
the --with-pidx flag (not 100% certain that this works at the moment)), and you must
set <DataArchiver type="PIDX"> (as opposed to the default which is type="UDA") in
the .ups input file.
Other caveats:
- Particles are not (currently?) supported in PIDX so any simulation that has a
particle data type will fail (most will print an error that PIDX does not
support them, but it seems some just die).
- Simulations that have overlapping patches (this may just be AMR type
sims) (eg: multibox_rmcrt_coal_1L) can save (slightly different) results.
In the multibox_rmcrt_coal_1L, we saw (only) a handful of differences like this:
((A 1 vs a 0 in a couple of locations) Also note that the UDA itself compared
successfully, but the checkpoint underneath it did not...)
DIFFERENCE [int 36, 5, 0] Time: 0.0003106658 Level: 0 Patch1: 0 Patch2: 0 Material: 0 Variable: areaFractionFX
multibox_RMCRT_coal_1L.uda/checkpoints goldStandard/.../multibox_RMCRT_coal_1L.uda/checkpoints
1 0
- "#if HAVE_PIDX" is used inconsistently through a number of files. Some PIDX stuff is #if'd out, while other code
is left in and compiles, it is just not used.
- There are a lot of cleanups that can and should take place wrt the PIDX integration.
While the code passes all the local RT tests (with the exception of particle tests),
I don't believe it has been run at large scale (though it should work) on a BGQ or Quartz@llnl.
Summary of changes: (Note, see pidx_xml branch commits if you want more information.)
M CCA/Ports/ApplicationInterface.h
M CCA/Components/Application/ApplicationCommon.h
- Added the ability to record (and retrieve) the number for the last regrid time step.
M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc
- When saving as PIDX, only create/output timestep.xml on the initial (I/O) time step that occurs after the regrid.
- Fixes that allow PIDX to save correctly (and efficiently) in parallel. If you are ever trying
to trace this back, read the comments from the commit logs for the "pidx_xml" branch.
- Remove createPIDX_dirs() as it was commented out and Sid tells me that PIDX creats its own dirs and we don't need this.
- Lot of white space fixes.
M CCA/Components/Examples/RMCRT_Test.cc
M CCA/Components/PostProcessUda/PostProcess.cc
- The DataArchive (DA) queryVariables() function now also returns the number of materials for each variable.
- "else" and "else if" should be on a separate line to make it easier to read.
M CCA/Components/Models/Radiation/RMCRT/RayGPU.cc
- Differentiate the output between the GPU and non-GPU reports so the viewer knows explicitly whether the GPU code was run.
M CCA/Components/Schedulers/OnDemandDataWarehouse.h
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Cosmetics: Line up variables, use more than 80 chars per line, white space.
Add in comments denoting default param values.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Cosmetics.
M CCA/Components/SimulationController/AMRSimulationController.cc
- Cosmetics: Use more white space, 80+ chars per line for better readability, etc.
M CCA/Ports/PIDXOutputContext.h
- const'ify some params.
- checkReturnCode() is a static function so mark it so.
M CCA/Ports/PIDXOutputContext.cc
- White spacee. Code alignment for readability.
M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc
- Add in PIDX functions. Note, queryPIDXSerial() is used (currently) by standalone codes (eg: puda).
Its purpose is to wrap the setupQueryPIDX()/queryPIDX() calls that have been added to
allow PIDX to truly run in parallel. At some point it would be good to update puda/compare_uda/etc
to run in parallel...
- See previous comments from PIDX branch for more details on the PIDX communicators that are necessary
to transfer data as some data does not live on all cores and thus can't use the golbal comm.
- Rename a few functions (queryAndSetParticlePositionName()) to be more accurate as to what they do.
- There are still a number of hacks in this code that need to be addressed (eg: var_materials map).
M Core/Geometry/IntVector.h
- Mostly cosmetics...
White space for readability.
Place 1-line functions in .h on one line to make it easier to see all provided functions.
M Core/Grid/Grid.cc
- White space, variable alignment for readability.
M Core/Grid/Level.h
M Core/Grid/Level.cc
- White space, coding standard (return type on its own line).
- Fix logic error in computeVariableExtents() that did not handle periodic boundaries correctly.
This fix was suggested as probably the correct way to do it by Todd... seems to pass tests and did fix
the issue (PIDX saving a particular something or other) that led me to it.
M Core/Grid/Patch.cc
- Place "else" on its own line for readability.
M Core/Grid/Variables/GridVariable.h
- Added emitPIDX().
- Opening "{" for functions in .h files goes on same line.
M Core/Grid/Variables/GridVariableBase.h
M Core/Grid/Variables/GridVariableBase.cc
- Organize #includes.
- White space, line up vars, etc for better readability.
- Return type on its own line.
M Core/Grid/Variables/ParticleData.h
- #include ParticleSubset.h for particleIndex.
M Core/Grid/Variables/ParticleSubset.h
- Cosmetic white space.
M Core/Grid/Variables/ParticleVariable.h
- White space, variable line up, etc.
- Added emitPIDX() function for particles. Note, particles do not fully work yet (on PIDX side).
And thus, this function hasn't really been tested.
M Core/Grid/Variables/ParticleVariableBase.h
M Core/Grid/Variables/ParticleVariableBase.cc
M Core/Grid/Variables/PerPatchBase.h
M Core/Grid/Variables/PerPatchBase.cc
M Core/Grid/Variables/ReductionVariableBase.h
M Core/Grid/Variables/ReductionVariableBase.cc
- Cosmetic white space. Coding standards. Etc.
M Core/Grid/Variables/Variable.h
M Core/Grid/Variables/Variable.cc
- Organize #includes.
- Use "const" on params that are const.
- Cosmetic white space, etc.
M Core/Grid/Variables/VarnameMatlPatch.h
- Pass non-changing strings by const reference (instead of copying them).
- White space for readability.
M Core/ProblemSpec/ProblemSpec.cc
- Line up vars, white space.
M R_Tester/helpers/compare_dat_files.pl
- Strip "/" from end of uda names.
- Clean up output to make it more readable (Todd I hope this doesn't break some of your scripts...)
M R_Tester/helpers/compare_dats
- White space.
M R_Tester/helpers/runSusTests.py
- Fix typo.
M StandAlone/compare_uda.cc
- White space.
- Line up vars.
- Coding standard.
- Line up case statement for better readability.
- 0 => nullptr
- query() now returns if the var was found (because PIDX has a list of all variables the simulation starts with
and the vars may not actually exist in the UDA.
- var => var_name (as it is actually the name, and not the var).
- Use 80+ columns.
M StandAlone/partvarRange.cco
M StandAlone/selectpart.cc
M StandAlone/tools/compute_Lnorm_udas.cc
M StandAlone/tools/dumpfields/dumpfields.cc
M StandAlone/tools/extractors/extractF.cc
M StandAlone/tools/extractors/extractS.cc
M StandAlone/tools/extractors/extractV.cc
M StandAlone/tools/extractors/faceextract.cc
M StandAlone/tools/extractors/lineextract.cc
M StandAlone/tools/extractors/partextract.cc
M StandAlone/tools/extractors/particle2tiff.cc
M StandAlone/tools/extractors/timeextract.cc
M StandAlone/tools/puda/AA_MMS.cc
M StandAlone/tools/puda/ER_MMS.cc
M StandAlone/tools/puda/GV_MMS.cc
M StandAlone/tools/puda/ICE_momentum.cc
M StandAlone/tools/puda/PIC.cc
M StandAlone/tools/puda/POL.cc
M StandAlone/tools/puda/asci.cc
M StandAlone/tools/puda/jacquie.cc
M StandAlone/tools/puda/jim1.cc
M StandAlone/tools/puda/jim2.cc
M StandAlone/tools/puda/jim3.cc
M StandAlone/tools/puda/pressure.cc
M StandAlone/tools/puda/puda.cc
M VisIt/interfaces/archiveInterface.cc
- queryVariables() now returns number of materials.
M StandAlone/tools/puda/varsummary.h
M StandAlone/tools/puda/varsummary.cc
- Swat some evil endls.
M build_scripts/build_pidx.sh
- FYI... Not sure if changing PIDX_TAG to "master" actually works...
M buildbot_try.sh
- Added a number of comments about use of this script.
- Fixed some typos.
- Spread command to multiple lines for readability.
267 lines of code changed in 22 files:
Fix for potentail fatal bug when putting variables into the Datawarehouse (DW) when the variable type is
different from the type specified by the VarLabel. I'm surprised that we did not validate this previously
and more surprised that many things did not fail because of this. I'm guessing that for the most part
people didn't accidentally trigger this issue, and when it did happen, the underlying data was close enough
that it didn't cause issues.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Put in a check to validate that the variable and var label types match when allocateAndPut() is called.
Only makes this check if assertions are configured on (ie, debug builds).
M CCA/Components/Arches/ExplicitSolver.cc
- Fix error where SFCYVariable as being put into the DW as a SFCXVariable (X instead of Y).
M CCA/Components/Arches/SourceTerms/RMCRT.cc
- Fix error where abskg and sigmaT4 were being put into the DW as doubles before being converted into float vars
in RMCRT later on.
M Core/Grid/Variables/GridVariable.h
- Add some whitespace and use {} for one line if statements.
24 lines of code changed in 1 file:
For infrastructure: Update existing DebugStreams and Dout objects to be constructed with a desription matching that found in environmentalFlags.txt. EnvironmentalFlags,txt itself also updated.
Components can individually go in and do this same thing now, ultimately deprecating and eventually removing environmentalFlags.txt (hopefully).
1 lines of code changed in 1 file:
Added constructors that initialize the elementss of the stencils
0 lines of code changed in 4 files:
Remove redundant code in SimulationState::clearMaterials.
With the switcher component, this was incorrectly decrementing the ref count on material sets, which is likely the reason ComputeSubsets were being deleted prematurely and subsequently casusing double delete issues when switching occurred. This problem would not manifest in anything but the switcher, as clearing materials only happened implicitly by the infrastructure via SimulationState DTOR. Switcher was calling it explicitly in Switcher::needRecompile().
Some other cleanup, e.g 0->nullptr, braces, white space, etc.
6 lines of code changed in 2 files:
cleanup of the namespace for debug streams and removed using namespace std
13 lines of code changed in 3 files:
minor remaning of debug stream names
1 lines of code changed in 1 file:
addition debug stream naming
1 lines of code changed in 1 file:
made the label map a member var
8 lines of code changed in 2 files:
Remove the machinery for shared DetailedTasks object. (1) this no longer makes sense in a multi-task graph environement, as teh whole point of multile primary graphs is that the DetailedTasks set will differ, (2) turns out this original "enhancement" and all supporting code was not even being excercised (for many years now), and (3) when actually enabled, any benifit was negligible relative to the overall complexity it introduced, even for the shared scrub table.
Many other refactorings, cleanups and other cosmetic changes, all as part of the next wave of task graph optimizations.
2 lines of code changed in 2 files:
* Removed Uintah::parallel_reduce.
* Added Uintah::parallel_reduce_min.
* Added Uintah::parallel_reduce_sum.
* Replaced use of Uintah::parallel_reduce with Uintah::parallel_reduce_sum.
* Replaced use of Uintah::parallel_for within KokkosSolver::computeStableTimeStep with Uintah::parallel_reduce_min.
* Cleaned up whitespace and formatting.
This commit extends Uintah's parallel patterns to support minimum reductions on scalar data.
36 lines of code changed in 1 file:
* Updated KokkosOpenMPScheduler.cc to use Kokkos::OpenMP::partition_master() for Kokkos-based builds.
* Added -npartitions and -nthreadsperpartition run-time options.
* Set the Kokkos-OpenMP Scheduler as the default scheduler for Kokkos-based builds.
* Added bulletproofing within SchedulerFactory.cc.
* Updated ProcessorGroup.h to use m_comm for -nthreads 1 or -npartitions 1.
* Added MasterLock.h to help avoid mixing synchronization primitives.
* Replaced use of #include <mutex> with #include <Core/Parallel/MasterLock.h>.
* Replaced use of std::mutex with Uintah::MasterLock.
* Cleaned up whitespace.
This commit extends the Kokkos-OpenMP Scheduler to support parallel execution of tasks within an MPI process.
Scheduler logic is based upon that of the Unified Scheduler, where individual threads are used as task runners.
In the context of the Kokkos-OpenMP Scheduler, individual partitions are used as task runners.
Individual partitions execute Kokkos-based tasks in parallel across the threads belonging to that partition and existing serial tasks serially.
Note, this scheduler requires MPI_THREAD_MULTIPLE support to run with multiple partitions per MPI process.
2 lines of code changed in 1 file:
moved PerPatchVars.h to Core and RunTimeStatsEnums.h to Schedulers to give better separation, Also removed unneeded ehader files
94 lines of code changed in 1 file:
Update copyright date.
93 lines of code changed in 143 files: