Lines of Code
[root]/CCA/Components/Arches/SourceTerms
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 233 (100.0%) | 5054 (100.0%) | 21.6 |
| derekhar | 26 (11.2%) | 2328 (46.1%) | 89.5 |
| allen | 128 (54.9%) | 1048 (20.7%) | 8.1 |
| bisaac | 28 (12.0%) | 547 (10.8%) | 19.5 |
| mcconnell | 7 (3.0%) | 403 (8.0%) | 57.5 |
| jthornoc | 19 (8.2%) | 341 (6.7%) | 17.9 |
| ohdiazi | 16 (6.9%) | 215 (4.3%) | 13.4 |
| zhouminmin | 3 (1.3%) | 144 (2.8%) | 48.0 |
| dav | 1 (0.4%) | 23 (0.5%) | 23.0 |
| jas | 3 (1.3%) | 3 (0.1%) | 1.0 |
| jholmen | 1 (0.4%) | 1 (0.0%) | 1.0 |
| ahumphrey | 1 (0.4%) | 1 (0.0%) | 1.0 |
This commit computes the default devol_to_HCN and devol_to_NH3 NOx parameters based on the HHV, ash and moisture composition. No change to RT.
0 lines of code changed in 2 files:
Adopts soleVariables for the dynamic radiation solving variables used for dictation rad solves.
25 lines of code changed in 2 files:
delete varlabel for reduction used when using dynamic radiation solve frequency.
1 lines of code changed in 1 file:
Added test for dynamic radiation solving frequencies.
This commit also constrains the solve to be within the solve frequency and the timescale estimated at runtime.
This is the first test to use perpatch variables in the checkpoint, so compare_uda will need to be extended to support this data type (and possibley PIDX? yuck)
Wall model integration is forthcoming.
109 lines of code changed in 3 files:
changed the example to be more generic
74 lines of code changed in 2 files:
added check for freq of 1 to always use the static case and added placeholder for using four task graphs
81 lines of code changed in 2 files:
refactored the task graph index setting to be task based, added set/get for the index, Within arches refactor the dynamic stepping to be completing with DoRadiation and the fixed stepping in Explicit Solver, and added a check method for reduction vars
257 lines of code changed in 4 files:
added additional comments for the dynamic radiation
20 lines of code changed in 1 file:
This commit fixes a bug when using second order time tabulated reaction rates. This commit will impact the acid base regression test.
0 lines of code changed in 2 files:
This adds input files and source code for the detailed and reduced soot models developed by Alex Josephson, David Lignell, and Kamron Brinkerhoff.
The detailed model is very computationally expensive and is included to help verify the reduced model in its development.
1913 lines of code changed in 8 files:
Added a smarter model for the split between devol and char in the NOx model in the case of birth and death (thanks to Derek). This changes mass_energy_balance_psnox test answers.
32 lines of code changed in 3 files:
This commit fixes the birth/death issues observed with the Tar integration and psNOx model and modifies the varlabels used by psNOx and ZZNox for devol and char oxidation. This commit also changes the way we are integrating Tar into the gas phase. Note that the Tar_fraction variable in the ParticleProperties section is being used to modify the light to heavy devol products (from the perspective of the NOx, and Tar). This commit changes the answers for mass_energy_balance.ups and mass_energy_balance_Tfluid.ups. We added a new test: mass_energy_balance_psnox.ups, which covers the psNOx model under regression tests. Please see mass_energy_balance_psnox.ups for an example of how to incorporate the tar mass into the coal gas mixture fraction and the b/d mass into Nox.
44 lines of code changed in 4 files:
This commit moves the Tar_fraction variable to the coalhelper. Computes additional variables in the CoalGasDevol and CoalGasOxi gas phase source terms to handle birth/death for NOx and Tar, and removes old functor and ifdef logic. This commit doesn't impact regression tests.
165 lines of code changed in 8 files:
This commit throttles the NOx char reduction reaction by a factor of the organic mass fraction. As organic mass goes to zero this reaction will turn off. No impact on regression tests.
63 lines of code changed in 2 files:
clean up of the dynamic radiation solve - made it fully local to arches
58 lines of code changed in 2 files:
removed test code
0 lines of code changed in 1 file:
removed my example for the task graph swap - added Derek's code for the actual implementation
133 lines of code changed in 2 files:
moved the passing of the app to a scheduling that is always called
5 lines of code changed in 1 file:
added the performance stats to the DO Radiation Model
6 lines of code changed in 1 file:
Fixing several warnings in Arches. Should not change answers.
96 lines of code changed in 4 files:
removal of shared state and introduction of a material manager
386 lines of code changed in 104 files:
Adding F1 for psNOx model
4 lines of code changed in 2 files:
Adding aditional parameter to psNox model
3 lines of code changed in 2 files:
Fixing a bug in the soot model. Not treating intrusions properly was
causing a divergence problem for cases at scale.
70 lines of code changed in 1 file:
Splitting up the transport eqn eval so that sources may used the RHS
construction in cases of rate limiting.
Also cleaned up some warnings.
local_RT showed one test failing (CoalRadPropsPlank) with noise diffs.
88 lines of code changed in 2 files:
clipping method for psNOx
43 lines of code changed in 1 file:
fixing bug in extended zeldovich mechanism
3 lines of code changed in 1 file:
Fix for potentail fatal bug when putting variables into the Datawarehouse (DW) when the variable type is
different from the type specified by the VarLabel. I'm surprised that we did not validate this previously
and more surprised that many things did not fail because of this. I'm guessing that for the most part
people didn't accidentally trigger this issue, and when it did happen, the underlying data was close enough
that it didn't cause issues.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Put in a check to validate that the variable and var label types match when allocateAndPut() is called.
Only makes this check if assertions are configured on (ie, debug builds).
M CCA/Components/Arches/ExplicitSolver.cc
- Fix error where SFCYVariable as being put into the DW as a SFCXVariable (X instead of Y).
M CCA/Components/Arches/SourceTerms/RMCRT.cc
- Fix error where abskg and sigmaT4 were being put into the DW as doubles before being converted into float vars
in RMCRT later on.
M Core/Grid/Variables/GridVariable.h
- Add some whitespace and use {} for one line if statements.
23 lines of code changed in 1 file:
rolled back changes to r58119
201 lines of code changed in 3 files:
fix absently minded move
164 lines of code changed in 2 files:
This commit adjust the enthalpy balance, and ash mass balance for conservation. This commit will not change the answers.
34 lines of code changed in 1 file:
removed need for calls to shared state for the time step and sim time
4 lines of code changed in 1 file:
Document remaining Douts.
1 lines of code changed in 1 file:
removed the shared state from the radiation model and re-invoked the in-situ
1 lines of code changed in 1 file:
Fixed incorrect parameters which had been changed previously to account for soot gasification.
Also adjusted the soot clipping. This will break the BrownSootSpectral Test.
35 lines of code changed in 1 file:
DQMOM with kokkos
6 lines of code changed in 1 file:
Removal of duplicate scheduling functionality in the Arches Task Interface. Now we go through the factory.
Cleaning up the failures in the kokkos turbulence models, which required an input file change (removal of volFraction def)
Fixing the setting of simTime in the Arches tasks. Previously time was zero always resulting in nonsense answers.
Finally, changing the Atomic task to derive off the Arches Task rather than be its own beast.
Expecting the following "failures" which will require update to GS:
S U M M A R Y
Failed: ARCHES-opt tests
:kokkos-x-scalar_mms_RK1: test failed comparison tests
:kokkos-x-scalar_mms_RK1: (restart) test failed comparison tests
:kokkos-x-scalar_mms_RK2: test failed comparison tests
:kokkos-x-scalar_mms_RK2: (restart) test failed comparison tests
:kokkos-x-scalar_mms_RK3: test failed comparison tests
:kokkos-x-scalar_mms_RK3: (restart) test failed comparison tests
:problem3_Shunn_mms-x: test failed comparison tests
:problem3_Shunn_mms-x: (restart) test failed comparison tests
:isotropic_kokkos_wale: test failed comparison tests
2 lines of code changed in 1 file:
Added a new optional task inside DOR for profiling solve frequency and scattering convergence.
121 lines of code changed in 2 files:
restructured teh Dout and DebugStream to register the streams to avoid conflicts
1 lines of code changed in 1 file:
Another change to spectral radiation. Redesign of the gas+soot properties and their interface with the solver.
4 lines of code changed in 1 file:
(24 more)