/trunk/src Developers: bisaac

Login name:
bisaac
Total Commits:
107 (0.8%)
Lines of Code:
5,642 (4.0%)
Most Recent Commit:
2018-12-13 11:17
Tweet this:
Tweet this

Activity by Clock Time

Activity by Hour of Day for bisaac

Activity by Day of Week for bisaac

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 107 (100.0%) 5642 (100.0%) 52.7
CCA/Components/Arches/TurbulenceModels/ 32 (29.9%) 3869 (68.6%) 120.9
CCA/Components/Arches/ParticleModels/ 19 (17.8%) 699 (12.4%) 36.7
CCA/Components/Arches/SourceTerms/ 28 (26.2%) 547 (9.7%) 19.5
CCA/Components/Arches/WallHTModels/ 14 (13.1%) 367 (6.5%) 26.2
CCA/Components/Arches/ 2 (1.9%) 60 (1.1%) 30.0
CCA/Components/Arches/PropertyModels/ 2 (1.9%) 50 (0.9%) 25.0
CCA/Components/Arches/PropertyModelsV2/ 2 (1.9%) 20 (0.4%) 10.0
CCA/Components/Arches/CoalModels/ 3 (2.8%) 16 (0.3%) 5.3
R_Tester/ 4 (3.7%) 12 (0.2%) 3.0
CCA/Components/Arches/Transport/ 1 (0.9%) 2 (0.0%) 2.0

Activity of bisaac

Most Recent Commits

bisaac 2018-12-13 11:17 Rev.: 59068

This commit computes the default devol_to_HCN and devol_to_NH3 NOx parameters based on the HHV, ash and moisture composition. No change to RT.

0 lines of code changed in 4 files:

  • CCA/Components/Arches/ParticleModels: CoalHelper.h (new)
  • CCA/Components/Arches/SourceTerms: psNox.cc (changed)
bisaac 2018-11-15 18:05 Rev.: 58923

This commit fixes a bug when using second order time tabulated reaction rates. This commit will impact the acid base regression test.

0 lines of code changed in 2 files:

  • CCA/Components/Arches/SourceTerms: TabRxnRate.cc (new)
bisaac 2018-10-29 17:38 Rev.: 58889

Added a smarter model for the split between devol and char in the NOx model in the case of birth and death (thanks to Derek). This changes mass_energy_balance_psnox test answers.

32 lines of code changed in 3 files:

  • CCA/Components/Arches/SourceTerms: psNox.cc (+29 -6), psNox.h (new)
bisaac 2018-10-25 14:59 Rev.: 58884

This commit fixes the birth/death issues observed with the Tar integration and psNOx model and modifies the varlabels used by psNOx and ZZNox for devol and char oxidation. This commit also changes the way we are integrating Tar into the gas phase. Note that the Tar_fraction variable in the ParticleProperties section is being used to modify the light to heavy devol products (from the perspective of the NOx, and Tar). This commit changes the answers for mass_energy_balance.ups and mass_energy_balance_Tfluid.ups. We added a new test: mass_energy_balance_psnox.ups, which covers the psNOx model under regression tests. Please see mass_energy_balance_psnox.ups for an example of how to incorporate the tar mass into the coal gas mixture fraction and the b/d mass into Nox.

47 lines of code changed in 5 files:

  • CCA/Components/Arches/SourceTerms: ZZNoxSolid.cc (new), psNox.cc (+37 -7), psNox.h (+5)
  • R_Tester: ARCHES.py (+3)
bisaac 2018-10-25 13:20 Rev.: 58883

This commit moves the Tar_fraction variable to the coalhelper. Computes additional variables in the CoalGasDevol and CoalGasOxi gas phase source terms to handle birth/death for NOx and Tar, and removes old functor and ifdef logic. This commit doesn't impact regression tests.

167 lines of code changed in 9 files:

  • CCA/Components/Arches/ParticleModels: CoalHelper.h (+2)
  • CCA/Components/Arches/SourceTerms: CoalGasDevol.cc (new), CoalGasDevol.h (+9), CoalGasOxi.cc (new), CoalGasOxi.h (+4)
bisaac 2018-10-25 10:48 Rev.: 58881

This commit throttles the NOx char reduction reaction by a factor of the organic mass fraction. As organic mass goes to zero this reaction will turn off. No impact on regression tests.

63 lines of code changed in 2 files:

  • CCA/Components/Arches/SourceTerms: psNox.cc (+53 -42), psNox.h (+10 -4)
bisaac 2018-09-28 09:32 Rev.: 58725

Fixed declaration error with k_ash_uncertain variable. This doesn't impact regression tests but will impact VUQ runs with this parameter.

1 lines of code changed in 1 file:

  • CCA/Components/Arches/WallHTModels: WallModelDriver.h (+1 -1)
bisaac 2018-07-20 14:34 Rev.: 58443

Removed if statement that was no longer needed. No impact on RT.

0 lines of code changed in 1 file:

  • CCA/Components/Arches/PropertyModelsV2: CCVel.cc (-3)
bisaac 2018-07-20 14:28 Rev.: 58442

Remaining changes to get nles working on the 64x64x64 test case. No impact on rt.

43 lines of code changed in 5 files:

  • CCA/Components/Arches/PropertyModelsV2: CCVel.cc (+20)
  • CCA/Components/Arches/TurbulenceModels: FractalUD.h (-6), MultifractalSGS.cc (+22 -131), MultifractalSGS.h (+1 -21), TurbulenceModelFactory.cc (-5)
bisaac 2018-07-19 11:08 Rev.: 58437

Updated coefficients for fourth order deriviative in NLES model. This wont impact RT.

1 lines of code changed in 1 file:

  • CCA/Components/Arches/TurbulenceModels: MultifractalSGS.h (+1 -2)
bisaac 2018-07-17 17:08 Rev.: 58434

Updated 4th order coefficients for interpolation. No impact on regression tests.

2 lines of code changed in 1 file:

  • CCA/Components/Arches: GridTools.h (+2 -2)
bisaac 2018-07-17 16:05 Rev.: 58431

Removed a redundant nles task and clean up some old comments.

10 lines of code changed in 9 files:

  • CCA/Components/Arches/TurbulenceModels: FilterStress.cc (del), FilterStress.h (del), FractalUD.cc (-42), MultifractalSGS.cc (+2 -267), MultifractalSGS.h (-30), SGSforTransport.cc (+8 -97), SGSforTransport.h (-1), TurbulenceModelFactory.cc (-11), sub.mk (-1)
bisaac 2018-07-17 14:43 Rev.: 58430

Fixed indentation in NLES code. No impact on regression tests.

1424 lines of code changed in 6 files:

  • CCA/Components/Arches/TurbulenceModels: FilterStress.cc (new 238), FilterStress.h (new 85), MultifractalSGS.cc (+682 -682), MultifractalSGS.h (+164 -164), SGSforTransport.cc (+215 -215), SGSforTransport.h (+40 -40)
bisaac 2018-06-29 14:24 Rev.: 58362

Added a fix to WallHT for the scenario where rad_q_max = rad_q_melt and we switch from regime 2 to regime 3. This was creating unphysical behavior liquid layer thickness. This commit shouldn't impact regression tests.

4 lines of code changed in 1 file:

  • CCA/Components/Arches/WallHTModels: WallModelDriver.cc (+4 -3)
bisaac 2018-06-20 16:54 Rev.: 58337

This commit adds all of Minmins work on the nles model. No impact on regression tests.

2463 lines of code changed in 12 files:

  • CCA/Components/Arches: ConvectionHelper.h (+58)
  • CCA/Components/Arches/Transport: KMomentum.h (+2)
  • CCA/Components/Arches/TurbulenceModels: FilterStress.cc (+292), FilterStress.h (+129), FractalUD.cc (+422), FractalUD.h (+117), MultifractalSGS.cc (+811), MultifractalSGS.h (+226), SGSforTransport.cc (+251), SGSforTransport.h (+73), TurbulenceModelFactory.cc (+78), sub.mk (+4)
bisaac 2018-06-05 10:35 Rev.: 58287

Modified burnout to be mo/mo0 instead of 1-mo/mo0 as per Phils request. This will change the answers to the mass_energy_balance test.

1 lines of code changed in 1 file:

  • CCA/Components/Arches/ParticleModels: Burnout.cc (+1 -1)
bisaac 2018-05-24 17:05 Rev.: 58267

Added initialization within a geometric object for the heat_loss property model. This won't impact tests.

50 lines of code changed in 2 files:

  • CCA/Components/Arches/PropertyModels: PropertyModelBase.cc (+15), PropertyModelBase.h (+35)
bisaac 2018-03-09 17:49 Rev.: 57925

Added a burnout particle model, and turned the model on in the inpute file: mass_energy_balance.ups. This will fail the uda compare for mass_energy_balance.ups due to the change in the number of saved parameters.

216 lines of code changed in 4 files:

  • CCA/Components/Arches/ParticleModels: Burnout.cc (+133), Burnout.h (+71), ParticleModelFactory.cc (+11), sub.mk (+1)
bisaac 2018-02-28 18:25 Rev.: 57902

Updated the additional log function for VUQ in WallHT. This impacts 1GW_em_tc and 1GW_pokluda in the noise.

3 lines of code changed in 1 file:

  • CCA/Components/Arches/WallHTModels: WallModelDriver.cc (+3 -3)
bisaac 2018-02-28 11:35 Rev.: 57898

Added uncertainity parameter for ash thermal conductivity.

14 lines of code changed in 2 files:

  • CCA/Components/Arches/WallHTModels: WallModelDriver.cc (+6 -1), WallModelDriver.h (+8)

(16 more)

Generated by StatSVN 0.7.0