Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 65 (100.0%) | 786 (100.0%) | 12.0 |
| harman | 61 (93.8%) | 747 (95.0%) | 12.2 |
| dav | 3 (4.6%) | 37 (4.7%) | 12.3 |
| ahumphrey | 1 (1.5%) | 2 (0.3%) | 2.0 |
runSusTests.py
- Fake out python's indentation requirement
ExchangeModels and ICE
- The base class now creates and destroys ICE/MPMLabel
- Only create MPMLabel if we're using MPMICE
1 lines of code changed in 2 files:
Disabled warning regarding input file differences.
1 lines of code changed in 1 file:
compare_dat_files.pl
- Comments
- Improved return codes
- Output format
compare_dats:
- Fixed hole in error checking. Both udas must have the same number of dat files
- Improved return codes
compare_sus_runs:
- Added summary to the bottom of the compare_sus_runs.log.txt file
Summary:
======================================
dat file comparsions: PASSED
uda comparisons: PASSED
checkpoint comparisons: PASSED
======================================
0 lines of code changed in 6 files:
Added comments.
Fixed syntax error.
Cleanup warning.
0 lines of code changed in 2 files:
- updated email distribution list for the gpu_rt and kokkos_rt.
- disable sci-malloc for debug compilations on kokkos builds.
- removed EOL white spaces.
0 lines of code changed in 2 files:
The reason for compare_uda aborting the comparison should now be visible to the user.
1 lines of code changed in 1 file:
Fix the href address for log files that live in the restart directory.
4 lines of code changed in 1 file:
Set env variable to fix issue with dialog running on certain terminals.
6 lines of code changed in 5 files:
Replaced environ['output_html'] with getenv( 'output_html' ). The environmental var output_html
may not exist , which is fine. getenv() returns "none" if environmental var isn't found. environ{} throws
an exception.
2 lines of code changed in 1 file:
Ignore header lines in dat files.
Expanded number regression expression to accept different number formats.
Variable name changes:
greatest_* -> max_*
first_significant_* -> first_*
has_significant_* -> detected_*
97 lines of code changed in 1 file:
- nuked tabs.
- 2 space indentation
- Added spaces and dividers
155 lines of code changed in 1 file:
Added LDFLAGS='-ldl' to kokkos configure line.
2 lines of code changed in 1 file:
Moved helpers/cleanup -> toplevel
Renamed svn_checkout_startTester -> svn_checkout_scripts
Download fresh copies of the scripts everynight.
0 lines of code changed in 1 file:
Email users when there's trash to be deleted.
0 lines of code changed in 1 file:
Added configuration for kokkos_rt, untested.
10 lines of code changed in 1 file:
Added a date stamp to the output.
1 lines of code changed in 1 file:
- Removed cyrus's configuration
- Added ability to output html from the local RT scripts. This will be useful for
inspecting buildbot failures.
- rsync an application's results to public_html/ after all tests have run.
- Misc. cleanup.
70 lines of code changed in 6 files:
Updated uintah-build:gpu_rt configure line
1 lines of code changed in 1 file:
uintah-build:
Using the default DBG_configure line, that include --enable-sci-malloc
0 lines of code changed in 1 file:
uintah-build: use hypre 2.8.0b until the patient stabilizes.
2 lines of code changed in 1 file:
uintah-build: typo in hypre path
2 lines of code changed in 1 file:
uintah-build configure:
using manually compiled packages.
--with-mpi=/usr/lib/mpich\\
--with-hypre=/usr/local/hypre-2.10.1 \\
--with-boost=/usr/local/boost-1.65.1 \\
--with-petsc=/usr/local/petsc-3.8.4 \\
9 lines of code changed in 1 file:
fixed typo
1 lines of code changed in 1 file:
uintah-build
- point configure to a local compilation of boost
- remove sci-malloc from the configure lines
- on gpu builds do not compile radprops or tabprops.
7 lines of code changed in 1 file:
New configure line for uintah-build.
6 lines of code changed in 1 file:
This should fix the HTML links for sus output.
1 lines of code changed in 1 file:
modUPS2
Fixed bug when the values to be updated contained white spaces.
0 lines of code changed in 2 files:
This commit brings the PIDX data I/O branch (named: pidx_xml) back into the trunk.
All PIDX data I/O is, by default, turned off. To use PIDX you have to configure
against the PIDX library (either installing manually and pointing at it, or using
the --with-pidx flag (not 100% certain that this works at the moment)), and you must
set <DataArchiver type="PIDX"> (as opposed to the default which is type="UDA") in
the .ups input file.
Other caveats:
- Particles are not (currently?) supported in PIDX so any simulation that has a
particle data type will fail (most will print an error that PIDX does not
support them, but it seems some just die).
- Simulations that have overlapping patches (this may just be AMR type
sims) (eg: multibox_rmcrt_coal_1L) can save (slightly different) results.
In the multibox_rmcrt_coal_1L, we saw (only) a handful of differences like this:
((A 1 vs a 0 in a couple of locations) Also note that the UDA itself compared
successfully, but the checkpoint underneath it did not...)
DIFFERENCE [int 36, 5, 0] Time: 0.0003106658 Level: 0 Patch1: 0 Patch2: 0 Material: 0 Variable: areaFractionFX
multibox_RMCRT_coal_1L.uda/checkpoints goldStandard/.../multibox_RMCRT_coal_1L.uda/checkpoints
1 0
- "#if HAVE_PIDX" is used inconsistently through a number of files. Some PIDX stuff is #if'd out, while other code
is left in and compiles, it is just not used.
- There are a lot of cleanups that can and should take place wrt the PIDX integration.
While the code passes all the local RT tests (with the exception of particle tests),
I don't believe it has been run at large scale (though it should work) on a BGQ or Quartz@llnl.
Summary of changes: (Note, see pidx_xml branch commits if you want more information.)
M CCA/Ports/ApplicationInterface.h
M CCA/Components/Application/ApplicationCommon.h
- Added the ability to record (and retrieve) the number for the last regrid time step.
M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc
- When saving as PIDX, only create/output timestep.xml on the initial (I/O) time step that occurs after the regrid.
- Fixes that allow PIDX to save correctly (and efficiently) in parallel. If you are ever trying
to trace this back, read the comments from the commit logs for the "pidx_xml" branch.
- Remove createPIDX_dirs() as it was commented out and Sid tells me that PIDX creats its own dirs and we don't need this.
- Lot of white space fixes.
M CCA/Components/Examples/RMCRT_Test.cc
M CCA/Components/PostProcessUda/PostProcess.cc
- The DataArchive (DA) queryVariables() function now also returns the number of materials for each variable.
- "else" and "else if" should be on a separate line to make it easier to read.
M CCA/Components/Models/Radiation/RMCRT/RayGPU.cc
- Differentiate the output between the GPU and non-GPU reports so the viewer knows explicitly whether the GPU code was run.
M CCA/Components/Schedulers/OnDemandDataWarehouse.h
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Cosmetics: Line up variables, use more than 80 chars per line, white space.
Add in comments denoting default param values.
M CCA/Components/Schedulers/SchedulerCommon.cc
- Cosmetics.
M CCA/Components/SimulationController/AMRSimulationController.cc
- Cosmetics: Use more white space, 80+ chars per line for better readability, etc.
M CCA/Ports/PIDXOutputContext.h
- const'ify some params.
- checkReturnCode() is a static function so mark it so.
M CCA/Ports/PIDXOutputContext.cc
- White spacee. Code alignment for readability.
M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc
- Add in PIDX functions. Note, queryPIDXSerial() is used (currently) by standalone codes (eg: puda).
Its purpose is to wrap the setupQueryPIDX()/queryPIDX() calls that have been added to
allow PIDX to truly run in parallel. At some point it would be good to update puda/compare_uda/etc
to run in parallel...
- See previous comments from PIDX branch for more details on the PIDX communicators that are necessary
to transfer data as some data does not live on all cores and thus can't use the golbal comm.
- Rename a few functions (queryAndSetParticlePositionName()) to be more accurate as to what they do.
- There are still a number of hacks in this code that need to be addressed (eg: var_materials map).
M Core/Geometry/IntVector.h
- Mostly cosmetics...
White space for readability.
Place 1-line functions in .h on one line to make it easier to see all provided functions.
M Core/Grid/Grid.cc
- White space, variable alignment for readability.
M Core/Grid/Level.h
M Core/Grid/Level.cc
- White space, coding standard (return type on its own line).
- Fix logic error in computeVariableExtents() that did not handle periodic boundaries correctly.
This fix was suggested as probably the correct way to do it by Todd... seems to pass tests and did fix
the issue (PIDX saving a particular something or other) that led me to it.
M Core/Grid/Patch.cc
- Place "else" on its own line for readability.
M Core/Grid/Variables/GridVariable.h
- Added emitPIDX().
- Opening "{" for functions in .h files goes on same line.
M Core/Grid/Variables/GridVariableBase.h
M Core/Grid/Variables/GridVariableBase.cc
- Organize #includes.
- White space, line up vars, etc for better readability.
- Return type on its own line.
M Core/Grid/Variables/ParticleData.h
- #include ParticleSubset.h for particleIndex.
M Core/Grid/Variables/ParticleSubset.h
- Cosmetic white space.
M Core/Grid/Variables/ParticleVariable.h
- White space, variable line up, etc.
- Added emitPIDX() function for particles. Note, particles do not fully work yet (on PIDX side).
And thus, this function hasn't really been tested.
M Core/Grid/Variables/ParticleVariableBase.h
M Core/Grid/Variables/ParticleVariableBase.cc
M Core/Grid/Variables/PerPatchBase.h
M Core/Grid/Variables/PerPatchBase.cc
M Core/Grid/Variables/ReductionVariableBase.h
M Core/Grid/Variables/ReductionVariableBase.cc
- Cosmetic white space. Coding standards. Etc.
M Core/Grid/Variables/Variable.h
M Core/Grid/Variables/Variable.cc
- Organize #includes.
- Use "const" on params that are const.
- Cosmetic white space, etc.
M Core/Grid/Variables/VarnameMatlPatch.h
- Pass non-changing strings by const reference (instead of copying them).
- White space for readability.
M Core/ProblemSpec/ProblemSpec.cc
- Line up vars, white space.
M R_Tester/helpers/compare_dat_files.pl
- Strip "/" from end of uda names.
- Clean up output to make it more readable (Todd I hope this doesn't break some of your scripts...)
M R_Tester/helpers/compare_dats
- White space.
M R_Tester/helpers/runSusTests.py
- Fix typo.
M StandAlone/compare_uda.cc
- White space.
- Line up vars.
- Coding standard.
- Line up case statement for better readability.
- 0 => nullptr
- query() now returns if the var was found (because PIDX has a list of all variables the simulation starts with
and the vars may not actually exist in the UDA.
- var => var_name (as it is actually the name, and not the var).
- Use 80+ columns.
M StandAlone/partvarRange.cco
M StandAlone/selectpart.cc
M StandAlone/tools/compute_Lnorm_udas.cc
M StandAlone/tools/dumpfields/dumpfields.cc
M StandAlone/tools/extractors/extractF.cc
M StandAlone/tools/extractors/extractS.cc
M StandAlone/tools/extractors/extractV.cc
M StandAlone/tools/extractors/faceextract.cc
M StandAlone/tools/extractors/lineextract.cc
M StandAlone/tools/extractors/partextract.cc
M StandAlone/tools/extractors/particle2tiff.cc
M StandAlone/tools/extractors/timeextract.cc
M StandAlone/tools/puda/AA_MMS.cc
M StandAlone/tools/puda/ER_MMS.cc
M StandAlone/tools/puda/GV_MMS.cc
M StandAlone/tools/puda/ICE_momentum.cc
M StandAlone/tools/puda/PIC.cc
M StandAlone/tools/puda/POL.cc
M StandAlone/tools/puda/asci.cc
M StandAlone/tools/puda/jacquie.cc
M StandAlone/tools/puda/jim1.cc
M StandAlone/tools/puda/jim2.cc
M StandAlone/tools/puda/jim3.cc
M StandAlone/tools/puda/pressure.cc
M StandAlone/tools/puda/puda.cc
M VisIt/interfaces/archiveInterface.cc
- queryVariables() now returns number of materials.
M StandAlone/tools/puda/varsummary.h
M StandAlone/tools/puda/varsummary.cc
- Swat some evil endls.
M build_scripts/build_pidx.sh
- FYI... Not sure if changing PIDX_TAG to "master" actually works...
M buildbot_try.sh
- Added a number of comments about use of this script.
- Fixed some typos.
- Spread command to multiple lines for readability.
37 lines of code changed in 3 files:
changed python -> python3
1 lines of code changed in 1 file:
Update the scripts to run with python 3.X.
33 lines of code changed in 4 files:
Added URL for memory/peformance plots to email message.
8 lines of code changed in 1 file:
getUniqueFilename()
- Fixed logic bugs. Now returns unique filename if the base ups file is modified more than once
with multiple modUPS() calls
18 lines of code changed in 1 file:
modUPS.py
- modUPS2()
User can either update an xml value or delete an xml section
# usage:
# mod_ups = modUPS2( inputDirectory, <ups file>, [ (<operation>, "xmlpath : value" )]
# where: operation = "update" or "delete"
- modUPS() & modUPS2()
consolidated redundant code.
ICE:
- Added 5 level advect problem.
- Added 5 level advect performance test
- Fixed glaring bug on buildbot tests, NIGHTLYTESTS = NIGHTLYTESTS + AMRTESTS + DIFFUSION + LODI
95 lines of code changed in 1 file:
- Removed tabs
- Added more descriptive exception messages.
- Name changes:
nameoftest() -> getTestName()
input() -> getUpsFile()
num_processes -> getMPISize()
testOS() -> getTestOS()
userFlags() -> getTestFlags()
ALGO -> application
Fixed setInputsDir() and simplified getInputsDir()
BugFix:
For performance tests pass modUPS() the local patch so it will modify a local
copy of the input file.
119 lines of code changed in 3 files:
Added python script to find "orphan" gold standards.
61 lines of code changed in 1 file:
Eliminated some confusing code and logic:
changed : setGeneratingGoldStandards() -> setInputsDir()
changed : generatingGoldStandards() -> getInputsDir()
Cleaned import statements for all component.py files, removed unnecessary conditional block.
30 lines of code changed in 2 files:
Removed duplicate copy command that shouldn't be called if there are no restarts
1 lines of code changed in 1 file:
Enable examples for GPU tests.
2 lines of code changed in 1 file:
Due to an unresolved debug compiliation error I removed Wasatch from the gpu_RT.
2 lines of code changed in 1 file: