Mixing
(13 files, 2561 lines)
Radiation
(10 files, 2703 lines)
TabProps
(7 files, 93 lines)
docs
(2 files, 2 lines)
fortran
(1 files, 125 lines)
[root]/Packages/Uintah/CCA/Components/Arches
Mixing
(13 files, 2561 lines)
Radiation
(10 files, 2703 lines)
TabProps
(7 files, 93 lines)
docs
(2 files, 2 lines)
fortran
(1 files, 125 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 644 (100.0%) | 34556 (100.0%) | 53.6 |
| harman | 396 (61.5%) | 29306 (84.8%) | 74.0 |
| jthornoc | 203 (31.5%) | 4117 (11.9%) | 20.2 |
| charlesreid | 8 (1.2%) | 719 (2.1%) | 89.8 |
| luitjens | 12 (1.9%) | 279 (0.8%) | 23.2 |
| dav | 13 (2.0%) | 114 (0.3%) | 8.7 |
| jas | 10 (1.6%) | 19 (0.1%) | 1.9 |
| sbrown | 1 (0.2%) | 1 (0.0%) | 1.0 |
| amorris | 1 (0.2%) | 1 (0.0%) | 1.0 |
computeMMSError()
- spacing
- removed extra L2 & Linfinity calculation from the cell-centered scalar section.
0 lines of code changed in 2 files:
added missing ;
0 lines of code changed in 2 files:
scalarOutletPressureBC()
- elminated nested loops over each face, now using boundary face iterator and face Iterator
20 lines of code changed in 1 file:
Global:
replaced nested loops with cell iterators.
This should not change the answers
179 lines of code changed in 9 files:
Code consolidation:
moved code from (u,v,w)velocityBC() into velocityBC()
This should not change the answers
14 lines of code changed in 3 files:
deleted mm(u,v,w)VelocityBC()
consolidation: moved all of the mm(u,v,w)VelocityBC code into mmVelocityBC()
This shouldn't change the answers.
17 lines of code changed in 2 files:
MomentumSolver.cc
buildLinearMatrixVelHat()
- removed Tau timing statements.
- removed switch/case statements and loop over x,y.z, it just is not needed.
- consolidated "get" statements
Boundarycondition.cc
velocityBC(), mmvelocityBC(), calculateVelRhoHat_mm(), mmsvelocityBC(),
- removed switch/case statements, consolidated common code.
Sources.cc
calculateVelocitySource(), modifyVelMassSource(), computeMomentumSource()
- removed switch/case statements, consolidated common code.
Discretization.cc
calculateVelocityCoeff(), calculateVelDiagonal()
- removed switch/case statements
RHSSolver.cc
calculateHatVelocity()
- removed switch/case statements
742 lines of code changed in 14 files:
MomentumSolver.cc
buildLinearMatrix() and sched_buildLinearMatrix()
- eliminated loop over x,y,z. Now just scheduling the task once for all 3 dirs.
- cleanup computes/requires
BoundaryConditions.cc
calculateVelocityPred_mm() & addPresGradVeolcityOutletPressureBC()
-elimiated switch/case statements, no longer looping over x,y,z.
velocityOutletPressureTangentBC()
- added loop over x,y,z. This is temporary until this routine can be overhauled.
RHSSolver.cc
calculateVelocity()
-elimiated switch/case statements, no longer looping over x,y,z.
This should not change the answers
396 lines of code changed in 7 files:
removed all
-#include <sgi_stl_warnings_off.h>
-#include <sgi_stl_warnings_on.h>
statements. No longer using SGI machines
0 lines of code changed in 9 files:
removed excess
#include <Core/Geometry/IntVector.h>
#include <Packages/Uintah/Core/Grid/Variables/ComputeSet.h>
statements
0 lines of code changed in 20 files:
removed excess
#include <Packages/Uintah/CCA/Components/Arches/TurbulenceModel.h>
#include <Core/Containers/OffsetArray1.h>
#include <Core/Containers/Array1.h>
statements
0 lines of code changed in 9 files:
removed extra
-#include <Packages/Uintah/Core/Grid/Variables/CCVariable.h>
0 lines of code changed in 26 files:
removed excess
#include <Packages/Uintah/Core/Grid/Variables/SFC(X,Y,Z)Variable.h>
0 lines of code changed in 15 files:
Trying to get some momentum.
- 2 space indentation
- {} surrounding conditional statements
- cleaned up the #includes.
Will not change the answers
57 lines of code changed in 1 file:
arches.cc: ProblemSetup()
- added {} around conditionals
CO2/SO2RateSrc.cc: problemSetup()
- added bulletproofing. The sulfur/carbon balance flags must be
must be set to true in <Arches> <BoundaryCondition> section of the input file.
34 lines of code changed in 4 files:
removed fortran code fort_mmenthalpybc()
- It's identical to fort_mmwallbc()
- replaced calls to fort_mmenthalpybc() -> fort_mmwallbc()
1 lines of code changed in 3 files:
-removed fortran routine fort_mmscalarwallbc() it is identical to fort_mmwallbc()
-changed calls to fort_mmscalarwallbc() -> fort_mmwallbc
2 lines of code changed in 2 files:
removed intrusionVelocityBC()
intrusionuVelocityBC()
intrusionvVelocityBC()
intrusionwVelocityBC()
1) they're never called
2) they're identical copies of mm[u,v,w]velocityBC() which is being used.
1 lines of code changed in 3 files:
Removed d_listDepVarNames and made it local since the dependent variable names are already stored in the LabelMap. When calling getState, we create a local temp variable (vector<string>) with the variables names.
11 lines of code changed in 2 files:
removed intrusionPressureBC()
- It's not being called in any files.
- It's identical to mmpressureBC()
0 lines of code changed in 2 files:
(138 more)