Lines of Code
[root]/Packages/Uintah/CCA/Components/Arches/TabProps
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 32 (100.0%) | 3299 (100.0%) | 103.0 |
| charlesreid | 17 (53.1%) | 3075 (93.2%) | 180.8 |
| dav | 9 (28.1%) | 224 (6.8%) | 24.8 |
| harman | 6 (18.8%) | 0 (0.0%) | 0.0 |
Fix necessary link library list so make will complete under Mac OSX.
3 lines of code changed in 2 files:
Global:
-2 space indentation
-loops wrapped with {}
-conditional statements wrapped with with {}
-added vertical space to improve readability
-removed comments that point out the obvious
- clean up some of the includes.
0 lines of code changed in 6 files:
--with-hdf5 now compiles. (Don't know how to run it to test, but...) The #includes and libs are found correctly.
1 lines of code changed in 1 file:
Fix compilation errors. I believe the without hdf5 is back to
compiling. Will test with-hdf5 soon.
M include/sci_defs/hdf5_testdefs.h.in
Only #include hdf5.h if hdf5 is configured.
M Packages/Uintah/CCA/Components/Arches/TabProps/BSpline.cc
M Packages/Uintah/CCA/Components/Arches/TabProps/BSpline.h
M Packages/Uintah/CCA/Components/Arches/TabProps/StateTable.cc
M Packages/Uintah/CCA/Components/Arches/TabProps/StateTable.h
- Fixed typo: #include sci_defs/hdf needs a '5'.
- We aren't turning off the 'entire' file with #if for hdf5, we are only
turning off the hdf5 parts.
- I believe that the only place I really need to print the 'hdf5' not
configured error message is in the BSpline base class constructor.
I believe everything calls that, so it is a good central place.
If this is not the case, talk to me and we can figure a better
way to do it.
- Don't use #ifndef NO_HDF5 as this is all handled inside the class.
This is mostly a semantic issue, but does make the .h file cleaner.
- Replaced generic exceptions with SCIRun class InternalError. If
this needs to be more specific so that it can be caught and handled,
we can look into something else.
- Place #includes in better order.
- Removed and added white space to make things more readable.
- A couple of coding standard updates.
- Added #if defined( HAVE_HDF5 ) to the specific places it is needed.
- Added in some "{}" for if statements (where they were missing) as I
came across them.
- It's ok to use "using namespace std" inside a .cc file.
M Packages/Uintah/CCA/Components/Arches/TabPropsTable.cc
- '|' is binary 'or'. '||' is boolean 'or'.
- Don't need 'this' inside a class' method. (Most of the time.)
(I don't think this is one of those times.)
- '=' is assignment, '==' is comparison. ;) (Ok, so the compiler caught this one for me. ;)
220 lines of code changed in 6 files:
Committing additional changes to TabProps table reader... sus is still not compiling, however. I'm going to work to fix this later.
23 lines of code changed in 4 files:
Updating header includes to be absolute
5 lines of code changed in 5 files:
adding one more (sub.mk) file
26 lines of code changed in 1 file:
Adding TabProps Table reader
3021 lines of code changed in 7 files: