Lines of Code
[root]/Packages/Uintah/StandAlone/tools/compare_mms
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 42 (100.0%) | 686 (100.0%) | 16.3 |
| harman | 18 (42.9%) | 665 (96.9%) | 36.9 |
| dav | 14 (33.3%) | 16 (2.3%) | 1.1 |
| jas | 10 (23.8%) | 5 (0.7%) | 0.5 |
M configure.ac
M configure
M aclocal.m4
M configVars.mk.in
Clean up configure so that variables placed into configVars.mk only
specify the libraries for that variable (and not required libraries).
This helps clean up the configVars.mk file (makes it easier to see
specifically the libraries listed for a specific variable, and cleans
up the compile lines as libraries are not listed multiple times. This
was the way the system was supposed to be set up and how the comments
say it works, just not the way it was implemented (for some
variables).
With this change, there might be a few sub.mk files that need extra
make library variables listed in them so that all libraries can be
found to successfully link an executable.
M .../*/sub.mk
Now need to add $(THREAD_LIBRARY) to many sub.mk files. Also used
spacing/indention to make some files easier to read.
1 lines of code changed in 2 files:
Fixes to fixes for PGI compiler... to allow compilation at LLNL (Atlas/uP).
M StandAlone/regression/sub.mk
M Packages/Uintah/StandAlone/tools/compare_mms/sub.mk
M Packages/Uintah/StandAlone/tools/radiusMaker/sub.mk
M Packages/Uintah/testprograms/sub.mk
M Packages/Uintah/testprograms/PatchBVH/sub.mk
M Packages/Uintah/testprograms/TestFastMatrix/sub.mk
M Packages/Uintah/testprograms/BNRRegridder/sub.mk
M Packages/Uintah/testprograms/IteratorTest/sub.mk
Need to link Lapack too (when Blas is used).
M Packages/Uintah/Core/Grid/Variables/ugc_templates.cc
- The "using namespace Uintah" wasn't enough for the xlC (AIX
compiler)... Had to use "Uintah::" explicitly.
- Indent. Organize #includes.
M Packages/Uintah/Core/Grid/Variables/GridVariableBase.h
- Declare the parent classes allocate function. (Might not be
completely necessary, but before it was only declared in the parent
and in the subclass which made it kinda hard to figure out where
it was coming from.)
M Packages/Uintah/Core/Grid/Variables/GridVariableBase.cc
- More indention.
M Packages/Uintah/Core/Grid/Variables/GridVariable.h
- AIX (xlC) compiler doesn't like the "using" statement... complains
that it can't figure out which function is the right one.
- Indent. Untabify.
1 lines of code changed in 1 file:
Fixes to allow Uintah to build using the PGI compiler:
M configure
M configure.ac
- Figure out size of 'long long' so that Endian.cc swapbytes() can be
set correctly... perhaps a bit of overkill, but...
- PGI compilers don't support -Wall, so don't use it.
- Better messages when determining dependency generation flag. Fix
grep for ":" as it sometimes is " :". See below (configVars.mk.in).
- pgf77 needs -lrt to link.
M configVars.mk.in
- ECHO should not be "echo -n" (no newline)... so named it more appropriately.
- Many compilers don't create dependency files (.d) with exactly "name.o : name.cc".
Then may use "name.o:name.cc". So don't use the ":" in the sed. This should
never cause a problem because of the "^".
- Added the dependency mode of: 'modify_and_move'. PGI compiler creates an invalid
.d file in the wrong place, so we have to fix it and move it.
- NOTE: the F77 dependency flag is currently (historically) just a copy of the CXX
flag... this has worked in the past and still works for everything but pgf77.
Soon (but not in this update) I will fix configure to do this correctly.
M StandAlone/regression/sub.mk
M Packages/Uintah/StandAlone/tools/compare_mms/sub.mk
M Packages/Uintah/StandAlone/tools/radiusMaker/sub.mk
- Need BLAS_LIBRARY to link... at least on Ranger using PGI.
- Please indent... it really does make it easier to read.
M Core/Malloc/Allocator.cc
Moved variable into the #if section that it is used in. Avoids compiler warning.
M Core/Util/Endian.cc
A Core/Util/testEndian.h.in
D Core/Util/Endian.h
- pgcc is requiring the swapbytes() for 'long long'... So add it
in. Since 'long long' size can be different on different machines,
use overkill method with configure figuring out size and setting it
for us.
- Moved Endian.h to testEndian.h.in to allow configure to modify it.
- Indented.
M Core/Util/sub.mk
M Packages/Uintah/Core/Grid/Variables/sub.mk
Untabified.
M Core/Util/Socket.cc
Fix compiler warning and possible 'random' error.
M Core/Math/MiscMath.cc
Fix PGI compiler issue.
M Packages/Uintah/CCA/Components/DataArchiver/DataArchiver.cc
M Packages/Uintah/CCA/Components/Schedulers/SchedulerCommon.cc
#include <time.h> is required for time functions.
M Packages/Uintah/CCA/Components/ICE/EOS/IdealGas.cc
M Packages/Uintah/CCA/Components/ICE/CustomBCs/sine.h
M Packages/Uintah/CCA/Components/ICE/CustomBCs/MMS_BCs.cc
M Packages/Uintah/CCA/Components/ICE/CustomBCs/microSlipBCs.cc
M Packages/Uintah/CCA/Components/ICE/BoundaryCond.cc
- Removed a bunch of definitions of "iter". (vector<IntVector>::const_iterator)...
probably a leftover from the iterator update a while back. In some cases,
renamed an interior (for loop) iterator from "iter" to "cIter" so that the
code would be a little more clear as to which iterator was being used
inside the inner for loop. Also, define some iterators in the for loop,
instead of above the loop. (for( vector::iterator iter...))
M Packages/Uintah/CCA/Components/ICE/AMRICE.h
M Packages/Uintah/Core/Grid/Variables/GridVariable.h
M Packages/Uintah/Core/Grid/Variables/GridVariableBase.h
Fix compiler warning about hidden parent class function.
M Packages/Uintah/CCA/Components/Arches/ExtraScalarSolver.h
Fix compiler warning about ineffectual use of a const return type. Eg:
const int doSomething() { return 1; }
doesn't mean anything... it doesn't make sense for the returned int to
be const. Should just be:
int doSomething() { return 1; }
M Packages/Uintah/CCA/Ports/SFC.h
Fix problem with nested comments. Don't use /* ... */ over many lines. Use #if 0.
M Packages/Uintah/StandAlone/tools/uda2nrrd/particles.cc
Comment about invalid code.
M Packages/Uintah/StandAlone/tools/puda/varsummary.cc
PGI compiler needs Min/Max defined.
M Packages/Uintah/StandAlone/tools/extractors/partextract.cc
#include <stdlib.h> for strtoll... Add hack to force (older (verion
7.1-2)) pgCC to allow strtoll.
M Packages/Uintah/Core/Grid/Patch.h
M Packages/Uintah/Core/Grid/AMR.h
Hack to remove PGI compiler warnings about unreachable code.
M Packages/Uintah/Core/Grid/Grid.h
Use white space... it is also your friend. Seriously (on a related
note ;) can someone tell me why they think "x=3;" is better than "x = 3;"?
M Packages/Uintah/Core/Grid/Variables/ReductionVariable_special.cc
Wow, this is an ugly file... Had to add some (templated) functions
that the PGI compiler was requiring.
M Packages/Uintah/Core/Grid/Variables/ComputeSet.h
Don't seem to need to #include the .cc file (for the templates) with
PGI anymore... at least not on Ranger using pgCC version 7.1-2.
M Packages/Uintah/Core/Grid/Variables/VarTypes.h
Needs the 'long long' var type.
M Packages/Uintah/Core/Grid/Variables/ComputeSet_special.cc
More use of white space, indentation, etc.
M Packages/Uintah/Core/DataArchive/DataArchive.cc
Added {} around what looks like a necessary block of code... strange
that this didn't cause hangs, etc in the code. Perhaps this section
of code isn't used that often? Hope the RT doesn't gripe
tomorrow... it's not my fault!
M Packages/Uintah/Core/Disclosure/TypeUtils.h
M Packages/Uintah/Core/Disclosure/TypeUtils.cc
Added 'long long' function. Organized the code a tad bit to make it
easier to see which functions (for which types) are defined.
M Packages/Uintah/testprograms/sub.mk
M Packages/Uintah/testprograms/PatchBVH/sub.mk
M Packages/Uintah/testprograms/TestFastMatrix/sub.mk
M Packages/Uintah/testprograms/BNRRegridder/sub.mk
M Packages/Uintah/testprograms/IteratorTest/sub.mk
Untabify. Clean up. Removed double definition of LIBS. Requires
BLAS_LIBRARY to link.
M Packages/Uintah/tools/BlasLapackTests/test_blas.c
Ranger's version of testcase... not sure I should have checked it
in... Probably need to have both with the #if separating them.
M Packages/Uintah/Dataflow/Modules/Selectors/ParticleFieldExtractor.h
Fix compiler warning about hidden function (update_progress).
M Packages/Uintah/Dataflow/Modules/Selectors/ParticleFieldExtractor.cc
Fix includes (better ordering). Fix (hack) PGI problem with finding atoll.
M Packages/Uintah/Dataflow/Modules/Selectors/FieldExtractor.h
More white space. Remove unused var. Move common code to above 'if'.
1 lines of code changed in 1 file:
Use the proper c++ standard for include files for the C inlude files, i.e.
<stdio.h> --> <cstdio>
<math.h> --> <cmath>
Tested on g++ 4.2 and 4.3 compilers.
5 lines of code changed in 10 files:
M CCA/Ports/ProblemSpecInterface.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.cc
* Only validate when told too.. currently only sus.cc tells the reader
to validate.
* Default dbg spew to off.
M CCA/Components/Schedulers/SchedulerCommon.cc
Turn off memory use dbg spew.
M StandAlone/sus.cc
Turn on reader validation.
M StandAlone/compare_uda.cc
Purely cosmetic update. Removed tabs, and indented.
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M StandAlone/tools/compare_mms/ExpMMS.h
M StandAlone/tools/compare_mms/SineMMS.h
M StandAlone/tools/compare_mms/MMS.h
M StandAlone/tools/compare_mms/compare_mms.cc
M StandAlone/tools/compare_mms/LinearMMS.h
Fixed compiler warnings.
6 lines of code changed in 9 files:
added press_equil_CC to the variable list
4 lines of code changed in 1 file:
More thrashing:
- ExpMMS.cc ( this was a copy paste of SineMMS.cc) All functions are now
returning -99999
-SineMMS.cc
wvelocity is not defined. Now returning -99999
compare_mms.cc
All over the place. Treat the velocity as a vector, not separate doubles.
added -verbose option
83 lines of code changed in 3 files:
overhaul:
- removed matl loop. The user can now specify it, default value is 0
- removed variable loop. The user already specifies the variable to interogate
why do we need a loop?
- removed try block
- formatting
289 lines of code changed in 1 file:
Removed MMS1.(cc/h) Doesn't appear to be used.
variable name change
A_ -> d_A
viscosity_ -> d_viscosity
p_ref_ -> d_p_ref
Now passing in A, viscosity and p_ref into ExpMMS()
26 lines of code changed in 7 files:
-bumped up the tolerance
-If the user specifies -v it also dumps out the difference to a file
named compScalar.dat
more diagnostic output
22 lines of code changed in 1 file:
added conditional to prevent indexing a variable off the patch
7 lines of code changed in 1 file:
cranked up the isequal tolerance to 100 * DBL_EPSILON
5 lines of code changed in 1 file:
overhauled
removed extraneous loops and logic
160 lines of code changed in 1 file:
Fix OSX linking... compare_mss was a little hungrier than Todd thought so I increased the amount of food allowed by the diet. ;)
7 lines of code changed in 1 file:
cleaned out PSELIBS section
4 lines of code changed in 1 file:
tabs
formatting
more descriptive exception
65 lines of code changed in 1 file: