Lines of Code
[root]/CCA/Components/Arches/ChemMix
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 57 (100.0%) | 1177 (100.0%) | 20.6 |
| jthornoc | 34 (59.6%) | 591 (50.2%) | 17.3 |
| jas | 12 (21.1%) | 269 (22.9%) | 22.4 |
| awabboud | 2 (3.5%) | 212 (18.0%) | 106.0 |
| u0407585 | 2 (3.5%) | 93 (7.9%) | 46.5 |
| dav | 3 (5.3%) | 10 (0.8%) | 3.3 |
| harman | 2 (3.5%) | 2 (0.2%) | 1.0 |
| derekhar | 2 (3.5%) | 0 (0.0%) | 0.0 |
- Cleanups from Vulcan@LLNL. Mostly cosmetic, though a few real fixes
found while porting to BGQ machine.
- Replaced proc0thread0cerr with proc0cerr as proc0cerr is (now
specifically) defined to only print out from thread 0 of process 0.
M CCA/Components/SimulationController/AMRSimulationController.cc
- Cosmetic
- Alphabetize the #includes for better readability and to remove duplicates.
- Put the #ifdef USE_GPERFTOOLS around entire block, instead of having
it multiple times and leaving dead if statements around it.
M CCA/Components/SimulationController/SimulationController.cc
- Cosmetic: Fix indentation (use diff -b to better see differences.)
M CCA/Components/DataArchiver/DataArchiver.cc
- Added the ability to specify checkpoint time via hours (in addition to seconds).
- Cleaned up the code to make it more readable for parsing this
information from input file - ie, use variable names that correspond
to the data they hold.
- Commented out a few lines of code that didn't do anything.
- Indented for readability, lined up some variable assignments.
M CCA/Components/Arches/CompDynamicProcedure.cc
- Alphabetize the #includes for better readability and to remove duplicates.
- Replaced proc0thread0cerr with proc0cerr.
M CCA/Components/Arches/DQMOM.cc
M CCA/Components/Arches/PropertyModels/PropertyModelBase.h
M CCA/Components/Arches/IncDynamicProcedure.cc
M CCA/Components/Arches/Arches.cc
- Replaced proc0thread0cerr with proc0cerr.
M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
- Throw a ProblemSetupException as that is what the error is.
M Core/Exceptions/InvalidState.cc
- Propagate (user supplied) error message.
M Core/Grid/Patch.cc
- Whitespace cleanup for readability.
M Core/Grid/Grid.h
- Whitespace cleanup for readability.
- Parameter to setExtraCells() is now (explicitly) const.
M Core/Grid/Level.cc
M Core/Grid/Grid.cc
- Coding standard and whitespace cleanup.
M Core/Parallel/Parallel.h
- Updated proc0cout to handle threaded versions of Uintah. If in MPI
only mode, then only prints for proc 0. If in threaded mode, only
prints for proc 0 thread 0.
- Removed proc0thread0cout as now only proc0cout is needed.
M Core/Thread/ThreadPool.h
- Remove tabs, line up code.
M Core/Thread/Thread.h
M Core/Thread/Parallel.h
M testprograms/Thread/parallel.cc
- Added the ThreadNS namespace because there are two classes named
'Parallel' in Uintah, and the one in the new ThreadNS is only used
in a few locations and thus is easier to move into its own NS.
M StandAlone/inputs/UPS_SPEC/ups_spec.xml
- Added 'walltimeStartHours' and 'walltimeIntervalHours' (to augment the
version that uses just seconds).
- Lined up for better readability.
M tools/StackTrace/StackTrace.cc
- Fixes for the stack trace tool for machines that only provide symbol
numbers in their stack traces. However, unfortunately, this still
doesn't seem to provide a valid stack trace on Vulcan.
1 lines of code changed in 2 files:
Fixed bug for the 2-D table coal interface. This correctly sets the Heat loss bounds for a 2-D table.
0 lines of code changed in 2 files:
Add a transform function for f and HL.
109 lines of code changed in 3 files:
**Warning: Answer will change **
Derek and Jeremy making this commit:
Added bulletproofing for boundary temperatures in arches.
Radiation models including Discrete-Ordinates (DO) and Reverse-Monte-Carlo-Ray-Tracing (RMCRT) now are passed a new temperature variable called "radiation_temperature".
This new variable is a copy of temperature with modified boundary conditions, consistent with DO and RMCRT radiation models.
This is fixing a known bug where the temperature in the boundary conditions for inlets and outlets was incorrect for radiation.
The cell-centered variable "radiation_temperature" can be set in input files using Dirichlet, Neumann, and Tabulated boundary conditions.
ForcedDirichlet is applied for in place of Dirichlet for variable "radiation_temperature". This commit is expected to break all radiation RTests.
0 lines of code changed in 1 file:
Pushing in Arches Task interface updates.
0 lines of code changed in 2 files:
Chaneg the classic table lookup to perform the search only once per tabulated value, and return a double vector of all dependent variables when getState is called to improve the speed
212 lines of code changed in 2 files:
Reversing the previous delete. This was causing segfaults in other
tests. However, valgrind is reporting it still as a "leak". I believe
the RT will as well.
Cleaning up some memory issues in other parts of Arches.
6 lines of code changed in 1 file:
Fixing a bug in the 3-d table lookup within Arches, that was making several restart files crash.
11 lines of code changed in 1 file:
Updating the 3-d table lookup within Arches. This removes a previous assumption used in the table look-ups with varying spacing in the first independent variable. THIS WILL CHANGE THE ANSWERS TO THE REGRESSION TESTS FOR ALL CASES USING 3D TABLE LOOKUPpwdpwdpwdpwdpwdpwd
82 lines of code changed in 1 file:
The following commits are mostly cosmetic in nature and should not
change any answers.
Lots of white space and indentation fixes. It is so much easier to
read code when variables are lined up, and values assigned to them
are also lined up.
M CCA/Components/Parent/Switcher.cc
- Variable "no_solver_specified" was misleading. It meant "no command
line solver specified". However, this is the default case and thus
this variable is not needed.
M CCA/Components/Wasatch/Expressions/EmbeddedGeometry/EmbeddedGeometryHelper.h
- InvalidState exception moved to Uintah namespace.
M CCA/Components/Solvers/AMR/AMRSolver.h
- Parent scheduleInitialize() is purely virtual so must be implemented
in each solver. This allows the user to more easily see whether the
scheduleInitialize() step actually does anything or not.
M CCA/Components/Solvers/HypreSolver.cc
- 'firstPassThrough_' is a class variable so needs the '_' suffix to
meet coding standard.
M CCA/Components/Solvers/SolverFactory.cc
M CCA/Components/Solvers/DirectSolve.cc
M CCA/Components/Solvers/HypreSolver.h
M CCA/Components/Solvers/SolverFactory.h
M CCA/Components/Solvers/DirectSolve.h
M CCA/Components/Solvers/CGSolver.h
- Indentation.
- Added (empty) scheduleInitialize() to Solvers that
require it to be implemented but do not actually use it.
M CCA/Ports/SolverInterface.h
- Moved destructor/constructor empty implementations into .h file for
easier viewing.
- Indentation / white space.
M CCA/Ports/SolverInterface.cc
- This file is empty now so should most likely be removed soon.
M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
- Throw exception if gzipInflate fails (previously it tried to just
kept going and the error was thus hard to find).
M CCA/Ports/sub.mk
- Don't need to compile empty file SolverInterface.cc now.
M Core/Exceptions/ErrnoException.h
M Core/Exceptions/ErrnoException.cc
- Change var name from errno_ to err_ as it might be easy to confuse "errno_" with "errno".
M Core/Exceptions/sub.mk
- Alphabetize list of libraries.
M Core/Exceptions/InvalidValue.cc
- Don't need superfluous "using std::cout".
M Core/Exceptions/InvalidState.cc
M Core/Exceptions/InvalidState.h
- Moved from SCIRun namespace to Uintah for two reasons:
1) SCIRun namespace will eventually go away.
2) InvalidState exception is already in Uintah namespace and these should be consistent.
M Core/IO/sub.mk
- IO now relies on Exception as the UintahZlibUtil now throws an exception if an error occurs.
M Core/IO/UintahZlibUtil.h
- White space / indentation.
- Add comment about what gzipInflate returns.
M Core/IO/UintahZlibUtil.cc
- Throw an exception when an error occurs instead of just return 0, as
the 0 is never checked and causes debugging to be more difficult.
M StandAlone/sus.cc
- Indent / white space.
- Print out which solver is being used.
9 lines of code changed in 1 file:
Missed a function re-def.
0 lines of code changed in 2 files:
Getting rid of the density reference reduction variable in favor of the
density reference array. Since the reference density is being computed
once at startup, there was no need to carry around the extra label
anymore.
153 lines of code changed in 13 files:
Version 0.1 of the Arches Task Interface. Will require boost so not
compiling for now.
0 lines of code changed in 1 file:
cleaned up compiler warnings.
2 lines of code changed in 2 files:
- Computing reference density once rather than every time step to avoid a reduction operation
- Reference density is now specified as a user input using the appropriate option given the property calculation.
- Added a single IV transform function for the classic-table interface.
- Don’t use cellInfo for pressure coefficient calculations.
- Fix a typo in the logic comparison for the advanced clipping.
- Updating a slew of input files to meet spec.
281 lines of code changed in 3 files:
Specifying the reference density uniformly across property calculations.
**This now requires that the reference density either be in a flow cell
or explicitly set from the input file.
34 lines of code changed in 5 files:
1) Remove some unused WARCHES code.
2) Rename the setVel function.
3) Set correct volume fraction in extra-cells and update code accordingly to account for the zero volume fraction in walls.
4) Require that the reference density is computed in a “real” flow cell
5) Add some new channel flow input files.
2 lines of code changed in 2 files:
Various modification to accomodate some optimizations in the fortran and
c++ functions for the momentum RHS construction.
6 lines of code changed in 1 file:
Updated copyright information.
10 lines of code changed in 10 files:
Conflicts:
src/CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
src/CCA/Components/Arches/ChemMix/ClassicTableInterface.h
259 lines of code changed in 2 files: