Directory CCA/Components/Models/Radiation/RMCRT/

Lines of Code

Developers

Most Recent Commits

harman 2014-12-29 10:32 Rev.: 52902

RMCRT_Test.cc
- The user can specify RMCRT:float or RMCRT:double.
problemSetup()
- added BC_bulletproofing
- added bulletproofing to catch if the the user is trying to save abskg but
it doesn't exist. The component hands RMCRT abskg but internally RMCRT:float
uses abskgRMCRT.

Ray.cc & RMCRTCommon.cc
Global:
setBC()
Added an additional template parameter. This parameter is used to fake out
the BC infrastructure when CCVariable<float> are being passed in. The infrastructure
doesn't handle floats. Thanks James.

0 lines of code changed in 8 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (new), RMCRTCommon.h (new), Ray.cc (new), Ray.h (new)

harman 2014-12-19 14:26 Rev.: 52832

Global d_sigmaT4_label -> d_sigmaT4Label (consistency with the rest of the global labels)


RMCRT_test.cc/.h
- component defines either float or dbl RMCRT
- d_abskgLabel -> d_comp(onent)AbskgLabel
- No longer recomputing the abskg, temperature and cellType every timestep. Compute once in initialize()
and carryForward every timestep.
- Added DoublToFloat() task to scheduleTimeAdvance()

Arches/RMCRT.cc
- cleaned out DQMONEqnFac .h files
- component defines either float or dbl RMCRT
- scheduleTimeAdvance()
added calls to DoubleToFloat() task
- computeSource()
removed cellType carryForward. That's handled by RMCRT

Wasatch/RadiationSource
- component defines either float or dbl RMCRT
- Added DoublToFloat() task to scheduleTimeAdvance() to schedule_ray_tracing


RMCRTCommon.cc
- now using d_comp(onent)AbskgLabel and d_comp(onent)TempLabel
- Component now decides if communicated variables are doubles or floats
Added logic where appropriate.
More templates
- Added DoubleToFloat() task. This simply casts the CCVariable< double> -> CCVariable<float>


Radiometer
- Component now decides if communicated variables are doubles or floats
Added logic where appropriate.
More templates

Ray
- now using d_comp(onent)AbskgLabel and d_comp(onent)TempLabel
- Component now decides if communicated variables are doubles or floats
Added logic where appropriate.
More templates
- coarsen_Q(): This task carries forward coarse level variables on non-radCalc timesteps
- Added coarsen_cellType()task: This task computes cellType on the coarse levels, needs additional logic.


RayGPU.cc
d_sigmaT4_label -> d_sigmaT4Label (consistency with the rest of the labels)


OnTheFlyAnalysis/radiometer
- Component now decides if communicated variables are doubles or floats


______________________________________________________________________
S U M M A R Y
Failed: ARCHES-opt tests <<<< These tests fail due to an new material set for abskg. The answers are the same >>>

:rmcrt_bm1_ML: test failed comparison tests
:rmcrt_bm1_ML: (restart) test failed comparison tests
:rmcrt_bm1_DO: test failed comparison tests
:rmcrt_bm1_DO: (restart) test failed comparison tests
:rmcrt_bm1_ML_thread: test failed comparison tests
:rmcrt_bm1_DO_thread: test failed comparison tests

Failed: Examples-opt tests <<<< This commit drastically improves the answers >>>
:RMCRT_bm1_DO: test failed comparison tests
:RMCRT_bm1_DO: (restart) test failed comparison tests
:RMCRT_ML: test failed comparison tests
:RMCRT_ML: (restart) test failed comparison tests
Passed: Wasatch-opt tests!

325 lines of code changed in 10 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+106 -34), RMCRTCommon.h (+25 -7), Radiometer.cc (new), Radiometer.h (new), Ray.cc (+148 -81), Ray.h (+14 -4), RayGPU.cc (new)

harman 2014-12-15 13:57 Rev.: 52816

removed floatRMCRT/

There's a few missing pieces before the component is able to choose between float/double
RMCRT.

99 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+99 -95)

harman 2014-12-15 12:38 Rev.: 52812

Templated more tasks/methods/variables on the type double/float.

153 lines of code changed in 8 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+1), Ray.cc (+48 -15), Ray.h (+2), RayGPU.cc (+48 -13), RayGPU.cuh (new), RayGPUKernel.cu (+38 -6)

harman 2014-12-10 13:37 Rev.: 52799

Added a temporary method for scheduling the radiometer task. This version is not using
spatially scheduling.

Increased the number of processes used in a nightly RT test.

87 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+85 -11), Radiometer.h (+2 -1)

harman 2014-11-29 14:20 Rev.: 52766

Templated the DataOnion/AdaptiveMesh task and updateSum()

64 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+61 -6), Ray.h (+3 -1)

harman 2014-11-24 17:41 Rev.: 52757

Started templating tasks/functions. This will allow for either double or float RMCRT
when complete. Hardwired for double.

* this won't change the answers.

90 lines of code changed in 6 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+36 -5), RMCRTCommon.h (+11 -4), Radiometer.cc (+26 -7), Radiometer.h (+3 -1), Ray.cc (+13 -6), Ray.h (+1 -1)

tsaad 2014-11-24 12:49 Rev.: 52753

fix some namespace issues int Ray et al that were causing build failures on mac dbg builds

3 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+3 -4)

harman 2014-11-20 15:40 Rev.: 52743

RMCRT_Test: scheduleTimeAdvance()
- For 2 level approach changed looping limits for sched_Refine_Q()

Ray.cc: sched_Refine_Q()
- Now using ghosts:AroundCells 1 for requires of divQ from the coarse level. *** Key

Converted input file into a multipatch 2L problem with Refinement ratio = 4

Now using 8 cores for nightly RT tests.

1 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+1 -1)

harman 2014-10-20 12:46 Rev.: 52594

Update the example component for the new radiometer. This does not include spatial scheduling of
the radiometer.

16 lines of code changed in 3 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+2 -2), Ray.cc (+10 -33), Ray.h (+4 -1)

jsutherland 2014-09-25 08:57 Rev.: 52496

Get RMCRT compiling on GPU again.

1 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RayGPU.cc (+1 -3)

harman 2014-09-23 16:11 Rev.: 52493

When deleting radiometerPatchSet use removeReference()

9 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+5 -1), Ray.cc (+4)

harman 2014-09-22 09:19 Rev.: 52478

Moved the creation of radiometerPatchSet outside of getPatches(). This will fix a memory leak.

24 lines of code changed in 3 files:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+10 -9), Radiometer.h (+2 -2), Ray.cc (+12 -4)

ahumphrey 2014-09-19 15:21 Rev.: 52474

* Add support for handling "Spatially scheduled" tasks in the taskgraph checksum ( MPIScheduler::verifyChecksum() ).
An example would be the radiometer task, which is not scheduled on all patches (only a smalll subset).
* This commit begins to address making this checksum more sophisticated.

1 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+1)

harman 2014-09-18 12:18 Rev.: 52458

Added spatial scheduling machinery. It works with the OnTheFlyAnalysis:radiometer()
and needs to be incorporated into the RMCRT::RayTrace() task. It doesnt't work
with dbg builds due to an issue with schedule:verifyChecksum().

166 lines of code changed in 4 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+3 -1), Radiometer.cc (+134 -27), Radiometer.h (+20 -6), Ray.cc (+9 -1)

harman 2014-09-15 12:33 Rev.: 52447

doRecompileTaskgraph()
- recompile TG after a rad calc timestep to turn off all-to-all communication.

6 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+6 -1)

harman 2014-09-13 12:25 Rev.: 52434

Added comments about expense of scheduling all-to-all variables

added
doRecompileTaskgraph() : can trigger a taskgraph recompile

Radiometer;
- added a conditional around the requires for the all-to-all variables.

The radiometer and ray tracing tasks should only require all-to-all variables on
calculation timesteps

66 lines of code changed in 4 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+20), RMCRTCommon.h (+18 -15), Radiometer.cc (+18 -5), Ray.cc (+10 -4)

harman 2014-09-11 16:34 Rev.: 52423

Only schedule the "requires" for the super expensive
- abskg,
- sigmaT4
- cellType
variables on calculation timesteps. Carry forward timesteps ignore them.
The driving component must have needsRecompile() implemented with appropriate logic. This is
a 80% solution to the problem.


RMCRT_Test:
- added needsRecompile() which calls doCarryForward().
- formatting
doCarryForward()
- no longer passing in timestep

Ray.cc
sched_rayTrace()
- added logic around the requires.
doCarryForward()
- no longer passing in timestep

Radiometer.cc/ RMCRTCommon
doCarryForward()
- no longer passing in timestep

This shouldn't change the answers.

22 lines of code changed in 4 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+3 -4), RMCRTCommon.h (+1 -2), Radiometer.cc (+1 -2), Ray.cc (+17 -14)

harman 2014-09-09 09:14 Rev.: 52405

problemSetup()
- added bulletproofing. Prevent the user from specifying a variable that
will be ignored. This falls outside the UPS spec. checking.

14 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+14 -3)

harman 2014-09-08 10:01 Rev.: 52400

Added bulletproofing to user inputs. The starting and ending points must differ by at least one cell.

10 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+10 -2)

harman 2014-09-05 13:26 Rev.: 52389

Now passing the grid into the problemSetup() tasks.

Added bulletproofing to VRLocationsMin/Max. They can't lie outside the
computational domain.

34 lines of code changed in 4 files:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+30 -3), Radiometer.h (+1), Ray.cc (+2 -1), Ray.h (+1)

harman 2014-08-15 13:35 Rev.: 52309

Removed a label that is no longer part of the ray trace kernel.

0 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RayGPUKernel.cu (-4)

harman 2014-08-15 10:17 Rev.: 52307

added printTask() to radiometer

5 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+5)

harman 2014-08-07 12:21 Rev.: 52280

Moved BC bulletproofing code from problemSetup to new function.
The component can elect to not call this.

The flag d_onOff_setBC can now be set by the component and no longer a input file option.
For single level RMCRT problems the component should set all BCs and you want to set this
to be false, for multi-level you *may* want it be true.


Arches:RMCRT.cc
- added single level rmcrt algorithm to sched_computeSource()

Updated ups spec

37 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+17 -3), Ray.h (+20 -9)

derekhar 2014-08-05 09:21 Rev.: 52274

Fixes bug for non-cubic cells. This recommits the change in commit #52211, and extends it to the float version of RMCRT.

3 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+3 -3)

derekhar 2014-08-04 19:22 Rev.: 52272

A reversion to version 52201 for RMCRT files Ray.cc and floatRMCRT/Ray.cc.

33 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+33 -33)

derekhar 2014-08-04 12:01 Rev.: 52265

Fixed bug, causing DO-RMCRT regression test to fail. The bug was caused by an incorrect sequence of code in the updatesumI function.

18 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+18 -22)

derekhar 2014-07-30 13:32 Rev.: 52212

Fixed a data-onion RMCRT bug. The rare-case bug occurred when RMCRT went down a level, while hitting a wall, with reflections turned on.

43 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+43 -39)

derekhar 2014-07-30 11:52 Rev.: 52211

Fixed bug in RMCRT. The bug caused RMCRT to incorrectly compute the ray-path-length which is used to calculate the boundary fluxes for non-cubic cells.

3 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: Ray.cc (+3 -3)

harman 2014-07-30 09:47 Rev.: 52210

Create and destroy d_matlSet once.

2 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+2 -3)

jas 2014-07-29 09:51 Rev.: 52207

Fix memory leak.

10 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+10 -6)

ahumphrey 2014-07-25 14:04 Rev.: 52202

Allow underlying, raw Task to know it's deviceID when GPU-enabled. This commit is on behalf of Abhishek Bagusetty with modifications by Alan Humphrey.

2 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: Ray.h (+1), RayGPU.cc (+1)

harman 2014-07-21 10:03 Rev.: 52185

Destructor
Added conditional so d_matlSet is only deleted once.

5 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+5 -3)

harman 2014-07-20 10:21 Rev.: 52182

Remove the d_matlSet reference *before* you delete it.

RMCRT_test_1L and Arches:methane_rmcrt.ups are valgrind clean.

3 lines of code changed in 1 file:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+3 -1)

harman 2014-07-17 10:30 Rev.: 52173

Only RMCRTCommon{} should delete d_matlSet.

1 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+1 -1), Ray.cc (-4)

harman 2014-07-15 13:54 Rev.: 52159

Applied the final polish to the radiometer refactor.

RMCRTCommon
- made common variables static

Radiometer
problemSetup() Added conditional statement around
variables that must be read when using OnTheFly. These
variables are duplicates of the what RMCRT uses.

This commit will fix the restart bug in RMCRT_VR.ups file

35 lines of code changed in 5 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+7 -1), RMCRTCommon.h (+6 -8), Radiometer.cc (+18 -15), Radiometer.h (+2 -1), Ray.cc (+2 -1)

harman 2014-07-11 17:28 Rev.: 52148

Now using static variables for

d_matl
d_matlSet
d_sigmaT4_label;
d_abskgLabel;
d_temperatureLabel;
d_cellTypeLabel;
d_divQLabel;

This class is instantiated more than once but only want to initialize these variables once.

Thanks Dav for all your help!!

28 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: RMCRTCommon.cc (+17 -5), RMCRTCommon.h (+11 -9)

harman 2014-07-11 09:54 Rev.: 52142

removed unused radiometer variables.

2 lines of code changed in 3 files:

• CCA/Components/Models/Radiation/RMCRT: RayGPU.cc (+1 -3), RayGPU.cuh (-2), RayGPUKernel.cu (+1 -2)

harman 2014-07-10 15:53 Rev.: 52135

More radiometer refactoring.
- removed radiometer methods and variables from ray.cc & ray.h
- Allow the radiometerFluxLabel to be modified.

The user interface has redundant entries and will be cleaned up shortly.

* The number of checkpoint variables will decrease by 1 causing the RT tests to fail*

414 lines of code changed in 4 files:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+52 -45), Radiometer.h (+21 -17), Ray.cc (+285 -424), Ray.h (+56 -81)

harman 2014-07-10 13:21 Rev.: 52127

Further encapsulation of the radiometer code. Moved the core computations
to a function which will eventually be called by RMCRT

81 lines of code changed in 2 files:

• CCA/Components/Models/Radiation/RMCRT: Radiometer.cc (+66 -56), Radiometer.h (+15 -5)

(24 more)