Lines of Code
[root]/CCA/Components/Schedulers
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 269 (100.0%) | 7474 (100.0%) | 27.7 |
| ahumphrey | 99 (36.8%) | 4043 (54.1%) | 40.8 |
| dav | 59 (21.9%) | 1485 (19.9%) | 25.1 |
| tsaad | 11 (4.1%) | 678 (9.1%) | 61.6 |
| harman | 9 (3.3%) | 658 (8.8%) | 73.1 |
| qymeng | 25 (9.3%) | 557 (7.5%) | 22.2 |
| jas | 61 (22.7%) | 47 (0.6%) | 0.7 |
| jholmen | 5 (1.9%) | 6 (0.1%) | 1.2 |
Reverting code to r52880 before my memory use fix commit. While most tests passed, the ones using AMR and the dynamic load balancer were not passing and the weeds are too deep within them to quickly figure out what is causing the problems. Next week I will attempt to figure out what is going on with them. My guess is that it will take quite a bit of effort to understand the inner workings of the dynamic loadbalancer in order to get everything to work, so it may be quite a while before this fix may go in.
579 lines of code changed in 16 files:
Finishing cleaning up the memory reduction commit... Main fix
was to add "delete d_archive" back to SimulationController.cc.
M CCA/Components/SimulationController/SimulationController.cc
- Add back in "delete d_archive"... This still needs to be investigated.
M CCA/Components/LoadBalancers/CostProfiler.cc
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
- Remove warning: numLevels is unsigned now.
- Cosmetics: coding standard, white space, {}s, etc
M Core/Grid/Patch.cc
M CCA/Components/Schedulers/DWDatabase.h
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Cosmetics: line up variables, untabify, coding standard, white space, {}s, etc
M CCA/Components/Schedulers/SchedulerCommon.cc
- Remove warning: numLevels is unsigned now.
173 lines of code changed in 4 files:
Two minor fixes to get Mac and GPU builds compiling after previous major commit.
M CCA/Components/Schedulers/DetailedTasks.cc
- Minor fix (variable name change) for GPU only code.
M Core/ProblemSpec/sub.mk
- Remove extra Core/Exceptions. Add needed Core/Math. (Found on Mac)
3 lines of code changed in 1 file:
This is the first commit (of what may be several over the next month or so) dealing with Uintah's excessive use
of memory with respect to its XML data structures (that are used for I/O) when running on thousands of patches.
This commit specificly addresses the excessive use of memory when restarting a simulation. Before this commit,
Uintah would read in a timestep.xml file (from the checkpoints/t00000/) directory and create an huge DOM
structure in memory. (On 8K patches on Vulcan (BGQ - LLNL) memory per process would increase by 100% (by
20 MB per process on the advect sample problem). On 30K patches, memory use of 200 MB or more has been observed.)
To solve this problem, instead of reading the XML into memory, we parse it on the fly and extract the data we need,
but do not save it. Note, there are two parts of the timestep.xml file that cause the memory issue: the 1000s of
<Grid> and <DataItem> tags. Small XML nodes are not a problem, and thus we still use them for some things (for
example, the component section read from the timestep.xml file. A full DOM of this node is created (during the
streaming read of the rest of the file) and this node is passed down to the component as before.
A number of changes in this commit are cosmetic, dealing with white space and coding standards, and were made
while I was digging through the code to understand where the memory issue was and how to fix it. To better
see real changes in the code, I highly suggest that you use a diff that ignores generic white space changes,
such as:
svn diff --diff-cmd diff --extensions -w <file_name>
Note,asIgetolderInolongercanreadtextlikethis,soIamaddingspacesintothecodetomakeit easier to see. :)
M CCA/Components/SimulationController/AMRSimulationController.cc
- Number of levels in a Grid (grid->numLevels()) cannot be negative and thus should be an unsigned int... it is now.
- Costmetic: English sentences start with capital letters and end with punctuation... yeah yeah I know.
M CCA/Components/SimulationController/SimulationController.cc
- queryGrid: pass through a pointer, don't create a new copy.
- Unsigned int for grid level number.
- Cosmetic white space/coding standards/English updates. Fixed some strange indentation. Untabify.
M CCA/Components/Parent/Switcher.cc
- Unsigned int for grid level number.
- Cosmetic: Swatted some evil endl's. :) (Why write 8 more characters of code, when 2 will do? And makes it easier to add to strings later...)
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.h
- Updates to consolidate code in load balancers... Still needs some direct attention as opposed to this
first pass while working on something else.
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h
- Add 'do-nothing' implementation of restartInitialize() to this class.
M CCA/Components/LoadBalancers/CostModelForecaster.cc
- Cosmetic: Untabbify, white space, {} around one line ifs, English.
M CCA/Components/LoadBalancers/DynamicLoadBalancer.h
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
- Moved restartInitialize() (and a number of supporting class d_ variables) into LoadBalancerCommon.
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English.
M CCA/Components/LoadBalancers/ProfileDriver.cc
M CCA/Components/LoadBalancers/CostModeler.h
- grid->numLevels() is now unsigned updates.
- Coding standard cleanups / English / white space.
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
- Make global DebugStream variables be less global (made static to file).
- Unsigned int for grid level number.
- Move restartInitialize() from DynamicLoadBalancer and ParticleLoadBalancer (code was exact duplicate in both files) here.
M CCA/Components/Solvers/AMR/AMRSolver.cc
- Cosmetic: White space, line up variables, English.
- Unsigned int for grid level number.
M CCA/Components/DataArchiver/DataArchiver.cc
M CCA/Components/DataArchiver/DataArchiver.h
- Comment added for where next XML memory fix should take place.
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
M CCA/Ports/ProblemSpecInterface.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.cc
- Created new version of readInputFile() which takes a list of patches that are specific to this processor. However,
I don't think anyone (me?) is using it yet, and I'm actually not convinced that it is the right function to fix
(see comments in code). I'm committing it just in case it turns out that we need it as we fix the rest of the
XML memory bloat issues. However, at that point if it turns out not to be useful, it should be removed.
M CCA/Components/Schedulers/TaskGraph.h
M CCA/Components/Schedulers/TaskGraph.cc
- Add some consistency to the member variable naming in this file. Half the variables use d_, and the other half
have a trailing _, and the third half ;) didn't do either one... sigh. Some examples.
lb -> d_lb
dts_ -> d_dts
- A few cosmetic fixes - variable line up, white space, etc.
- Removed var/matl from lb->getOldProcessorAssignment()... need to verify that this is correct... see above.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Removed unused parameters to lb->getOldProcessorAssignment(). However, the DynamicLoadBalancer still uses the
version with parameters (though it doesn't really need them either). It is unclear why getOldProcessorAssignment()
is not declared in LoadBalancerCommon common or several of the other Load Balancers, and also unclear which function
is actually being called. This is defined in the LoadBalancer.h in CCA/Ports/. This needs more investigation.
M CCA/Components/Schedulers/DetailedTasks.h
M CCA/Components/Schedulers/DetailedTasks.cc
- Almost all cosmetic, white space, untabbify, lining up vars, English, etc changes.
- Add trailing _ to numPendingInternalDependencies to denote member var.
M CCA/Components/Schedulers/MPIScheduler.cc
- Few cosmetic cleanups.
M CCA/Components/Schedulers/SchedulerCommon.cc
M StandAlone/tools/pfs/rawToUniqueGrains.cc
M StandAlone/tools/puda/PIC.cc
M StandAlone/tools/extractors/extractV.cc
M StandAlone/tools/extractors/extractF.cc
M StandAlone/tools/extractors/partextract.cc
M StandAlone/partvarRange.cc
M StandAlone/tools/puda/jim1.cc
M StandAlone/tools/puda/jim3.cc
M StandAlone/tools/puda/varsummary.cc
M StandAlone/tools/puda/puda.cc
M StandAlone/tools/puda/POL.cc
M StandAlone/slb.cc
- Cosmetic white space fixes.
- numLevels() casts to avoid warnings.
M CCA/Components/Arches/Radiation/RadHypreSolver.cc
- Few cosmetic changes.
M CCA/Components/Regridder/RegridderCommon.cc
M CCA/Components/Regridder/SingleLevelRegridder.cc
M CCA/Components/Regridder/TiledRegridder.cc
- Cosmetic white space fixes.
- numLevels() casts to avoid warnings.
M CCA/Ports/Output.h
- Use const vars when possible.
- White space, English.
M CCA/Ports/LoadBalancer.h
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
M Core/OS/Dir.h
M Core/OS/Dir.cc
M Core/OS/Dir_boost.cc
- Use 'const' when variables don't change.
- Cosmetic: line up variables, untabbify, white space, {} around one line ifs, English.
- Don't use "std::" in half the file and not in the other half.
M Core/Grid/Patch.h
M Core/Grid/Patch.cc
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English.
M Core/Grid/Grid.h
M Core/Grid/Grid.cc
- Added readLevelsFromFile(), parseLevelFromFile(), and parseGridFromFile() to parse XML without creating a full DOM.
This provides a 50% memory decrease (per process) on Vulcan (LLNL-BGQ) for 8K processors when restarting the
advect problem. At some point in the future it might be nice to replace my (brute force - straightfoward -
assumes that the input xml file is very well behaved) approach with the streaming reader functions from the
lib xml library. This is not done at this point as it is unclear how well that library will fit into our use
case, how much time it will take to convert to, and the fact that we want to get this pushed out to the users asap.
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English, coding standards.
- numLevels is now an unsigned int.
M Core/Grid/Task.cc
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
M Core/Grid/SimulationState.h
M Core/Grid/SimulationState.cc
- Cosmetic: Alphabetize/sort #includes.
M Core/Grid/Level.h
M Core/Grid/Level.cc
- Returned patch from addPatch() is not used anywhere so remove the return type.
- Cosmetic: line up variables, untabbify, white space, {} around one line ifs, English.
M Core/Geometry/Vector.h
M Core/Geometry/Vector.cc
- Added the fromString() function.
- Cosmetic: Alphabetize/sort #includes.
M Core/Geometry/IntVector.h
M Core/Geometry/IntVector.cc
- Added the fromString() function.
M Core/Containers/HashTable.h
- Moved the call to first() into the constructor... Not quite sure what the reason for this is,
but everywhere a HashTable is created, "first()" is immediately called, so it makes sense
to just do it in once place instead of having to do it each time it is used.
D Core/Containers/StringUtil.cc
D Core/Containers/StringUtil.h
A + Core/Util/StringUtil.h
A + Core/Util/StringUtil.cc
M Core/Grid/SimulationTime.cc
M Core/Tracker/TrackerServer.cc
M Core/Persistent/Pstreams.cc
M Core/Persistent/Persistent.cc
M Core/Util/FileUtils.cc
- Moved StringUtil.* to Core/Util/ to all its use in other locations (higher up the build tree).
M Core/Containers/sub.mk
- Untabbify.
M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc
- Rename variables so they are readable, eg: d_tsurl becomes d_ts_path_and_filename, d_tstimes becomes d_ts_times, etc.
- Change a few more functions to parse xml file data on the fly (instead of parsing DOMs), eg: queryEndiannessAndBits()
- Use NULL instead of 0.
- Pass strings as 'const &' instead of copying them every time.
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
M Core/ProblemSpec/ProblemSpec.h
M Core/ProblemSpec/ProblemSpec.cc
- Added constructor to take in a string buffer to create a new DOM from. (Use: stream parse an xml file and put the
needed pieces into a string, then turn only that information into a DOM.)
- Added routines to help in the stream parsing of an XML file: findBlock()
- checkForInputError() replaced.
- parseIntVector replaced with fromString() in respective files.
M Core/Util/DynamicLoader.cc
- Alphabetize #includes.
M Core/Util/sub.mk
- Alphabetize
A Core/Util/XMLUtils.h
A Core/Util/XMLUtils.cc
- Added new helper functions for parsing xml files on the fly.
M StandAlone/compare_uda.cc
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
- numLevels() is unsigned now.
- Bulletproofing - verify input args are actually directories.
M StandAlone/restart_merger.cc
- Minor cosmetic fixes.
M StandAlone/sus.cc
- Bulletproofing - catch case when user accidentally runs sus with a UDA and not a UPS.
453 lines of code changed in 7 files:
Updated list of scheduler related environmental flags
Added documentation to clarify Exectimes and execsummary output
6 lines of code changed in 5 files:
Add multi-threading to Unified subschedulers. This should fix the issues with failing ICE and UCF tests.
44 lines of code changed in 1 file:
Only do the work of the SingleProcessorScheduler (within Unified Scheduler) if not using MPI or GPU, and also not using multiple threads. Previously, the specified number of threads were created, but task graph was executed serially... without using the created threads for task execution.
3 lines of code changed in 1 file:
* In input files (<Scheduler> section), only accept Scheduler values that are in the UPS_Spec.
* Better error handling for 'command line/input file' scheduler parameters, specifically for the Unified Scheduler.
* Update environmentalFlags list
26 lines of code changed in 3 files:
Fix bug with initialization of per-level maxGhostCells and maxLevelOffset.
6 lines of code changed in 1 file:
Code cleanup before another search for the pack-buffer meory leak
267 lines of code changed in 5 files:
Reanimate per level suppport for maxGhostCells and maxLevelOffset. These are the horizontal and vertical ranges (respectively) considered by the loadbalancer when creating a neighborhood.
Also clean up some compiler warnings in Relocate.cc
50 lines of code changed in 6 files:
More sophisticated verifyChecksum() method for the Unified Scheduler. This will handle the presence of "spatial tasks", e.g. radiometer
20 lines of code changed in 1 file:
Differentiate timingsStats.{min,max,avg} files by MPI_Comm sizes. This way we can gather stats for multiple sized jobs run from the same directory.
8 lines of code changed in 1 file:
Add Mutex to Unified Scheduler for thread-safe MPI stats (e.g. wait times, etc).
Some misc. code cleanup.
23 lines of code changed in 3 files:
Add significant functionality to MPI stats.
Cleanup and formatting in Unified and MPI schedulers.
522 lines of code changed in 4 files:
formatting:
- added {}, method dividers and spacing to improve readability.
106 lines of code changed in 1 file:
* Cleanup CUDA stream creation flow (we should only need 1 stream per GPU task with aggregated H2D & D2H copies).
* Report more & better info for GPUStats DebugStream.
* Add temporary fix for Wasatch case where a field exists on the GPU, but requires a ghost update.
* This should allow James to put some more GPU regression testing in place.
* Some minor cleanup in a few spots
127 lines of code changed in 3 files:
Report more meaningful information via GPUStats DebugStream.
21 lines of code changed in 1 file:
Reverting accidental commit of this file.
0 lines of code changed in 1 file:
Updated configure to match configure.ac from previous commit.
29 lines of code changed in 1 file:
Quick refactor on previous Spatial task scheduling commit.
3 lines of code changed in 1 file:
* Add support for handling "Spatially scheduled" tasks in the taskgraph checksum ( MPIScheduler::verifyChecksum() ).
An example would be the radiometer task, which is not scheduled on all patches (only a smalll subset).
* This commit begins to address making this checksum more sophisticated.
27 lines of code changed in 1 file:
Remove errant call to unlock DataWarehouse level lock in clear(). This was benign but was confusing as it was never locked in the first place. Currently the level lock is not even being used.
2 lines of code changed in 1 file:
Remove unnecessary nested locks that were causing EDEADLK in transferFrom() for ParticleVariables. These write locks are not recursive. Everything transferFrom calls already has the appropriate read and write locks. NOTE: the removed comment was stale and inaccurate.
3 lines of code changed in 1 file:
Global:
formatting: added dividers between methods/functions
verifyChecksum()
- more descriptive error message
- add {}
111 lines of code changed in 2 files:
M CCA/Components/Schedulers/SchedulerFactory.cc
- Actually print out the full error this time. :)
M Core/Parallel/Parallel.h
M Core/Parallel/Parallel.cc
- Moved (to the .h file) and renamed a number of (static) varaibles
that should be class variables (and should not just be global
variables in the .cc file). I would have liked to do this to all of
them, but worldComm_ is of type MPI_Comm which is a fancy typedef,
and if I move it to the .h file, then I have to #include mpi.h
in that file, which makes a lot of files now dependent on mpi.h,
so I'd like to avoid that.
1 lines of code changed in 1 file:
A number of clean ups for Vulcan (LLNL - BGQ machine). Most
importantly, fixed memory usage reporting (see ProcessInfo.cc).
M CCA/Components/SimulationController/AMRSimulationController.h
M CCA/Components/SimulationController/AMRSimulationController.cc
- Added white space, removed tabs, line up params, etc.
M CCA/Components/SimulationController/SimulationController.cc
- Moved toHumanUnits() to ProcessInfo so it can be used by others.
- Line up variables, add white space.
- Consistent (correct) capitalization/punctuation of some comments.
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.cc
- inNeighborhood() did not have the same declaration as its parent
(superclass)... removed "const MaterialSubset*" to fix this... not
sure how this worked before.
- White space.
M CCA/Components/LoadBalancers/LoadBalancerCommon.h
- Add "d_" to several class variables to be consistent and conform to coding standard.
- Removed extra (unnecessary) level of indentation.
- White space, line up variables.
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
- Add "d_" to several class variables to be consistent and conform to coding standard.
- White space.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Alphabetize #includes to more easily determine what is included.
- White space, line up variables.
M CCA/Components/Schedulers/UnifiedScheduler.cc
- Minor white space, coding standard update.
M CCA/Components/Schedulers/MPIScheduler.cc
- Minor white space fix.
M CCA/Components/Schedulers/SchedulerCommon.cc
- ProcessInfo GetMemoryResident() renamed with lowercase 'g' to match coding standard.
- Added processor rank to commented out memory usage print statement.
M CCA/Components/Arches/Radiation/RadPropertyCalculator.h
- Alphabetize #includes, remove superfluous ;s, remove tabs, line up functions/variables.
M Core/OS/ProcessInfo.h
M Core/OS/ProcessInfo.cc
- Fixed (added) BGQ memory usage querying code. Previously, it was
calling the generic linux version, and trying to open
/proc/<pid>/status to get memory info. On BGQ machines, this file
does not exist (except on the I/O node - where, while it exists,
it does not have valid information in it). In the generic linux
version, if the file fails to open, then an error is NOT thrown,
and 0 is returned... most likely we should fix this so that it
throws an error...
Note, the code for using the "mallinfo" (for BGQ) version of memory
checking was also added to this file, but is commented out and not
used because it uses an integer as the return variable and thus
does not correctly handle systems with more than 2 GB of memory.
- Coding standard updates.
- Moved toHumanUnits() here.
- Use lowercase letter for first letter in function names to be consistent and follow standard.
M Core/Parallel/Parallel.cc
M Core/Thread/Thread_pthreads.cc
- Minor white space, capitalization/punctuation.
M StandAlone/sub.mk
- For static builds, need Wasatch 3P libs to link.
M StandAlone/sus.cc
- Alphabetize #includes.
51 lines of code changed in 4 files:
Throw exception if a non-threaded scheduler is specified in the UPS file and "-nthreads <n>" is used on the command line.
5 lines of code changed in 1 file:
All variables that do not change and member functions that do not
change class data should be made const. In this checkin, a number of
things passed into the Schedulers can be made const (the 'output' port
variable is the main one here).
Made a number of minor cleanups including whitespace, tab removal,
coding standard, etc.
M CCA/Components/DataArchiver/DataArchiver.h
- Clean up layout of functions.
- Make const all functions that don't chance the class' data.
- Remove superfluous ;s.
M CCA/Components/DataArchiver/DataArchiver.cc
- Add const to functions updated in .h file.
- Minor coding standard, white space, readability cleanups.
M CCA/Components/ReduceUda/UdaReducer.h
M CCA/Components/ReduceUda/UdaReducer.cc
- Line up variables for better readability.
- Pass strings as 'const &', instead of copying them.
M CCA/Components/Schedulers/SchedulerFactory.h
M CCA/Components/Schedulers/SchedulerFactory.cc
M CCA/Components/Schedulers/DynamicMPIScheduler.h
M CCA/Components/Schedulers/DynamicMPIScheduler.cc
M CCA/Components/Schedulers/SingleProcessorScheduler.h
M CCA/Components/Schedulers/SingleProcessorScheduler.cc
M CCA/Components/Schedulers/UnifiedScheduler.h
M CCA/Components/Schedulers/UnifiedScheduler.cc
M CCA/Components/Schedulers/MPIScheduler.h
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/MessageLog.h
M CCA/Components/Schedulers/MessageLog.cc
M CCA/Components/Schedulers/SchedulerCommon.h
M CCA/Components/Schedulers/SchedulerCommon.cc
- Pass 'Output' port variable as const as it is not used to change the output.
- Line up variables for better readability, add some white space, remove spurious tabs.
M CCA/Ports/Output.h
- Add 'const' to all functions that don't change the class' data.
- White space / Readability
M StandAlone/sus.cc
- Clarify MAX_THREADS error message.
- It is unclear to me how the specification of number of threads and
<scheduler> work together... ie which one gets precedence. When I
figure it out, I will fix this further.
136 lines of code changed in 20 files:
Remove Heirarchical and BNR regridder and supporting classes, tests, etc.
* NOTE: It has been shown these do not scale, and in the case of ICE these regridders have undesired side effects WRT fine level solution, and in fact are disallowed by ICE.
* The only input file found to be using the Heirarchical regridder was /inputs/Examples/wave.ups (Similar to AMRWaveEquation test problem from Chombo), and has been changed to have the appropriate <Regridder> attributes.
* This commit also enables clean support for GPUPerPatch variables need by Wasatch with CUDA enabled.
1 lines of code changed in 1 file:
A new and correct version of the modifies version of the relocation algorithm. The user only provides the list of varlabels that require relocation. Then, the new relocation algorithm creates temporary variables to store the relocated data. Finally, data is copied (safely, psets are replaced as well) from the temporary relocated variables back to the original list supplied by the user.
104 lines of code changed in 3 files:
Allow underlying, raw Task to know it's deviceID when GPU-enabled. This commit is on behalf of Abhishek Bagusetty with modifications by Alan Humphrey.
71 lines of code changed in 3 files:
fix a bug in the Modifies version of the relocation algorithm that showed up when running multipatch/processor + MPI. This change does not affect the traditional relocation algorithm that uses pre_reloc varlabels. The RT should not fail.
9 lines of code changed in 1 file:
Fix issue with GPUDataWarehouse::getItem() failing for GPUPerPatch vars.
Also, do some formatting, cleanup, etc.
0 lines of code changed in 2 files:
Restrict execution to a single thread for the first timestep on restarts.
This fixes the deadlock when restarting with high thread counts on BGQ architecture.
8 lines of code changed in 3 files:
Cleanup some stale Scheduler/Task code while waiting on the debug queue.
89 lines of code changed in 3 files:
* Clean up a slew of warnings in Schedulers and Tests.
* Humble beginnings of some infrastructure cleanup and documentation, starting with sus.cc
7 lines of code changed in 2 files:
Remove obsolete schedulers.
NOTE: This is going to break tests, due the SVN diffs themselves containing the very line /R_Tester/helpers/runSusTests.py looks for to bail: "Caught exception" (see below).
# was an exception thrown
exception = system("grep -q 'Caught exception' sus.log.txt");
Changing this string results in the script catching its own SVN diffs during RT.
Todd - How do we want to handle this?
26 lines of code changed in 11 files:
remove a cout statement from the relocation algorithm
0 lines of code changed in 1 file:
Add particle relocation version that doesn't require pre-relocation variables. Please use this with caution as it requires additional testing. A warning has be provided in the documentation of the associated functions to remind users of that caution.
564 lines of code changed in 5 files:
(41 more)