Directory CCA/Components/SimulationController/

Total Files:
5
Deleted Files:
0
Lines of Code:
2454

[root]/CCA/Components/SimulationController

Lines of Code

CCA/Components/SimulationController/ Lines of Code

Developers

Author Changes Lines of Code Lines per Change
Totals 47 (100.0%) 1552 (100.0%) 33.0
dav 18 (38.3%) 1190 (76.7%) 66.1
harman 16 (34.0%) 289 (18.6%) 18.0
ahumphrey 7 (14.9%) 65 (4.2%) 9.2
jas 5 (10.6%) 5 (0.3%) 1.0
qymeng 1 (2.1%) 3 (0.2%) 3.0

Most Recent Commits

dav 2014-12-26 21:01 Rev.: 52897

Reverting code to r52880 before my memory use fix commit. While most tests passed, the ones using AMR and the dynamic load balancer were not passing and the weeds are too deep within them to quickly figure out what is causing the problems. Next week I will attempt to figure out what is going on with them. My guess is that it will take quite a bit of effort to understand the inner workings of the dynamic loadbalancer in order to get everything to work, so it may be quite a while before this fix may go in.

102 lines of code changed in 4 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (new), SimulationController.cc (new)
dav 2014-12-23 20:17 Rev.: 52889


Finishing cleaning up the memory reduction commit... Main fix
was to add "delete d_archive" back to SimulationController.cc.

M CCA/Components/SimulationController/SimulationController.cc

- Add back in "delete d_archive"... This still needs to be investigated.

M CCA/Components/LoadBalancers/CostProfiler.cc
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc

- Remove warning: numLevels is unsigned now.
- Cosmetics: coding standard, white space, {}s, etc

M Core/Grid/Patch.cc
M CCA/Components/Schedulers/DWDatabase.h
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc

- Cosmetics: line up variables, untabify, coding standard, white space, {}s, etc

M CCA/Components/Schedulers/SchedulerCommon.cc

- Remove warning: numLevels is unsigned now.

7 lines of code changed in 1 file:

  • CCA/Components/SimulationController: SimulationController.cc (+7 -4)
dav 2014-12-23 00:29 Rev.: 52884

Hopefully this fixes errors from the previous larege memory use reduction commit.

M CCA/Components/SimulationController/SimulationController.cc

- I need to investigate the delete of the temporary data archive... Commenting it out for now.

M CCA/Components/DataArchiver/DataArchiver.cc

- White space clean up.
- Removed a releaseDocument() that should not have been there. (The release happens
automatically when the var goes out of scope.)

M Core/Grid/Grid.cc

- Handle periodic boundaries in the input xml file.

4 lines of code changed in 1 file:

  • CCA/Components/SimulationController: SimulationController.cc (+4 -1)
dav 2014-12-22 15:49 Rev.: 52882


This is the first commit (of what may be several over the next month or so) dealing with Uintah's excessive use
of memory with respect to its XML data structures (that are used for I/O) when running on thousands of patches.
This commit specificly addresses the excessive use of memory when restarting a simulation. Before this commit,
Uintah would read in a timestep.xml file (from the checkpoints/t00000/) directory and create an huge DOM
structure in memory. (On 8K patches on Vulcan (BGQ - LLNL) memory per process would increase by 100% (by
20 MB per process on the advect sample problem). On 30K patches, memory use of 200 MB or more has been observed.)
To solve this problem, instead of reading the XML into memory, we parse it on the fly and extract the data we need,
but do not save it. Note, there are two parts of the timestep.xml file that cause the memory issue: the 1000s of
<Grid> and <DataItem> tags. Small XML nodes are not a problem, and thus we still use them for some things (for
example, the component section read from the timestep.xml file. A full DOM of this node is created (during the
streaming read of the rest of the file) and this node is passed down to the component as before.

A number of changes in this commit are cosmetic, dealing with white space and coding standards, and were made
while I was digging through the code to understand where the memory issue was and how to fix it. To better
see real changes in the code, I highly suggest that you use a diff that ignores generic white space changes,
such as:

svn diff --diff-cmd diff --extensions -w <file_name>

Note,asIgetolderInolongercanreadtextlikethis,soIamaddingspacesintothecodetomakeit easier to see. :)

M CCA/Components/SimulationController/AMRSimulationController.cc

- Number of levels in a Grid (grid->numLevels()) cannot be negative and thus should be an unsigned int... it is now.
- Costmetic: English sentences start with capital letters and end with punctuation... yeah yeah I know.

M CCA/Components/SimulationController/SimulationController.cc

- queryGrid: pass through a pointer, don't create a new copy.
- Unsigned int for grid level number.
- Cosmetic white space/coding standards/English updates. Fixed some strange indentation. Untabify.

M CCA/Components/Parent/Switcher.cc

- Unsigned int for grid level number.
- Cosmetic: Swatted some evil endl's. :) (Why write 8 more characters of code, when 2 will do? And makes it easier to add to strings later...)

M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.h

- Updates to consolidate code in load balancers... Still needs some direct attention as opposed to this
first pass while working on something else.

M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h

- Add 'do-nothing' implementation of restartInitialize() to this class.

M CCA/Components/LoadBalancers/CostModelForecaster.cc

- Cosmetic: Untabbify, white space, {} around one line ifs, English.

M CCA/Components/LoadBalancers/DynamicLoadBalancer.h
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc

- Moved restartInitialize() (and a number of supporting class d_ variables) into LoadBalancerCommon.
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English.

M CCA/Components/LoadBalancers/ProfileDriver.cc
M CCA/Components/LoadBalancers/CostModeler.h

- grid->numLevels() is now unsigned updates.
- Coding standard cleanups / English / white space.

M CCA/Components/LoadBalancers/LoadBalancerCommon.cc

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
- Make global DebugStream variables be less global (made static to file).
- Unsigned int for grid level number.
- Move restartInitialize() from DynamicLoadBalancer and ParticleLoadBalancer (code was exact duplicate in both files) here.

M CCA/Components/Solvers/AMR/AMRSolver.cc

- Cosmetic: White space, line up variables, English.
- Unsigned int for grid level number.

M CCA/Components/DataArchiver/DataArchiver.cc
M CCA/Components/DataArchiver/DataArchiver.h

- Comment added for where next XML memory fix should take place.
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M CCA/Ports/ProblemSpecInterface.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.cc

- Created new version of readInputFile() which takes a list of patches that are specific to this processor. However,
I don't think anyone (me?) is using it yet, and I'm actually not convinced that it is the right function to fix
(see comments in code). I'm committing it just in case it turns out that we need it as we fix the rest of the
XML memory bloat issues. However, at that point if it turns out not to be useful, it should be removed.

M CCA/Components/Schedulers/TaskGraph.h
M CCA/Components/Schedulers/TaskGraph.cc

- Add some consistency to the member variable naming in this file. Half the variables use d_, and the other half
have a trailing _, and the third half ;) didn't do either one... sigh. Some examples.

lb -> d_lb
dts_ -> d_dts

- A few cosmetic fixes - variable line up, white space, etc.
- Removed var/matl from lb->getOldProcessorAssignment()... need to verify that this is correct... see above.

M CCA/Components/Schedulers/OnDemandDataWarehouse.cc

- Removed unused parameters to lb->getOldProcessorAssignment(). However, the DynamicLoadBalancer still uses the
version with parameters (though it doesn't really need them either). It is unclear why getOldProcessorAssignment()
is not declared in LoadBalancerCommon common or several of the other Load Balancers, and also unclear which function
is actually being called. This is defined in the LoadBalancer.h in CCA/Ports/. This needs more investigation.

M CCA/Components/Schedulers/DetailedTasks.h
M CCA/Components/Schedulers/DetailedTasks.cc

- Almost all cosmetic, white space, untabbify, lining up vars, English, etc changes.
- Add trailing _ to numPendingInternalDependencies to denote member var.

M CCA/Components/Schedulers/MPIScheduler.cc

- Few cosmetic cleanups.

M CCA/Components/Schedulers/SchedulerCommon.cc
M StandAlone/tools/pfs/rawToUniqueGrains.cc
M StandAlone/tools/puda/PIC.cc
M StandAlone/tools/extractors/extractV.cc
M StandAlone/tools/extractors/extractF.cc
M StandAlone/tools/extractors/partextract.cc
M StandAlone/partvarRange.cc
M StandAlone/tools/puda/jim1.cc
M StandAlone/tools/puda/jim3.cc
M StandAlone/tools/puda/varsummary.cc
M StandAlone/tools/puda/puda.cc
M StandAlone/tools/puda/POL.cc
M StandAlone/slb.cc

- Cosmetic white space fixes.
- numLevels() casts to avoid warnings.

M CCA/Components/Arches/Radiation/RadHypreSolver.cc

- Few cosmetic changes.

M CCA/Components/Regridder/RegridderCommon.cc
M CCA/Components/Regridder/SingleLevelRegridder.cc
M CCA/Components/Regridder/TiledRegridder.cc

- Cosmetic white space fixes.
- numLevels() casts to avoid warnings.

M CCA/Ports/Output.h

- Use const vars when possible.
- White space, English.

M CCA/Ports/LoadBalancer.h

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M Core/OS/Dir.h
M Core/OS/Dir.cc
M Core/OS/Dir_boost.cc

- Use 'const' when variables don't change.
- Cosmetic: line up variables, untabbify, white space, {} around one line ifs, English.
- Don't use "std::" in half the file and not in the other half.

M Core/Grid/Patch.h
M Core/Grid/Patch.cc

- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English.

M Core/Grid/Grid.h
M Core/Grid/Grid.cc

- Added readLevelsFromFile(), parseLevelFromFile(), and parseGridFromFile() to parse XML without creating a full DOM.
This provides a 50% memory decrease (per process) on Vulcan (LLNL-BGQ) for 8K processors when restarting the
advect problem. At some point in the future it might be nice to replace my (brute force - straightfoward -
assumes that the input xml file is very well behaved) approach with the streaming reader functions from the
lib xml library. This is not done at this point as it is unclear how well that library will fit into our use
case, how much time it will take to convert to, and the fact that we want to get this pushed out to the users asap.
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English, coding standards.
- numLevels is now an unsigned int.

M Core/Grid/Task.cc

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M Core/Grid/SimulationState.h
M Core/Grid/SimulationState.cc

- Cosmetic: Alphabetize/sort #includes.

M Core/Grid/Level.h
M Core/Grid/Level.cc

- Returned patch from addPatch() is not used anywhere so remove the return type.
- Cosmetic: line up variables, untabbify, white space, {} around one line ifs, English.

M Core/Geometry/Vector.h
M Core/Geometry/Vector.cc

- Added the fromString() function.
- Cosmetic: Alphabetize/sort #includes.

M Core/Geometry/IntVector.h
M Core/Geometry/IntVector.cc

- Added the fromString() function.

M Core/Containers/HashTable.h

- Moved the call to first() into the constructor... Not quite sure what the reason for this is,
but everywhere a HashTable is created, "first()" is immediately called, so it makes sense
to just do it in once place instead of having to do it each time it is used.

D Core/Containers/StringUtil.cc
D Core/Containers/StringUtil.h
A + Core/Util/StringUtil.h
A + Core/Util/StringUtil.cc
M Core/Grid/SimulationTime.cc
M Core/Tracker/TrackerServer.cc
M Core/Persistent/Pstreams.cc
M Core/Persistent/Persistent.cc
M Core/Util/FileUtils.cc

- Moved StringUtil.* to Core/Util/ to all its use in other locations (higher up the build tree).

M Core/Containers/sub.mk

- Untabbify.

M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc

- Rename variables so they are readable, eg: d_tsurl becomes d_ts_path_and_filename, d_tstimes becomes d_ts_times, etc.
- Change a few more functions to parse xml file data on the fly (instead of parsing DOMs), eg: queryEndiannessAndBits()
- Use NULL instead of 0.
- Pass strings as 'const &' instead of copying them every time.
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M Core/ProblemSpec/ProblemSpec.h
M Core/ProblemSpec/ProblemSpec.cc

- Added constructor to take in a string buffer to create a new DOM from. (Use: stream parse an xml file and put the
needed pieces into a string, then turn only that information into a DOM.)
- Added routines to help in the stream parsing of an XML file: findBlock()
- checkForInputError() replaced.
- parseIntVector replaced with fromString() in respective files.

M Core/Util/DynamicLoader.cc

- Alphabetize #includes.

M Core/Util/sub.mk

- Alphabetize

A Core/Util/XMLUtils.h
A Core/Util/XMLUtils.cc

- Added new helper functions for parsing xml files on the fly.

M StandAlone/compare_uda.cc

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
- numLevels() is unsigned now.
- Bulletproofing - verify input args are actually directories.

M StandAlone/restart_merger.cc

- Minor cosmetic fixes.

M StandAlone/sus.cc

- Bulletproofing - catch case when user accidentally runs sus with a UDA and not a UPS.

96 lines of code changed in 2 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+55 -55), SimulationController.cc (+41 -48)
ahumphrey 2014-11-08 11:07 Rev.: 52661

Fix PAPI support in trunk

14 lines of code changed in 3 files:

  • CCA/Components/SimulationController: SimulationController.cc (+9 -8), SimulationController.h (new)
dav 2014-11-03 16:46 Rev.: 52628

More cosmetic/standards/white space/untabbifying/etc updates I missed in previous commit.

156 lines of code changed in 2 files:

  • CCA/Components/SimulationController: SimulationController.cc (+64 -64), SimulationController.h (+92 -92)
dav 2014-11-03 16:38 Rev.: 52627

Cosmetic/standards/white space/untabbifying/etc updates before digging into code for excess memory usage on restarts.

592 lines of code changed in 2 files:

  • CCA/Components/SimulationController: SimulationController.cc (+561 -531), SimulationController.h (+31 -29)
harman 2014-10-29 14:30 Rev.: 52613

replaced tabs with spaces.

Reformatted output when SCIDebug componentTimings:+ is turned on. It's easier to parse and
added a descriptive header.

57 lines of code changed in 1 file:

  • CCA/Components/SimulationController: SimulationController.cc (+57 -51)
ahumphrey 2014-10-22 12:04 Rev.: 52600

Add significant functionality to MPI stats.
Cleanup and formatting in Unified and MPI schedulers.

37 lines of code changed in 1 file:

  • CCA/Components/SimulationController: SimulationController.cc (+37 -26)
dav 2014-10-02 16:56 Rev.: 52535

- Cleanups from Vulcan@LLNL. Mostly cosmetic, though a few real fixes
found while porting to BGQ machine.

- Replaced proc0thread0cerr with proc0cerr as proc0cerr is (now
specifically) defined to only print out from thread 0 of process 0.

M CCA/Components/SimulationController/AMRSimulationController.cc

- Cosmetic
- Alphabetize the #includes for better readability and to remove duplicates.
- Put the #ifdef USE_GPERFTOOLS around entire block, instead of having
it multiple times and leaving dead if statements around it.

M CCA/Components/SimulationController/SimulationController.cc

- Cosmetic: Fix indentation (use diff -b to better see differences.)

M CCA/Components/DataArchiver/DataArchiver.cc

- Added the ability to specify checkpoint time via hours (in addition to seconds).
- Cleaned up the code to make it more readable for parsing this
information from input file - ie, use variable names that correspond
to the data they hold.
- Commented out a few lines of code that didn't do anything.
- Indented for readability, lined up some variable assignments.

M CCA/Components/Arches/CompDynamicProcedure.cc

- Alphabetize the #includes for better readability and to remove duplicates.
- Replaced proc0thread0cerr with proc0cerr.

M CCA/Components/Arches/DQMOM.cc
M CCA/Components/Arches/PropertyModels/PropertyModelBase.h
M CCA/Components/Arches/IncDynamicProcedure.cc
M CCA/Components/Arches/Arches.cc

- Replaced proc0thread0cerr with proc0cerr.

M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc

- Throw a ProblemSetupException as that is what the error is.

M Core/Exceptions/InvalidState.cc

- Propagate (user supplied) error message.

M Core/Grid/Patch.cc

- Whitespace cleanup for readability.

M Core/Grid/Grid.h

- Whitespace cleanup for readability.
- Parameter to setExtraCells() is now (explicitly) const.

M Core/Grid/Level.cc
M Core/Grid/Grid.cc

- Coding standard and whitespace cleanup.

M Core/Parallel/Parallel.h

- Updated proc0cout to handle threaded versions of Uintah. If in MPI
only mode, then only prints for proc 0. If in threaded mode, only
prints for proc 0 thread 0.
- Removed proc0thread0cout as now only proc0cout is needed.

M Core/Thread/ThreadPool.h

- Remove tabs, line up code.

M Core/Thread/Thread.h
M Core/Thread/Parallel.h
M testprograms/Thread/parallel.cc

- Added the ThreadNS namespace because there are two classes named
'Parallel' in Uintah, and the one in the new ThreadNS is only used
in a few locations and thus is easier to move into its own NS.

M StandAlone/inputs/UPS_SPEC/ups_spec.xml

- Added 'walltimeStartHours' and 'walltimeIntervalHours' (to augment the
version that uses just seconds).
- Lined up for better readability.

M tools/StackTrace/StackTrace.cc

- Fixes for the stack trace tool for machines that only provide symbol
numbers in their stack traces. However, unfortunately, this still
doesn't seem to provide a valid stack trace on Vulcan.

133 lines of code changed in 2 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+25 -34), SimulationController.cc (+108 -108)
harman 2014-09-12 15:10 Rev.: 52429

SimulationState:
- added bool d_recompileTaskGraph, getRecompileTaskGraph(), setRecompileTaskgraph().
This is used by code deep inside a component with no easy access to the existing
simComp->needRecompile().

AMRSimulationController
needRecompile()
- check the sharedState if a taskgraph recompile has been requested.

10 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+10 -7)
dav 2014-08-19 14:32 Rev.: 52317


A number of clean ups for Vulcan (LLNL - BGQ machine). Most
importantly, fixed memory usage reporting (see ProcessInfo.cc).

M CCA/Components/SimulationController/AMRSimulationController.h
M CCA/Components/SimulationController/AMRSimulationController.cc

- Added white space, removed tabs, line up params, etc.

M CCA/Components/SimulationController/SimulationController.cc

- Moved toHumanUnits() to ProcessInfo so it can be used by others.
- Line up variables, add white space.
- Consistent (correct) capitalization/punctuation of some comments.

M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.cc

- inNeighborhood() did not have the same declaration as its parent
(superclass)... removed "const MaterialSubset*" to fix this... not
sure how this worked before.
- White space.

M CCA/Components/LoadBalancers/LoadBalancerCommon.h

- Add "d_" to several class variables to be consistent and conform to coding standard.
- Removed extra (unnecessary) level of indentation.
- White space, line up variables.

M CCA/Components/LoadBalancers/LoadBalancerCommon.cc

- Add "d_" to several class variables to be consistent and conform to coding standard.
- White space.

M CCA/Components/Schedulers/OnDemandDataWarehouse.cc

- Alphabetize #includes to more easily determine what is included.
- White space, line up variables.

M CCA/Components/Schedulers/UnifiedScheduler.cc

- Minor white space, coding standard update.

M CCA/Components/Schedulers/MPIScheduler.cc

- Minor white space fix.

M CCA/Components/Schedulers/SchedulerCommon.cc

- ProcessInfo GetMemoryResident() renamed with lowercase 'g' to match coding standard.
- Added processor rank to commented out memory usage print statement.

M CCA/Components/Arches/Radiation/RadPropertyCalculator.h

- Alphabetize #includes, remove superfluous ;s, remove tabs, line up functions/variables.

M Core/OS/ProcessInfo.h
M Core/OS/ProcessInfo.cc

- Fixed (added) BGQ memory usage querying code. Previously, it was
calling the generic linux version, and trying to open
/proc/<pid>/status to get memory info. On BGQ machines, this file
does not exist (except on the I/O node - where, while it exists,
it does not have valid information in it). In the generic linux
version, if the file fails to open, then an error is NOT thrown,
and 0 is returned... most likely we should fix this so that it
throws an error...
Note, the code for using the "mallinfo" (for BGQ) version of memory
checking was also added to this file, but is commented out and not
used because it uses an integer as the return variable and thus
does not correctly handle systems with more than 2 GB of memory.

- Coding standard updates.
- Moved toHumanUnits() here.
- Use lowercase letter for first letter in function names to be consistent and follow standard.

M Core/Parallel/Parallel.cc
M Core/Thread/Thread_pthreads.cc

- Minor white space, capitalization/punctuation.

M StandAlone/sub.mk

- For static builds, need Wasatch 3P libs to link.

M StandAlone/sus.cc

- Alphabetize #includes.



100 lines of code changed in 4 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+29 -25), AMRSimulationController.h (+5 -5), SimulationController.cc (+66 -68)
ahumphrey 2014-07-11 16:49 Rev.: 52147

Restrict execution to a single thread for the first timestep on restarts.
This fixes the deadlock when restarting with high thread counts on BGQ architecture.

11 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+11)
harman 2014-06-12 07:48 Rev.: 51971

AMRICE.cc & DDT1.cc
problemSetup()
- allow the single level regridder to pass through the bulletproofing

SingleLevelRegridder.cc
problemSetup()
- compute the refinement ratio for each level. Do not use the refinement ratio from the oldGrid.
The regridder's definition of the RR is different than what is stored in the Level.

AMRSimulationController.cc
run()
-reversed the order of the calls to doRegridding()

7 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+7 -6)
harman 2014-06-10 16:05 Rev.: 51949

if (newGrid != oldGrid) {

sharedState->setRegridTimestep(true) On **ALL** mpi ranks not just rank 0
}

6 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+6 -1)
harman 2014-06-03 11:53 Rev.: 51919

Global formatting:
-added {}
-added vertical and horizontal spaces.

90 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+90 -44)
harman 2014-05-29 07:50 Rev.: 51887

Added the ability to regrid only once. This mechanism will be used
to regrid on a single level restart.

RegridderCommon.cc
problemSetup_Bulletproofing()
- removed maxLevel > 1 test

SchedulersCommon.cc
scheduleAndDoDataCopy()
- verify that when reduction variables are copied to the new_dw they are actually reduction vars.
Previously, SoleVariables were included in this copy.

AMRSimulationController.cc
run()
- added code to regrid once if specified.

Usage:
<AMR>
<Regridder type="Tiled">
<regrid_once> true </regrid_once>
</Regridder>
</AMR>

13 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+13 -3)
ahumphrey 2014-05-15 14:21 Rev.: 51840

Excise last bits of Windows support from src/CCA

3 lines of code changed in 2 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+1 -1), SimulationController.cc (+2 -8)
qymeng 2014-05-01 10:08 Rev.: 51795

Removed many of datawarehouse locks by using atomic operations

3 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+3 -1)
harman 2014-02-24 09:59 Rev.: 51563

- cleaned up formatting for SCI_DEBUG ComponentTimes
- multiply LIB by 100.

4 lines of code changed in 1 file:

  • CCA/Components/SimulationController: SimulationController.cc (+4 -3)
harman 2014-01-29 13:11 Rev.: 51516

More housekeeping
renamed directory PatchComber -> ReduceUda

2 lines of code changed in 3 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+1 -1), sub.mk (+1 -1)
harman 2014-01-29 11:20 Rev.: 51514

DataArchiver.cc
- reduceUdaSetup()
Just use a plain copy for coping the checkpoints.
Now copying the original ups and input.xml.org files

-beginOutputTimestep()
fixed compiler warning

- copy_outputProblemSpec()
cleaned up output statement

AMRSimulationController.cc
- run() inside reduceUda conditional block
setting the intital physical time from reduceUda

Dir.cc
- getFilenamesBySuffix()
comment out cout statement

UdaReducer.cc
- polished, added comments, cleaned up user output

- added user message

- initialize()
set delt = 0. You must have this if outputInitTimestep was used.

- computeLabels()
removed code that will never be used.

- deleted finalizeTimestep related code. It's not needed

- needRecompile()
recompile the taskgraph every timestep. The saved variable list
and the number of matls could change from timestep to timestep.

reduce_uda is in final testing phase. All initial tests show that it's working.

2 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+2)
harman 2014-01-24 11:51 Rev.: 51501

Overall:
Renamed functions and tasks to be more descriptive
Split big functions and tasks into smaller chunks of single purpose code where appropriate
Cleaned up the SCI_DEBUG output so you can now follow what is going on.
Note none of the logic was touched.

Specifics:

executedTimestep -> findNext_OutputCheckPoint_Timestep
-> writeto_xml_files


outputTimestep() -> makeTimestepDirs()

task:outputReduction -> outputReductionVars()

task:output -> task:outputVariables()

finalizeTimestep() -> finalizeTimestep + sched_allOutputTasks


20 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+20 -11)
harman 2014-01-22 12:54 Rev.: 51487

Overall
Cleaning out combined_patches, reuse combinePatchSetup() & more heavy construction on reduceUda, details below.

sus.cc
- removed combine_patch option and related code.
- renamed doCombinePatches() -> setReduceUdaFlags()

Output.h
- alphabetize includes
- renamed doCombinePatches() -> setReduceUdaFlags()

SimulationController.h
- renamed doCombinePatches() -> setReduceUdaFlags()
- removed d_combinedPatches variable

SimulationController.cc
- renamed doCombinePatches() -> setReduceUdaFlags()
- remove d_combinedPatches variable
- cleaned up schizophrenic indentation
- using proc0cout instead of cout with conditional wrappers
- pulled reduceUda code from preGridSetup()

AMRSimulationController.cc
- removed d_combinePatches variable
- added d_timeinfo code from SimulationController to reduceUda conditional block


UdaReducer.cc/.h
- removed piles of code that failed for various reasons.

DataArchiver.h
- renamed doCombinePatches() -> setReduceUdaFlags()

DataArchiver.cc
-- renamed doCombinePatches() -> setReduceUdaFlags()
- cleaned up debugstream output so you can follow it.
- minor reformatting
- reduceUdaSetup()
- the entire checkpoints directory is now being copied to the new uda.


76 lines of code changed in 3 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+20 -21), SimulationController.cc (+53 -69), SimulationController.h (+3 -6)
jas 2014-01-16 00:47 Rev.: 51467

Updated copyright information.

5 lines of code changed in 5 files:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+1 -1), AMRSimulationController.h (+1 -1), SimulationController.cc (+1 -1), SimulationController.h (+1 -1), sub.mk (+1 -1)
harman 2014-01-07 13:33 Rev.: 51437

Set scrubbing to none if the load balancer is using getNthProc input
file option. Previously it was also set for reduceUda and it didn't work with
multi-level grids.


2 lines of code changed in 1 file:

  • CCA/Components/SimulationController: AMRSimulationController.cc (+2 -3)
Generated by StatSVN 0.7.0