AMR
(10 files, 2871 lines)
HyprePreconds
(13 files, 1181 lines)
HypreSolvers
(19 files, 1981 lines)
[root]/CCA/Components/Solvers
AMR
(10 files, 2871 lines)
HyprePreconds
(13 files, 1181 lines)
HypreSolvers
(19 files, 1981 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 35 (100.0%) | 292 (100.0%) | 8.3 |
| dav | 15 (42.9%) | 238 (81.5%) | 15.8 |
| tsaad | 2 (5.7%) | 36 (12.3%) | 18.0 |
| jas | 15 (42.9%) | 18 (6.2%) | 1.2 |
| harman | 3 (8.6%) | 0 (0.0%) | 0.0 |
Fix for static build when GPU (NVCC) is turned on. If you have
external device specific functions in .cu files, then you need to link
them with the -dc (in addition to the -c) flag. Then you have to link
all of these files together in a separate step using the nvcc
compiler's -dlink flag. This update removes the compilation of .cu
files in multiple other files (which thus created multiple definitions
of the same symbols).
I've created a new faux library lib/libgpu_extra_link.a that holds the
output from the -dlink command, and this is linked into sus.
M configVars.mk.in
- Added "-dc" to the nvcc link line.
M Makefile.in
- Build lib/libgpu_extra_link.a if Static and CUDA.
M StandAlone/sub.mk
- Sus now depends on lib/libgpu_extra_link.a (if Static/CUDA).
M include/sci_defs/cuda_testdefs.h.in
- Cosmetic fixes: cleaned up indentation and a few comments.
M CCA/Components/Models/Radiation/RMCRT/RayGPUKernel.cu
- No longer include the .cu files, just include the .h file.
M CCA/Components/Solvers/sub.mk
- Cosmetic fixes: Alphabetize, remove duplicate libs, consolidate if's.
M CCA/Components/Schedulers/GPUDataWarehouse.h
- Cosmetic fixes, clean up spacing, make easier to read.
- Remove unnecessary ;'s after constructor/destructor.
M CCA/Components/Schedulers/UnifiedScheduler.cc
- Indent.
- Group common variables.
M CCA/Components/Arches/sub.mk
- Cosmetic fixes: Cleanup, Indentation, consolidate if's.
M Core/Util/GPU.h
- Fix namespace: uintah -> Uintah
- isThread0_Blk0() is an external function, declare it as such.
M Core/Util/GPU.cu
- Fix namespace: uintah -> Uintah
- Fix function specification layout.
22 lines of code changed in 2 files:
scheduleSolve()
Fixed the bulletproofing when periodic BCs are used.
The non-periodic directions can have any grid resolution
0 lines of code changed in 2 files:
The following commits are mostly cosmetic in nature and should not
change any answers.
Lots of white space and indentation fixes. It is so much easier to
read code when variables are lined up, and values assigned to them
are also lined up.
M CCA/Components/Parent/Switcher.cc
- Variable "no_solver_specified" was misleading. It meant "no command
line solver specified". However, this is the default case and thus
this variable is not needed.
M CCA/Components/Wasatch/Expressions/EmbeddedGeometry/EmbeddedGeometryHelper.h
- InvalidState exception moved to Uintah namespace.
M CCA/Components/Solvers/AMR/AMRSolver.h
- Parent scheduleInitialize() is purely virtual so must be implemented
in each solver. This allows the user to more easily see whether the
scheduleInitialize() step actually does anything or not.
M CCA/Components/Solvers/HypreSolver.cc
- 'firstPassThrough_' is a class variable so needs the '_' suffix to
meet coding standard.
M CCA/Components/Solvers/SolverFactory.cc
M CCA/Components/Solvers/DirectSolve.cc
M CCA/Components/Solvers/HypreSolver.h
M CCA/Components/Solvers/SolverFactory.h
M CCA/Components/Solvers/DirectSolve.h
M CCA/Components/Solvers/CGSolver.h
- Indentation.
- Added (empty) scheduleInitialize() to Solvers that
require it to be implemented but do not actually use it.
M CCA/Ports/SolverInterface.h
- Moved destructor/constructor empty implementations into .h file for
easier viewing.
- Indentation / white space.
M CCA/Ports/SolverInterface.cc
- This file is empty now so should most likely be removed soon.
M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
- Throw exception if gzipInflate fails (previously it tried to just
kept going and the error was thus hard to find).
M CCA/Ports/sub.mk
- Don't need to compile empty file SolverInterface.cc now.
M Core/Exceptions/ErrnoException.h
M Core/Exceptions/ErrnoException.cc
- Change var name from errno_ to err_ as it might be easy to confuse "errno_" with "errno".
M Core/Exceptions/sub.mk
- Alphabetize list of libraries.
M Core/Exceptions/InvalidValue.cc
- Don't need superfluous "using std::cout".
M Core/Exceptions/InvalidState.cc
M Core/Exceptions/InvalidState.h
- Moved from SCIRun namespace to Uintah for two reasons:
1) SCIRun namespace will eventually go away.
2) InvalidState exception is already in Uintah namespace and these should be consistent.
M Core/IO/sub.mk
- IO now relies on Exception as the UintahZlibUtil now throws an exception if an error occurs.
M Core/IO/UintahZlibUtil.h
- White space / indentation.
- Add comment about what gzipInflate returns.
M Core/IO/UintahZlibUtil.cc
- Throw an exception when an error occurs instead of just return 0, as
the 0 is never checked and causes debugging to be more difficult.
M StandAlone/sus.cc
- Indent / white space.
- Print out which solver is being used.
216 lines of code changed in 13 files:
Removed unnecessary calls to:
sched->overrideVariableBehavior(hypre_solver_label.....)
You only need to overide the behavior once in the solver component, unless
you're using a subscheduler. In ICE, which uses a subscheduler, you have to override
using the parent scheduler.
* should not change the answers.
0 lines of code changed in 1 file:
Implement setting/retrieving setupFrequency using the solver parameters.
7 lines of code changed in 1 file:
add a method to the HypreSolver2Parameters to set the setupFrequency. This will allow the component to control that frequency instead of the user. We should eventually rip it out from the solver-input spec.
36 lines of code changed in 2 files:
Updated copyright information.
11 lines of code changed in 14 files: