Lines of Code
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 52 (100.0%) | 335 (100.0%) | 6.4 |
| ahumphrey | 13 (25.0%) | 169 (50.4%) | 13.0 |
| dav | 6 (11.5%) | 146 (43.6%) | 24.3 |
| jas | 32 (61.5%) | 19 (5.7%) | 0.5 |
| harman | 1 (1.9%) | 1 (0.3%) | 1.0 |
Code cleanup before another search for the pack-buffer meory leak
165 lines of code changed in 8 files:
- Cleanups from Vulcan@LLNL. Mostly cosmetic, though a few real fixes
found while porting to BGQ machine.
- Replaced proc0thread0cerr with proc0cerr as proc0cerr is (now
specifically) defined to only print out from thread 0 of process 0.
M CCA/Components/SimulationController/AMRSimulationController.cc
- Cosmetic
- Alphabetize the #includes for better readability and to remove duplicates.
- Put the #ifdef USE_GPERFTOOLS around entire block, instead of having
it multiple times and leaving dead if statements around it.
M CCA/Components/SimulationController/SimulationController.cc
- Cosmetic: Fix indentation (use diff -b to better see differences.)
M CCA/Components/DataArchiver/DataArchiver.cc
- Added the ability to specify checkpoint time via hours (in addition to seconds).
- Cleaned up the code to make it more readable for parsing this
information from input file - ie, use variable names that correspond
to the data they hold.
- Commented out a few lines of code that didn't do anything.
- Indented for readability, lined up some variable assignments.
M CCA/Components/Arches/CompDynamicProcedure.cc
- Alphabetize the #includes for better readability and to remove duplicates.
- Replaced proc0thread0cerr with proc0cerr.
M CCA/Components/Arches/DQMOM.cc
M CCA/Components/Arches/PropertyModels/PropertyModelBase.h
M CCA/Components/Arches/IncDynamicProcedure.cc
M CCA/Components/Arches/Arches.cc
- Replaced proc0thread0cerr with proc0cerr.
M CCA/Components/Arches/ChemMix/ClassicTableInterface.cc
- Throw a ProblemSetupException as that is what the error is.
M Core/Exceptions/InvalidState.cc
- Propagate (user supplied) error message.
M Core/Grid/Patch.cc
- Whitespace cleanup for readability.
M Core/Grid/Grid.h
- Whitespace cleanup for readability.
- Parameter to setExtraCells() is now (explicitly) const.
M Core/Grid/Level.cc
M Core/Grid/Grid.cc
- Coding standard and whitespace cleanup.
M Core/Parallel/Parallel.h
- Updated proc0cout to handle threaded versions of Uintah. If in MPI
only mode, then only prints for proc 0. If in threaded mode, only
prints for proc 0 thread 0.
- Removed proc0thread0cout as now only proc0cout is needed.
M Core/Thread/ThreadPool.h
- Remove tabs, line up code.
M Core/Thread/Thread.h
M Core/Thread/Parallel.h
M testprograms/Thread/parallel.cc
- Added the ThreadNS namespace because there are two classes named
'Parallel' in Uintah, and the one in the new ThreadNS is only used
in a few locations and thus is easier to move into its own NS.
M StandAlone/inputs/UPS_SPEC/ups_spec.xml
- Added 'walltimeStartHours' and 'walltimeIntervalHours' (to augment the
version that uses just seconds).
- Lined up for better readability.
M tools/StackTrace/StackTrace.cc
- Fixes for the stack trace tool for machines that only provide symbol
numbers in their stack traces. However, unfortunately, this still
doesn't seem to provide a valid stack trace on Vulcan.
9 lines of code changed in 2 files:
Report #threads per MPI process only when using MPI_THREAD_MULTIPLE (level 3).
0 lines of code changed in 2 files:
Output to std:out the number of threads per mpi process.
1 lines of code changed in 1 file:
Provide more descriptive message for level of MPI thread suport.
2 lines of code changed in 1 file:
This is a very minor commit.
M Core/Grid/Level.h
M Core/Parallel/Parallel.h
- Fix indentation.
M Core/Grid/BoundaryConditions/BCGeomBase.h
M Core/Grid/BoundaryConditions/BCGeomBase.cc
- Fix white space, line up variables.
- Remove 'const' from several return values as it doesn't make sense and icc gives a warning.
- All arguments for determineIteratorLimits() should be const (as none of them change or return anything).
- Remove superfluous ;s after some function definitions.
- Plase "template<>" on the preceding line from "class" per standard and consistency.
2 lines of code changed in 1 file:
M CCA/Components/Schedulers/SchedulerFactory.cc
- Actually print out the full error this time. :)
M Core/Parallel/Parallel.h
M Core/Parallel/Parallel.cc
- Moved (to the .h file) and renamed a number of (static) varaibles
that should be class variables (and should not just be global
variables in the .cc file). I would have liked to do this to all of
them, but worldComm_ is of type MPI_Comm which is a fancy typedef,
and if I move it to the .h file, then I have to #include mpi.h
in that file, which makes a lot of files now dependent on mpi.h,
so I'd like to avoid that.
130 lines of code changed in 2 files:
A number of clean ups for Vulcan (LLNL - BGQ machine). Most
importantly, fixed memory usage reporting (see ProcessInfo.cc).
M CCA/Components/SimulationController/AMRSimulationController.h
M CCA/Components/SimulationController/AMRSimulationController.cc
- Added white space, removed tabs, line up params, etc.
M CCA/Components/SimulationController/SimulationController.cc
- Moved toHumanUnits() to ProcessInfo so it can be used by others.
- Line up variables, add white space.
- Consistent (correct) capitalization/punctuation of some comments.
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h
M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.cc
- inNeighborhood() did not have the same declaration as its parent
(superclass)... removed "const MaterialSubset*" to fix this... not
sure how this worked before.
- White space.
M CCA/Components/LoadBalancers/LoadBalancerCommon.h
- Add "d_" to several class variables to be consistent and conform to coding standard.
- Removed extra (unnecessary) level of indentation.
- White space, line up variables.
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
- Add "d_" to several class variables to be consistent and conform to coding standard.
- White space.
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
- Alphabetize #includes to more easily determine what is included.
- White space, line up variables.
M CCA/Components/Schedulers/UnifiedScheduler.cc
- Minor white space, coding standard update.
M CCA/Components/Schedulers/MPIScheduler.cc
- Minor white space fix.
M CCA/Components/Schedulers/SchedulerCommon.cc
- ProcessInfo GetMemoryResident() renamed with lowercase 'g' to match coding standard.
- Added processor rank to commented out memory usage print statement.
M CCA/Components/Arches/Radiation/RadPropertyCalculator.h
- Alphabetize #includes, remove superfluous ;s, remove tabs, line up functions/variables.
M Core/OS/ProcessInfo.h
M Core/OS/ProcessInfo.cc
- Fixed (added) BGQ memory usage querying code. Previously, it was
calling the generic linux version, and trying to open
/proc/<pid>/status to get memory info. On BGQ machines, this file
does not exist (except on the I/O node - where, while it exists,
it does not have valid information in it). In the generic linux
version, if the file fails to open, then an error is NOT thrown,
and 0 is returned... most likely we should fix this so that it
throws an error...
Note, the code for using the "mallinfo" (for BGQ) version of memory
checking was also added to this file, but is commented out and not
used because it uses an integer as the return variable and thus
does not correctly handle systems with more than 2 GB of memory.
- Coding standard updates.
- Moved toHumanUnits() here.
- Use lowercase letter for first letter in function names to be consistent and follow standard.
M Core/Parallel/Parallel.cc
M Core/Thread/Thread_pthreads.cc
- Minor white space, capitalization/punctuation.
M StandAlone/sub.mk
- For static builds, need Wasatch 3P libs to link.
M StandAlone/sus.cc
- Alphabetize #includes.
5 lines of code changed in 1 file:
Finish stripping out Windows support.
Also update UPS_Spec from previous commit.
2 lines of code changed in 1 file:
Back out 'domain boundary condition summary' modifications.
Will soon use proc0thread0cout macro for coherent multi-threaded output.
0 lines of code changed in 1 file:
Updated copyright information.
19 lines of code changed in 32 files: