September 2016 Commit Log

Number of Commits:
93
Number of Active Developers:
13
harman 2016-09-30 13:33 Rev.: 55821

Added regression test for single level cpu rmcrt max_rayLength feature.

37 lines of code changed in 2 files:

harman 2016-09-30 12:52 Rev.: 55820

file name change

RMCRT_test_1L.ups -> RMCRT_bm1_1L.ups

149 lines of code changed in 15 files:

harman 2016-09-30 12:15 Rev.: 55819

Implemented Derek's idea for truncating a ray after a user defined distance. CPU, single level only.

<algorithm type='singleLevel'>
<ROI_extents type='max_rayLength'>
<length> 0.1 </length>
</ROI_extents>
</algorithm>


Added bulletproofing if the rayLengh is inf, nan or negative.

Variable name change d_whichROI_algo -> d_ROI_alg


207 lines of code changed in 6 files:

bpeterson 2016-09-30 10:03 Rev.: 55818

A bug fix to make sure the random ray ID # is never more than the amount of total rays

14 lines of code changed in 1 file:

jthornoc 2016-09-29 14:47 Rev.: 55816

Following my last commit, this should set the BC information/level in
the restartInitializeTimeAdvance which is needed for the regridder.

12 lines of code changed in 1 file:

derekhar 2016-09-29 14:07 Rev.: 55815

Changed multi-level intrusion Model, for arches-rmcrt.

6 lines of code changed in 1 file:

jthornoc 2016-09-29 13:11 Rev.: 55814

This should fix the segfault for the regrid dbg test.

2 lines of code changed in 3 files:

harman 2016-09-27 17:57 Rev.: 55813

Ray.cc sched_Refine_Q() and refineQ()
interpolate coarse level radtionVolq -> fine level using standard machinery.

ups files:
save radiationVolq on the finest level.

25 lines of code changed in 1 file:

derekhar 2016-09-27 17:14 Rev.: 55811

Clean-Up. Renamed class variables, added header compiler directives.

6 lines of code changed in 4 files:

ahumphrey 2016-09-27 16:26 Rev.: 55810

Some cleanup before working toward support for multiple "Normal" task-graphs.

This work aims to support a single compilation phase for >1 distinct TGs, and will cycle between them on specific timesteps. Precisely this support is for radiation and non-radiation timesteps within Arches. This way we avoid the continual hit from TG recompilation for RMCRT radiation timesteps.

Ripped out some unused source and header files from 1994.

75 lines of code changed in 12 files:

cgritton 2016-09-27 15:50 Rev.: 55809

AutoCycleFluxBC now changes flux direction based on the average concentration and user inputs for max and min set points

127 lines of code changed in 12 files:

derekhar 2016-09-27 15:37 Rev.: 55808

Added a new quadrature set for radiation in Arches.

180 lines of code changed in 3 files:

jas 2016-09-27 15:13 Rev.: 55806

Change map<const int,. . > to map<int,. . > to fix compiler error with clang 3.9 on mira.

5 lines of code changed in 4 files:

dav 2016-09-27 14:56 Rev.: 55805

Fix proc signature for tempaltes.

22 lines of code changed in 1 file:

harman 2016-09-27 14:56 Rev.: 55804

setBoundaryConditions()
Fixed abskg computes/requires bug when using floats. A different VarLabel is used with
floats are enabled.


5 lines of code changed in 1 file:

dav 2016-09-27 14:17 Rev.: 55803


Add in code from Sidharth to complete the update to allow for
switching between PIDX and UDA output. These changes come from Sid,
but I've cleaned up the syntax a little in some cases. I've tested
them against the local RT but not extensively against PIDX tests
themselves.

M CCA/Ports/Output.h
M CCA/Components/DataArchiver/DataArchiver.h

- Add setSaveAsUDA() and setSaveAsPIDX() functions.

M CCA/Components/DataArchiver/DataArchiver.cc

- White space.
- Guards to check for when using PIDX.


M CCA/Components/SimulationController/AMRSimulationController.cc

- When switching between PIDX and original UDA, let the 'output' (DataArchiver) know which to use.
- If using PIDX, only save timestep.xml for checkpoints.

M CCA/Ports/PIDXOutputContext.h
M CCA/Ports/PIDXOutputContext.cc

- Remove unnecessary ';' from outside of procedures.
- Move empty destructor from .cc file to .h file.
- Align variables / white space.
- Swat evil endl.
- Use variables names that describe their content, not non-meaningful names (eg: me).
- Pass args as const when they are.
- Use a single line for .h file procedures when they are only a single line. Makes reading
the 'spec' much easier.
- Don't mix printf and cout.



135 lines of code changed in 6 files:

harman 2016-09-27 12:32 Rev.: 55801

Added boundary flux calculations to DO algorithm. Verified against 1L with a refinement ratio of 1.


145 lines of code changed in 1 file:

jthornoc 2016-09-27 10:47 Rev.: 55798

NEW not so more...

14 lines of code changed in 1 file:

harman 2016-09-27 08:59 Rev.: 55797

Enable boundary flux computation in input files.

Added machinery (incomplete) to compute boundary fluxes in ML and DO.


61 lines of code changed in 1 file:

jthornoc 2016-09-26 16:54 Rev.: 55796

Actually prune BCInfo based on per-patch information. Somehow this
escaped my previous commits.

Also add an override flag to force the area calculation on boundaries.
This might be useful for debugging or processing sus output (Ben).

37 lines of code changed in 6 files:

cgritton 2016-09-26 15:18 Rev.: 55794

Fixed issue with restart associated with the scalar flux boundary conditions

10 lines of code changed in 10 files:

cgritton 2016-09-26 13:42 Rev.: 55793

Added Factory for FluxBC models. AutoCycleFluxBC is a place holder and is currently the same as FluxBCModel.

506 lines of code changed in 10 files:

ahumphrey 2016-09-26 11:59 Rev.: 55792

Fix so that all RMCRT variants work correctly with non-rectanguler domains.

15 lines of code changed in 1 file:

jthornoc 2016-09-23 14:10 Rev.: 55791

Warning.

0 lines of code changed in 1 file:

jthornoc 2016-09-23 13:45 Rev.: 55790

Prune out intrusions on a perPatch basis, deleting those intrusions not
associated with the current patch.

Also add a new regression test related to these changes.

1434 lines of code changed in 14 files:

dav 2016-09-23 11:53 Rev.: 55789

Turning off the xml texwriter.

1 lines of code changed in 1 file:

cgritton 2016-09-23 08:46 Rev.: 55786

Fix for memory leak

2 lines of code changed in 1 file:

cgritton 2016-09-22 15:55 Rev.: 55785

Fixed segfault issue associated with d_fluxbc pointer set to null.

2 lines of code changed in 1 file:

cgritton 2016-09-22 14:32 Rev.: 55784

Cleaned up tabs

1 lines of code changed in 1 file:

cgritton 2016-09-22 14:30 Rev.: 55783

Moved FluxBCModel to PhysicalBC directory

404 lines of code changed in 9 files:

cgritton 2016-09-22 13:47 Rev.: 55782

Moved scalar flux boundary conditions out of AMRMPM and into its own class.

949 lines of code changed in 10 files:

jthornoc 2016-09-21 16:41 Rev.: 55781

Fix a double delete on the area VarLabels. Strangely, this problem only
shows up as a segfault on opt builds but NOT on debug builds.

Also silence a few warnings.

26 lines of code changed in 4 files:

dav 2016-09-21 15:33 Rev.: 55780

Indentation is your friend.

2 lines of code changed in 1 file:

jthornoc 2016-09-21 15:31 Rev.: 55779

Adding a #ifdef that went missing...

2 lines of code changed in 1 file:

dav 2016-09-21 12:53 Rev.: 55778


Main changes:

Fixes to allow "Nth proc output" to work based on simulation time and wall time.

Also skeleton for writing out grid.xml information in binary, but this is no where
near complete.

Moved the "adjustDelT()" call up higher in the main simulation time loop. Tests
appear to say this is fine, but note that delta t is now updated before regridding.
I assume regridding does not use delta t, but did not trace the code all the way through.

M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc

- Added in getNextCheckpointWalltime(), etc, as these were not exposed before and are
now needed by the SimulationController.
- Broke the grid.xml writing code out into separate procedures to make it less messy.
The grid writing in binary is just a stub at this point.
- Cosmetics: White space, untabify, alignment, etc.

M CCA/Components/SimulationController/AMRSimulationController.h

- Do NOT name variables with a single letter (eg: 't' is terrible). Renamed to 'time'.
(Unless in a very small, self-contained loop, and even then it is bad).
- Cosmetics.

M CCA/Components/SimulationController/AMRSimulationController.cc

- Add in checks to support "Nth rank output" based on simulation time and wall clock time.
- Moved adjustDelT() up a little higher in the main simulation loop. This should not be an
issue and all tests pass.
- Rename t -> time. DO NOT USE one letter variable names. Thank you.
- White space.

M CCA/Ports/Output.h

- Added interface for getNextCheckpointWalltime() and getCheckpointWalltimeInterval().

546 lines of code changed in 5 files:

jthornoc 2016-09-21 12:18 Rev.: 55777

Add missing header.

226 lines of code changed in 1 file:

jthornoc 2016-09-21 12:17 Rev.: 55776

Reduce the domain edge BC information to be contained to local patches
only. Also reduce the numbers of reduction variables for inlet areas to
only occur in the case of Swirl and MassFlow inlets.

Clean up some warnings.

This commit should only change the answers for the
channel_LagPart_inlet.

1042 lines of code changed in 20 files:

jthornoc 2016-09-20 14:39 Rev.: 55774

Fix compiler issues with my previous commits.

3 lines of code changed in 1 file:

jthornoc 2016-09-20 14:32 Rev.: 55773

Adding RK integrator to the kokkos scalar update.

96 lines of code changed in 2 files:

jthornoc 2016-09-20 14:32 Rev.: 55772

Using Array3 for the ConvectiveFlux assembly to simplify the code.
Added a mom-fe-update in the kokkos solver.
Fixed a bug with the rhs not being initialized properly at the start of
each timestep.
Turn back on FaceVelocity calculation using the *Vel…SPBC arches
notation.
KFEupdate now only needs one version of the parallel_for with the
lambda.

43 lines of code changed in 4 files:

jthornoc 2016-09-20 14:32 Rev.: 55771

Use the velocity names for the current code to get the face velocity
calc to actually work.

9 lines of code changed in 2 files:

dav 2016-09-20 12:08 Rev.: 55770

Fix for GPU code: LoadBalancer -> LoadBalancerPort.

14 lines of code changed in 3 files:

dav 2016-09-19 18:15 Rev.: 55768

M CCA/Components/Schedulers/Relocate.h

- Cosmetic: White space, Alignment.

M CCA/Components/Schedulers/Relocate.cc

- Change lb to m_lb inside an assert statement that I missed on previous commit.

0 lines of code changed in 4 files:

dav 2016-09-19 18:06 Rev.: 55767


M CCA/Components/SimulationController/AMRSimulationController.cc

- Change setNthProc() to setNthRank()... don't know how this didn't make it into the previous commit.

3 lines of code changed in 1 file:

dav 2016-09-19 17:47 Rev.: 55766

The main changes in this commit only effect a simulation when <outputNthProc> is
set (> 1) in the .ups file.

This commit allows for PIDX output on every process for a time step
output, while using every Nth process (if so specified) for UDA
checkpoint output. Eventually the need for this Nth Proc changing
hack (and Nth proc output itself) should go away when PIDX fully takes
over I/O.

Note, when using "Nth Process Output", both a checkpoint and a time step save
CANNOT occur on the same time step. Therefore the time step output is postponed
for one time step.

On a slightly different note, we use the term proc badly... we should use process,
or perhaps better yet, rank... as proc is usually taken to mean "processor", but
in MPI's case, means process - and the term MPI uses for process is rank.

D CCA/Ports/LoadBalancer.cc
D CCA/Ports/LoadBalancer.h
A + CCA/Ports/LoadBalancerPort.cc
A + CCA/Ports/LoadBalancerPort.h

- Renamed from LoadBalancer to LoadBalancerPort to avoid confusion with the LoadBalancer itself.
- Added "setNthProc()" so that the SimulationController can change the value as needed.

M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc

- Added postponeNextOutputTimestep(). This pushes off the output of a time step by one
time step. (This occurs if using Nth Process Output and a checkpoint and a time step
where to occur on the same time step.)
- Added savingAsPIDX() boolean query function so that the SimulationController
can avoid doing all of this hack when we are not using PIDX.
- Removed "getCurrentTimestep()" and "getCurrentTime()", as, per the documentation on them,
they should not be used anyway; you should get this info from the shared state. Note,
the DataArchiver name (getCurrentTime()) is different from the shared state name
(getElapsedTime()) which was also confusing.
- Pass const string parameters by reference.
- White space cleanup / alignments.

- If the input file has no <save> labels, but specifies an output interval, throw an exception.
- If the 'logname' is not available when running a simulation, put 'unknown' instead of ignoring.
Should probably find a better fix then 'unknown', but that will have to wait for another day.
- Swat some evil endls. :)
- Don't calculate 'currsecs' on every process, just on rank 0.
- Removed all calls to usingMPI() as Alan deprecated it in a recent commit.
- procOnLevel is (I hope) a boolean array... so declare and use it as such.
- Don't name a variable with a single letter. n -> var_cnt

- Did I mention white space cleanups... Please for the sake of older eyes...

M CCA/Components/ICE/ICE.cc
M CCA/Components/Models/FluidsBased/AdiabaticTable.cc
M CCA/Components/Models/FluidsBased/NonAdiabaticTable.cc
M CCA/Components/Models/FluidsBased/NonAdiabaticTable.h
M CCA/Components/Models/FluidsBased/SimpleRxn.cc
M CCA/Components/Models/FluidsBased/SimpleRxn.h
M CCA/Components/Models/Radiation/RMCRT/Radiometer.cc
M CCA/Components/OnTheFlyAnalysis/MinMax.cc
M CCA/Components/OnTheFlyAnalysis/1stLawThermo.cc
M CCA/Components/OnTheFlyAnalysis/containerExtract.cc
M CCA/Components/OnTheFlyAnalysis/lineExtract.cc
M CCA/Components/OnTheFlyAnalysis/momentumAnalysis.cc
M CCA/Components/OnTheFlyAnalysis/particleExtract.cc
M CCA/Components/OnTheFlyAnalysis/planeExtract.cc
M CCA/Components/OnTheFlyAnalysis/statistics.cc

- Use shared state getElapsedTime()
- Naming conventions: sharedState -> d_sharedState (to match other class vars in file).
- White space / alignments / etc.

M CCA/Components/LoadBalancers/CostProfiler.cc

- White space separation of #includes between CCA and Core

M CCA/Components/Arches/PressureSolverV2.cc
M CCA/Components/Arches/Radiation/RadPetscSolver.cc
M CCA/Components/Examples/Poisson2.cc
M CCA/Components/Examples/DOSweep.cc
M CCA/Components/Examples/RMCRT_Test.cc
M CCA/Components/Examples/RegridderTest.cc
M CCA/Components/Examples/SolverTest1.cc
M CCA/Components/FVM/ElectrostaticSolve.cc
M CCA/Components/ICE/impAMRICE.cc
M CCA/Components/ICE/impICE.cc
M CCA/Components/LoadBalancers/CostProfiler.h
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/MPM/AMRMPM.cc
M CCA/Components/MPM/ImpMPM.cc
M CCA/Components/MPM/SerialMPM.cc
M CCA/Components/Parent/Switcher.cc
M CCA/Components/ReduceUda/UdaReducer.h
M CCA/Components/ReduceUda/UdaReducer.cc
M CCA/Components/Regridder/RegridderCommon.h
M CCA/Components/Regridder/RegridderCommon.cc
M CCA/Components/Regridder/SingleLevelRegridder.cc

- LoadBalancer -> LoadBalancerPort
- White space cleanup / alignments.

M CCA/Components/LoadBalancers/LoadBalancerCommon.h
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc

- LoadBalancer -> LoadBalancerPort.
- Add setNthRank().
- getOutputProc() -> getOutputRank().
- Whitespace / alignment.
- Fix comment to indicate getOutputProc is returning an MPI rank.

M CCA/Components/LoadBalancers/ProfileDriver.h
M CCA/Components/LoadBalancers/ProfileDriver.cc
M CCA/Components/Regridder/TiledRegridder.cc
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/SchedulerCommon.h
M CCA/Components/Schedulers/SchedulerCommon.cc

- Cosmetics: Whitespace / alignment / coding standards / alphabetize #includes / etc.
- LoadBalancer -> LoadBalancerPort

M CCA/Components/Schedulers/OnDemandDataWarehouse.h
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
M CCA/Components/Schedulers/Relocate.h
M CCA/Components/Schedulers/Relocate.cc

- Name class variables according to naming convention. (eg: aborted -> d_aborted).
- Be consistent with naming convention of class variables in same file.
- LoadBalancer -> LoadBalancerPort.

M CCA/Components/Schedulers/TaskGraph.h
M CCA/Components/Schedulers/TaskGraph.cc

- LoadBalancer -> LoadBalancerPort.
- White space. Name variable "subset" more accurately: "handling_rank". I don't know
why it was named "subset" to begin with as it doesn't appear to be a "set" to me...

M CCA/Components/Schedulers/UnifiedScheduler.cc

- White space.

M CCA/Components/SimulationController/AMRSimulationController.cc

- There are a lot of cosmetic cleanups in this file, but the real/main change is:
- Add in hack to handle changing from "nth process output" (for checkpoints) to
"1 process output" (for time steps) when running with PIDX (and nth process is > 1).
- Declare variables (start) where they are used, not at the top of a function.
- Move the terminal output of the 0th timestep out of the main simulation loop.
- White space / alignment / etc.
- LoadBalancer -> LoadBalancerPort.

M CCA/Components/SimulationController/SimulationController.h
M CCA/Components/SimulationController/SimulationController.cc
M CCA/Components/Solvers/AMR/AMRSolver.cc
M CCA/Components/Solvers/AMR/HypreDriver.cc
M CCA/Components/Solvers/AMR/HypreDriverStruct.cc
M CCA/Components/Solvers/CGSolver.cc
M CCA/Components/Solvers/HypreSolver.cc
M CCA/Components/Wasatch/Expressions/Coordinate.cc
M CCA/Components/Wasatch/Expressions/PoissonExpression.cc
M CCA/Components/Wasatch/Expressions/Pressure.cc
M CCA/Components/Wasatch/Expressions/RadiationSource.cc
M CCA/Components/Wasatch/Wasatch.cc
M CCA/Ports/Scheduler.h
M CCA/Ports/sub.mk
M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc
M Core/Grid/Grid.h
M Core/Grid/Grid.cc
M Core/Grid/Level.h
M Core/Grid/Level.cc
M StandAlone/tools/uda2vis/uda2vis.cc

- LoadBalancer -> LoadBalancerPort.
- Cosmetic white space, alpha, etc.

M CCA/Ports/Output.h

- Removed getCurrentTimestep() and getCurrentTime() as the user should get
them from the shared state.
- Added postponeNextOutputTimestep().
- Added savingAsPIDX().



1136 lines of code changed in 124 files:

ahumphrey 2016-09-17 15:54 Rev.: 55755

Remove SingleProcessor Scheduler/LoadBalancer.

Most of the work here has been in removing the need for Parallel::determineIfRunningUnderMPI(), as running Uintah with MPI is now an invariant, even with only a single process. We ALWAYS run Uintah with MPI.

The last simple step will be to remove usage of Parallel::usingMPI() (which now simply returns true), and also do away with the "-mpi" command line option. Right now sus has been modified to silently ignore "-mpi" and once the nightly RT scripts have been modified, we can deprecate usage.

Note that the following examples of a single process run are synonymous and all use the MPI scheduler with 1 rank:

./sus input.ups
./sus -mpi input.ups
mpirun -np 1 ./sus input.ups
mpirun -np 1 ./sus -mpi input.ups

337 lines of code changed in 59 files:

zhouminmin 2016-09-15 14:49 Rev.: 55752

Fixed sign error in Thermophoresis model. This will break rt 1GW_RT.ups.

0 lines of code changed in 2 files:

tsaad 2016-09-15 14:02 Rev.: 55750

Fix failing wasatch RT. Check for WasatchDefs.h before looking for HAVE_POKITT

8 lines of code changed in 1 file:

ahumphrey 2016-09-15 13:37 Rev.: 55749

More concurrency work on MPI recv engine - also moving to straight mutex sync on task queues (no CrowdMonitor). Ultimately these queues need to be lock-free data structures.

Cleaned up ProcesorGroup, along with some other misc formatting/cleanup while under the hood.

Updates to tsan_suppression file

298 lines of code changed in 17 files:

cgritton 2016-09-15 11:31 Rev.: 55748

Currently contains the amprmpm functionality

211 lines of code changed in 3 files:

jas 2016-09-14 17:23 Rev.: 55747

Add missing MPMFVM library.

0 lines of code changed in 2 files:

harman 2016-09-14 16:30 Rev.: 55746

framework scripts:
- verify that all of the xml files are valid before trying to do anything with them.

Added a infrastructure raceTest tst file to kick up race conditions.


340 lines of code changed in 11 files:

dav 2016-09-13 14:37 Rev.: 55745

Add cyrus defs. Auto-download W3P source initially. Fix CMake cleaning.

28 lines of code changed in 8 files:

harman 2016-09-13 14:22 Rev.: 55744

added no_cuda tag to the OFC4 test.


5 lines of code changed in 1 file:

dav 2016-09-13 14:01 Rev.: 55743

Beat cmake with a stick to make it do what is requested. Update Titan specs

7 lines of code changed in 5 files:

dav 2016-09-13 13:45 Rev.: 55742

Add albion

21 lines of code changed in 1 file:

dav 2016-09-13 13:44 Rev.: 55741

add 'cuda' to the name of the install dir

1 lines of code changed in 1 file:

harman 2016-09-13 13:32 Rev.: 55740

Cover up.

Disable tests that won't run on a cuda build.

23 lines of code changed in 1 file:

harman 2016-09-13 09:53 Rev.: 55739

Don't use
--enable-sci-malloc
when running on cyrus.mech.

4 lines of code changed in 1 file:

jsutherland 2016-09-13 09:52 Rev.: 55738

Fix logic in the wasatch regression tests.
Thank you, Todd, for the fix!

1 lines of code changed in 1 file:

bisaac 2016-09-12 16:28 Rev.: 55737

Removed superfluous patch/intrusion intersection check as we have already done this with findRelevantIntrusions function. No impact on rt.

24 lines of code changed in 1 file:

harman 2016-09-12 16:23 Rev.: 55736

Added "no_cuda" option. Skip the test if this is a cuda enabled build.

Disabled Arches:coal_channel_hi_vel test, covering up a bug in Arches + radprops/tabprobs that causes the
nightly RT scripts to lockup.


18 lines of code changed in 16 files:

jsutherland 2016-09-12 15:36 Rev.: 55735

Add tests to be run when PoKiTT is enabled.

20 lines of code changed in 1 file:

cgritton 2016-09-12 12:28 Rev.: 55734

Updates to MPMFVM/sub.mk

11 lines of code changed in 2 files:

cgritton 2016-09-12 12:02 Rev.: 55733

Base set of files for the electrostatic mpm component

210 lines of code changed in 9 files:

ahumphrey 2016-09-12 09:58 Rev.: 55732

More concurrency work along with significant cleanup in DetailedTasks.

1518 lines of code changed in 7 files:

harman 2016-09-09 15:56 Rev.: 55731

pulled weeds

0 lines of code changed in 3 files:

harman 2016-09-09 14:28 Rev.: 55730

constructor
- Only execute cuda calls if 1) you have compiled with cuda and 2) you're using a device.


21 lines of code changed in 1 file:

harman 2016-09-09 13:56 Rev.: 55729

Added regression testing environmental variables

15 lines of code changed in 1 file:

harman 2016-09-09 08:46 Rev.: 55726

dead wood

0 lines of code changed in 1 file:

cgritton 2016-09-08 17:10 Rev.: 55724

Updated ElectrostaticSolve to handle multiple materials

541 lines of code changed in 17 files:

ahumphrey 2016-09-08 15:22 Rev.: 55722

More DependencyBatch concurrency improvements, std::atomic::compare_exchange_strong cleans up some dicey logic related to makeMPIRequest() and recieved().

Using std::memory_order_seq_cst for the strictest memory ordering. Might be able to relax this in the future.

Some other cleanup while under the hood.

234 lines of code changed in 7 files:

tsaad 2016-09-08 13:36 Rev.: 55721

cleanup the Wasatch RT tests. This may break the nightly RT.

8 lines of code changed in 1 file:

tsaad 2016-09-08 13:21 Rev.: 55720

add two varden tests for the new non-conservation form lowMach formulation. This new approach helps us avoid a Newton solve per grid point.

4 lines of code changed in 1 file:

jas 2016-09-08 11:36 Rev.: 55719

Turn off introspection.

1 lines of code changed in 1 file:

dav 2016-09-07 16:23 Rev.: 55714

Bullet proofing - must be using MPI if you want the Hypre solver.

0 lines of code changed in 2 files:

tsaad 2016-09-07 14:32 Rev.: 55713

Support the non-conservation form of the scalar equations for the low-Mach algorithm.

188 lines of code changed in 17 files:

ahumphrey 2016-09-07 12:29 Rev.: 55712

A few infrastructure concurrency fixes. Move DependencyBatch members to std::atomic, etc.

Arches - deafult initialize pointer members to nullptr, move member assignment to CTOR, remove using namespace std, add copyright header.

283 lines of code changed in 7 files:

bisaac 2016-09-07 11:22 Rev.: 55710

Added the first draft of the new wallht model. Shouldn't impact on regression tests.

252 lines of code changed in 6 files:

dav 2016-09-07 10:58 Rev.: 55708

Fix w3p gpu build. Somehow a '.' disappeared from the file name in previous commit.

2 lines of code changed in 1 file:

dav 2016-09-06 16:10 Rev.: 55707

Fix memory usage reporting bug on Vulcan/BGQ - the bug occurred when John cleaned out old checks (specifically _AIX) for the ProcessInfo::isSupported routine. _AIX apparently is a historical remnant (AIX was IBM's old OS) but works on BGQ machines and allowed isSupported to return true. I have replaced the previously used _AIX with __bgq__ which is more clear.

3 lines of code changed in 3 files:

dav 2016-09-06 15:11 Rev.: 55706

Be consistent in placement of HAVE_*.

2 lines of code changed in 1 file:

dav 2016-09-06 14:59 Rev.: 55705

These fortran files are not cuda dependent anymore - they depend on the .o file as before.

5 lines of code changed in 1 file:

dav 2016-09-06 12:58 Rev.: 55704


The main updates in this commit are to configure and the build system:
A number of bullet-proofing / clean-ups have been added to configure,
and the dependency of Arches on Wasatch has been removed. (Note,
Arches still needs to build TabProps/RadProps in the Wasatch 3P.) I
have tested this on several machines, but it is possible that it will
now catch some peoples' bad configure lines (that 'worked' before but
only accidentally). If your configure stops working because of this
commit, please let me know so I can help you fix it. -Dav

M configure
M configure.ac

- Force bad configure command line arguments to be errors instead of warnings.
This will help avoid users accidentally mis-typing an arg and not noticing.
The autoconf configure system does not normally allow this to happen as
their philosophy is that configure usually calls a sub-configure and passes
args down to it... Thus configure "ignores" bad args under the theory that
a "sub configure" will use them. However, we don't do this and this will
help catch configure command line typos and potentially save developers and
users a lot of headaches.

The bad news is that in order to get this functionality, we have
to hack the autconf'd generated configure script and add a
variable (enable_option_checking=fatal) at the top. I have added
a section to configure.ac with the information about doing this,
but anyone who re-generates configure needs to manually follow the
instructions.

- Configure now will immediately tell you if you have typed in an invalid
file/directory name (bad spelling, doesn't exist) for the --with flags.
Perviously this occurred manually each time (now it is part of the macro)
at the point in the configure script when the library was tested for.

- Fix handling of finding the C/C++ compilers and version checking better.
Configure now determines which compiler (eg: GCC, ICC, XLC) you are
using explicitly and can test for things (like version) appropriately.
The version check may still need to be updated a little.

- Updated the --with handling to know whether the flag was set or not. Previously
we were using a "" (blank) value, which was ambiguous.

- Flag --without as invalid on anything we don't explicitly handle (we
only handle without on a few things such as: --without-fortran or
--without-hypre).

- Allow the external Wasatch 3P to be specified on a single line (instead
of having a separate line for SpatialOps, ExprLib, etc) using
--with-wasatch3p=DIR. This will find all 4 W3P libs with one configure line.

- Got rid of IS_VS (wasn't set/used and don't know what it was for).

- While "no" and no (without quotes) are the same thing to configure, be consistent
and use "no" (with quotes) everywhere.

- Remove the BUILD_WASATCH_FOR_ARCHES logic, as we no longer need Wasatch to
be built for Arches.

- Clean up the left over files from relatively new MPI const test section.

- Fix the HAVE_ACCELERATE

- Update --enable-wasatch_3p to take a list of libs to build (in the case you only
wish to build a subset. Eg: --enable-wasatch_3p=radprops,tabprops
Pass list of libs to the build_wasatch_3p.sh script.

923 lines of code changed in 46 files:

derekhar 2016-09-06 12:24 Rev.: 55703

Changed call to abs to std::abs.

1 lines of code changed in 1 file:

harman 2016-09-02 16:31 Rev.: 55701

File that contains rules to remove false positive from normal tsan output. I'm not sure if this is the
right location in trunk for this.

27 lines of code changed in 1 file:

derekhar 2016-09-02 16:04 Rev.: 55700

Added Cloud Benchmark to arches-uintah.

242 lines of code changed in 11 files:

jsutherland 2016-09-02 15:32 Rev.: 55699

Add a file to be compiled through nvcc

2 lines of code changed in 1 file:

jsutherland 2016-09-02 15:23 Rev.: 55698

Accidentally committed this mystery file...

0 lines of code changed in 1 file:

jsutherland 2016-09-02 15:05 Rev.: 55697

Initial commit for support of coal models. This includes:
- 23 different coal types
- 4 different devolatilization models
- 4 different char oxidation/gasification models

The coal models require PoKiTT.

Removed several GPU runnable traits from expressions while we await framework support for particles on GPU

Josh McConnell was responsible for much of the heavy lifting to bring this code over from ODT, where it has been developed over the past few years.

16747 lines of code changed in 130 files:

banerjee 2016-09-01 20:34 Rev.: 55696

Added regression tests for Arena. The list is called ARENATESTS.

20 lines of code changed in 1 file:

dav 2016-09-01 17:40 Rev.: 55693

Fix bad line continuation

1 lines of code changed in 1 file:

harman 2016-09-01 10:25 Rev.: 55692

remove dependency on Wasatch library.
compiles with:
gcc dynamic
gcc static
gcc + cuda
clang dynamic



1 lines of code changed in 1 file:

August 2016 »

Generated by StatSVN 0.7.0