[root]/CCA/Components/Wasatch/Expressions
BoundaryConditions
(13 files, 2749 lines)
EmbeddedGeometry
(7 files, 913 lines)
MMS
(4 files, 1906 lines)
PBE
(11 files, 1909 lines)
Precipitation
(15 files, 2220 lines)
Particles
(11 files, 1588 lines)
PostProcessing
(13 files, 1716 lines)
TarAndSoot
(9 files, 770 lines)
Turbulence
(15 files, 2325 lines)
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 186 (100.0%) | 703 (100.0%) | 3.7 |
| jsutherland | 38 (20.4%) | 296 (42.1%) | 7.7 |
| tsaad | 43 (23.1%) | 268 (38.1%) | 6.2 |
| jas | 93 (50.0%) | 90 (12.8%) | 0.9 |
| dav | 7 (3.8%) | 40 (5.7%) | 5.7 |
| ahumphrey | 5 (2.7%) | 9 (1.3%) | 1.8 |
Add support for compressible Navier-Stokes Boundary Conditions (NSCBC) for the compressible algorithm.
This commit introduces several changes across wasatch:
1. Support for non reflecting boundaries, Hard Inlets, and Walls. We don't have a case working with Inlets yet.
2. Start migration towards a new BC specification method. This new approach requires a bit more programming, but removes ambiguity from stencil operations at the boundary as well as which mask points are to be used.
3. Use the speed sound in the calculation of the stable timestep when the compressible algorithm is switched on
4. Add regression tests for the NSCBCs
5. Various other changes that are to small to cite.
NOTE: The NSCBCs DO NOT work in parallel because of different dependencies on different patches. This will be addressed in future commits.
This commit will break the RT.
57 lines of code changed in 4 files:
More cleanup. Fixing some doxygen output and removing a few more warnings.
0 lines of code changed in 2 files:
Clean up numerous compiler warnings
1 lines of code changed in 1 file:
Commit on behalf of Josh McConnell.
Adds tar and soot transport equations, along with appropriate coupling to coal models.
1 lines of code changed in 2 files:
Update to conform to new ExprLib API.
7 lines of code changed in 13 files:
Enable GPU calculation with RadProps (in Wasatch).
Changes to RadProps consistent with API changes made in conjunction with this commit.
33 lines of code changed in 4 files:
The main changes in this commit only effect a simulation when <outputNthProc> is
set (> 1) in the .ups file.
This commit allows for PIDX output on every process for a time step
output, while using every Nth process (if so specified) for UDA
checkpoint output. Eventually the need for this Nth Proc changing
hack (and Nth proc output itself) should go away when PIDX fully takes
over I/O.
Note, when using "Nth Process Output", both a checkpoint and a time step save
CANNOT occur on the same time step. Therefore the time step output is postponed
for one time step.
On a slightly different note, we use the term proc badly... we should use process,
or perhaps better yet, rank... as proc is usually taken to mean "processor", but
in MPI's case, means process - and the term MPI uses for process is rank.
D CCA/Ports/LoadBalancer.cc
D CCA/Ports/LoadBalancer.h
A + CCA/Ports/LoadBalancerPort.cc
A + CCA/Ports/LoadBalancerPort.h
- Renamed from LoadBalancer to LoadBalancerPort to avoid confusion with the LoadBalancer itself.
- Added "setNthProc()" so that the SimulationController can change the value as needed.
M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc
- Added postponeNextOutputTimestep(). This pushes off the output of a time step by one
time step. (This occurs if using Nth Process Output and a checkpoint and a time step
where to occur on the same time step.)
- Added savingAsPIDX() boolean query function so that the SimulationController
can avoid doing all of this hack when we are not using PIDX.
- Removed "getCurrentTimestep()" and "getCurrentTime()", as, per the documentation on them,
they should not be used anyway; you should get this info from the shared state. Note,
the DataArchiver name (getCurrentTime()) is different from the shared state name
(getElapsedTime()) which was also confusing.
- Pass const string parameters by reference.
- White space cleanup / alignments.
- If the input file has no <save> labels, but specifies an output interval, throw an exception.
- If the 'logname' is not available when running a simulation, put 'unknown' instead of ignoring.
Should probably find a better fix then 'unknown', but that will have to wait for another day.
- Swat some evil endls. :)
- Don't calculate 'currsecs' on every process, just on rank 0.
- Removed all calls to usingMPI() as Alan deprecated it in a recent commit.
- procOnLevel is (I hope) a boolean array... so declare and use it as such.
- Don't name a variable with a single letter. n -> var_cnt
- Did I mention white space cleanups... Please for the sake of older eyes...
M CCA/Components/ICE/ICE.cc
M CCA/Components/Models/FluidsBased/AdiabaticTable.cc
M CCA/Components/Models/FluidsBased/NonAdiabaticTable.cc
M CCA/Components/Models/FluidsBased/NonAdiabaticTable.h
M CCA/Components/Models/FluidsBased/SimpleRxn.cc
M CCA/Components/Models/FluidsBased/SimpleRxn.h
M CCA/Components/Models/Radiation/RMCRT/Radiometer.cc
M CCA/Components/OnTheFlyAnalysis/MinMax.cc
M CCA/Components/OnTheFlyAnalysis/1stLawThermo.cc
M CCA/Components/OnTheFlyAnalysis/containerExtract.cc
M CCA/Components/OnTheFlyAnalysis/lineExtract.cc
M CCA/Components/OnTheFlyAnalysis/momentumAnalysis.cc
M CCA/Components/OnTheFlyAnalysis/particleExtract.cc
M CCA/Components/OnTheFlyAnalysis/planeExtract.cc
M CCA/Components/OnTheFlyAnalysis/statistics.cc
- Use shared state getElapsedTime()
- Naming conventions: sharedState -> d_sharedState (to match other class vars in file).
- White space / alignments / etc.
M CCA/Components/LoadBalancers/CostProfiler.cc
- White space separation of #includes between CCA and Core
M CCA/Components/Arches/PressureSolverV2.cc
M CCA/Components/Arches/Radiation/RadPetscSolver.cc
M CCA/Components/Examples/Poisson2.cc
M CCA/Components/Examples/DOSweep.cc
M CCA/Components/Examples/RMCRT_Test.cc
M CCA/Components/Examples/RegridderTest.cc
M CCA/Components/Examples/SolverTest1.cc
M CCA/Components/FVM/ElectrostaticSolve.cc
M CCA/Components/ICE/impAMRICE.cc
M CCA/Components/ICE/impICE.cc
M CCA/Components/LoadBalancers/CostProfiler.h
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/MPM/AMRMPM.cc
M CCA/Components/MPM/ImpMPM.cc
M CCA/Components/MPM/SerialMPM.cc
M CCA/Components/Parent/Switcher.cc
M CCA/Components/ReduceUda/UdaReducer.h
M CCA/Components/ReduceUda/UdaReducer.cc
M CCA/Components/Regridder/RegridderCommon.h
M CCA/Components/Regridder/RegridderCommon.cc
M CCA/Components/Regridder/SingleLevelRegridder.cc
- LoadBalancer -> LoadBalancerPort
- White space cleanup / alignments.
M CCA/Components/LoadBalancers/LoadBalancerCommon.h
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
- LoadBalancer -> LoadBalancerPort.
- Add setNthRank().
- getOutputProc() -> getOutputRank().
- Whitespace / alignment.
- Fix comment to indicate getOutputProc is returning an MPI rank.
M CCA/Components/LoadBalancers/ProfileDriver.h
M CCA/Components/LoadBalancers/ProfileDriver.cc
M CCA/Components/Regridder/TiledRegridder.cc
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/SchedulerCommon.h
M CCA/Components/Schedulers/SchedulerCommon.cc
- Cosmetics: Whitespace / alignment / coding standards / alphabetize #includes / etc.
- LoadBalancer -> LoadBalancerPort
M CCA/Components/Schedulers/OnDemandDataWarehouse.h
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc
M CCA/Components/Schedulers/Relocate.h
M CCA/Components/Schedulers/Relocate.cc
- Name class variables according to naming convention. (eg: aborted -> d_aborted).
- Be consistent with naming convention of class variables in same file.
- LoadBalancer -> LoadBalancerPort.
M CCA/Components/Schedulers/TaskGraph.h
M CCA/Components/Schedulers/TaskGraph.cc
- LoadBalancer -> LoadBalancerPort.
- White space. Name variable "subset" more accurately: "handling_rank". I don't know
why it was named "subset" to begin with as it doesn't appear to be a "set" to me...
M CCA/Components/Schedulers/UnifiedScheduler.cc
- White space.
M CCA/Components/SimulationController/AMRSimulationController.cc
- There are a lot of cosmetic cleanups in this file, but the real/main change is:
- Add in hack to handle changing from "nth process output" (for checkpoints) to
"1 process output" (for time steps) when running with PIDX (and nth process is > 1).
- Declare variables (start) where they are used, not at the top of a function.
- Move the terminal output of the 0th timestep out of the main simulation loop.
- White space / alignment / etc.
- LoadBalancer -> LoadBalancerPort.
M CCA/Components/SimulationController/SimulationController.h
M CCA/Components/SimulationController/SimulationController.cc
M CCA/Components/Solvers/AMR/AMRSolver.cc
M CCA/Components/Solvers/AMR/HypreDriver.cc
M CCA/Components/Solvers/AMR/HypreDriverStruct.cc
M CCA/Components/Solvers/CGSolver.cc
M CCA/Components/Solvers/HypreSolver.cc
M CCA/Components/Wasatch/Expressions/Coordinate.cc
M CCA/Components/Wasatch/Expressions/PoissonExpression.cc
M CCA/Components/Wasatch/Expressions/Pressure.cc
M CCA/Components/Wasatch/Expressions/RadiationSource.cc
M CCA/Components/Wasatch/Wasatch.cc
M CCA/Ports/Scheduler.h
M CCA/Ports/sub.mk
M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc
M Core/Grid/Grid.h
M Core/Grid/Grid.cc
M Core/Grid/Level.h
M Core/Grid/Level.cc
M StandAlone/tools/uda2vis/uda2vis.cc
- LoadBalancer -> LoadBalancerPort.
- Cosmetic white space, alpha, etc.
M CCA/Ports/Output.h
- Removed getCurrentTimestep() and getCurrentTime() as the user should get
them from the shared state.
- Added postponeNextOutputTimestep().
- Added savingAsPIDX().
9 lines of code changed in 5 files:
Support the non-conservation form of the scalar equations for the low-Mach algorithm.
97 lines of code changed in 7 files:
Support for GPU evaluation of tabular properties through TabProps.
Thanks to Babak for getting this ready.
15 lines of code changed in 2 files:
remove a cout statement
0 lines of code changed in 2 files:
Get rid of the SetCurrentTime expression. All Wasatch calculations of time related quantities (dt, t, tstep, rkstage...) take place in traditional Uintah tasks now. Access to these quantities is done via Expression Placeholders on SingleValueFields.
0 lines of code changed in 3 files:
Update Wasatch to use PerPatch<double> instead of PerPatch<double*>. This goes hand in hand with Brad's commit of yesterday as well as changes in ExprLib.
In addition, fix the updateCurrentTime task to avoid task dependency issues on GPU. This removes the dependence on SetCurrentTime.
12 lines of code changed in 1 file:
Fix a bad little bug on ScalarRHS where a source term would not be properly added.
3 lines of code changed in 1 file:
More species transport development:
- energy equation coupling with species in the diffusive flux treatment
- update wasatch spec to remove some superfluous entries. This also modified a number of the compressible tests
- use TagNames for temperature and heat flux
Bug fixes:
- use proper units on gas constant in density calculation.
- use proper units on gas constant in temperature calculation.
These bug fixes required changes to input files to get molecular weights in g/mol or kg/kmol.
Misc. formatting changes.
Note that this will cause diffs on several of the compressible tests due to the bug fix and naming change on temperature.
3 lines of code changed in 1 file:
First cut at species transport via PoKiTT
205 lines of code changed in 1 file:
Fix a bug when using the nonlinear solver for the density to avoid division by zero when the mixture fraction is zero.
Also store the relative error in the UnconvergedPts field.
15 lines of code changed in 2 files:
Replace usage of NULL macro (type int) with nullptr (pointer literal of type: nullptr_t).
nullptr is implicitly convertible and comparable to any pointer type or pointer-to-member type, but is not implicitly comparable to integral types, except that it is convertible to bool (explicitly).
9 lines of code changed in 5 files:
- Fix some doxygen.
- whitespace changes
9 lines of code changed in 6 files:
Fix the problem with fortran .h files (in Arches) not being generated correctly (on the binary
side) when CUDA is turned on.
Update the make system so that the dependency rules for CUDA enabled files are created
automatically. The user no-longer has to specify that each CUDA_ENABLED_SRCS .cu file
depends on the corresponding .cc file. Updated both Wasatch and Arches to use the
new approach.
M Makefile.in
- Add a 'function' (make-cuda-target) that will create CUDA dependency rules automatically,
instead of having the developer have to list the rules manually. This function must
be called in each sub.mk file that creates a CUDA_ENABLED_SRCS list.
- Remove all .cu and (mostly fortran) .h files from the <bin> side when
"make cleanreally" is called.
M configure
M configure.ac
- Put in check to verify that Uintah and Wasatch 3P are both (or neither) being
built with CUDA.
- Will also add Candera check once I get more info.
A include/sci_defs/wasatch_testdefs.h.in
- Place PoKitt and Candera defines in new (configure generated binary side) wasatch_defs.h
file.
M CCA/Components/Arches/sub.mk
- Fix fortran .h file dependency problem. Note, these dependencies are have been (and
continue to be) manually entered into the sub.mk file. However, previously, they
used multiple lines (eg: Source.$(OBJEXT) was written 5 times. You don't need to
do this, you can just list it once and then put all the files it depends on.
When building without CUDA, the fortran .h files are needed to create
the object files (eg: Source.o). However, if CUDA is turned on, then they are
needed to create the CUDA .cu file (eg: <bin>/Source.cu). Perviously, at least
on some machines (though the problem should have shown up on all machines?), the fortran
.h files were not being generated.
It appears that currently Arches/sub.mk is the only directory that has CUDA files that
are dependent on fortran .h files. If this occurs in other sub-dirs for Arches (as
CUDA is added to the code), then the same approach should be taken in those files.
M CCA/Components/Arches/ChemMix/sub.mk
M CCA/Components/Arches/CoalModels/sub.mk
M CCA/Components/Arches/LagrangianParticles/sub.mk
M CCA/Components/Arches/Operators/sub.mk
M CCA/Components/Arches/ParticleModels/sub.mk
M CCA/Components/Arches/PropertyModels/sub.mk
M CCA/Components/Arches/PropertyModelsV2/sub.mk
M CCA/Components/Arches/SourceTerms/sub.mk
M CCA/Components/Arches/Task/sub.mk
M CCA/Components/Arches/Transport/sub.mk
M CCA/Components/Arches/TransportEqns/sub.mk
M CCA/Components/Arches/Utility/sub.mk
M CCA/Components/Arches/WallHTModels/sub.mk
M CCA/Components/Wasatch/Expressions/BoundaryConditions/sub.mk
M CCA/Components/Wasatch/Expressions/MMS/sub.mk
M CCA/Components/Wasatch/Expressions/PostProcessing/sub.mk
M CCA/Components/Wasatch/Expressions/Turbulence/sub.mk
M CCA/Components/Wasatch/Expressions/sub.mk
M CCA/Components/Wasatch/Operators/sub.mk
M CCA/Components/Wasatch/Transport/sub.mk
M CCA/Components/Wasatch/sub.mk
- Call make system function make-cuda-target to generate CUDA .cu dependencies.
18 lines of code changed in 1 file:
Clean up some doxygen warnings.
19 lines of code changed in 5 files:
Fix the ability to make just Arches (--enable-arches instead of having to --enable-all-components).
M configure
M configure.ac
- Force the use of CMake 3.1+ if building Wasatch or VisIt).
- Add in RadProps info to W3P check.
M CCA/Components/Wasatch/Transport/sub.mk
M CCA/Components/Wasatch/Expressions/sub.mk
M CCA/Components/Wasatch/Operators/sub.mk
M CCA/Components/Arches/CoalModels/sub.mk
M CCA/Components/Arches/sub.mk
- Remove superfluous white space.
- Alphabetize.
- Fix comment typo (cut/paste error).
- Untabify (as appropriate).
M CCA/Components/Wasatch/sub.mk
- Same as above and:
- Fix the problem where CUDA_ENABLED_SRCS was not set if just building Arches.
- A number of files (eg: BCHelper.cc) were listed twice in the list of sources.
M Core/Grid/UnknownVariable.h
- Remove warning (Exception is now in the Uintah namespace so don't need to qualify it).
13 lines of code changed in 1 file:
One additional improvement to the Hypre solver interface:
Do NOT allocate/destroy grid every timestep unless necessary (timestep = 1, setupfrequency, restart).
Please let me know if you notice any speedups at large scale (32K+ cores).
0 lines of code changed in 1 file:
remove a cout statement
0 lines of code changed in 1 file:
1. Add expression that specifies a (structured) layout of spherical bubbles.
2. Cleanup some code and rename a few variables for clarity.
67 lines of code changed in 3 files:
Enable CUDA for the analytic density calculator.
6 lines of code changed in 1 file:
Move non-conflicting classes that were in SCIRun namespace to Uintah namespace.
36 lines of code changed in 12 files:
cleanup a bunch of header inclusions and move some code around to simplify operator usage
3 lines of code changed in 12 files:
remove a couple of annoying couts.
0 lines of code changed in 1 file:
This is embarrassing...
Fix several bugs in the refactor that was done for the compressible flow formulation:
1. Fix sign error for the dissipation function. Note that Wasatch computes the strain tensor and then constructs the stress tensor as needed on the fly. This was the source of the sign error issue. (Thanks to Mike Hansen who suspected an issue with the diffusive terms).
2. Fix how the stress tensor is calculated in the dissipation function. One must not forget to multiply the strain tensor by the viscosity and also subtract the dilatation from the normal strain.
3. This one is bad. The dilatation and the density were swapped in the construction of the stress tensor in the momentum rhs.
This commit will break every single Wasatch test that solves the Navier-Stokes equations.
11 lines of code changed in 5 files:
Update copyright date to 2016.
54 lines of code changed in 81 files: