Lines of Code
[root]/CCA/Components/Wasatch/Transport
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 237 (100.0%) | 8586 (100.0%) | 36.2 |
| jsutherland | 96 (40.5%) | 5137 (59.8%) | 53.5 |
| tsaad | 83 (35.0%) | 3293 (38.4%) | 39.6 |
| dav | 3 (1.3%) | 92 (1.1%) | 30.6 |
| jas | 45 (19.0%) | 32 (0.4%) | 0.7 |
| ahumphrey | 8 (3.4%) | 20 (0.2%) | 2.5 |
| mcconnell | 2 (0.8%) | 12 (0.1%) | 6.0 |
remove a few cout statements
0 lines of code changed in 2 files:
Add support for compressible Navier-Stokes Boundary Conditions (NSCBC) for the compressible algorithm.
This commit introduces several changes across wasatch:
1. Support for non reflecting boundaries, Hard Inlets, and Walls. We don't have a case working with Inlets yet.
2. Start migration towards a new BC specification method. This new approach requires a bit more programming, but removes ambiguity from stencil operations at the boundary as well as which mask points are to be used.
3. Use the speed sound in the calculation of the stable timestep when the compressible algorithm is switched on
4. Add regression tests for the NSCBCs
5. Various other changes that are to small to cite.
NOTE: The NSCBCs DO NOT work in parallel because of different dependencies on different patches. This will be addressed in future commits.
This commit will break the RT.
921 lines of code changed in 17 files:
More cleanup. Fixing some doxygen output and removing a few more warnings.
0 lines of code changed in 2 files:
Clean up numerous compiler warnings
34 lines of code changed in 20 files:
Clean up a few compiler warnings
1 lines of code changed in 2 files:
Commit on behalf of Josh McConnell.
Adds tar and soot transport equations, along with appropriate coupling to coal models.
1650 lines of code changed in 16 files:
Update Update due to PoKiTT API change
2 lines of code changed in 2 files:
Update SpeciesN due to changes in pokitt API.
2 lines of code changed in 1 file:
Support the non-conservation form of the scalar equations for the low-Mach algorithm.
18 lines of code changed in 5 files:
Add a file to be compiled through nvcc
2 lines of code changed in 1 file:
Initial commit for support of coal models. This includes:
- 23 different coal types
- 4 different devolatilization models
- 4 different char oxidation/gasification models
The coal models require PoKiTT.
Removed several GPU runnable traits from expressions while we await framework support for particles on GPU
Josh McConnell was responsible for much of the heavy lifting to bring this code over from ODT, where it has been developed over the past few years.
1329 lines of code changed in 10 files:
Fix a bug on heat capacity when PoKiTT is enabled, but we aren't running species transport.
3 lines of code changed in 1 file:
Tentative basic BC support for species until full NSCBC goes in.
Add an input file.
27 lines of code changed in 2 files:
- Add support for ASR preconditioner with species transport. Note that this doesn't treat chemical stiffness - only acoustic stiffness.
- Setup species transport regression tests
163 lines of code changed in 2 files:
More species transport development:
- energy equation coupling with species in the diffusive flux treatment
- update wasatch spec to remove some superfluous entries. This also modified a number of the compressible tests
- use TagNames for temperature and heat flux
Bug fixes:
- use proper units on gas constant in density calculation.
- use proper units on gas constant in temperature calculation.
These bug fixes required changes to input files to get molecular weights in g/mol or kg/kmol.
Misc. formatting changes.
Note that this will cause diffs on several of the compressible tests due to the bug fix and naming change on temperature.
370 lines of code changed in 14 files:
First cut at species transport via PoKiTT
669 lines of code changed in 7 files:
Replace usage of NULL macro (type int) with nullptr (pointer literal of type: nullptr_t).
nullptr is implicitly convertible and comparable to any pointer type or pointer-to-member type, but is not implicitly comparable to integral types, except that it is convertible to bool (explicitly).
20 lines of code changed in 8 files:
Fix failing build.
7 lines of code changed in 1 file:
Fix case-insensitive files system problem.
76 lines of code changed in 1 file:
Rearrange artificial compressibility to be outside the momentum equation spec. Also move the internal energy equation outside the momentum spec.
829 lines of code changed in 7 files:
Add the Acoustic Stiffness Reduction (ASR) model of Wang and Trouve for Artifical Compressibility. This model produces less effects on the magnitude of pressure waves when compares to PGS and is a natural fit for gravity-driven/dominated flows.
353 lines of code changed in 2 files:
Add the Pressure Gradient Scaling (PGS) Artificial Compressibility (AC) model. This rescales the acoustic speed to allow for near-advective CFLs.
253 lines of code changed in 4 files:
Fix the problem with fortran .h files (in Arches) not being generated correctly (on the binary
side) when CUDA is turned on.
Update the make system so that the dependency rules for CUDA enabled files are created
automatically. The user no-longer has to specify that each CUDA_ENABLED_SRCS .cu file
depends on the corresponding .cc file. Updated both Wasatch and Arches to use the
new approach.
M Makefile.in
- Add a 'function' (make-cuda-target) that will create CUDA dependency rules automatically,
instead of having the developer have to list the rules manually. This function must
be called in each sub.mk file that creates a CUDA_ENABLED_SRCS list.
- Remove all .cu and (mostly fortran) .h files from the <bin> side when
"make cleanreally" is called.
M configure
M configure.ac
- Put in check to verify that Uintah and Wasatch 3P are both (or neither) being
built with CUDA.
- Will also add Candera check once I get more info.
A include/sci_defs/wasatch_testdefs.h.in
- Place PoKitt and Candera defines in new (configure generated binary side) wasatch_defs.h
file.
M CCA/Components/Arches/sub.mk
- Fix fortran .h file dependency problem. Note, these dependencies are have been (and
continue to be) manually entered into the sub.mk file. However, previously, they
used multiple lines (eg: Source.$(OBJEXT) was written 5 times. You don't need to
do this, you can just list it once and then put all the files it depends on.
When building without CUDA, the fortran .h files are needed to create
the object files (eg: Source.o). However, if CUDA is turned on, then they are
needed to create the CUDA .cu file (eg: <bin>/Source.cu). Perviously, at least
on some machines (though the problem should have shown up on all machines?), the fortran
.h files were not being generated.
It appears that currently Arches/sub.mk is the only directory that has CUDA files that
are dependent on fortran .h files. If this occurs in other sub-dirs for Arches (as
CUDA is added to the code), then the same approach should be taken in those files.
M CCA/Components/Arches/ChemMix/sub.mk
M CCA/Components/Arches/CoalModels/sub.mk
M CCA/Components/Arches/LagrangianParticles/sub.mk
M CCA/Components/Arches/Operators/sub.mk
M CCA/Components/Arches/ParticleModels/sub.mk
M CCA/Components/Arches/PropertyModels/sub.mk
M CCA/Components/Arches/PropertyModelsV2/sub.mk
M CCA/Components/Arches/SourceTerms/sub.mk
M CCA/Components/Arches/Task/sub.mk
M CCA/Components/Arches/Transport/sub.mk
M CCA/Components/Arches/TransportEqns/sub.mk
M CCA/Components/Arches/Utility/sub.mk
M CCA/Components/Arches/WallHTModels/sub.mk
M CCA/Components/Wasatch/Expressions/BoundaryConditions/sub.mk
M CCA/Components/Wasatch/Expressions/MMS/sub.mk
M CCA/Components/Wasatch/Expressions/PostProcessing/sub.mk
M CCA/Components/Wasatch/Expressions/Turbulence/sub.mk
M CCA/Components/Wasatch/Expressions/sub.mk
M CCA/Components/Wasatch/Operators/sub.mk
M CCA/Components/Wasatch/Transport/sub.mk
M CCA/Components/Wasatch/sub.mk
- Call make system function make-cuda-target to generate CUDA .cu dependencies.
9 lines of code changed in 1 file:
Clean up some doxygen warnings.
56 lines of code changed in 9 files:
Fix the ability to make just Arches (--enable-arches instead of having to --enable-all-components).
M configure
M configure.ac
- Force the use of CMake 3.1+ if building Wasatch or VisIt).
- Add in RadProps info to W3P check.
M CCA/Components/Wasatch/Transport/sub.mk
M CCA/Components/Wasatch/Expressions/sub.mk
M CCA/Components/Wasatch/Operators/sub.mk
M CCA/Components/Arches/CoalModels/sub.mk
M CCA/Components/Arches/sub.mk
- Remove superfluous white space.
- Alphabetize.
- Fix comment typo (cut/paste error).
- Untabify (as appropriate).
M CCA/Components/Wasatch/sub.mk
- Same as above and:
- Fix the problem where CUDA_ENABLED_SRCS was not set if just building Arches.
- A number of files (eg: BCHelper.cc) were listed twice in the list of sources.
M Core/Grid/UnknownVariable.h
- Remove warning (Exception is now in the Uintah namespace so don't need to qualify it).
7 lines of code changed in 1 file:
Fix a bad bug in the SolverParameters base class that essentially set the Matrix setup frequency to 1 - ALWAYS. Unless the user specifies setupFrequency in the input file or the component developer casts the SolverParameters as a HypreSolver2Params, the setupFrequency is always set to 1. This likely impacted all Wasatch results that required a linear solver since Feb 2014. I think the setupFrequency should not be specified by the user from the input file. In addition, if the Matrix stencil is not changing, then there's no need to re-setup the matrix. Instead, I added a new option updateCoefFrequency that allows one to keep the Matrix structure intact but only update the coefficients. Test this via setUpdateCoefFrequency. I also added this option to the Uintah ups spec. This commit should not impact Arches simulations since Arches sets the setupFrequency through the input file. This commit will break many Wasatch RT tests with minor diffs.
3 lines of code changed in 1 file:
Do NOT setup the matrix every timestep for variable density flows.
Turns out that we really don't need to do that since our interface to Hypre will allow changing values while sparsity patterns are fixed.
This SHOULD put us back on track with scalability on the linear solver in Wasatch with varden problems.
1 lines of code changed in 1 file:
When the pressure solver is disabled, allow users to specify an expression for the pressure. This untangles a few knots related to the fact that the pressure expression requires access to Uintah-related information.
3 lines of code changed in 1 file:
GPU-ready particle operators. Commit on behalf of Dr. Babak Goshayeshi.
9 lines of code changed in 4 files:
Move non-conflicting classes that were in SCIRun namespace to Uintah namespace.
2 lines of code changed in 2 files:
untangle a mess of circular includes that was causing problems for GPU particle operators.
1139 lines of code changed in 13 files:
Fix a bug that showed up when using a GPU build in CPU-only mode.
5 lines of code changed in 1 file:
Make sure we get GPU versions of the pressure and density IC for compressible flows.
150 lines of code changed in 2 files:
support Lagrangian particle transport with compressible flows.
45 lines of code changed in 6 files:
fix a bug that prevents restarts on scalar transport
4 lines of code changed in 1 file:
add body force effects to the total internal energy equation.
Fix a bug in passing the body force tag to the compressible momentum equations.
44 lines of code changed in 4 files:
change the STATE of all transported quantities to STATE_NP1 rather than STATE_NONE.
This makes things consistent with the "state" nomenclature.
This commit will NOT change the answers. The failing RT is caused by my previous commit.
21 lines of code changed in 9 files:
Fix a serious bug in the compressible flow solver.
1. Problems with the units for the gas constant (universal/specific). Must use specific gas constant.
2. The default behavior for the transport equation is to compute the diffusive flux based on the transported variable. In the case of the totalInternalEnergy, use the temperature instead.
Thanks to Mike Hansen for helping out and providing comparison datasets.
10 lines of code changed in 1 file:
This is embarrassing...
Fix several bugs in the refactor that was done for the compressible flow formulation:
1. Fix sign error for the dissipation function. Note that Wasatch computes the strain tensor and then constructs the stress tensor as needed on the fly. This was the source of the sign error issue. (Thanks to Mike Hansen who suspected an issue with the diffusive terms).
2. Fix how the stress tensor is calculated in the dissipation function. One must not forget to multiply the strain tensor by the viscosity and also subtract the dilatation from the normal strain.
3. This one is bad. The dilatation and the density were swapped in the construction of the stress tensor in the momentum rhs.
This commit will break every single Wasatch test that solves the Navier-Stokes equations.
48 lines of code changed in 4 files:
Update copyright date to 2016.
30 lines of code changed in 43 files:
(5 more)