Lines of Code
[root]/CCA/Components/Arches/ParticleModels
| Author | Changes | Lines of Code | Lines per Change |
|---|---|---|---|
| Totals | 114 (100.0%) | 895 (100.0%) | 7.8 |
| jthornoc | 107 (93.9%) | 883 (98.7%) | 8.2 |
| ohdiazi | 2 (1.8%) | 8 (0.9%) | 4.0 |
| harman | 4 (3.5%) | 3 (0.3%) | 0.7 |
| milo | 1 (0.9%) | 1 (0.1%) | 1.0 |
Change 1:
Moved the RMCRT radiometer into it’s own spec. This creates a clean line between RMCRT as a radiation model
and RMCRT as a radiometer from the input perspective. Behind the scenes, not much changed as RMCRT as the
radiometer still functions as a source term.
Change 2:
Implemented doInterpolation in the trunk that Derek had introduced in the kokkos branch. This reduces code
clutter and hopefully makes merging easier to the kokkos branch.
3 lines of code changed in 2 files:
Removing cout.
0 lines of code changed in 2 files:
Commented cout.
1 lines of code changed in 1 file:
This commit fixes a failing test from my last commit (not running to completion) but breaks a bunch of new ones.
I’ve moved the RHS addition of the DQMOM source to DQMOMNoInversion where no DQMOM inversion is taking place. This consolidates some work and removes the need for an extra task. As such, this breaks Coal Production tests in the fuzz.
The Kokkos dqmom_example_char test also fails, but this appears because the source wasn’t being added in the correct place for Kokkos-DQMOM. Differences are small, however. This is still under development…
Also re-grouped the particle models into fewer, more intuitive groups.
Some other minor cleanup occurred.
83 lines of code changed in 9 files:
Initialize some variables to avoid garbage in extra cells.
Update box1.ups input file.
Remove convection calc in extra cells for tangential vel comps. (will
cause RT failure due to diffs in extra cells).
Other general cleanup.
73 lines of code changed in 1 file:
Find and replace all: "new_get_uintah_field" is now "get_field"
306 lines of code changed in 35 files:
Final (?) cleanup of old variable getters. Old variable getters are now
commented out in TaskVariableTools and new getters are used everywhere.
27 lines of code changed in 7 files:
Fifth replacement of variable getters from TaskVariableTools.
This commit hits some of the getters with irregular spacing (thanks
RegEx).
18 lines of code changed in 3 files:
Fourth replacement of variable getters from TaskVariableTools.
This commit comments out one of the older getters in TaskVariableTools.
Note also that this was the first commit to handle pointers with the new
method in some cases.
139 lines of code changed in 12 files:
Third replacement of variable getters from TaskVariableTools.
74 lines of code changed in 10 files:
Second replacement of variable getters from TaskVariableTools.
29 lines of code changed in 9 files:
First commit using the new variable getter in TaskVariableTools.
34 lines of code changed in 10 files:
Clearing up enum names.
13 lines of code changed in 3 files:
Removing the build_task function which is not needed anymore.
0 lines of code changed in 1 file:
Addressing multiple issues for the KokkosSolver in this commit:
1) Start with smarter naming of the Arches task names for easier debugging.
2) Clean up of code (removal of commented lines, etc)
3) Rearranging of a few things to facilitate heat loss calc. and table lookup
4) Trying to clean up some of the naming conventions in TransportFactory - more work needed
5) Starting to remove the build_all_tasks function and actually build them when initially parsing the input file to remove redundant parsing
6) Added a default momentum name
7) Removed some initialization loops in favor of the .initialize() function on grid variables. Hoping there will be kokkos/uintah backend support for this.
8) Added a “volumetric” scalar support - was there before but not explicitly.
9) Turning off computesWithScratchGhost in the dyn. model until the errant mpi errors can be sorted.
Answers on Kokkos Tests are affected because of one or more of the following:
- rho_star isn’t initialized at sched_Initialize to the density value. There was no value in doing this and it created a task ordering problem.
- Different numbers of variables in checkpoint
- Fuzz differences in the helium tests
Otherwise the grid refinement verification studies passed, which are run manually.
72 lines of code changed in 1 file:
Updating Char model with Salvatore's Iavarone changes.
2 lines of code changed in 1 file:
1. Char oxidation smith 2016 was deleted and char oxidation 2018 was renamed to CharOxidationSmith.
2. Char Oxidation model was renamed to CharOxidationSmithConstLv0. This is the first version of the smith char model and uses a constant particle diameter. This char model will not be used in production code, but it can be use for testing.
3. The following inputs files: mass_energy_balance, mass_energy_balance_Tfluid, mass_energy_balance_psnox, OFC_smith2016 (this file was rename to OFC_smith) and mass_energy_balance_psnox used the CharOxidationSmith2016 model, thus, they are updated to CharOxidationSmith (version of 2018). Therefore, RT is going to fail for these tests.
4. The input file OFC_smith was deleted.
5. The following input files use the original version of CharOxidationSmith (Named CharOxidationSmithConstLv0 after this commit): Coal_Nox,multibox_rmcrt_coal_1L, multibox_rmcrt_coal_2, multibox_rmcrt_coal_DO. The RT will not fail for these tests.
6 lines of code changed in 1 file:
Cleaning up print statements.
12 lines of code changed in 2 files:
minor change in the calculation of the density of deposits based on posrosity. No test is expected to break. Milo
1 lines of code changed in 1 file:
Updated Copyright date
2 lines of code changed in 3 files: