/trunk/src Developers: jthornoc

Login name:
jthornoc
Total Commits:
764 (9.0%)
Lines of Code:
7,343 (7.7%)
Most Recent Commit:
2019-12-13 17:36
Tweet this:
Tweet this

Activity by Clock Time

Activity by Hour of Day for jthornoc

Activity by Day of Week for jthornoc

Activity in Directories

Directory Changes Lines of Code Lines per Change
Totals 764 (100.0%) 7343 (100.0%) 9.6
CCA/Components/Arches/Transport/ 104 (13.6%) 1402 (19.1%) 13.4
CCA/Components/Arches/PropertyModelsV2/ 135 (17.7%) 1253 (17.1%) 9.2
CCA/Components/Arches/ 90 (11.8%) 1243 (16.9%) 13.8
CCA/Components/Arches/TurbulenceModels/ 93 (12.2%) 1070 (14.6%) 11.5
CCA/Components/Arches/ParticleModels/ 107 (14.0%) 883 (12.0%) 8.2
CCA/Components/Arches/Task/ 56 (7.3%) 469 (6.4%) 8.3
CCA/Components/Arches/Utility/ 65 (8.5%) 389 (5.3%) 5.9
CCA/Components/Arches/SourceTerms/ 14 (1.8%) 210 (2.9%) 15.0
CCA/Components/Arches/SourceTermsV2/ 33 (4.3%) 148 (2.0%) 4.4
R_Tester/ 4 (0.5%) 87 (1.2%) 21.7
CCA/Components/Arches/BoundaryConditions/ 15 (2.0%) 74 (1.0%) 4.9
CCA/Components/Arches/LagrangianParticles/ 9 (1.2%) 52 (0.7%) 5.7
CCA/Components/Arches/ChemMixV2/ 12 (1.6%) 47 (0.6%) 3.9
CCA/Components/Arches/ChemMix/ 12 (1.6%) 15 (0.2%) 1.2
CCA/Components/Arches/TransportEqns/ 2 (0.3%) 1 (0.0%) 0.5
Core/Geometry/ 2 (0.3%) 0 (0.0%) 0.0
CCA/Ports/ 2 (0.3%) 0 (0.0%) 0.0
CCA/Components/Arches/CoalModels/ 9 (1.2%) 0 (0.0%) 0.0

Activity of jthornoc

Most Recent Commits

jthornoc 2019-12-13 17:36 Rev.: 59902

Like the explicit solver, only allow CFD to execute on the finest level.

0 lines of code changed in 4 files:

  • CCA/Components/Arches: KokkosSolver.cc (changed), KokkosSolver.h (new)
jthornoc 2019-12-13 11:33 Rev.: 59896

Change 1:
Moved the RMCRT radiometer into it’s own spec. This creates a clean line between RMCRT as a radiation model
and RMCRT as a radiometer from the input perspective. Behind the scenes, not much changed as RMCRT as the
radiometer still functions as a source term.

Change 2:
Implemented doInterpolation in the trunk that Derek had introduced in the kokkos branch. This reduces code
clutter and hopefully makes merging easier to the kokkos branch.

120 lines of code changed in 15 files:

  • CCA/Components/Arches: ExplicitSolver.cc (new), GridTools.h (+31)
  • CCA/Components/Arches/ParticleModels: FaceParticleVel.h (+3 -20)
  • CCA/Components/Arches/PropertyModelsV2: CCVel.cc (+3 -18), FaceVelocities.cc (+9 -45), VarInterpolation.h (+1 -14)
  • CCA/Components/Arches/SourceTerms: SourceTermFactory.cc (+53 -3), SourceTermFactory.h (+1 -1)
jthornoc 2019-12-03 14:47 Rev.: 59871

Removing cout.

0 lines of code changed in 2 files:

  • CCA/Components/Arches/ParticleModels: DQMOMNoInversion.cc (new)
jthornoc 2019-12-03 14:46 Rev.: 59870

This commit fixes the failure-to-run-to-completion error for test isotropic_p4_dynsmag_32 per my commit revision 59865. However, this commit creates new comparison errors with these three tests:

isotropic_p4_dynsmag_32
isotropic_p4_wale_32
isotropic_p4_sigma_32

The decay spectrum however, looks reasonably accurate and nearly identical to previous results so I am chalking this one up to fuzz diffs.

Other minor cleanup here and there.

89 lines of code changed in 13 files:

  • CCA/Components/Arches: ExplicitSolver.cc (+21 -11), ExplicitSolver.h (+2), TurbulenceModelPlaceholder.cc (new)
  • CCA/Components/Arches/TurbulenceModels: DSFT.cc (+53 -6), DSFT.h (+6 -6), DSmaCs.h (new), WALE.cc (+1 -1)
jthornoc 2019-12-02 15:04 Rev.: 59865

Fixing a DW bug with the DYN model.

20 lines of code changed in 6 files:

  • CCA/Components/Arches/TurbulenceModels: DSFT.cc (+8 -8), DSmaCs.h (+2 -19), DSmaMMML.h (+4 -28), TurbulenceModelFactory.cc (new)
jthornoc 2019-12-02 14:59 Rev.: 59864

Test commit - added a line separator.

0 lines of code changed in 2 files:

  • CCA/Components/Arches: Arches.cc (new)
jthornoc 2019-11-22 23:53 Rev.: 59850

These tests need some work to conform to my last commit. Turning them
off for now.

2 lines of code changed in 1 file:

  • R_Tester: ARCHES.py (+2 -2)
jthornoc 2019-11-22 17:46 Rev.: 59849

This commit fixes a failing test from my last commit (not running to completion) but breaks a bunch of new ones.

I’ve moved the RHS addition of the DQMOM source to DQMOMNoInversion where no DQMOM inversion is taking place. This consolidates some work and removes the need for an extra task. As such, this breaks Coal Production tests in the fuzz.

The Kokkos dqmom_example_char test also fails, but this appears because the source wasn’t being added in the correct place for Kokkos-DQMOM. Differences are small, however. This is still under development…

Also re-grouped the particle models into fewer, more intuitive groups.

Some other minor cleanup occurred.

137 lines of code changed in 21 files:

  • CCA/Components/Arches: DQMOM.cc (new), ExplicitSolver.cc (+12 -8), KokkosSolver.cc (+16 -13)
  • CCA/Components/Arches/ParticleModels: CoalDensity.cc (+4 -6), DQMOMNoInversion.cc (+42 -42), DQMOMNoInversion.h (+3 -2), ParticleModelFactory.cc (new), ParticleModelFactory.h (new)
  • CCA/Components/Arches/Task: TaskFactoryBase.cc (new), TaskFactoryBase.h (new)
  • CCA/Components/Arches/Transport: TransportFactory.cc (new), TransportFactory.h (-1)
jthornoc 2019-11-20 16:46 Rev.: 59838

Removed the work performed in timestep_init for scalars and rellocated
it into the eval function conditioned on the timestep.

Cleaned up some task names to include Class origin.

Reconfigured the GridIndStudyTemp.py file with a little more generality.

61 lines of code changed in 3 files:

  • CCA/Components/Arches/Transport: KScalarRHS.h (+48 -65), TransportFactory.cc (+13 -11)
jthornoc 2019-11-18 16:05 Rev.: 59832

Initialize some variables to avoid garbage in extra cells.
Update box1.ups input file.
Remove convection calc in extra cells for tangential vel comps. (will
cause RT failure due to diffs in extra cells).
Other general cleanup.

93 lines of code changed in 7 files:

  • CCA/Components/Arches/ParticleModels: FaceParticleVel.h (+73 -62)
  • CCA/Components/Arches/PropertyModelsV2: UnweightVariable.h (+4 -2)
  • CCA/Components/Arches/Transport: KFEUpdate.h (new), KScalarRHS.h (+5 -12), TransportFactory.cc (+9 -2)
jthornoc 2019-11-15 16:00 Rev.: 59827

Adding the option of saving out specific radiation intensities.
Updated an RT input file which will cause this test to fail due to the
addition of new saved variables.

0 lines of code changed in 8 files:

  • CCA/Components/Arches: UPSHelper.cc (new), UPSHelper.h (new)
  • CCA/Components/Arches/SourceTerms: DORadiation.cc (changed), DORadiation.h (changed)
jthornoc 2019-11-06 16:01 Rev.: 59796

Remove all traces of get_unmanaged field getters.

1 lines of code changed in 7 files:

  • CCA/Components/Arches/PropertyModelsV2: spectralProperties.cc (new)
  • CCA/Components/Arches/Task: FieldContainer.h (-32), SampleTask.cc (new), TaskVariableTools.h (new)
jthornoc 2019-11-06 15:50 Rev.: 59795

Remove use of unmanaged field getter.

12 lines of code changed in 1 file:

  • CCA/Components/Arches/PropertyModelsV2: spectralProperties.cc (+12 -11)
jthornoc 2019-10-30 15:01 Rev.: 59764

Spacing/returns on DOUT.

2 lines of code changed in 1 file:

  • CCA/Components/Arches/Task: TaskFactoryBase.cc (+2 -2)
jthornoc 2019-10-29 13:02 Rev.: 59758

Getting rid of a warning and use of a macro.

0 lines of code changed in 4 files:

  • CCA/Components/Arches/Transport: StressTensor.cc (changed), StressTensor.h (new)
jthornoc 2019-10-29 12:13 Rev.: 59757

Find and replace all: "new_get_uintah_field" is now "get_field"

1206 lines of code changed in 159 files:

  • CCA/Components/Arches/BoundaryConditions: BoundaryFunctors.h (new), HandOff.h (+5 -5)
  • CCA/Components/Arches/ChemMixV2: ColdFlowProperties.cc (+7 -7), ConstantStateProperties.cc (+4 -4)
  • CCA/Components/Arches/ParticleModels: BodyForce.h (+4 -4), Burnout.cc (+9 -9), CharOxidationps.h (+41 -41), CoalDensity.cc (+10 -10), CoalTemperature.cc (new), Constant.h (new), DQMOMNoInversion.cc (+4 -4), DepositionEnthalpy.cc (new), DepositionVelocity.cc (new), DragModel.h (+16 -16), ExampleParticleModel.h (new), FOWYDevol.h (new), FaceParticleVel.h (+12 -12), PartVariablesDQMOM.cc (+7 -7), RateDeposition.cc (new), ShaddixEnthalpy.h (new), ShaddixOxidation.h (+27 -27), TotNumDensity.cc (+4 -4), WDragModel.h (+21 -21)
  • CCA/Components/Arches/PropertyModelsV2: BurnsChriston.cc (+14 -14), CCVel.cc (+12 -12), CO.cc (+33 -33), ConsScalarDiffusion.cc (new), ConstantProperty.h (new), ContinuityPredictor.cc (+6 -6), DensityPredictor.cc (+11 -11), DensityRK.cc (new), DensityStar.cc (+8 -8), Drhodt.cc (new), FaceVelocities.cc (+21 -21), GasKineticEnergy.cc (+5 -5), OneDWallHT.cc (new), UFromRhoU.cc (+14 -14), UnweightVariable.h (+21 -21), VarInterpolation.h (+3 -3), VariableStats.cc (new), WallHFVariable.cc (+32 -32), cloudBenchmark.cc (new), gasRadProperties.cc (+5 -5), partRadProperties.cc (+28 -28), sootVolumeFrac.cc (+4 -4), spectralProperties.cc (+7 -7), sumRadiation.cc (+3 -3)
  • CCA/Components/Arches/SourceTermsV2: GravityA.cc (new), MMS_Shunn.h (new), MMS_ShunnP3.h (+8 -8), MMS_mom.h (new), MMS_mom_csmag.h (new), MMS_scalar.cc (+10 -10)
  • CCA/Components/Arches/Task: SampleTask.cc (+9 -9), TaskVariableTools.h (+2 -2), TemplatedSampleTask.h (new)
  • CCA/Components/Arches/Transport: AddPressGradient.cc (+8 -8), ComputePsi.h (+11 -11), Diffusion.h (+9 -9), KFEUpdate.h (+12 -12), KMomentum.h (+24 -24), KScalarRHS.h (+31 -31), PressureBC.cc (new), PressureEqn.cc (+17 -17), StressTensor.cc (+19 -19), TimeAve.h (new), VelRhoHatBC.cc (+6 -6)
  • CCA/Components/Arches/TurbulenceModels: DSFT.cc (+39 -39), DSmaCs.h (+14 -14), DSmaMMML.h (+31 -31), FractalUD.cc (+60 -60), MultifractalSGS.cc (+55 -55), SGSforTransport.cc (+15 -15), SGSsigma.cc (+16 -16), Smagorinsky.cc (new), WALE.cc (+13 -13), WallConstSmag.cc (+9 -9)
  • CCA/Components/Arches/Utility: AlmgrenMMS.h (new), FileInit.h (new), GridInfo.cc (new), InitLagrangianParticleVelocity.cc (new), MassFlowRate.cc (new), ShunnMMS.h (+3 -3), ShunnMMSP3.h (+4 -4), SurfaceNormals.cc (new), SurfaceVolumeFractionCalc.cc (new), TaskAlgebra.h (new), TaylorGreen3D.h (new), WaveFormInit.h (+2 -2)
jthornoc 2019-10-29 12:12 Rev.: 59756

Updating these two files as there was a problem with a git merge and my
earlier commits. This should preserve Todds commit with the updated
variable getters.

109 lines of code changed in 2 files:

  • CCA/Components/Arches/PropertyModelsV2: partRadProperties.cc (+81 -81), sumRadiation.cc (+28 -28)
jthornoc 2019-10-29 12:12 Rev.: 59755

Redefine these as not static.

144 lines of code changed in 4 files:

  • CCA/Components/Arches: UPSHelper.cc (+135), UPSHelper.h (+7 -116), sub.mk (new)
jthornoc 2019-10-29 12:12 Rev.: 59754

Removing old variable getters for good.

0 lines of code changed in 1 file:

  • CCA/Components/Arches/Task: TaskVariableTools.h (-52)
jthornoc 2019-10-29 12:12 Rev.: 59753

Final (?) cleanup of old variable getters. Old variable getters are now
commented out in TaskVariableTools and new getters are used everywhere.

171 lines of code changed in 21 files:

  • CCA/Components/Arches/BoundaryConditions: BoundaryFunctors.h (+5 -10)
  • CCA/Components/Arches/ChemMixV2: ColdFlowProperties.cc (+2 -3)
  • CCA/Components/Arches/ParticleModels: CharOxidationps.h (+1 -1), DepositionEnthalpy.cc (+4 -8), DepositionVelocity.cc (+3 -6), PartVariablesDQMOM.cc (+4 -8), RateDeposition.cc (+11 -11), ShaddixEnthalpy.h (+2 -2), TotNumDensity.cc (+2 -4)
  • CCA/Components/Arches/PropertyModelsV2: DensityPredictor.cc (+2 -4), UFromRhoU.cc (+2 -2), UnweightVariable.h (+9 -10), gasRadProperties.cc (+38 -41), spectralProperties.cc (+24 -27)
  • CCA/Components/Arches/Task: TaskVariableTools.h (+43 -43)
  • CCA/Components/Arches/Transport: KScalarRHS.h (+3 -26), StressTensor.cc (+1 -1), VelRhoHatBC.cc (+6 -6)
  • CCA/Components/Arches/TurbulenceModels: MultifractalSGS.cc (+3 -3), SGSforTransport.cc (+6 -12), SGSsigma.cc (-7)

(65 more)

Generated by StatSVN 0.7.0