[root]/CCA/Components/Arches/SourceTerms
Author | Changes | Lines of Code | Lines per Change |
---|---|---|---|
Totals | 42 (100.0%) | 1624 (100.0%) | 38.6 |
harman | 28 (66.7%) | 1414 (87.1%) | 50.5 |
jthornoc | 14 (33.3%) | 210 (12.9%) | 15.0 |
Change 1:
Moved the RMCRT radiometer into it’s own spec. This creates a clean line between RMCRT as a radiation model
and RMCRT as a radiometer from the input perspective. Behind the scenes, not much changed as RMCRT as the
radiometer still functions as a source term.
Change 2:
Implemented doInterpolation in the trunk that Derek had introduced in the kokkos branch. This reduces code
clutter and hopefully makes merging easier to the kokkos branch.
54 lines of code changed in 4 files:
sched_initialize()
calling sched_initialize_VarLabel() instead of sched_initialize_sigmaT4()
0 lines of code changed in 2 files:
*.ups
- changed label from abskt -> absk, to cut down on the confusion. The user can specify any
absorption coefficient.
Arches/SourceTerms/RMCRT.*
- renamed variables m_abskt -> m_absk_*
Arches/PropertyModelsV2/sumRadiation.cc
- problemSetup()
Added some confusing code to only add absk_name to the vector of names if it's unique.
We need to clearly define what abskt is and stick with that definition.
12 lines of code changed in 3 files:
Adding the option of saving out specific radiation intensities.
Updated an RT input file which will cause this test to fail due to the
addition of new saved variables.
0 lines of code changed in 4 files:
Replaced VarLabel::find( name) with VarLabel::find( name, exceptionMesg ).
Spacing.
23 lines of code changed in 1 file:
VarLabel.*
Added a version of find() that throws an exception if the VarLabel isn't found. This will
reduce the bulletproofing clutter in the app codes.
RMCRT.*
- Implemented the sigmaT4 task that includes particle temperatures and absk. This is different
from the RMCRT::sigmaT4()
- Variable name changes.
- removed dead code.
- added m_matlSet variable.
345 lines of code changed in 2 files:
Collapse the code that sets the boundary conditions on the intensity into 1 function.
3 lines of code changed in 1 file:
SourceTerms/DORadiation.*
- Ordinate loops changed variable name ix to ord.
- doSweepAdvanced: deleted unused variable in prototype
DORadiationModel:
- Removed dead global variables or code that does nothing
- transition to using m_ for all global/member variables
- eliminated bool flags describing what to use for an initial guess. Now using single var with enums.
- defaults for global vars are specified in the header file, not randomly through out the code.
- Ordinate loops changed variable name ix to ord.
- removed BoundaryCondition(), it's empty.
- If the scope of a variable is within a task/function define it there, not in the header file.
- Standardized global label names to _<name>_label
- Remove intensitysolveSweepOptimizedOld() it's not called.
- defined m_gn = Ghost::None, use that throughout.
26 lines of code changed in 2 files:
- Variable name changes:
my_stringstream_object -> labelName
direcn -> dir
- Moved accessor code from .cc to the .h file
- Created global variables m_matls and m_matIdx and eliminated the redundant calls to allMaterials("Arches"_
- Using pre existing labels instead of VarLabel::find(X)
- created helper function to compute the intensity index. No need for
ix + iband *_DO_model->getIntOrdinates()
all over the place.
183 lines of code changed in 2 files:
Formatting!!!
405 lines of code changed in 2 files:
Changed member naming convenction from _varName -> m_varName.
255 lines of code changed in 2 files:
Formatted the output from RMCRT so it's not a jumbled mess at the start of the run.
Removed superfulous VR in xml tags
VRViewAngle -> viewAngle
VROrientation -> orientation
VRLocationsMin -> locationsMin
VRLocationsMax -> locationsMax
Deleted deprecated code from OnTheFly radiometer.
** This commit shouldn't change the answers.
7 lines of code changed in 1 file:
Arches/RMCRT
- Added restart hack task so the radiation temperature can be used in a computation.
Radiometer is now computing the intensity.
59 lines of code changed in 2 files:
BoundaryCondition::sched_create_radiation_temperature()
- check all patches that a rank owns for the existence of a radiation_temp in the new_dw. This is hackish
RMCRT_Radiation::sched_restartInitialize()
- fixed memory leak
3 lines of code changed in 1 file:
RMCRT.cc
sched_restartInitialize(): combined conditional statements. No longer computing _tempLabel, that's been
moved to create_radiation_tempHack task.
BoundaryCondition*
added create_radiation_temperatureHack()
simplified sched_create_radiation_temperatur()
ExplicitSolver.cc
Passing restart flag into sched_create_radiation_temperature()
Added call to sched_create_radiation_temperature() so the radiation_temperature
is computed on a restart.
6 lines of code changed in 1 file:
Bolt RMCRT:Virtual Radiometer directly to Arches.
Arches/SourceTerms/RMCRT*
- Added radiometerOnly section to computeSources() task.
- minor polishing
RMCRT/*.cc *.h
- Renamed initializeRadVars -> initialize_VRFlux() task and pulled out the carry forward code.
- Added initialize_sigmaT4() task
Updated ups spec.
84 lines of code changed in 2 files:
Updating the psNOx model.
Aside from some minor aesthetic changes, the tar
split is adjusted in the case that the light gas splits
cannot achived the overall pyrolosis split defined in Tillman.
Also, the defaults were adjusted to match the inputs from the
latest V/UQ round.
This commit breaks the mass_energy_balance_psnox.ups test.
135 lines of code changed in 5 files:
Cleaning up print statements.
21 lines of code changed in 1 file:
Updated Copyright date
3 lines of code changed in 4 files: