Directory CCA/Components/Arches/SourceTermsV2/

Lines of Code

Developers

Most Recent Commits

jthornoc 2019-10-29 12:13 Rev.: 59757

Find and replace all: "new_get_uintah_field" is now "get_field"

56 lines of code changed in 12 files:

• CCA/Components/Arches/SourceTermsV2: GravityA.cc (+8 -8), MMS_Shunn.h (+14 -14), MMS_ShunnP3.h (+8 -8), MMS_mom.h (new), MMS_mom_csmag.h (new), MMS_scalar.cc (+10 -10)

jthornoc 2019-10-29 12:12 Rev.: 59752

Fifth replacement of variable getters from TaskVariableTools.
This commit hits some of the getters with irregular spacing (thanks
RegEx).

10 lines of code changed in 3 files:

• CCA/Components/Arches/SourceTermsV2: GravityA.cc (+2 -2), MMS_ShunnP3.h (+5 -5), MMS_scalar.cc (+3 -3)

jthornoc 2019-10-29 12:12 Rev.: 59751

Fourth replacement of variable getters from TaskVariableTools.
This commit comments out one of the older getters in TaskVariableTools.
Note also that this was the first commit to handle pointers with the new
method in some cases.

11 lines of code changed in 5 files:

• CCA/Components/Arches/SourceTermsV2: MMS_Shunn.h (+3 -3), MMS_ShunnP3.h (+2 -2), MMS_mom.h (+2 -2), MMS_mom_csmag.h (+2 -2), MMS_scalar.cc (+2 -2)

jthornoc 2019-10-29 12:12 Rev.: 59750

Third replacement of variable getters from TaskVariableTools.

11 lines of code changed in 4 files:

• CCA/Components/Arches/SourceTermsV2: GravityA.cc (+6 -6), MMS_Shunn.h (+3 -3), MMS_ShunnP3.h (+1 -1), MMS_scalar.cc (+1 -1)

jthornoc 2019-10-29 12:11 Rev.: 59749

Second replacement of variable getters from TaskVariableTools.

24 lines of code changed in 4 files:

• CCA/Components/Arches/SourceTermsV2: MMS_Shunn.h (+8 -8), MMS_mom.h (+4 -4), MMS_mom_csmag.h (+8 -8), MMS_scalar.cc (+4 -4)

jthornoc 2019-10-22 12:41 Rev.: 59729

Clearing up enum names.

10 lines of code changed in 1 file:

• CCA/Components/Arches/SourceTermsV2: GravityA.cc (+10 -10)

jthornoc 2019-09-27 20:48 Rev.: 59667

Removing the build_task function which is not needed anymore.

0 lines of code changed in 2 files:

• CCA/Components/Arches/SourceTermsV2: SourceTermFactoryV2.cc (-27)

jthornoc 2019-06-26 15:17 Rev.: 59487

Addressing multiple issues for the KokkosSolver in this commit:

1) Start with smarter naming of the Arches task names for easier debugging.
2) Clean up of code (removal of commented lines, etc)
3) Rearranging of a few things to facilitate heat loss calc. and table lookup
4) Trying to clean up some of the naming conventions in TransportFactory - more work needed
5) Starting to remove the build_all_tasks function and actually build them when initially parsing the input file to remove redundant parsing
6) Added a default momentum name
7) Removed some initialization loops in favor of the .initialize() function on grid variables. Hoping there will be kokkos/uintah backend support for this.
8) Added a “volumetric” scalar support - was there before but not explicitly.
9) Turning off computesWithScratchGhost in the dyn. model until the errant mpi errors can be sorted.

Answers on Kokkos Tests are affected because of one or more of the following:

- rho_star isn’t initialized at sched_Initialize to the density value. There was no value in doing this and it created a task ordering problem.
- Different numbers of variables in checkpoint
- Fuzz differences in the helium tests

Otherwise the grid refinement verification studies passed, which are run manually.

26 lines of code changed in 2 files:

• CCA/Components/Arches/SourceTermsV2: MMS_ShunnP3.h (-2), SourceTermFactoryV2.cc (+26 -36)