[root]/CCA/Components/Arches/Transport
Author | Changes | Lines of Code | Lines per Change |
---|---|---|---|
Totals | 112 (100.0%) | 1408 (100.0%) | 12.5 |
jthornoc | 104 (92.9%) | 1402 (99.6%) | 13.4 |
harman | 6 (5.4%) | 6 (0.4%) | 1.0 |
jholmen | 2 (1.8%) | 0 (0.0%) | 0.0 |
This commit fixes a failing test from my last commit (not running to completion) but breaks a bunch of new ones.
I’ve moved the RHS addition of the DQMOM source to DQMOMNoInversion where no DQMOM inversion is taking place. This consolidates some work and removes the need for an extra task. As such, this breaks Coal Production tests in the fuzz.
The Kokkos dqmom_example_char test also fails, but this appears because the source wasn’t being added in the correct place for Kokkos-DQMOM. Differences are small, however. This is still under development…
Also re-grouped the particle models into fewer, more intuitive groups.
Some other minor cleanup occurred.
6 lines of code changed in 4 files:
Removed the work performed in timestep_init for scalars and rellocated
it into the eval function conditioned on the timestep.
Cleaned up some task names to include Class origin.
Reconfigured the GridIndStudyTemp.py file with a little more generality.
61 lines of code changed in 3 files:
Initialize some variables to avoid garbage in extra cells.
Update box1.ups input file.
Remove convection calc in extra cells for tangential vel comps. (will
cause RT failure due to diffs in extra cells).
Other general cleanup.
16 lines of code changed in 4 files:
Getting rid of a warning and use of a macro.
0 lines of code changed in 4 files:
Find and replace all: "new_get_uintah_field" is now "get_field"
146 lines of code changed in 19 files:
Final (?) cleanup of old variable getters. Old variable getters are now
commented out in TaskVariableTools and new getters are used everywhere.
10 lines of code changed in 3 files:
Fifth replacement of variable getters from TaskVariableTools.
This commit hits some of the getters with irregular spacing (thanks
RegEx).
9 lines of code changed in 2 files:
Fourth replacement of variable getters from TaskVariableTools.
This commit comments out one of the older getters in TaskVariableTools.
Note also that this was the first commit to handle pointers with the new
method in some cases.
51 lines of code changed in 9 files:
Third replacement of variable getters from TaskVariableTools.
64 lines of code changed in 10 files:
Second replacement of variable getters from TaskVariableTools.
9 lines of code changed in 2 files:
First commit using the new variable getter in TaskVariableTools.
13 lines of code changed in 4 files:
Clearing up enum names.
15 lines of code changed in 4 files:
Fixing an issue where two enums had the same name causing undefined
behavior with the compiled exe.
14 lines of code changed in 3 files:
Compact grid variable getters with a variadic option.
0 lines of code changed in 1 file:
Warnings.
3 lines of code changed in 1 file:
Encapsulating the Sandbox and SSPRK solvers a little better.
Added a test of the linear solver in the Sandbox and cleared out what was there before.
46 lines of code changed in 4 files:
Removing the build_task function which is not needed anymore.
0 lines of code changed in 1 file:
Initialize variables to zero in the extra cell to get RT passing.
4 lines of code changed in 1 file:
Clean up a leak.
2 lines of code changed in 1 file:
* Replaced tabs with spaces.
0 lines of code changed in 2 files:
Minor cleanup. Added additional output variables for helium_rk1.ups.
4 lines of code changed in 2 files:
Consolidate the FE update into one class.
27 lines of code changed in 5 files:
Removing the storage of the ProblemSpec from the Unweight function. This
was leftover from the last large commit.
9 lines of code changed in 1 file:
Addressing multiple issues for the KokkosSolver in this commit:
1) Start with smarter naming of the Arches task names for easier debugging.
2) Clean up of code (removal of commented lines, etc)
3) Rearranging of a few things to facilitate heat loss calc. and table lookup
4) Trying to clean up some of the naming conventions in TransportFactory - more work needed
5) Starting to remove the build_all_tasks function and actually build them when initially parsing the input file to remove redundant parsing
6) Added a default momentum name
7) Removed some initialization loops in favor of the .initialize() function on grid variables. Hoping there will be kokkos/uintah backend support for this.
8) Added a “volumetric” scalar support - was there before but not explicitly.
9) Turning off computesWithScratchGhost in the dyn. model until the errant mpi errors can be sorted.
Answers on Kokkos Tests are affected because of one or more of the following:
- rho_star isn’t initialized at sched_Initialize to the density value. There was no value in doing this and it created a task ordering problem.
- Different numbers of variables in checkpoint
- Fuzz differences in the helium tests
Otherwise the grid refinement verification studies passed, which are run manually.
891 lines of code changed in 15 files:
Putting braces on an if statement to avoid the infamous goto fail bug.
2 lines of code changed in 1 file:
Updated Copyright date
6 lines of code changed in 6 files: