December 2014 Commit Log

Number of Commits:
99
Number of Active Developers:
11
derekhar 2014-12-29 15:56 Rev.: 52906

Added more statements to inform users of bad input.

0 lines of code changed in 2 files:

derekhar 2014-12-29 15:20 Rev.: 52905

Added additional bullet-proofing for parsing the input file.

0 lines of code changed in 2 files:

jthornoc 2014-12-29 11:24 Rev.: 52904

Add back in missing files from Dav's commit r52897.

626 lines of code changed in 4 files:

jthornoc 2014-12-29 11:24 Rev.: 52903

Recommitting Arches changes that were reverted by Dav's commit, r52897.

0 lines of code changed in 48 files:

harman 2014-12-29 10:32 Rev.: 52902

RMCRT_Test.cc
- The user can specify RMCRT:float or RMCRT:double.
problemSetup()
- added BC_bulletproofing
- added bulletproofing to catch if the the user is trying to save abskg but
it doesn't exist. The component hands RMCRT abskg but internally RMCRT:float
uses abskgRMCRT.

Ray.cc & RMCRTCommon.cc
Global:
setBC()
Added an additional template parameter. This parameter is used to fake out
the BC infrastructure when CCVariable<float> are being passed in. The infrastructure
doesn't handle floats. Thanks James.

0 lines of code changed in 10 files:

harman 2014-12-29 09:54 Rev.: 52901

ScheduleTimeAdvance()
- added sched_DoubleToFloat() for the type conversion of abskg.

0 lines of code changed in 2 files:

harman 2014-12-29 09:35 Rev.: 52899

Added method to Search through the saved labels in the ups:DataArchive section and return true if variable is found
This is useful for subcomponents & models.

0 lines of code changed in 4 files:

jsutherland 2014-12-27 08:36 Rev.: 52898

Cleanup on some BC related stuff. More substantive changes in the works for variable density treatment.

0 lines of code changed in 10 files:

dav 2014-12-26 21:01 Rev.: 52897

Reverting code to r52880 before my memory use fix commit. While most tests passed, the ones using AMR and the dynamic load balancer were not passing and the weeds are too deep within them to quickly figure out what is causing the problems. Next week I will attempt to figure out what is going on with them. My guess is that it will take quite a bit of effort to understand the inner workings of the dynamic loadbalancer in order to get everything to work, so it may be quite a while before this fix may go in.

4414 lines of code changed in 193 files:

dav 2014-12-26 11:43 Rev.: 52896

Fix so puda will run - some libs now use proc0cout which requires Uintah::Parallel to be initialized (even if we are not running MPI).

5 lines of code changed in 1 file:

u0407585 2014-12-24 16:17 Rev.: 52894

This sets particle temperature to gas temperature if we have small weights. It will break one of the coal regression tests with minimal changes.

50 lines of code changed in 2 files:

jsutherland 2014-12-24 11:53 Rev.: 52893

Cleanup on some BC related stuff. More substantive changes in the works for variable density treatment.

111 lines of code changed in 5 files:

u0407585 2014-12-24 10:27 Rev.: 52892

Added Tognotti's Devolatilization model. This will not impact regression tests.

435 lines of code changed in 4 files:

dav 2014-12-23 20:17 Rev.: 52889


Finishing cleaning up the memory reduction commit... Main fix
was to add "delete d_archive" back to SimulationController.cc.

M CCA/Components/SimulationController/SimulationController.cc

- Add back in "delete d_archive"... This still needs to be investigated.

M CCA/Components/LoadBalancers/CostProfiler.cc
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc

- Remove warning: numLevels is unsigned now.
- Cosmetics: coding standard, white space, {}s, etc

M Core/Grid/Patch.cc
M CCA/Components/Schedulers/DWDatabase.h
M CCA/Components/Schedulers/MPIScheduler.cc
M CCA/Components/Schedulers/OnDemandDataWarehouse.cc

- Cosmetics: line up variables, untabify, coding standard, white space, {}s, etc

M CCA/Components/Schedulers/SchedulerCommon.cc

- Remove warning: numLevels is unsigned now.

257 lines of code changed in 8 files:

jthornoc 2014-12-23 16:20 Rev.: 52888

Adding a constant property/env model.
Also added a constant density dmqom test case.

212 lines of code changed in 4 files:

derekhar 2014-12-23 15:59 Rev.: 52887

Fixed a bad merge from a previous commit.

3 lines of code changed in 1 file:

derekhar 2014-12-23 15:36 Rev.: 52885

Added an additional particle model for radiation. The constant complex-index-refraction model. Decoupled the particle temperature from the gas temperature for radiation.

529 lines of code changed in 17 files:

dav 2014-12-23 00:29 Rev.: 52884

Hopefully this fixes errors from the previous larege memory use reduction commit.

M CCA/Components/SimulationController/SimulationController.cc

- I need to investigate the delete of the temporary data archive... Commenting it out for now.

M CCA/Components/DataArchiver/DataArchiver.cc

- White space clean up.
- Removed a releaseDocument() that should not have been there. (The release happens
automatically when the var goes out of scope.)

M Core/Grid/Grid.cc

- Handle periodic boundaries in the input xml file.

65 lines of code changed in 3 files:

dav 2014-12-22 17:18 Rev.: 52883


Two minor fixes to get Mac and GPU builds compiling after previous major commit.

M CCA/Components/Schedulers/DetailedTasks.cc

- Minor fix (variable name change) for GPU only code.

M Core/ProblemSpec/sub.mk

- Remove extra Core/Exceptions. Add needed Core/Math. (Found on Mac)

4 lines of code changed in 2 files:

dav 2014-12-22 15:49 Rev.: 52882


This is the first commit (of what may be several over the next month or so) dealing with Uintah's excessive use
of memory with respect to its XML data structures (that are used for I/O) when running on thousands of patches.
This commit specificly addresses the excessive use of memory when restarting a simulation. Before this commit,
Uintah would read in a timestep.xml file (from the checkpoints/t00000/) directory and create an huge DOM
structure in memory. (On 8K patches on Vulcan (BGQ - LLNL) memory per process would increase by 100% (by
20 MB per process on the advect sample problem). On 30K patches, memory use of 200 MB or more has been observed.)
To solve this problem, instead of reading the XML into memory, we parse it on the fly and extract the data we need,
but do not save it. Note, there are two parts of the timestep.xml file that cause the memory issue: the 1000s of
<Grid> and <DataItem> tags. Small XML nodes are not a problem, and thus we still use them for some things (for
example, the component section read from the timestep.xml file. A full DOM of this node is created (during the
streaming read of the rest of the file) and this node is passed down to the component as before.

A number of changes in this commit are cosmetic, dealing with white space and coding standards, and were made
while I was digging through the code to understand where the memory issue was and how to fix it. To better
see real changes in the code, I highly suggest that you use a diff that ignores generic white space changes,
such as:

svn diff --diff-cmd diff --extensions -w <file_name>

Note,asIgetolderInolongercanreadtextlikethis,soIamaddingspacesintothecodetomakeit easier to see. :)

M CCA/Components/SimulationController/AMRSimulationController.cc

- Number of levels in a Grid (grid->numLevels()) cannot be negative and thus should be an unsigned int... it is now.
- Costmetic: English sentences start with capital letters and end with punctuation... yeah yeah I know.

M CCA/Components/SimulationController/SimulationController.cc

- queryGrid: pass through a pointer, don't create a new copy.
- Unsigned int for grid level number.
- Cosmetic white space/coding standards/English updates. Fixed some strange indentation. Untabify.

M CCA/Components/Parent/Switcher.cc

- Unsigned int for grid level number.
- Cosmetic: Swatted some evil endl's. :) (Why write 8 more characters of code, when 2 will do? And makes it easier to add to strings later...)

M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.h

- Updates to consolidate code in load balancers... Still needs some direct attention as opposed to this
first pass while working on something else.

M CCA/Components/LoadBalancers/SingleProcessorLoadBalancer.h

- Add 'do-nothing' implementation of restartInitialize() to this class.

M CCA/Components/LoadBalancers/CostModelForecaster.cc

- Cosmetic: Untabbify, white space, {} around one line ifs, English.

M CCA/Components/LoadBalancers/DynamicLoadBalancer.h
M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc

- Moved restartInitialize() (and a number of supporting class d_ variables) into LoadBalancerCommon.
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English.

M CCA/Components/LoadBalancers/ProfileDriver.cc
M CCA/Components/LoadBalancers/CostModeler.h

- grid->numLevels() is now unsigned updates.
- Coding standard cleanups / English / white space.

M CCA/Components/LoadBalancers/LoadBalancerCommon.cc

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
- Make global DebugStream variables be less global (made static to file).
- Unsigned int for grid level number.
- Move restartInitialize() from DynamicLoadBalancer and ParticleLoadBalancer (code was exact duplicate in both files) here.

M CCA/Components/Solvers/AMR/AMRSolver.cc

- Cosmetic: White space, line up variables, English.
- Unsigned int for grid level number.

M CCA/Components/DataArchiver/DataArchiver.cc
M CCA/Components/DataArchiver/DataArchiver.h

- Comment added for where next XML memory fix should take place.
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M CCA/Ports/ProblemSpecInterface.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.h
M CCA/Components/ProblemSpecification/ProblemSpecReader.cc

- Created new version of readInputFile() which takes a list of patches that are specific to this processor. However,
I don't think anyone (me?) is using it yet, and I'm actually not convinced that it is the right function to fix
(see comments in code). I'm committing it just in case it turns out that we need it as we fix the rest of the
XML memory bloat issues. However, at that point if it turns out not to be useful, it should be removed.

M CCA/Components/Schedulers/TaskGraph.h
M CCA/Components/Schedulers/TaskGraph.cc

- Add some consistency to the member variable naming in this file. Half the variables use d_, and the other half
have a trailing _, and the third half ;) didn't do either one... sigh. Some examples.

lb -> d_lb
dts_ -> d_dts

- A few cosmetic fixes - variable line up, white space, etc.
- Removed var/matl from lb->getOldProcessorAssignment()... need to verify that this is correct... see above.

M CCA/Components/Schedulers/OnDemandDataWarehouse.cc

- Removed unused parameters to lb->getOldProcessorAssignment(). However, the DynamicLoadBalancer still uses the
version with parameters (though it doesn't really need them either). It is unclear why getOldProcessorAssignment()
is not declared in LoadBalancerCommon common or several of the other Load Balancers, and also unclear which function
is actually being called. This is defined in the LoadBalancer.h in CCA/Ports/. This needs more investigation.

M CCA/Components/Schedulers/DetailedTasks.h
M CCA/Components/Schedulers/DetailedTasks.cc

- Almost all cosmetic, white space, untabbify, lining up vars, English, etc changes.
- Add trailing _ to numPendingInternalDependencies to denote member var.

M CCA/Components/Schedulers/MPIScheduler.cc

- Few cosmetic cleanups.

M CCA/Components/Schedulers/SchedulerCommon.cc
M StandAlone/tools/pfs/rawToUniqueGrains.cc
M StandAlone/tools/puda/PIC.cc
M StandAlone/tools/extractors/extractV.cc
M StandAlone/tools/extractors/extractF.cc
M StandAlone/tools/extractors/partextract.cc
M StandAlone/partvarRange.cc
M StandAlone/tools/puda/jim1.cc
M StandAlone/tools/puda/jim3.cc
M StandAlone/tools/puda/varsummary.cc
M StandAlone/tools/puda/puda.cc
M StandAlone/tools/puda/POL.cc
M StandAlone/slb.cc

- Cosmetic white space fixes.
- numLevels() casts to avoid warnings.

M CCA/Components/Arches/Radiation/RadHypreSolver.cc

- Few cosmetic changes.

M CCA/Components/Regridder/RegridderCommon.cc
M CCA/Components/Regridder/SingleLevelRegridder.cc
M CCA/Components/Regridder/TiledRegridder.cc

- Cosmetic white space fixes.
- numLevels() casts to avoid warnings.

M CCA/Ports/Output.h

- Use const vars when possible.
- White space, English.

M CCA/Ports/LoadBalancer.h

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M Core/OS/Dir.h
M Core/OS/Dir.cc
M Core/OS/Dir_boost.cc

- Use 'const' when variables don't change.
- Cosmetic: line up variables, untabbify, white space, {} around one line ifs, English.
- Don't use "std::" in half the file and not in the other half.

M Core/Grid/Patch.h
M Core/Grid/Patch.cc

- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English.

M Core/Grid/Grid.h
M Core/Grid/Grid.cc

- Added readLevelsFromFile(), parseLevelFromFile(), and parseGridFromFile() to parse XML without creating a full DOM.
This provides a 50% memory decrease (per process) on Vulcan (LLNL-BGQ) for 8K processors when restarting the
advect problem. At some point in the future it might be nice to replace my (brute force - straightfoward -
assumes that the input xml file is very well behaved) approach with the streaming reader functions from the
lib xml library. This is not done at this point as it is unclear how well that library will fit into our use
case, how much time it will take to convert to, and the fact that we want to get this pushed out to the users asap.
- Cosmetic: Line up variables, untabbify, white space, {} around one line ifs, English, coding standards.
- numLevels is now an unsigned int.

M Core/Grid/Task.cc

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M Core/Grid/SimulationState.h
M Core/Grid/SimulationState.cc

- Cosmetic: Alphabetize/sort #includes.

M Core/Grid/Level.h
M Core/Grid/Level.cc

- Returned patch from addPatch() is not used anywhere so remove the return type.
- Cosmetic: line up variables, untabbify, white space, {} around one line ifs, English.

M Core/Geometry/Vector.h
M Core/Geometry/Vector.cc

- Added the fromString() function.
- Cosmetic: Alphabetize/sort #includes.

M Core/Geometry/IntVector.h
M Core/Geometry/IntVector.cc

- Added the fromString() function.

M Core/Containers/HashTable.h

- Moved the call to first() into the constructor... Not quite sure what the reason for this is,
but everywhere a HashTable is created, "first()" is immediately called, so it makes sense
to just do it in once place instead of having to do it each time it is used.

D Core/Containers/StringUtil.cc
D Core/Containers/StringUtil.h
A + Core/Util/StringUtil.h
A + Core/Util/StringUtil.cc
M Core/Grid/SimulationTime.cc
M Core/Tracker/TrackerServer.cc
M Core/Persistent/Pstreams.cc
M Core/Persistent/Persistent.cc
M Core/Util/FileUtils.cc

- Moved StringUtil.* to Core/Util/ to all its use in other locations (higher up the build tree).

M Core/Containers/sub.mk

- Untabbify.

M Core/DataArchive/DataArchive.h
M Core/DataArchive/DataArchive.cc

- Rename variables so they are readable, eg: d_tsurl becomes d_ts_path_and_filename, d_tstimes becomes d_ts_times, etc.
- Change a few more functions to parse xml file data on the fly (instead of parsing DOMs), eg: queryEndiannessAndBits()
- Use NULL instead of 0.
- Pass strings as 'const &' instead of copying them every time.
- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.

M Core/ProblemSpec/ProblemSpec.h
M Core/ProblemSpec/ProblemSpec.cc

- Added constructor to take in a string buffer to create a new DOM from. (Use: stream parse an xml file and put the
needed pieces into a string, then turn only that information into a DOM.)
- Added routines to help in the stream parsing of an XML file: findBlock()
- checkForInputError() replaced.
- parseIntVector replaced with fromString() in respective files.

M Core/Util/DynamicLoader.cc

- Alphabetize #includes.

M Core/Util/sub.mk

- Alphabetize

A Core/Util/XMLUtils.h
A Core/Util/XMLUtils.cc

- Added new helper functions for parsing xml files on the fly.

M StandAlone/compare_uda.cc

- Cosmetic: Alphabetize/sort #includes, line up variables, untabbify, white space, {} around one line ifs, English.
- numLevels() is unsigned now.
- Bulletproofing - verify input args are actually directories.

M StandAlone/restart_merger.cc

- Minor cosmetic fixes.

M StandAlone/sus.cc

- Bulletproofing - catch case when user accidentally runs sus with a UDA and not a UPS.

4453 lines of code changed in 82 files:

harman 2014-12-22 12:57 Rev.: 52880

Multi-level RMCRT:
- removed maxLevels == 1 from the conditional.

This won't change the answers.

4 lines of code changed in 3 files:

harman 2014-12-22 11:38 Rev.: 52879

- Removed global variables/methods that aren't being used.

- No longer computing sigmaT4 or cellType on non-arches levels
That's handled by RMCRT.

This won't change the answers.

24 lines of code changed in 3 files:

jthornoc 2014-12-20 00:46 Rev.: 52877

Fix another bad merge.
Remote a dbg print statement.

0 lines of code changed in 3 files:

jthornoc 2014-12-20 00:45 Rev.: 52876

Fix some mistakes during merge.

0 lines of code changed in 3 files:

jthornoc 2014-12-20 00:45 Rev.: 52875

Set lower bound on temperature to 273 instead of 290.

1 lines of code changed in 1 file:

jthornoc 2014-12-20 00:45 Rev.: 52874

Made Coal regression tests have consistent boundary conditions and
initial conditions.

20 lines of code changed in 3 files:

jthornoc 2014-12-20 00:45 Rev.: 52873

Fixed the remaining regression tests so that they at least run.

0 lines of code changed in 2 files:

jthornoc 2014-12-20 00:44 Rev.: 52872

Made the 2 regression test work, and dqmom_test_1. Modified radiation
files so that they are compatible with new coal data base, and new
labels.

49 lines of code changed in 5 files:

jthornoc 2014-12-20 00:44 Rev.: 52871

Syntax bug.

1 lines of code changed in 1 file:

jthornoc 2014-12-20 00:44 Rev.: 52870

Fixed particle temperature labels, so they are consistent with the new
particle temperature calculation.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:44 Rev.: 52869

Fixed a failed merge and used Derek's latest version of RadProperties
from svn tree.

3 lines of code changed in 2 files:

jthornoc 2014-12-20 00:44 Rev.: 52868

Removed Ben print statements. Added Yamamotodevol changes. Made
coal_channel work. Eddited radiation files to fix bugs. Fixed Enthalpy
shadix radiation bug.

49 lines of code changed in 3 files:

jthornoc 2014-12-20 00:43 Rev.: 52867

adding abskp varlable to enthalpy shaddix

51 lines of code changed in 1 file:

jthornoc 2014-12-20 00:43 Rev.: 52866

Fix some compiler errors.
Remove git test commit to demonstrate the awesomeness that is Git.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:43 Rev.: 52865

testing commits

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:43 Rev.: 52864

Adding in Ben\'s commits, which update the models to the non-time-lagged
version. Several other modification were made in these changes to aid in
fixing the time-lag problem.

-Jeremy and Ben

7 lines of code changed in 5 files:

jthornoc 2014-12-20 00:43 Rev.: 52863

Removing test comment/commit.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:42 Rev.: 52862

test commit.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:42 Rev.: 52861

Test commit.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:42 Rev.: 52860

test commit.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:42 Rev.: 52859

Removing test commit.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:42 Rev.: 52858

Test commit.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:42

Merge conflicts.

35 lines of code changed in 6 files:

jthornoc 2014-12-20 00:41 Rev.: 52855

add comment for derek.

1 lines of code changed in 1 file:

jthornoc 2014-12-20 00:41 Rev.: 52854

Removed Ben print statements. Added Yamamotodevol changes. Made
coal_channel work. Eddited radiation files to fix bugs. Fixed Enthalpy
shadix radiation bug.

226 lines of code changed in 12 files:

jthornoc 2014-12-20 00:41 Rev.: 52853

adding abskp varlable to enthalpy shaddix

53 lines of code changed in 1 file:

jthornoc 2014-12-20 00:41 Rev.: 52852

Fix some compiler errors.
Remove git test commit to demonstrate the awesomeness that is Git.

5 lines of code changed in 3 files:

jthornoc 2014-12-20 00:40 Rev.: 52851

testing commits

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:40 Rev.: 52850

Adding in Ben\'s commits, which update the models to the non-time-lagged
version. Several other modification were made in these changes to aid in
fixing the time-lag problem.

-Jeremy and Ben

1801 lines of code changed in 39 files:

jthornoc 2014-12-20 00:40 Rev.: 52849

Removing test comment/commit.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:39 Rev.: 52848

test commit.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:39 Rev.: 52847

Test commit.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:39 Rev.: 52846

Adding a coal density computer.

3 lines of code changed in 1 file:

jthornoc 2014-12-20 00:39 Rev.: 52845

test commit.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:39 Rev.: 52844

Removing test commit.

0 lines of code changed in 1 file:

jthornoc 2014-12-20 00:39 Rev.: 52843

Test commit.

2 lines of code changed in 1 file:

jthornoc 2014-12-20 00:38 Rev.: 52841

Merge conflicts.

313 lines of code changed in 17 files:

jthornoc 2014-12-20 00:38 Rev.: 52840

Add a nominal value for the abscissa.

6 lines of code changed in 2 files:

jthornoc 2014-12-20 00:38 Rev.: 52839

Merge conflicts.

381 lines of code changed in 18 files:

jthornoc 2014-12-20 00:37 Rev.: 52838

Adding a coal density property model for use in all coal models.

41 lines of code changed in 3 files:

jthornoc 2014-12-20 00:37 Rev.: 52837

Adding a coal density computer.

333 lines of code changed in 4 files:

jthornoc 2014-12-20 00:37 Rev.: 52836

Merging conflict with SVN head.

108 lines of code changed in 7 files:

jthornoc 2014-12-20 00:36 Rev.: 52835

Fix a ghost issue on the MOM RHS construction.

0 lines of code changed in 2 files:

harman 2014-12-19 16:44 Rev.: 52833

DataArchive: Added
// Does a variable exist on a patch at this timestep?
bool exists( const std::string& varname,
const Patch* patch,
const int timeStep );

compare_uda:
- Added bulletproofing to catch if a variable doesn't exist in both udas
on a timestep. This plugs a hole/bug that existed when
<outputInitTimestep>
was set and the variables saved in the udas differed during t0000.

60 lines of code changed in 3 files:

harman 2014-12-19 14:26 Rev.: 52832

Global d_sigmaT4_label -> d_sigmaT4Label (consistency with the rest of the global labels)


RMCRT_test.cc/.h
- component defines either float or dbl RMCRT
- d_abskgLabel -> d_comp(onent)AbskgLabel
- No longer recomputing the abskg, temperature and cellType every timestep. Compute once in initialize()
and carryForward every timestep.
- Added DoublToFloat() task to scheduleTimeAdvance()

Arches/RMCRT.cc
- cleaned out DQMONEqnFac .h files
- component defines either float or dbl RMCRT
- scheduleTimeAdvance()
added calls to DoubleToFloat() task
- computeSource()
removed cellType carryForward. That's handled by RMCRT

Wasatch/RadiationSource
- component defines either float or dbl RMCRT
- Added DoublToFloat() task to scheduleTimeAdvance() to schedule_ray_tracing


RMCRTCommon.cc
- now using d_comp(onent)AbskgLabel and d_comp(onent)TempLabel
- Component now decides if communicated variables are doubles or floats
Added logic where appropriate.
More templates
- Added DoubleToFloat() task. This simply casts the CCVariable< double> -> CCVariable<float>


Radiometer
- Component now decides if communicated variables are doubles or floats
Added logic where appropriate.
More templates

Ray
- now using d_comp(onent)AbskgLabel and d_comp(onent)TempLabel
- Component now decides if communicated variables are doubles or floats
Added logic where appropriate.
More templates
- coarsen_Q(): This task carries forward coarse level variables on non-radCalc timesteps
- Added coarsen_cellType()task: This task computes cellType on the coarse levels, needs additional logic.


RayGPU.cc
d_sigmaT4_label -> d_sigmaT4Label (consistency with the rest of the labels)


OnTheFlyAnalysis/radiometer
- Component now decides if communicated variables are doubles or floats


______________________________________________________________________
S U M M A R Y
Failed: ARCHES-opt tests <<<< These tests fail due to an new material set for abskg. The answers are the same >>>

:rmcrt_bm1_ML: test failed comparison tests
:rmcrt_bm1_ML: (restart) test failed comparison tests
:rmcrt_bm1_DO: test failed comparison tests
:rmcrt_bm1_DO: (restart) test failed comparison tests
:rmcrt_bm1_ML_thread: test failed comparison tests
:rmcrt_bm1_DO_thread: test failed comparison tests

Failed: Examples-opt tests <<<< This commit drastically improves the answers >>>
:RMCRT_bm1_DO: test failed comparison tests
:RMCRT_bm1_DO: (restart) test failed comparison tests
:RMCRT_ML: test failed comparison tests
:RMCRT_ML: (restart) test failed comparison tests
Passed: Wasatch-opt tests!


496 lines of code changed in 17 files:

guilkey 2014-12-18 15:43 Rev.: 52830

Fix an error message so that it tells me information that I can use.

0 lines of code changed in 2 files:

derekhar 2014-12-18 12:31 Rev.: 52829

Made DO-radiation consisently use zero ghost
cells when allocating memory for the DO b array.

2 lines of code changed in 1 file:

derekhar 2014-12-18 11:49 Rev.: 52828

Modified DO-radiation to use no ghost cells for the source term in the DO-Solve.

1 lines of code changed in 1 file:

harman 2014-12-17 15:17 Rev.: 52827

Added patch IDs to dbg.

0 lines of code changed in 2 files:

jsutherland 2014-12-16 20:49 Rev.: 52824

Move some stuff out of the BCHelper.h header to reduce clutter.

0 lines of code changed in 4 files:

jsutherland 2014-12-16 20:49 Rev.: 52823

OCD formatting changes.

81 lines of code changed in 9 files:

derekhar 2014-12-16 16:03 Rev.: 52822

Added bullet-proofing for several of the labels used radiation coefficient model.
Fixed some radiation related screen-output. General housekeeping changes.

52 lines of code changed in 3 files:

derekhar 2014-12-16 15:01 Rev.: 52821

Fix unit error in source term for gas enthalpy.

3 lines of code changed in 1 file:

jholmen 2014-12-16 14:08 Rev.: 52820

Updated environmentalFlags to include variables for setting and debugging CPU thread affinity

0 lines of code changed in 4 files:

derekhar 2014-12-16 10:28 Rev.: 52819

Minor housekeeping commit. Changed spacing and coding-order to be easier to read.

106 lines of code changed in 2 files:

jholmen 2014-12-15 21:04 Rev.: 52818

Updated list of scheduler related environmental flags
Added documentation to clarify Exectimes and execsummary output

47 lines of code changed in 7 files:

jsutherland 2014-12-15 14:12 Rev.: 52817

Minor stylistic changes, formatting, and improved const correctness related to BC infrastructure.

67 lines of code changed in 6 files:

harman 2014-12-15 13:57 Rev.: 52816

removed floatRMCRT/

There's a few missing pieces before the component is able to choose between float/double
RMCRT.


108 lines of code changed in 9 files:

harman 2014-12-15 13:13 Rev.: 52814

Removed floatRMCRT from build this fixes the cuda build.

0 lines of code changed in 2 files:

harman 2014-12-15 12:38 Rev.: 52812

Templated more tasks/methods/variables on the type double/float.

153 lines of code changed in 10 files:

guilkey 2014-12-15 09:18 Rev.: 52811

Remove TongeRamesh model for now...

0 lines of code changed in 8 files:

guilkey 2014-12-14 17:33 Rev.: 52810

Adding the TongeRamesh material model developed by Andy Tonge and KT Ramesh
of JHU.

6620 lines of code changed in 6 files:

dav 2014-12-11 17:53 Rev.: 52808

M ProblemSpec/ProblemSpec.cc

Remove bizarre code fragment that seems to do nothing... And yes, I
did run 'svn blame' and know who you are... ;)

0 lines of code changed in 1 file:

derekhar 2014-12-11 13:56 Rev.: 52806

This commit, moves all computations of abskp to radPropertyCalculator.cc. It also makes improvements to DO-radiation scattering, and radprops.
A new class was created in this commit, which contains the machinery for computing particle absorption coefficients.
This commit changes the answers to two arches tests, coal_channel and coal_RadPropsPlanck.

907 lines of code changed in 18 files:

jsutherland 2014-12-10 17:05 Rev.: 52802

Test to see if this fixes Jeremy's multithread problems. If so, I will prepare a more efficient solution. This will currently give a slight performance hit.

0 lines of code changed in 2 files:

harman 2014-12-10 13:37 Rev.: 52799

Added a temporary method for scheduling the radiometer task. This version is not using
spatially scheduling.

Increased the number of processes used in a nightly RT test.

89 lines of code changed in 4 files:

jsutherland 2014-12-09 16:19 Rev.: 52797

silence a few warnings.

0 lines of code changed in 4 files:

jsutherland 2014-12-05 10:35 Rev.: 52787

Numerous changes to address warnings kicked up by "cppcheck" - a decent static code analysis tool.
Also some formatting changes along the way.

127 lines of code changed in 42 files:

tsaad 2014-12-05 09:41 Rev.: 52786

remove an unnecessary division when constructing the oscillating cylinder. Thanks James for pointing this out.

0 lines of code changed in 2 files:

jthornoc 2014-12-04 16:04 Rev.: 52784

cout -> proc0cout.

5 lines of code changed in 1 file:

tsaad 2014-12-03 12:06 Rev.: 52781

propagate high order time integration to the variable-density pressure source

39 lines of code changed in 1 file:

derekhar 2014-12-03 11:57 Rev.: 52780

Fix Regression tests. Should have exact comparison.

3 lines of code changed in 1 file:

tsaad 2014-12-03 09:46 Rev.: 52779

some major changes to correct a few theoretical issues when constructing the rhs of the pressure-Poisson for high-order projection. A few Wasatch tests will fail.

115 lines of code changed in 10 files:

ahumphrey 2014-12-01 22:48 Rev.: 52777

Add multi-threading to Unified subschedulers. This should fix the issues with failing ICE and UCF tests.

44 lines of code changed in 1 file:

derekhar 2014-12-01 16:56 Rev.: 52774

Moved initialization of source term so that the sum is properly initialized to zero for radiation scattering.

6 lines of code changed in 1 file:

leavy 2014-12-01 15:09 Rev.: 52772

Initial Convected Particle Tetrahedral domain Interpolation (CPTI) method implementation. Input files are used to import tetrahedral mesh geometries to better fit complex shapes. The axisymmetric version is just a placeholder for now. CPTI uses a similar technique to the one used in CPDI.

1104 lines of code changed in 30 files:

leavy 2014-12-01 14:57 Rev.: 52771

test commit for cpti changes

0 lines of code changed in 1 file:

derekhar 2014-12-01 13:25 Rev.: 52770

Added Scattering in discrete ordinates radiation using the radProps property model. Also made some changes to reflections in discrete ordinates radiation. In this version, the complex index of refraction is a constant for all particles.

405 lines of code changed in 21 files:

tsaad 2014-12-01 09:35 Rev.: 52768

Add support to use a single predictor in the variable density algorithm. This can be triggered by using: <UseOnePredictor/> in the <VariableDensity> block.

49 lines of code changed in 15 files:

November 2014 »

Generated by StatSVN 0.7.0