July 2017 Commit Log

Number of Commits:
94
Number of Active Developers:
12
allen 2017-07-31 14:29 Rev.: 56834

removed the active status from the name, because it can change, also the semi-colon messes up the parsing for the in-situ

0 lines of code changed in 2 files:

allen 2017-07-31 14:26 Rev.: 56833

debug streams were changed to the douts so added them to the correct list

2 lines of code changed in 1 file:

allen 2017-07-31 14:25 Rev.: 56832

added more patch info

45 lines of code changed in 1 file:

bisaac 2017-07-31 14:14 Rev.: 56831

Removed print statement.

0 lines of code changed in 1 file:

bisaac 2017-07-31 13:07 Rev.: 56830

Added illinois 6 ash to the new emissivity model.

25 lines of code changed in 1 file:

bisaac 2017-07-31 12:01 Rev.: 56829

Added coordination number to emissivity model. This doesn't impact regression tests.

81 lines of code changed in 1 file:

jbhooper 2017-07-28 16:54 Rev.: 56828

-- Update MPM Regression Tests to enable testing on OSX.

20 lines of code changed in 1 file:

jbhooper 2017-07-28 16:11 Rev.: 56827

-- Fix compile issues for last two check-ins.

0 lines of code changed in 2 files:

harman 2017-07-28 16:03 Rev.: 56826

All:
Added comment about OS options.

MPMICE: changd OS option to ALL.

Separate out AMR tests to ease infrastructure testing.

67 lines of code changed in 6 files:

jbhooper 2017-07-28 14:40 Rev.: 56825

-- Clean up diffusion labels in MPM code.
-- Enable MAC OS RT on Darwin for actual testing and comparisons.

596 lines of code changed in 19 files:

harman 2017-07-28 10:30 Rev.: 56824

Wrapped cullIntersection() calls with conditional statement if(patch != neighor).


8 lines of code changed in 2 files:

harman 2017-07-27 16:41 Rev.: 56823

disable debugging output

1 lines of code changed in 1 file:

harman 2017-07-27 15:01 Rev.: 56822

Performing cullIntersection on all levels. Originally, this was called on fine levels where there could
be neighboring patches with inside corners. Now the inside corners can occur on all levels.

Moved conditional if (patch != neighborPatch) cullIntersection() inside of method.


26 lines of code changed in 4 files:

harman 2017-07-25 15:36 Rev.: 56820

More descriptive exception message, added level index.

1 lines of code changed in 1 file:

harman 2017-07-25 12:56 Rev.: 56819

Updated exception message. Output the timestep instead of the looping index.

1 lines of code changed in 1 file:

harman 2017-07-21 16:12 Rev.: 56818

Ray.cc
- changed Dout dbg to extern Dout g_ray_dbg. Shutdowns aren't clean if there are to Dout's with the
same name???

ARCHES.py
- added cpu and threaded regression tests for the input files:
multibox_rmcrt_coal_1L.ups
multibox_rmcrt_coal_2L.ups
multibox_rmcrt_coal_DO.ups


52 lines of code changed in 2 files:

harman 2017-07-21 14:59 Rev.: 56817

RMCRTCommon:
- pulled requires weed.


Ray.cc:
- turned exception into a warning. It possible for the user to save abskg and the float representation
abskgRMCRT in the same uda.


SourceTerms/RMCRT
extraSetup()
- On the coarse level initialize either abskgt or abskgRMCRT depending if user selects float or double
version.

converted DebugStream -> DOUT.


11 lines of code changed in 3 files:

bisaac 2017-07-21 13:55 Rev.: 56815

Added a minimum size for the particles in the case where there is not a flux of particles to the wall. Doesn't impact regression tests.

36 lines of code changed in 1 file:

bisaac 2017-07-20 17:19 Rev.: 56814

Updated the wall ht model to account for liquid slag heating above the ash fluid temperature. This will break 1GW_RT and 1GW_em_tc.

246 lines of code changed in 3 files:

harman 2017-07-20 17:09 Rev.: 56813

Started dusting off the poisson3 component which will be used for infrastructure debugging.

9 lines of code changed in 1 file:

harman 2017-07-20 15:13 Rev.: 56812

computeVariableExtentsWithBoundaryCheck()
- added comments
- use getExtraCell(Low/High)Index instead of get(Low/High)Index for the pre-clamped extents.

18 lines of code changed in 1 file:

harman 2017-07-20 13:50 Rev.: 56811

bulletpoofing
- changed the code for determining the number of failed tests.

7 lines of code changed in 1 file:

jsutherland 2017-07-20 11:06 Rev.: 56810

Output every timestep to circumvent GPU bug and get a test running again.

1 lines of code changed in 1 file:

jsutherland 2017-07-20 10:38 Rev.: 56809

disable a few more gpu tests until we can sort out the issue.

2 lines of code changed in 1 file:

guilkey 2017-07-20 10:05 Rev.: 56808

Creating a THREADEDTESTS set. Currently only 1 test (Charpy),
added to NIGHTLY set of tests.

3 lines of code changed in 1 file:

harman 2017-07-19 14:37 Rev.: 56805

Ray:
- throw exception if haloCells < (2,2,2)
- tweaked DOUT statements
- computeExtents
patch->getInterior cells for high and low for patch_based ROI

TaskGraph:
createDetailedDependencies()
- Turned off cullIntersection() It returns the wrong lo & hi at the inside corner of the L
patches for RMCRT_+_Domain_DO.ups

Patch:computeVariableExtentsWithBoundaryCheck()
- changed the arbitrary value of numGhostCells from 5 to 1.

Examples.py
- removed EOL spaces.
- added the domain test RMCRT_+Domain_DO

42 lines of code changed in 4 files:

harman 2017-07-19 13:57 Rev.: 56804

Removed EOL spaces.

14 lines of code changed in 1 file:

harman 2017-07-19 10:58 Rev.: 56803

Added sanity test that exercises the infrastructure on a non-cubic level + regridding. The mpm object is a "star."
An exception is thrown on the first timestep in getModifiableRegion(), similar to the RMCRT + domain exception.

13 lines of code changed in 1 file:

jbhooper 2017-07-18 20:43 Rev.: 56802

-- Rename the ReactionDiffusion directory to be simply "Diffusion" in the MPM code, in anticipation of updating the diffusion models to work with Serial MPM as well as backporting some portion of the Structural Energetics branch in order to enable basic reaction functionality in solid solutions.

3594 lines of code changed in 79 files:

dav 2017-07-18 19:01 Rev.: 56801


Some minor (I hope) updates to help keep the user from using configure incorrectly, and to avoid allowing
configure to find system libraries (in this case for hypre, those this should actually be expanded to
all the tests at some point) that shadow the specifically requested libraries the user wants.

This commit really should not break anything, but it is possible that many people have bad configure
lines, and this will catch it... they will just have to update their configure line to be unambiguous.
It should also catch if the user points to any libraries in /usr/lib, which if we allowed would
cause the make system to use libraries found in /usr/lib instead of those specified by the user (via configure).

If you run into configure issues with this update, please let me know.

M aclocal.m4

- Configure previously checked for (and disallowed) --with-<lib>=/usr/lib but a logic issue allowed --with-<lib>-/usr/lib/
(notice the / at the end of the line) to get through. This is no longer the case. If you run into a problem with this,
you most likely can just remove --with-<lib> from your configure line. If this doesn't work, let us know and we'll fix it.

M configVars.mk.in

- Previously there was a separate rule for compiling .cpp files (even though up until very recently, we didn't have any.)
However, while the .ccp rule was almost identical to the .cc rule, it wasn't finished. Because it uses the exact same
compilation line as .cc files, I just removed the redundant rule, and pointed .cpp files at the same make fragment
as .cc files. If we ever need to do something specific for .cpp files, we can add the rule back (and bring it up to date).

M configure.ac
M configure

- Pull in the changes from aclocal.m4.
- Minor informational update.
- Put in a check that hopefully disallows system libraries from shadowing other specific libs (only implemented for HYPRE
at this point).

5 lines of code changed in 3 files:

derekhar 2017-07-18 18:00 Rev.: 56800

Made BrownSoot model interface properly with radiation properties, and radiation.

2 lines of code changed in 2 files:

jthornoc 2017-07-18 15:32 Rev.: 56799

* In a previous commit, I had messed up the template parameters for the convection helper.
* Split out the FE update for momentum from the “momentum_solve” - this was due to a requires and modifies in the same task group. Combining them needs a little more work to ensure everything is working as planned.
* Added a global_pack_tasks for testing.
* For single patch cases, packed and unpacked momentum solves show exact comparison

176 lines of code changed in 9 files:

harman 2017-07-17 16:58 Rev.: 56798

Increased complexity of this AMR test. Blow it out so it's 3D.

2 lines of code changed in 1 file:

jthornoc 2017-07-17 13:35 Rev.: 56797

This commit breaks the kokkos scalar tests.

* Template ConvectionHelper to enable temporary variable use in this function.
* Changed up some of the macros to have better (more descriptive) names
* Added a new patch range macro
* Packaged the momentum updates into a smaller package
* register_variable now passes a bool to indicate if the variable is temp or not. If temp, it avoids the registration

223 lines of code changed in 18 files:

ahumphrey 2017-07-14 18:13 Rev.: 56794

Fix name shadowing issue in DOUT variadic macro.

33 lines of code changed in 2 files:

ahumphrey 2017-07-14 13:38 Rev.: 56793

Revert DOUT.hpp to original, nearly pristine state.
Recommendation is to use explicit operator bool() for checking active state, but left active method in with coments.
Some other minor cleanup.

18 lines of code changed in 3 files:

harman 2017-07-14 12:27 Rev.: 56792

Grid::printStatistics()
- added debug stream (GRID) that output patch extents

environmentalFlags.txt
- additional entries and organization.

DOUT.hpp
- fixed a bug, the first SCI_DEBUG name listed is properly read and processed.

74 lines of code changed in 3 files:

bisaac 2017-07-14 12:03 Rev.: 56791

Added additional check for particle size in the pokluda emissivity model.

3 lines of code changed in 2 files:

ahumphrey 2017-07-14 11:15 Rev.: 56790

Cleanup DOUT-based debugging output for RMCRT-related classes. Still having issues with use of DOUT in DbgOutput::print* methods. Working on it.

For those who are wondering, below is my spiel on Dout (class) and DOUT (variadic macro), why DebugStream is not a great idea in our world today, and perhaps some motivation to move in this direction should you actually want coherent, lock-free output by multiple threads or MPI ranks. Dout simply co-opts the SCI_DEBUG env var and does not effect DebugStream.

// ------------------------------------------------------------------------------------------------
// Dout (class) versions of the above (moving away from DebugStream)
//
// Dout is an extremely lightweight way to provide the same functionality as DebugStream,
// but in a fully lock-free way for both multiple threads and MPI ranks. Dout also does not
// inherit from from the standard library (std::ostream specifically) as DebugStream does.
// The DOUT variadic macro is then used, which is printf-based. By the POSIX standard, printf
// must "behave" like it acquired a lock. The Dout class also defines an explicit bool() operator
// for checking state, e.g. active or inactive.
// ------------------------------------------------------------------------------------------------

90 lines of code changed in 7 files:

zhouminmin 2017-07-14 10:16 Rev.: 56789

Deleted file 'deposition.diff'.

0 lines of code changed in 1 file:

zhouminmin 2017-07-14 10:15 Rev.: 56788

cange the initialization of variables and fix a small bug, it would break the 1GW.ups

42 lines of code changed in 1 file:

ahumphrey 2017-07-14 09:34 Rev.: 56787

Missed clipping one line.

0 lines of code changed in 1 file:

ahumphrey 2017-07-14 09:32 Rev.: 56786

Give SFC test full-fledged build system membership,static, gpu, etc

27 lines of code changed in 1 file:

harman 2017-07-14 08:59 Rev.: 56785

reference make3.log when concatenating to the htmllog

5 lines of code changed in 1 file:

harman 2017-07-13 16:47 Rev.: 56784

printTask() and printSchedule() DOUT versions:
- now calling printf instead of DOUT macro.

16 lines of code changed in 1 file:

bisaac 2017-07-13 15:43 Rev.: 56783

Added German lignite to the new emissivity model.

12 lines of code changed in 1 file:

jsutherland 2017-07-13 14:06 Rev.: 56782

Eliminate creation of an unnecessary PlaceHolder expression on transport equations.
This will allow ExprLib to trap more user specification errors.

0 lines of code changed in 2 files:

ahumphrey 2017-07-13 12:37 Rev.: 56781

Working with SFC and loadblancer functionality, re-enable SFC test.
Other minor cleanup, fix some comments.

40 lines of code changed in 12 files:

jsutherland 2017-07-12 10:30 Rev.: 56780

Split BoundaryCondition.cc into several files to reduce the size of the resulting object file(s).

1693 lines of code changed in 27 files:

bisaac 2017-07-11 13:41 Rev.: 56779

Added regime 3 back into the wall ht model. This shouldn't impact regression tests.

10 lines of code changed in 1 file:

ahumphrey 2017-07-10 15:45 Rev.: 56778

Further simplify Radiometer spatial patchset construction.

3 lines of code changed in 1 file:

ahumphrey 2017-07-10 15:33 Rev.: 56777

Simplfy unnecessarily complicated proc0cout macro.
Just print from proc0/masterThread (T0), always the same regardless of number of threads or scheduler type.

2 lines of code changed in 1 file:

bpeterson 2017-07-10 12:52 Rev.: 56776

An RMCRT/GPU data onion cleanup of many items Todd and I discussed a month ago. Many of the changes are cosmetic (cleaner code, better comments). One change allows for any task to specify how many GPU streams it needs. This also fixes a bug where debug mode ran with too many threads, using up too many resources for a GPU RMCRT data onion kernel to execute.

175 lines of code changed in 10 files:

ahumphrey 2017-07-10 12:22 Rev.: 56775

Remove unused lock, move another mutex to use std::lockguard (RAII mechanism).

6 lines of code changed in 1 file:

harman 2017-07-10 10:16 Rev.: 56774

Migration from DebugStream -> DOUT.

44 lines of code changed in 4 files:

ahumphrey 2017-07-08 23:16 Rev.: 56773

Fix spatial scheduling in Radiometer so we create a single spatial task with a PatchSet like: { {19}, {22}, {25} } (singleton subsets like level->eachPatch()), NOT -> { {19,22,25} }. This is because one proc isn't guaranteed to own all patches in the multi-element subset.

Added Dout versions of printTask and printSchedule to DbgOutput. Now we actually get coherent output when multiple ranks write to stdout.

192 lines of code changed in 7 files:

bpeterson 2017-07-07 21:19 Rev.: 56772

Hopefuly this fixes the debug bug completely. Let debug mode have all the registers it needs.

0 lines of code changed in 1 file:

bisaac 2017-07-07 15:56 Rev.: 56771

Added new emissivity model. This will not impact any regression tests.

74 lines of code changed in 2 files:

zhouminmin 2017-07-07 14:56 Rev.: 56770

change the initialization of variables and fix a small bug, it would break the 1GW.ups

0 lines of code changed in 1 file:

ahumphrey 2017-07-07 12:03 Rev.: 56769

Remove the old, delayed thread detach approach. Threads should be detached upon creation and left to run and terminate on their own, e.g. no join.

4 lines of code changed in 1 file:

harman 2017-07-07 10:40 Rev.: 56766

getRegionModifiable()
- Added more details to the exception message if nCellsCopied != nRequested Cells.
- using DOUT instead of cout.

18 lines of code changed in 1 file:

harman 2017-07-07 10:31 Rev.: 56765

cullIntersection()
- spacing
- reworked BJW's comments
- more descriptive variable names.

45 lines of code changed in 1 file:

ahumphrey 2017-07-07 09:50 Rev.: 56764

Both temporal and spatial scheduling working correctly for Radiometer.

Effectively, spatial tasks are scheduled "level->eachSpatialPatch()" as opposed to "level->eachPatch". Working to generalize this within the infratructure. For now, schedule spatial tasks independently (independent task for each patch the spatial task runs on), as opposed to scheduling with a spatial PatchSubset. This is so the load balancer can distribute patches more effectively (as opposed to lumping all spatial tasks on a particular node), and so that MPI dependencies can be generated and met correctly.

239 lines of code changed in 8 files:

jthornoc 2017-07-06 22:45 Rev.: 56763

Final API change commits.

27 lines of code changed in 39 files:

jthornoc 2017-07-06 22:45

More API change.

307 lines of code changed in 177 files:

jthornoc 2017-07-06 22:44 Rev.: 56760

Limiting line length.

12 lines of code changed in 1 file:

harman 2017-07-06 14:18 Rev.: 56759

TaskGraph::createDetailedDependencies()
- Restrict the warning about requires with ghost cells >0 and modifying that variable to debug builds.

4 lines of code changed in 1 file:

jthornoc 2017-07-06 11:56 Rev.: 56758

Cleaned up warnings.

4 lines of code changed in 2 files:

jthornoc 2017-07-06 11:50 Rev.: 56757

Clean up warnings.

356 lines of code changed in 6 files:

jthornoc 2017-07-06 11:39 Rev.: 56756

ConstantProperty was missing a restartInitialize.
For task group scheduling, when there is a single task, use the task name rather than the group name.
Reverting the use of the task group scheduling in ExplicitSolver for now. Something isn't working correctly.

61 lines of code changed in 3 files:

ahumphrey 2017-07-06 09:41 Rev.: 56755

Modify Radiometer for spatial scheduling with ghost cells. Need empty DetailedTasks for dependency generation phase under current model. Unnecessary comm is bypassed the way it should be. Still working on correct patch assignments in the infrastructure, but close.

33 lines of code changed in 1 file:

bpeterson 2017-07-06 01:00 Rev.: 56754

This fixes an odd cudaErrorInvalidDeviceFunction bug. The problem wasn't the kernel being called, but that another kernel which wasn't ever called didn't have enough registers. It also only showed up in debug mode builds. Now the kernels can run again

6 lines of code changed in 1 file:

jthornoc 2017-07-05 17:09 Rev.: 56753

Fix a bug (thanks, Oscar for finding it) in the temp variable retrieval
- face centered variables only.

Also reduce the number of args for temp variable retrieval.

15 lines of code changed in 2 files:

jthornoc 2017-07-05 17:08 Rev.: 56752

Arches task interface API changed to pass packed_task boolean.

138 lines of code changed in 85 files:

jthornoc 2017-07-05 17:08 Rev.: 56751

Cleanup + pass the pack_tasks bool into the callback.

102 lines of code changed in 8 files:

guilkey 2017-07-05 12:29 Rev.: 56748

Add MaxAbsElemComp which, in addition to returning the maximum component of
the matrix, also returns the indices where that element lives.

0 lines of code changed in 2 files:

guilkey 2017-07-03 17:07 Rev.: 56746

schedule new MPM task in MPMICE also.

1 lines of code changed in 1 file:

jthornoc 2017-07-03 16:07 Rev.: 56744

Allows for retrieval of a temporary variable through a common API.

18 lines of code changed in 1 file:

jthornoc 2017-07-03 15:58 Rev.: 56743

Removing the returnNullPointer API for variable retrieval.

89 lines of code changed in 2 files:

bisaac 2017-07-03 15:41 Rev.: 56742

Added a time-averaging concept to the particle arrival size. This will change the answers in 1GW_RT and 1GW_em_tc.

4 lines of code changed in 1 file:

bisaac 2017-07-03 15:14 Rev.: 56741

Removed confusing time-averaging split for deposition rate, and moved it do the end. This will change 1GW_RT and 1GW_em_tc within machine noise.

8 lines of code changed in 1 file:

guilkey 2017-07-03 15:12 Rev.: 56740

Break interpolateToParticlesAndUpdate into two tasks. The new task computes
gradient (velocity, temperature, deformation) on the particles
(computeParticleGradients). I had intended to integrate these more closely for
efficiency, but the combinatorics of all possible options,
(e.g., XPIC, axisymmetry, etc.) made this daunting, so I'm opting for finer
grain tasks that might perform better anyway.

165 lines of code changed in 2 files:

harman 2017-07-03 14:04 Rev.: 56739

test

1 lines of code changed in 1 file:

guilkey 2017-07-03 13:23 Rev.: 56738

More minor tweaks, comments.

4 lines of code changed in 1 file:

guilkey 2017-07-03 12:52 Rev.: 56737

Move the conditional on scheduling setPrescribedMotion to scheduleTimeAdvance.

17 lines of code changed in 1 file:

guilkey 2017-07-03 10:23 Rev.: 56735

Cleanup of outdated comments.

1 lines of code changed in 1 file:

guilkey 2017-07-03 09:57 Rev.: 56734

Make sure p.externalforce gets initialized if using load curve types other than
pressure.

7 lines of code changed in 1 file:

guilkey 2017-07-03 09:13 Rev.: 56733

Remove the requires for the old pExternalForceLabel.

4 lines of code changed in 1 file:

harman 2017-07-03 08:54 Rev.: 56732

test of svn

1 lines of code changed in 1 file:

guilkey 2017-07-02 19:11 Rev.: 56727

Adding the option to skip over the first contact step. For now, the default is
to keep doing it.

28 lines of code changed in 5 files:

guilkey 2017-07-02 17:07 Rev.: 56726

Minor cleanup in scheduling.

4 lines of code changed in 1 file:

guilkey 2017-07-02 16:57 Rev.: 56725

Don't set the velocity BC in the contact code as it has already been set in
interpolateToParticlesAndUpdate and contact won't induce any out of plane
velocity components.

0 lines of code changed in 1 file:

guilkey 2017-07-02 16:42 Rev.: 56724

A bit more clean up, fixing comments, and deleting no longer needed "requires".

2 lines of code changed in 1 file:

guilkey 2017-07-02 16:38 Rev.: 56723

Minor clean up, shouldn't change any answers.

11 lines of code changed in 1 file:

June 2017 »

Generated by StatSVN 0.7.0