January 2018 Commit Log

Number of Commits:
118
Number of Active Developers:
16
dav 2018-01-30 20:06 Rev.: 57748


Mostly cosemetic commit. Added in a number of "const" declarations and cleaned up
the code around them.

M CCA/Components/DataArchiver/DataArchiver.h
M CCA/Components/DataArchiver/DataArchiver.cc

- Mark methods as const if they don't change object data.
- Pass (all) params as constants where appropriate.
- Return const pointers to object data (as appropriate).
- Align params, white space.
- Rename findAllVariableTypes() to the more accurate findAllVariablesWithType().
- The "d_" vars are being phased out, so using direct getMPIRank() call instead.

M CCA/Ports/LoadBalancer.h

- Rename enum to use CAPITAL names for clarity. (The enum itself should probably be a named type.)
This makes grep'ing for them much easier.
- Remove tabs, white space.

M CCA/Components/LoadBalancers/DynamicLoadBalancer.cc
M CCA/Components/LoadBalancers/LoadBalancerCommon.cc
M CCA/Components/LoadBalancers/ParticleLoadBalancer.cc
M CCA/Components/SimulationController/AMRSimulationController.cc

- White space.
- Remove some "d_" usage.
- Use new LoadBalancer enum NAMES.
- Single line "if" statements need to use {}.


427 lines of code changed in 7 files:

bisaac 2018-01-30 17:12 Rev.: 57747

Updated volume time-averaging for particle arrival size. This will modify the Arches tests: 1GW_RT, 1GW_em_tc, and mass_energy_balance.

108 lines of code changed in 3 files:

jholmen 2018-01-29 16:54 Rev.: 57743

* Added TaskType Hypre.
* Updated TaskType logic to support Task::Hypre.
* Updated Kokkos-OpenMP Scheduler logic to exit OpenMP thread partitions when a Hypre task is selected.
* Cleaned up whitespace and formatting.

This commit allows Hypre tasks to be differentiated from OncePerProc tasks. This differentiation is used within the Kokkos-OpenMP Scheduler to make all OpenMP threads within an MPI process available to a Hypre task as opposed to only those within the OpenMP thread partition that selected the Hypre task.

311 lines of code changed in 9 files:

jbhooper 2018-01-26 16:10 Rev.: 57739

-- Fix segfault in smooth cylinder particle creation.

29 lines of code changed in 1 file:

jholmen 2018-01-26 15:37 Rev.: 57738

* Ensure that we have OpenMP before attempting to use it.

6 lines of code changed in 1 file:

harman 2018-01-26 10:54 Rev.: 57737

Added comments for enabling core dumps.

0 lines of code changed in 2 files:

jholmen 2018-01-25 22:25 Rev.: 57731

* Updated KokkosOpenMPScheduler.cc to use Kokkos::OpenMP::partition_master() for Kokkos-based builds.
* Added -npartitions and -nthreadsperpartition run-time options.
* Set the Kokkos-OpenMP Scheduler as the default scheduler for Kokkos-based builds.
* Added bulletproofing within SchedulerFactory.cc.
* Updated ProcessorGroup.h to use m_comm for -nthreads 1 or -npartitions 1.
* Added MasterLock.h to help avoid mixing synchronization primitives.
* Replaced use of #include <mutex> with #include <Core/Parallel/MasterLock.h>.
* Replaced use of std::mutex with Uintah::MasterLock.
* Cleaned up whitespace.

This commit extends the Kokkos-OpenMP Scheduler to support parallel execution of tasks within an MPI process.

Scheduler logic is based upon that of the Unified Scheduler, where individual threads are used as task runners.

In the context of the Kokkos-OpenMP Scheduler, individual partitions are used as task runners.

Individual partitions execute Kokkos-based tasks in parallel across the threads belonging to that partition and existing serial tasks serially.

Note, this scheduler requires MPI_THREAD_MULTIPLE support to run with multiple partitions per MPI process.

547 lines of code changed in 52 files:

harman 2018-01-25 16:43 Rev.: 57729

Added scheduling of prerequisite tasks upstream of the exchange task.

Added function that's called from the semi-implicit pressure solve subscheduler that
add "requires" for variables from the parentDW.

134 lines of code changed in 7 files:

derekhar 2018-01-25 10:53 Rev.: 57726

fixed typo that prevented table deletion.

1 lines of code changed in 1 file:

derekhar 2018-01-24 12:25 Rev.: 57723

fix unit error in zeldovich mechanism

1 lines of code changed in 1 file:

derekhar 2018-01-24 09:45 Rev.: 57722

Updated arches file to exlude deleted test.

0 lines of code changed in 1 file:

derekhar 2018-01-23 19:55 Rev.: 57718

Fixed ambigous iterator use in nested for loop.

3 lines of code changed in 1 file:

harman 2018-01-23 09:37 Rev.: 57713

Destroy pScratchLabel.

1 lines of code changed in 1 file:

guilkey 2018-01-22 20:34 Rev.: 57711

Remove commented out var labels that are now in the diffusion labels.

0 lines of code changed in 2 files:

harman 2018-01-22 18:32 Rev.: 57710

Removed "flowWork" flag from MPM and ups files. It's always false.


16 lines of code changed in 4 files:

allen 2018-01-22 15:09 Rev.: 57708

added an additional output for memory, made stats reduction optinal

222 lines of code changed in 2 files:

allen 2018-01-22 14:27 Rev.: 57707

added per node communicator and changed logic for per node reductions

34 lines of code changed in 3 files:

allen 2018-01-22 14:26 Rev.: 57706

added return and fixed member var

2 lines of code changed in 1 file:

allen 2018-01-22 14:24 Rev.: 57705

formatting fix

1 lines of code changed in 1 file:

harman 2018-01-22 11:43 Rev.: 57704

Removed code that isn't being used.

54 lines of code changed in 3 files:

jthornoc 2018-01-20 23:32 Rev.: 57701

Turning off restart on these tests. Need to fix the failures.

4 lines of code changed in 1 file:

ahumphrey 2018-01-19 16:34 Rev.: 57699

A viable short-term solution for the broken timers on BGQ architecture. Using the __bgq__ compiler macro.

Still need to fix lap timer for EMA, but this should get the production and scaling test runs working again.

97 lines of code changed in 5 files:

harman 2018-01-19 15:49 Rev.: 57698

Added <useSlipCoeffs> flag so the user can run with without modifying the exchange coefficients.

advectSlipExch.ups
- added more variables to analyze
- lowered cfd
- <useSlipCoeffs> = false


Slip.*
- vel_CC_exchange returns the change in velocity (delta_vel_exch) not the updated
vel_CC.

-bug fixes in the equations for forming matrix.

AdvectslipExch.ups now give reasonable results.

75 lines of code changed in 2 files:

allen 2018-01-19 13:37 Rev.: 57697

removed node based stats for now

22 lines of code changed in 1 file:

jthornoc 2018-01-19 11:44 Rev.: 57696

Starting to add geometry_fill to DQMOM variables. This still needs work.
Added an example input file.

39 lines of code changed in 2 files:

jholmen 2018-01-18 15:11 Rev.: 57692

* Updated build system support for Kokkos.
* Added build_kokkos.sh.
* Renamed build_kokkos.

This commit allows --enable-kokkos to be used to download and build Kokkos release 2.5.00.

Note, a custom Kokkos installation can be specified using --with-kokkos=DIR.

199 lines of code changed in 3 files:

harman 2018-01-18 14:33 Rev.: 57691

Added outputProblemSpec to all exchange models.

Added input file for slip momentum exchange.

Added ups spec for slip momentum exchange.

ICE.*
- removed all calls to exchangeCoefficient code.
- added exchangeModel->outputProblemSpec()
- removed dead wood updateExchangeCoefficiients()

Slip.*
- minor bug fixes so ups will run to completion and restarts will work.
Results have not been verified.

113 lines of code changed in 9 files:

harman 2018-01-18 14:27 Rev.: 57690

Improved formatting and added a few comments.

41 lines of code changed in 1 file:

jthornoc 2018-01-18 12:47 Rev.: 57689

Not permanently injecting the dqmom equation section into KScalartTransport
as it causes problems on restart. Added an option to dump a copy of the input
file to disk so that one may examine the result of the injection before it is
removed.

Also turned off restarts for the kokkos_handoff example. Looks like this needs some more
debugging.

31 lines of code changed in 2 files:

cgritton 2018-01-18 12:34 Rev.: 57688

Cleaned out old VarLabels from MPMLabel.

33 lines of code changed in 4 files:

harman 2018-01-17 15:46 Rev.: 57685

Fixed typo

2 lines of code changed in 1 file:

harman 2018-01-17 15:43 Rev.: 57684

ICE, impAMRICE, MPMICE
- API change for sched_AddExch_Vel_Temp_CC()

ExchangeModel.*
- added d_zero_matl and surfaceNorm and isSurfaceCell VarLabels
- updated Model method parameters.

Scalar.*
- Removed EOL spaces.
- Polished.

Slip.*
major restructure
- Added sched_AddExch_velFC(), vel_FC_exchange() and addExch_VelFC()
- Consolidated all CC velocity exchange into a single function/method.
- Scheduling computeSurfaceNorman() and ComputeMeanFreePath() before face centered exchange
- Major scrubbing and modernization of all code.



661 lines of code changed in 9 files:

derekhar 2018-01-17 14:51 Rev.: 57683

Untethered Arches from Wasatch3p libraries radprops and tabprops.

23 lines of code changed in 8 files:

allen 2018-01-17 14:47 Rev.: 57682

merged initializeOutput for PIDX

244 lines of code changed in 7 files:

allen 2018-01-17 14:12 Rev.: 57681

removed old PIDX code

2 lines of code changed in 1 file:

bisaac 2018-01-17 12:51 Rev.: 57680

Fixed issue related to computing delta_n on x+, y+, and z+ wall faces. Also re-indented the file. This file isn't under RT yet.

168 lines of code changed in 1 file:

allen 2018-01-16 17:52 Rev.: 57673

moved PerPatchVars.h to Core and RunTimeStatsEnums.h to Schedulers to give better separation, Also removed unneeded ehader files

313 lines of code changed in 51 files:

guilkey 2018-01-16 16:29 Rev.: 57672

Adding a hopefully helpful comment.

1 lines of code changed in 1 file:

dav 2018-01-16 15:41 Rev.: 57670

Fix static build when Examples are not built.

2 lines of code changed in 1 file:

harman 2018-01-16 15:00 Rev.: 57669

Slip:
Added computeMeanFreePath() and computeSurfaceRotationMatrix().
CCExchange will now compile.


Overall:
Polished and pulled a few weeds.

551 lines of code changed in 8 files:

allen 2018-01-16 14:09 Rev.: 57668

simpified the minimal builds and minor clean up of dependencies

8 lines of code changed in 1 file:

allen 2018-01-16 13:54 Rev.: 57666

simpified the minimal builds and minor clean up of dependencies

58 lines of code changed in 9 files:

harman 2018-01-16 11:11 Rev.: 57665

Delete exchange model

1 lines of code changed in 1 file:

allen 2018-01-15 17:56 Rev.: 57664

reorder to pick up var

12 lines of code changed in 1 file:

allen 2018-01-15 17:32 Rev.: 57663

minor updates for minimal builds

7 lines of code changed in 1 file:

harman 2018-01-15 13:13 Rev.: 57659

- Added Deletion VarLabel objects.

- Cell Centered and face centered exchange is now computed in Models/MultiMatlExchange/Scalar.cc



175 lines of code changed in 5 files:

guilkey 2018-01-15 00:05 Rev.: 57656

Remove missed reference to "Rogue" particles.

0 lines of code changed in 1 file:

guilkey 2018-01-15 00:03 Rev.: 57655

Remove some dead wood from the MPMFlags and mpm_spec

0 lines of code changed in 2 files:

guilkey 2018-01-14 23:25 Rev.: 57653

Bringing in improvement to partextract from Cyberstone branch.

9 lines of code changed in 1 file:

allen 2018-01-13 09:17 Rev.: 57648

added missing delete calls

48 lines of code changed in 1 file:

allen 2018-01-13 09:15 Rev.: 57647

moved CUDA code inside of examples check

9 lines of code changed in 1 file:

ahumphrey 2018-01-12 17:18 Rev.: 57642

Enable examples for GPU tests.

2 lines of code changed in 1 file:

allen 2018-01-12 14:52 Rev.: 57640

Added flags to allow for finer grained builds, moved the uda2vis out of tools to VisIt dir

2261 lines of code changed in 21 files:

harman 2018-01-12 13:58 Rev.: 57639

Merge from LastMPMICE branch to trunk

Rerouted some plumbing. Face centered momentum exchange is now computed in the MultiMatlExchange models
instead of ICE.

631 lines of code changed in 14 files:

jholmen 2018-01-12 13:51 Rev.: 57638

* Fixed dbgCell indexing.

3 lines of code changed in 1 file:

jthornoc 2018-01-12 12:57 Rev.: 57637

Bad merge fix.

0 lines of code changed in 1 file:

jholmen 2018-01-12 12:33 Rev.: 57636

* Reverted RayKokkos.cc to r57476.
* Reverted RayKokkos.h to r57461.

This commit fixes Kokkos-based builds from trunk code.

461 lines of code changed in 2 files:

jthornoc 2018-01-12 12:26 Rev.: 57635

Adding more more Arches/kokkos testing in rt.

Fixing a bug in IntrusionBC.

39 lines of code changed in 2 files:

jthornoc 2018-01-12 12:26 Rev.: 57634

Use label name rather than the ArchesLabel reference.

19 lines of code changed in 1 file:

bisaac 2018-01-12 11:29 Rev.: 57633

Removed unused required flag from input files and from source code. This won't impact regression tests.

0 lines of code changed in 2 files:

ahumphrey 2018-01-11 17:09 Rev.: 57625

Remove old, unused Example Component. Update UPS spec accordingly.

0 lines of code changed in 2 files:

dav 2018-01-11 14:39 Rev.: 57620

Cosmetic update: Consolidate one line functions in .h file to be more easily read (in terms of a class spec). Added a few comments about what data the variables hold.

9 lines of code changed in 1 file:

allen 2018-01-11 13:56 Rev.: 57619

added comments

11 lines of code changed in 3 files:

bisaac 2018-01-11 12:04 Rev.: 57618

Updated the linear contribution to the devol model. This will change answers in partMassFlow and Coal_Nox.

11 lines of code changed in 1 file:

allen 2018-01-11 07:55 Rev.: 57617

fixed copy paste error in check

2 lines of code changed in 1 file:

allen 2018-01-10 18:21 Rev.: 57615

added MultiMatlExchange Models

734 lines of code changed in 4 files:

zhouminmin 2018-01-10 16:35 Rev.: 57613

To be consistent with wall heat transfer model (w/m2)

1 lines of code changed in 1 file:

jholmen 2018-01-10 13:08 Rev.: 57611

* Moved declarations inside the parallel pattern.

16 lines of code changed in 1 file:

jholmen 2018-01-10 11:27 Rev.: 57610

* Removed an extra comma in Kokkos-enabled code.

1 lines of code changed in 1 file:

allen 2018-01-10 09:27 Rev.: 57608

removed a cerr

0 lines of code changed in 1 file:

jas 2018-01-09 17:40 Rev.: 57604

Update copyright date.

2623 lines of code changed in 3624 files:

allen 2018-01-09 17:09 Rev.: 57603

changed logic for getting delta t fo subtaks

19 lines of code changed in 2 files:

bisaac 2018-01-09 14:57 Rev.: 57602

Added RT test with mass/enthalpy conservation in the case of slagging walls.

3 lines of code changed in 1 file:

jthornoc 2018-01-09 14:42 Rev.: 57601

Adding a no-pressure-solve version of the DQMOM char example.
Adding some bullet proofing.

4 lines of code changed in 1 file:

bisaac 2018-01-09 13:56 Rev.: 57600

Added new regression test showing mass and energy conservation for coal problems.

3 lines of code changed in 1 file:

bisaac 2018-01-09 11:40 Rev.: 57599

This commit adjust the enthalpy balance, and ash mass balance for conservation. This commit will not change the answers.

481 lines of code changed in 13 files:

allen 2018-01-08 17:05 Rev.: 57596

begin to treat Sole varibales as first class vars

2 lines of code changed in 1 file:

allen 2018-01-08 16:35 Rev.: 57595

cleanup of depencendies to applications

575 lines of code changed in 8 files:

allen 2018-01-08 16:35 Rev.: 57594

removed reference to MPM

4 lines of code changed in 1 file:

allen 2018-01-08 16:33

removed need for calls to shared state for the time step and sim time

1108 lines of code changed in 4 files:

allen 2018-01-08 16:28

removed need for calls to shared state for the time step and sim time

2267 lines of code changed in 120 files:

allen 2018-01-08 16:26 Rev.: 57581

begin to treat Sole varibales as first class vars

59 lines of code changed in 1 file:

jholmen 2018-01-08 11:36 Rev.: 57575

* Get views after setup for boundedRayLength.

33 lines of code changed in 1 file:

allen 2018-01-08 10:35 Rev.: 57574

removed pass sharedstate

1 lines of code changed in 1 file:

harman 2018-01-08 10:11 Rev.: 57573

Due to an unresolved debug compiliation error I removed Wasatch from the gpu_RT.


4 lines of code changed in 2 files:

jsutherland 2018-01-06 11:53 Rev.: 57572

Remove shared state from a few places where it isn't needed.

14 lines of code changed in 9 files:

zhouminmin 2018-01-05 16:24 Rev.: 57571

Adding the convection term for the wall heat transfer model

143 lines of code changed in 2 files:

allen 2018-01-05 16:10 Rev.: 57570

removed unneeded dependency

0 lines of code changed in 1 file:

allen 2018-01-05 15:49

removed unneeded dependency

0 lines of code changed in 2 files:

allen 2018-01-05 15:48 Rev.: 57567

added error handling to prevent crahses

25 lines of code changed in 1 file:

allen 2018-01-05 15:46 Rev.: 57566

added ifdef to remove warning

3 lines of code changed in 1 file:

allen 2018-01-05 15:24 Rev.: 57565

commented out unused var to remove warnign

0 lines of code changed in 2 files:

allen 2018-01-05 15:09

added labels for the sim time and time step

15 lines of code changed in 2 files:

jsutherland 2018-01-05 10:05 Rev.: 57562

Update locations for W3P libraries.
These were just migrated to a new server.

11 lines of code changed in 5 files:

bpeterson 2018-01-04 19:23 Rev.: 57561

Fixing a silly bug that gave bad outputs

2 lines of code changed in 1 file:

jholmen 2018-01-04 16:50 Rev.: 57560

* Fixed dbgCell indexing.

3 lines of code changed in 1 file:

jholmen 2018-01-04 16:16 Rev.: 57559

* Fixed debugging output.

2 lines of code changed in 1 file:

bpeterson 2018-01-04 15:34 Rev.: 57558

This adds GPU portable RMCRT Data Onion. This commit also adds a ton of bug fixes.

757 lines of code changed in 2 files:

allen 2018-01-04 13:29 Rev.: 57557

added missing header files

3 lines of code changed in 1 file:

ohdiazi 2018-01-04 11:06 Rev.: 57555

Adding dqmom rt test

1 lines of code changed in 1 file:

ohdiazi 2018-01-04 11:06 Rev.: 57553

adding RT test

20 lines of code changed in 1 file:

ohdiazi 2018-01-04 11:06 Rev.: 57552

fixing rt test and adding arches spec

41 lines of code changed in 4 files:

ohdiazi 2018-01-04 11:06 Rev.: 57551

RT test for char model

1 lines of code changed in 1 file:

ohdiazi 2018-01-04 11:06 Rev.: 57550

task to compute dqmom variables

254 lines of code changed in 5 files:

ohdiazi 2018-01-04 11:06 Rev.: 57549

fixing particle factory

36 lines of code changed in 3 files:

ohdiazi 2018-01-04 11:05 Rev.: 57548

residual: 1e-3

1 lines of code changed in 1 file:

ohdiazi 2018-01-04 11:05 Rev.: 57547

updating arches_spec for char model ps

157 lines of code changed in 2 files:

ohdiazi 2018-01-04 11:05 Rev.: 57546

merging commit

0 lines of code changed in 3 files:

ohdiazi 2018-01-04 11:05 Rev.: 57545

ups for od char

151 lines of code changed in 8 files:

ohdiazi 2018-01-04 11:05 Rev.: 57544

Smith 2016 char oxidation model

1162 lines of code changed in 6 files:

ohdiazi 2018-01-04 11:05 Rev.: 57543

fixing helium plume

236 lines of code changed in 5 files:

jthornoc 2018-01-03 18:03 Rev.: 57542

Moving logic to correct postion.

9 lines of code changed in 1 file:

bisaac 2018-01-03 16:54 Rev.: 57541

Removed the constraint on net heat flux being positive or zero within wall ht model. This commit will change the answers in 1GW_RT and 1GW_em_tc.

2 lines of code changed in 1 file:

bisaac 2018-01-03 15:56 Rev.: 57540

Corrected max tempertaure in the presence of additional sources. This commit will not impact regression tests.

1 lines of code changed in 1 file:

bisaac 2018-01-03 15:06 Rev.: 57539

Added additional source terms to the wall heat transfer model - coal_region. This commit will not impact regression tests.

60 lines of code changed in 2 files:

jthornoc 2018-01-03 14:13 Rev.: 57538

Updating the approach to handling non-normal velocity conditions on intrusion.
This commit breaks the intrusion_test and the multi_patch_intrusion_test.

304 lines of code changed in 4 files:

derekhar 2018-01-02 17:45 Rev.: 57537

Fixed Spectral DO sweeping algorithm when not using scattering.

4 lines of code changed in 1 file:

derekhar 2018-01-02 15:47 Rev.: 57536

Fix bug in divQ calculation for DORadiation for cases without scattering, with sweeps.

3 lines of code changed in 1 file:

December 2017 »

Generated by StatSVN 0.7.0