November 2018 Commit Log

Number of Commits:
68
Number of Active Developers:
9
harman 2018-11-30 18:36 Rev.: 58982

Added #define ALL_LEVELS 99

2 lines of code changed in 1 file:

harman 2018-11-30 18:20 Rev.: 58981

- Incorporated temporal scheduling virtual function calls into ICE and OnTheFly.

- Added full temporal scheduling support to planeAverage & meanTurbFluxes

- updated ups spec

This feature is disabled due to a bug in getSubCycleProgress().


232 lines of code changed in 18 files:

ahumphrey 2018-11-30 13:45 Rev.: 58979

Cleanup under the hood as the most recent TG work/project moves forward. Mostly cosmetic changes for readability.

138 lines of code changed in 5 files:

derekhar 2018-11-29 16:00 Rev.: 58977

The wall model now normalizes the relaxation coefficient based on the maximum solve frequency for dynamic radiation frequency.

This will allow users to adopt the dynamic solve frequency approach without it affecting the averaging window that they chose based on the base or maximum radiation solve frequency.

18 lines of code changed in 2 files:

harman 2018-11-29 15:59 Rev.: 58976

Removed OnTheFlyAnalysis/containerExtract.

0 lines of code changed in 5 files:

harman 2018-11-29 15:20 Rev.: 58975

scheduleRestartInitialize() & scheduleIntialize()
- consolidated redundant code.

3 lines of code changed in 2 files:

derekhar 2018-11-29 14:20 Rev.: 58974

delete varlabel for reduction used when using dynamic radiation solve frequency.

1 lines of code changed in 1 file:

harman 2018-11-29 12:32 Rev.: 58973

Added make_unique() for clang compilers.

20 lines of code changed in 2 files:

harman 2018-11-29 10:08 Rev.: 58972

planeAverage:
- use unique ids in label names. This class is instantiated twice.
- initialize ave[]

meanTurbFluxes:
- Added sched_writeToFiles() for planeAve_1 & 2
- delete copy-paste code that isn't used.
- clean out #includes
- move from new -> shared_ptr

125 lines of code changed in 4 files:

derekhar 2018-11-28 17:51 Rev.: 58971

adopt temporal scheduling for the wall model. This will remove unneeded ghost communication on non-radiation steps.

115 lines of code changed in 2 files:

allen 2018-11-28 15:24 Rev.: 58969

added bulletproofing to the map:;at method usage

67 lines of code changed in 1 file:

jthornoc 2018-11-28 14:34 Rev.: 58968

Minor cosmetic changes. Also, do not require that <ParticleModels> be
specified for DQMOM.

33 lines of code changed in 4 files:

ahumphrey 2018-11-28 13:14 Rev.: 58967

Fix more inaccurate error mesgs in DWDatabase.

2 lines of code changed in 1 file:

ahumphrey 2018-11-28 13:06 Rev.: 58965

Fix accuracy of error message when putting foreign vars into DW.
Reorder appearance of methods in OnDemandDW to match header... send/recvMPI methods adjacent in impl file.
A few minor cosmetic changes elswhere.

123 lines of code changed in 7 files:

ahumphrey 2018-11-28 12:21 Rev.: 58964

Massive cleanup and refactoring in OnDemandDW. This source code was diffuclut to read, and I'm needing to make significant changes in the MPI engine to support optimizations in TG dependency analysis (in the context of RMCRT radiation with threaded schedulers).

1456 lines of code changed in 9 files:

allen 2018-11-27 19:12 Rev.: 58963

added full support for PerPatch vars

0 lines of code changed in 2 files:

harman 2018-11-27 18:14 Rev.: 58962

This should have been deleted in revision 58672

0 lines of code changed in 80 files:

derekhar 2018-11-27 17:15 Rev.: 58961

Added test for dynamic radiation solving frequencies.

This commit also constrains the solve to be within the solve frequency and the timescale estimated at runtime.
This is the first test to use perpatch variables in the checkpoint, so compare_uda will need to be extended to support this data type (and possibley PIDX? yuck)
Wall model integration is forthcoming.

117 lines of code changed in 5 files:

allen 2018-11-27 17:09 Rev.: 58960

changed to cout

0 lines of code changed in 2 files:

allen 2018-11-27 17:07 Rev.: 58959

added by pass for PerPatch vars

6 lines of code changed in 1 file:

allen 2018-11-27 16:26 Rev.: 58958

added DOUT for run a task acually runs

9 lines of code changed in 3 files:

harman 2018-11-27 16:03 Rev.: 58957

All of the major pieces are filled in and the two instantiations of planeAverage are
executing tasks.


176 lines of code changed in 5 files:

allen 2018-11-27 15:57 Rev.: 58956

added a fake dependency to the the task to happen late in the time step

24 lines of code changed in 1 file:

jthornoc 2018-11-27 13:53 Rev.: 58955

Cosmetics.

10 lines of code changed in 3 files:

ahumphrey 2018-11-27 13:08 Rev.: 58954

Update and revive DW task access checking and RunningTaskInfo code.
Fixed a few other typos and formatting in these areas while under the hood.

123 lines of code changed in 8 files:

allen 2018-11-26 17:19 Rev.: 58953

removed the get for the calc frequency as it is no longer needed

0 lines of code changed in 2 files:

allen 2018-11-26 16:51 Rev.: 58952

tab removal

13 lines of code changed in 1 file:

allen 2018-11-26 16:50 Rev.: 58951

changed the example to be more generic

74 lines of code changed in 2 files:

allen 2018-11-26 16:48 Rev.: 58950

changed the logic to check for the task graph index

15 lines of code changed in 2 files:

harman 2018-11-26 16:24 Rev.: 58949

planeAverage:
- moved transforCellIndex() and planeIterator() from private -> public
- added templated method to compute planar ave. Previous it was computed at print time.

meanTurbFluxes:
- added a monitorCell for debugging
- scheduled tasks to compute Q_bar, which is used in the calculatio of turbulent fluctuations
- Filled in the calc of turbulent fluctuations


132 lines of code changed in 4 files:

allen 2018-11-26 14:43 Rev.: 58948

removed debug DOUT

0 lines of code changed in 1 file:

allen 2018-11-26 13:08 Rev.: 58947

added check for freq of 1 to always use the static case and added placeholder for using four task graphs

83 lines of code changed in 3 files:

allen 2018-11-21 13:02 Rev.: 58946

refactored the task graph index setting to be task based, added set/get for the index, Within arches refactor the dynamic stepping to be completing with DoRadiation and the fixed stepping in Explicit Solver, and added a check method for reduction vars

472 lines of code changed in 28 files:

allen 2018-11-20 15:32 Rev.: 58945

added perpatch to the list

4 lines of code changed in 1 file:

ahumphrey 2018-11-19 13:31 Rev.: 58944

Infrastructure restructuring and cleanup while starting last thesis-related task graph work.

Big things that I will always change when I see them.... and I saw much of this recently:

1.) ALWAYS use {} for 1-line conditionals.
if (<predicate>) {
// do stuff
}

2.) Use C++ static _cast over C-style casts, static_cast<int>(myvar) is checked at compile time, C casts are not and can fail at runtime.

3.) use "nullptr" over "0 or NULL" in the context of pointers and their assignment. Using NULL or 0 can be ambigous, e.g., compiler converting to non-pointer type 'int' from NULL (nullptr can't be assigned to an integral type). nullptr is a keyword and usage/intent is clear. From the standard: "The pointer literal is the keyword nullptr. It is an rvalue of type std::nullptr_t.".

4.) Things like Dout/Debugstreams that are specific to a compilation unit should be placed into an unnamed namespace (which is a utility to make an identifier translation unit local). The effect is almost identical to decalring something static.

5.) Use meanigful names, a bit lengthy is OK if it helps clarity. Remember, the compiler doesn't care about your names (values just go into registers), but the people maintaining your code do.. Code is meant to be read and maintained.

6.) Whitespace is our friend, but 80 column lines went away long ago.....

793 lines of code changed in 14 files:

harman 2018-11-17 14:55 Rev.: 58942

Pull in Sultan's changes.
- Use K_l and K_R to compute vel_FCME instead of averaging vel_CC_ME_L and vel_CC_ME_R.

264 lines of code changed in 2 files:

harman 2018-11-17 13:27 Rev.: 58941

Added comments.
Fixed syntax error.
Cleanup warning.

0 lines of code changed in 2 files:

allen 2018-11-16 19:35 Rev.: 58940

added Uintah namespace

1 lines of code changed in 1 file:

allen 2018-11-16 19:29 Rev.: 58939

added Uintah namespace

1 lines of code changed in 1 file:

allen 2018-11-16 19:16

Changed interface to match AppCom

7 lines of code changed in 4 files:

jthornoc 2018-11-16 18:20 Rev.: 58936

Fixed a bug in the intrusion inlet. The velocity index was being
reassigned.

0 lines of code changed in 2 files:

harman 2018-11-16 17:18 Rev.: 58935

Update computeTaskGraphIndex()

6 lines of code changed in 2 files:

jthornoc 2018-11-16 15:37 Rev.: 58934

Warnings.

22 lines of code changed in 4 files:

jthornoc 2018-11-16 15:09 Rev.: 58933

Add a call to problemSetupCommon.

10 lines of code changed in 1 file:

harman 2018-11-16 15:09 Rev.: 58932

Global:
d_materialManager -> d_matlManager

Code consolidation.
- ScalarExch::addExch_Vel_Temp_C() now computing surfaceNorm and isSurface in one place
ExchangeModel::ComputeSurfaceNormal()


117 lines of code changed in 9 files:

jthornoc 2018-11-16 14:40 Rev.: 58931

Adding a skeleton property evaluator for transport of the PC variables.

258 lines of code changed in 14 files:

allen 2018-11-16 12:47 Rev.: 58930

removed the time from the getTaskGraphIndex interface and changed the name

31 lines of code changed in 6 files:

allen 2018-11-16 12:46 Rev.: 58929

added additional comments for the dynamic radiation

20 lines of code changed in 1 file:

jthornoc 2018-11-16 12:07 Rev.: 58928

Register missing new variable.

0 lines of code changed in 2 files:

jthornoc 2018-11-16 12:07 Rev.: 58927

The computesWithScratchGhost required some extra error checking to
ensure that, in the packed case, a computes and requires on the same
variable was resolved properly.

36 lines of code changed in 2 files:

jthornoc 2018-11-16 12:07 Rev.: 58926

Fix a typo.

1 lines of code changed in 1 file:

jthornoc 2018-11-16 12:07 Rev.: 58925

Update print statement.

2 lines of code changed in 1 file:

jthornoc 2018-11-16 12:07 Rev.: 58924

Removing temporary variable option for portability reasons.

335 lines of code changed in 22 files:

bisaac 2018-11-15 18:05 Rev.: 58923

This commit fixes a bug when using second order time tabulated reaction rates. This commit will impact the acid base regression test.

0 lines of code changed in 2 files:

derekhar 2018-11-15 17:53 Rev.: 58922

This adds input files and source code for the detailed and reduced soot models developed by Alex Josephson, David Lignell, and Kamron Brinkerhoff.
The detailed model is very computationally expensive and is included to help verify the reduced model in its development.

1913 lines of code changed in 8 files:

harman 2018-11-15 17:46 Rev.: 58921

Created separate schedule() methods for each of the tasks so they can be used by other
analysis modules.

writeToFiles()
- pass in the directory name.


290 lines of code changed in 3 files:

guilkey 2018-11-15 12:57 Rev.: 58920

Reworking the fastCpdiInterpolator to revert to the regular cpdiInterpolator
if particles span more than two grid cells in any direction. Some additional
modifications might be forthcoming.

340 lines of code changed in 1 file:

harman 2018-11-14 10:52 Rev.: 58913

The pieces of the puzzle (tasks) are starting to take shape and solidify.
No communcation betweeen pieces.

*** heavy construction zone ***

353 lines of code changed in 5 files:

jholmen 2018-11-12 20:17 Rev.: 58906

* Added the GPUIDs SCI_DEBUG environment variable.

This environment variable reports information helpful for uniquely identifying GPUs when using multiple MPI processes and GPUs per node.

27 lines of code changed in 3 files:

harman 2018-11-12 12:27 Rev.: 58905


This module computes the mean turbulent fluxes on each user defined plane in the domain
u'u'_bar, v'v'_bar, w'w'_bar u'v'_bar, v'w'_bar u'w'_bar

foreach Q ( T, P, scalar )
( u'Q'_bar(y), v'Q'_bar(y), w'Q'_bar(y) )
end

** heavy contruction zone **


788 lines of code changed in 4 files:

jthornoc 2018-11-12 12:13 Rev.: 58904

Locking out the intrusion storage since this is occurring in a callback
and modifying a class member.

0 lines of code changed in 4 files:

jthornoc 2018-11-12 11:53 Rev.: 58903

Fixing a problem with the intrusions when multiple patches are on one
MPI rank. This is currently *not* threadsafe.

17 lines of code changed in 2 files:

harman 2018-11-08 17:22 Rev.: 58902

Removed OnTheFlyAnalysis for faster recompilation.

0 lines of code changed in 6 files:

harman 2018-11-06 18:54 Rev.: 58901

Changed initialization of CC_pos from Point(0,0,0) -> Point(-DBL_MAX.....).

More descriptive function name: findCellIndex -> transformCellIndex

Set the invariant cell positions of each plane = level->InteriorCellRange()/2


53 lines of code changed in 2 files:

harman 2018-11-05 18:09 Rev.: 58900

planeAverage:
- fixed memory leaks
- Creat a custom MPI_communicator. In multilevel/processor problems there's no guarentee that every rank
will own patches. Thanks Dav and Alan.
- Return immediately if a task has an empty patchSubset.

DbgOutput:
- printTask(): allow for empty patchSubsets.


299 lines of code changed in 3 files:

jbhooper 2018-11-04 23:04 Rev.: 58897

Pull diffusion check out of inner loop.

0 lines of code changed in 2 files:

harman 2018-11-02 17:13 Rev.: 58896

planeAverage.*
- switched from debugStream to Dout so the output doesn't become garbled when running in parallel.

- Decreased number of significant figures in output from 15 to 14. This hides the numerical fuzz
that's picked up when running in parallel. This allows for direct comparisons beweeen serial output

- Added clone virtual function allowing for deep copies of vector < vector <shared_ptr> > d_allLevels_planarVars

- computePlanarSums(): removed flow control logic d_progressVar. This task needs to be computed on all patches.

- Added resetProgressVar() task. It's trival but has to execute after the other tasks.

*** single and 4 core test problem are giving the same results for 2 level advect problem.

DbgOutput.*
- Added another implementation of printTask()

162 lines of code changed in 5 files:

harman 2018-11-01 17:37 Rev.: 58895

Replaced tabs with spaces.

2364 lines of code changed in 199 files:

October 2018 »

Generated by StatSVN 0.7.0